| opendevreview | Merged openstack/large-scale master: rabbitmq: add erlang scheduler recommendation https://review.opendev.org/c/openstack/large-scale/+/855508 | 07:19 |
|---|---|---|
| frickler | felixhuettner[m]: ^^ I missed that patch earlier, but it seems the spelling of the options is a bit off? I can create a followup if you agree | 07:41 |
| amorin | yes feel free | 07:42 |
| amorin | I think, the option is different if you set it on rabbit than on erlang vm | 07:44 |
| amorin | (you are talking about the +sbt and -sbt, right?) | 07:45 |
| felixhuettner[m] | it seems like that depends on how you call erlang (just to cause more confusion :) ) | 07:57 |
| felixhuettner[m] | the official docker image directly calls `beam.smp` which uses a minus character | 07:57 |
| felixhuettner[m] | but if you call `erl` the docs say you should use a plus character | 07:57 |
| felixhuettner[m] | just tested that an this seems to fit reality | 07:59 |
| felixhuettner[m] | should we just add a note that this depends on how you start rabbitmq? | 08:00 |
| amorin | maybe yes, to avoid confusion? | 08:01 |
| amorin | or maybe dont give any option, just say that this could/should be tuned and give a link to external doc? | 08:01 |
| felixhuettner[m] | i would still add a note since this is really non-obvious | 08:02 |
| amorin | ack | 08:02 |
| felixhuettner[m] | i'll build a short patch | 08:03 |
| frickler | it should also be "sbt" and not "stb" for the second variant I think | 08:05 |
| felixhuettner[m] | you are right, thanks | 08:05 |
| opendevreview | Felix Huettner proposed openstack/large-scale master: Clarify the erlang scheduler options https://review.opendev.org/c/openstack/large-scale/+/856604 | 08:06 |
| frickler | I was also comparing this only to the other options we set in kolla-ansible, but if both variants are used somewhere, that's indeed confusing https://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/roles/rabbitmq/defaults/main.yml#L82 | 08:07 |
| opendevreview | Merged openstack/large-scale master: Clarify the erlang scheduler options https://review.opendev.org/c/openstack/large-scale/+/856604 | 08:28 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!