| gibi | bauzas: replied in https://review.opendev.org/c/openstack/nova/+/947507 | 06:56 |
|---|---|---|
| gibi | bauzas: we merged a relnote | 06:56 |
| gibi | dansmith, sean-k-mooney[m]: this is ready to land and need a second core https://review.opendev.org/c/openstack/nova/+/922496 (rip out the remote debugger) | 06:58 |
| *** bauzas2 is now known as bauzas | 09:35 | |
| sean-k-mooney | ... i have been using kde for the last week to test somethign and i keep forgetting that its configure to sleep so my irc client keeps disconnecting in the evening | 10:35 |
| opendevreview | Merged openstack/nova master: [doc]Remove eventlet based API endpoints https://review.opendev.org/c/openstack/nova/+/947507 | 10:57 |
| opendevreview | Merged openstack/nova master: [doc]Describe file based GMR triggering https://review.opendev.org/c/openstack/nova/+/947508 | 10:57 |
| opendevreview | Merged openstack/nova master: Remove WSGIServer related config options https://review.opendev.org/c/openstack/nova/+/947595 | 11:14 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: WIP:Translate scatter-gather to futurist https://review.opendev.org/c/openstack/nova/+/947966 | 11:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Use futurist for _get_default_green_pool() https://review.opendev.org/c/openstack/nova/+/948072 | 11:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Replace utils.spawn_n with spawn https://review.opendev.org/c/openstack/nova/+/948076 | 11:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Add spawn_on https://review.opendev.org/c/openstack/nova/+/948079 | 11:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rename DEFAULT_GREEN_POOL to DEFAULT_EXECUTOR https://review.opendev.org/c/openstack/nova/+/948086 | 11:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Make the default executor configurable https://review.opendev.org/c/openstack/nova/+/948087 | 11:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Move ComputeManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948186 | 11:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Move ConductorManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948187 | 11:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Make nova.utils.pass_context private https://review.opendev.org/c/openstack/nova/+/948188 | 11:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Move ComputeManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948186 | 11:23 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Move ConductorManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948187 | 11:23 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Make nova.utils.pass_context private https://review.opendev.org/c/openstack/nova/+/948188 | 11:23 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rename DEFAULT_GREEN_POOL to DEFAULT_EXECUTOR https://review.opendev.org/c/openstack/nova/+/948086 | 11:24 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Make the default executor configurable https://review.opendev.org/c/openstack/nova/+/948087 | 11:24 |
| sean-k-mooney | melwitt: gibi: before i forget https://review.opendev.org/c/openstack/nova/+/946950 is my change to get rid of the ovn live migration hack can we try and merge that sooner rather then later. it seams to work but i want to get as much soak time in the ci this cycle as we can | 11:58 |
| sean-k-mooney | we cant backport this due to the ovn version in ubuntu22.04 so this is a purly master only fix | 11:58 |
| gibi | sean-k-mooney[m]: +2 | 12:26 |
| sean-k-mooney | thanks | 12:26 |
| sean-k-mooney | i need ot go find and approve that debuger remvoeal pacth actully | 12:27 |
| sean-k-mooney | my irc client disconened last night but i got the ping on slack do you happen to have the link if not ill find it its definetly in my review dashbaord | 12:28 |
| frickler | sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/922496 | 12:29 |
| frickler | looks like it is in merge conflict now, though | 12:29 |
| sean-k-mooney | damit i shoudl have merged it this morning | 12:30 |
| sean-k-mooney | but thanks | 12:30 |
| sean-k-mooney | this isnt urgent | 12:30 |
| sean-k-mooney | on the plus sid ethe reason its in merge conflict is becasue we merged more imporant eventlet removal patches so its nice that we are finally making progress on this | 12:33 |
| gibi | () | 12:36 |
| gibi | :) | 12:36 |
| * gibi going to rebase it | 12:36 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Remove nova debugger functionality https://review.opendev.org/c/openstack/nova/+/922496 | 12:37 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: split monkey_patching form import https://review.opendev.org/c/openstack/nova/+/922425 | 12:37 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Remove superfluous monkey patching form func test https://review.opendev.org/c/openstack/nova/+/947237 | 12:37 |
| gibi | it was a trivial rebase due to removed files | 12:38 |
| sean-k-mooney | oh right because we delete the api entry point | 12:49 |
| sean-k-mooney | im just goign to fast approve that with a comment | 12:50 |
| gibi | thanks! | 12:59 |
| dansmith | gibi: it seems like you have multiple stacks of eventlet patches that are not all in a single queue? | 13:45 |
| dansmith | I got to the top of the one I was looking at before and they're all +2+W | 13:45 |
| gibi | dansmith: correct. I try to keep independent patches in independent series | 13:45 |
| dansmith | this stack has a WIP in the second spot: https://review.opendev.org/c/openstack/nova/+/948064/2 | 13:45 |
| dansmith | is that the best one to start on next, or is there another stack of more ready ones? | 13:46 |
| gibi | yep that series is WIP at the scatter-gather change. Still worth a conceptual review if you have time. The other two simple series got approved today | 13:47 |
| gibi | this was the eventlet based WSGI removal https://review.opendev.org/c/openstack/nova/+/948064/2 | 13:47 |
| gibi | and this was the small removals https://review.opendev.org/c/openstack/nova/+/947237/3 | 13:48 |
| gibi | kamil has https://review.opendev.org/c/openstack/nova/+/947212 but that also got approved | 13:48 |
| gibi | so at the moment I can only offer the one with the WIP in the second slot | 13:48 |
| gibi | and that is only for conceptiula / directional reviews | 13:49 |
| gibi | I want to rush locally with that series up until I can run nova-scheduler with threading in a devstack (which is not far) | 13:49 |
| dansmith | okay | 13:50 |
| gibi | s/I can run/I can try to start/ | 13:50 |
| * gibi is supper happy to got so many reviews in this short period of time | 13:50 | |
| opendevreview | Thomas Rotsaert proposed openstack/nova master: feat(hypervisors) - Adding new hypervisor property `hypervisor_rack`. https://review.opendev.org/c/openstack/nova/+/948216 | 14:20 |
| opendevreview | Thomas Rotsaert proposed openstack/nova master: feat(hypervisors) - Adding new hypervisor property `hypervisor_rack`. https://review.opendev.org/c/openstack/nova/+/948216 | 14:21 |
| dansmith | gibi: I'm surprised to see this with no test change: https://review.opendev.org/c/openstack/nova/+/948064/2/nova/quota.py | 14:22 |
| dansmith | is this already covered and the existing tests still fully working? | 14:22 |
| sean-k-mooney | the existing test are workign https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b14/openstack/b14cdd4f87e54daeb81f9f053bf9bdb2/cover/z_8ee3d46129bdc436_quota_py.html is the coverage report | 14:25 |
| sean-k-mooney | i guess that imples that there is a potital gap in unit test coverage | 14:26 |
| dansmith | there's a lot not covered there | 14:27 |
| sean-k-mooney | the coverate repot does nto account for fucntional test | 14:27 |
| dansmith | right | 14:27 |
| dansmith | which is why I'm asking :) | 14:27 |
| dansmith | I would assume people who have +2d it also checked that :) | 14:27 |
| gibi | dansmith: I assumed that the existing test covered it well enough that that it proves the from the outside it produce the same resoult regardless of the internals | 14:29 |
| sean-k-mooney | i spend most of my review time trying to conveice my slef that the refactor did the same thing (albeit in a more efficnet way) and was mostly happy with the passing tempest/tox test that it was workign as expected | 14:29 |
| sean-k-mooney | gibi: right that was my tought process as well however at the unit test level there i sa gap | 14:29 |
| dansmith | that's a little scary, guys | 14:29 |
| sean-k-mooney | i mean it had no unit test coverage before either https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_4e4/openstack/4e4c4e1313844ef5bdb09e666d4119fd/cover/z_8ee3d46129bdc436_quota_py.html#t1210 | 14:31 |
| dansmith | sean-k-mooney: fine, but that's a good reason to _add_ it before we break something that has apparently been working in production | 14:32 |
| sean-k-mooney | so the actul coverage went up 2% | 14:32 |
| sean-k-mooney | i dont disagree with that sentiemtn | 14:32 |
| dansmith | and if we had no coverage on anything, that's not a good reason to just make untested changes because there's nobody watching | 14:32 |
| sean-k-mooney | woudl you like me to pull it form the queue or defer to a follow up i nthe series | 14:32 |
| dansmith | I just broke the new thing and am running functional so we'll see, hopefully something will notice | 14:32 |
| dansmith | sean-k-mooney: is it in the actual gate? | 14:33 |
| sean-k-mooney | the gate jobs are running | 14:33 |
| gibi | I'm OK to pull it and I can try to add extra coverage. | 14:33 |
| sean-k-mooney | ok ill drop +w | 14:34 |
| dansmith | a bunch of the quota functional tests have run and it didn't fail.. long ways to go still, but... | 14:34 |
| dansmith | {6} nova.tests.functional.db.test_quota.QuotaTestCase.test_server_group_members_count_by_user_2_False [0.224107s] ... FAILED | 14:37 |
| dansmith | so that one is at least running the code, which is good, but I don't see that it has any build requests to check that part | 14:39 |
| sean-k-mooney | dansmith: as an asside do you know if there is a reason we dont include the funtioal test in the coverage report today? i would guess its runtime but i never really tought about it | 14:46 |
| dansmith | yeah I wish we had it too, | 14:46 |
| sean-k-mooney | dansmith: im not sure if that woudl be a good or bad thing | 14:46 |
| dansmith | I'm guessing because it's a separate job, but we could just make the regular functional be the coverage one, if not for the inherited job thing :/ | 14:47 |
| dansmith | I'd like to have it | 14:47 |
| sean-k-mooney | dansmith: well i think we could do it. it might be something i hack on the next time i fell like hacking on those kidn of thing | 14:47 |
| dansmith | I run a lot of coverage reports locally when I suspect someone hasn't actually added a test | 14:47 |
| sean-k-mooney | well tis just calling our tox target so that josb can run anything we want if we update it. | 14:48 |
| sean-k-mooney | what i was mroe wondering is woudl we want a combined coverage reprot (form both testsuites) or seperate unit/functional reports | 14:48 |
| sean-k-mooney | job wise i think combined is nice but ya i just said i woudl ask | 14:49 |
| dansmith | we could, maybe that would be better | 14:49 |
| dansmith | gibi: okay, one test runs that code and doesn't have (AFAICT) any build requests | 14:50 |
| dansmith | gibi: if you wouldn't mind at least mentioning in the commit message that we don't need additional testing, that would be appreciated, | 14:50 |
| dansmith | but adding BR coverage to that existing test seems prudent to me as well, since you're changing that code | 14:50 |
| gibi | dansmith: I will add the missing coverage. No problemo | 14:51 |
| gibi | :) | 14:51 |
| dansmith | gibi: thanks | 14:53 |
| opendevreview | Merged openstack/nova master: FUP improve and add integration tests for PCI SR-IOV servers https://review.opendev.org/c/openstack/nova/+/944106 | 15:10 |
| opendevreview | Thomas Rotsaert proposed openstack/nova master: feat(hypervisors) - Adding new hypervisor property `hypervisor_rack`. https://review.opendev.org/c/openstack/nova/+/948248 | 16:11 |
| opendevreview | Thomas Rotsaert proposed openstack/nova master: feat(hypervisors) - Adding new hypervisor property `hypervisor_rack`. https://review.opendev.org/c/openstack/nova/+/948248 | 16:11 |
| opendevreview | ribaudr proposed openstack/nova stable/2025.1: FUP Remove unnecessary PCI check https://review.opendev.org/c/openstack/nova/+/946625 | 16:18 |
| opendevreview | ribaudr proposed openstack/nova stable/2025.1: FUP Remove unnecessary PCI check https://review.opendev.org/c/openstack/nova/+/948251 | 16:23 |
| opendevreview | ribaudr proposed openstack/nova stable/2025.1: FUP Remove unnecessary PCI check https://review.opendev.org/c/openstack/nova/+/946623 | 16:26 |
| opendevreview | ribaudr proposed openstack/nova stable/2025.1: FUP Update pci-passthrough and virtual-gpu documentation https://review.opendev.org/c/openstack/nova/+/948253 | 16:39 |
| opendevreview | ribaudr proposed openstack/nova stable/2025.1: FUP Update pci-passthrough and virtual-gpu documentation https://review.opendev.org/c/openstack/nova/+/948254 | 16:40 |
| opendevreview | ribaudr proposed openstack/nova stable/2025.1: FUP Update pci-passthrough and virtual-gpu documentation https://review.opendev.org/c/openstack/nova/+/948254 | 16:41 |
| opendevreview | Thomas Rotsaert proposed openstack/nova master: feat(hypervisors) - Adding new hypervisor property `hypervisor_rack`. https://review.opendev.org/c/openstack/nova/+/948258 | 17:41 |
| opendevreview | Thomas Rotsaert proposed openstack/nova master: feat(hypervisors) - Adding new hypervisor property `hypervisor_rack`. https://review.opendev.org/c/openstack/nova/+/948258 | 17:43 |
| -opendevstatus- NOTICE: Gerrit is getting restarted to pick up container image updates. It should only be gone for a moment. | 18:16 | |
| opendevreview | Merged openstack/nova master: Remove nova debugger functionality https://review.opendev.org/c/openstack/nova/+/922496 | 19:21 |
| opendevreview | Merged openstack/nova master: split monkey_patching form import https://review.opendev.org/c/openstack/nova/+/922425 | 19:21 |
| opendevreview | Merged openstack/nova master: Remove superfluous monkey patching form func test https://review.opendev.org/c/openstack/nova/+/947237 | 19:21 |
| opendevreview | Merged openstack/nova master: Remove workaround for ovn live migration https://review.opendev.org/c/openstack/nova/+/946950 | 19:41 |
| opendevreview | Thomas Rotsaert proposed openstack/nova master: feat(hypervisors) - Adding new hypervisor property `hypervisor_rack`. https://review.opendev.org/c/openstack/nova/+/948276 | 21:16 |
| opendevreview | Thomas Rotsaert proposed openstack/nova master: feat(hypervisors) - Adding new hypervisor property `hypervisor_rack`. https://review.opendev.org/c/openstack/nova/+/948276 | 21:16 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!