| Uggla | sean-k-mooney[m], yep I'm gonna update them this morning. | 07:33 |
|---|---|---|
| gibi | sean-k-mooney[m]: re triage: I feel Uggla put sizeable effort to pre-select bugs that are easy to triage and this made it effective. | 07:52 |
| gibi | also I feel that it was mostly sean-k-mooney[m] and Uggla who did this triage work. If this feel sustainable then I'm happy. | 07:52 |
| gibi | I personally would like to look at bugs async and then bring up the questionable ones in the meeting. | 07:53 |
| gibi | and nothing prevents me to do that :) | 07:54 |
| Uggla | gibi, would you like me to select several bugs upfront let's say Friday. So we could discuss them during Tuesday meeting ? | 08:03 |
| gibi | that is one way to do it. But if it just for me then it is OK to continue as is and I will try to find some bugs to look at async time to time | 09:44 |
| Uggla | gibi, I'm not sure it is for you only. I have the feeling I'd rather have the bugs we will discuss in advanced to thing about them and do some research. | 09:57 |
| Uggla | Following yesterday’s triage exercise during the Nova meeting, and some additional work I did this morning, we’ve gone from over 160 new bugs down to 152. | 11:09 |
| Uggla | I marked as Incomplete and notified reporters for bugs that were clearly missing information. | 11:09 |
| Uggla | I went back through bugs from the last 50 days, and I believe all of them now have enough info for proper triage. | 11:09 |
| Uggla | I also noted the bugs to triage in the next meeting (2025-04-29 or 2025-05-06) here: | 11:09 |
| Uggla | https://etherpad.opendev.org/p/nova-bug-selection-for-triaging | 11:09 |
| gibi | Uggla: thank! | 11:15 |
| gibi | I will try to set aside some time to look at some of them | 11:15 |
| gibi | Uggla: FYI I saw you set https://bugs.launchpad.net/nova/+bug/2102038 fix comitted, I set it back to in progress as there is no commit merged and the patches proposed are only providign a reproducer and some doc but not a real fix yet | 11:20 |
| Uggla | gibi, oh ok. Sure no pb. I was maybe a bit too aggressive with that one. :) What is important for me, is to set it as something different than new (which is the case). | 11:23 |
| sean-k-mooney | Uggla: we also do not use fix commited any more by the way | 11:29 |
| sean-k-mooney | we stop that about 8 years ago | 11:29 |
| sean-k-mooney | basicly the logic is master is inteneded to be deployable to production and the same is ture of the stable branhces | 11:30 |
| sean-k-mooney | so if we have commited the change we treat it as released | 11:30 |
| sean-k-mooney | so we use fix released as the done state even if we have not had an upstream "release" tagged | 11:30 |
| sean-k-mooney | there is no automation to move things form fix commit to fix released either so if we used fix commited you would have to go back and update all bugs every time we do any release by hand | 11:31 |
| opendevreview | Kamil Sambor proposed openstack/nova master: Replace eventlet sleep with time.sleep https://review.opendev.org/c/openstack/nova/+/947212 | 13:24 |
| gibi | Uggla: no worries. I saw it, fixed it, and just let you know for the future :) | 14:02 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [hacking] N373 do not use eventlet primitives https://review.opendev.org/c/openstack/nova/+/947265 | 14:22 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Remove nova.service.process_launcher https://review.opendev.org/c/openstack/nova/+/947260 | 14:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Remove nova debugger functionality https://review.opendev.org/c/openstack/nova/+/922496 | 14:33 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: split monkey_patching form import https://review.opendev.org/c/openstack/nova/+/922425 | 14:33 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Remove superfluous monkey patching form func test https://review.opendev.org/c/openstack/nova/+/947237 | 14:33 |
| dansmith | bauzas: gibi: could one of you +W this? https://review.opendev.org/c/openstack/nova/+/946065 | 14:40 |
| dansmith | just tests and you've both +Wed already | 14:40 |
| dansmith | that would close that work out on the nova side I think | 14:40 |
| bauzas | done | 14:41 |
| gibi | bauzas was faster :) | 14:42 |
| dansmith | thanks | 14:44 |
| opendevreview | Rajesh Tailor proposed openstack/nova master: Fix 'nova-manage image_property set' command https://review.opendev.org/c/openstack/nova/+/946733 | 15:30 |
| opendevreview | Merged openstack/nova master: Functional tests for one-time-use devices https://review.opendev.org/c/openstack/nova/+/946065 | 16:01 |
| Uggla | sean-k-mooney, if you have a moment, can you have a look at 947558: update constraint for oslo.utils to new release 7.3.1 | https://review.opendev.org/c/openstack/requirements/+/947558 I found the issue, proposed a fix in the comments. But that's probably not the good way to fix the issue. So I'll appreciate your thought about it. | 16:15 |
| sean-k-mooney | loading context | 16:27 |
| sean-k-mooney | oh so py38 has not been part of the runtimes for a while | 16:27 |
| sean-k-mooney | it was there for oslo because they lag one release behind | 16:28 |
| sean-k-mooney | but we shoudl be remvoing that now | 16:28 |
| sean-k-mooney | Uggla: its failing because oslo.utils bumpted teh min version to 39 https://github.com/openstack/oslo.utils/blob/master/setup.cfg#L9 | 16:28 |
| sean-k-mooney | that why it can install in 3.8 | 16:29 |
| sean-k-mooney | oh this is 2024.2 | 16:32 |
| Uggla | sean-k-mooney, not for the requested version https://opendev.org/openstack/oslo.utils/src/commit/145e0455d75fe11d55595e1c5dedcde0a1acdc05/setup.cfg#L9 | 16:34 |
| sean-k-mooney | ya i noticed that after i typed up a respocne | 16:34 |
| sean-k-mooney | im goign to take a look at the actul error quickly | 16:34 |
| sean-k-mooney | so they have not merge the pyprojec.toml paces an dnew version of pip and setup tools hae stared dropping supprot for that | 16:37 |
| sean-k-mooney | im not sure if that is related | 16:37 |
| sean-k-mooney | given this is python 3.8 i guess this job is still on ubuntu 22.04 | 16:37 |
| sean-k-mooney | Distro: Ubuntu 20.04 | 16:37 |
| sean-k-mooney | ok even older. | 16:37 |
| Uggla | sean-k-mooney, there is somethink related to the package named produced as I state in my comment. | 16:41 |
| sean-k-mooney | https://zuul.opendev.org/t/openstack/build/dd880dad1d3a486a92d8decd7fc9fd7c/log/job-output.txt#3576 | 16:42 |
| sean-k-mooney | pkg_resources.DistributionNotFound: The 'oslo.utils>=3.36.0' distribution was not found and is required by oslo.log | 16:42 |
| sean-k-mooney | which is odd becaues we are adding 7.3.1 | 16:43 |
| sean-k-mooney | so we need to look earlier | 16:43 |
| sean-k-mooney | normally this happens if some package has a cap (max version pin) | 16:43 |
| Uggla | sean-k-mooney, please look at my comment this is due to the fact that the package is oslo_utils instead of oslo.utils. | 16:45 |
| sean-k-mooney | it does look like we installed oslo.utils-7.3.1 | 16:46 |
| sean-k-mooney | so kind of | 16:47 |
| sean-k-mooney | teh pytohn modluel is oslo_utils | 16:47 |
| sean-k-mooney | you saying that the way pbr built it is broken | 16:47 |
| sean-k-mooney | and now its reproting as oslo_utils in pip freeze? | 16:47 |
| sean-k-mooney | or when its built | 16:48 |
| sean-k-mooney | if so that coudl be because we dont have a pyproject.toml file | 16:48 |
| sean-k-mooney | its oslo.utils here too https://zuul.opendev.org/t/openstack/build/dd880dad1d3a486a92d8decd7fc9fd7c/log/job-output.txt#2433-2434 | 16:51 |
| sean-k-mooney | Uggla: have you tired repoducing this locally? | 16:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: WIP:Translate scatter-gather to futurist https://review.opendev.org/c/openstack/nova/+/947966 | 16:59 |
| sean-k-mooney | Uggla: im running the command locally in a ubuntu 20.04 container now ill let you know if i find anyting | 17:08 |
| Uggla | sean-k-mooney, as you can see I managed to fix the issue. But using an mv is probably not really clean. | 18:03 |
| sean-k-mooney | Uggla: i dont see how you fixed the issue | 18:04 |
| sean-k-mooney | ugh did you put it in a comment instead of actully pushign a patch | 18:05 |
| Uggla | yes | 18:06 |
| Uggla | https://review.opendev.org/c/openstack/requirements/+/947558/comments/16851def_9bf88f81 | 18:06 |
| sean-k-mooney | ths really confusing when you ping some one out of the blue to look at a patch where there is not clear indication that you changed anything | 18:07 |
| Uggla | sorry :( | 18:09 |
| sean-k-mooney | its ok. so packege_resouce on py38 | 18:09 |
| sean-k-mooney | does not return or use the same name as pip | 18:09 |
| sean-k-mooney | specificly pip freeze | 18:10 |
| sean-k-mooney | we can make this work by doign pkg_resources.require(name.replace('.','_')) | 18:10 |
| sean-k-mooney | instead of pkg_resources.require(name) | 18:10 |
| sean-k-mooney | on python 3.8 | 18:10 |
| sean-k-mooney | however that is not really teh correct fix | 18:10 |
| sean-k-mooney | we could do that here https://github.com/openstack/requirements/blob/master/openstack_requirements/cmds/check_conflicts.py#L51C25-L51C52 | 18:10 |
| sean-k-mooney | and gard i by the python version. | 18:11 |
| Uggla | yep I agree this is another possibility. | 18:11 |
| sean-k-mooney | but it would be beter to undersand why it is behviing diffently | 18:11 |
| Uggla | yes that was the reason why I asked you. If you have an idea about the reason. | 18:13 |
| sean-k-mooney | my guess is somethign in pkg_resouces has changed | 18:13 |
| sean-k-mooney | i woudl have to see if there are any recent releases | 18:14 |
| sean-k-mooney | https://setuptools.pypa.io/en/latest/pkg_resources.html | 18:15 |
| sean-k-mooney | so pkg_resouces is deprecated for removal | 18:15 |
| sean-k-mooney | we may want to swap to import lib instead | 18:15 |
| sean-k-mooney | pkg_resocue i think is gon in python 3.13 | 18:17 |
| sean-k-mooney | i think we are ment to use https://docs.python.org/3/library/importlib.resources.html instead | 18:18 |
| sean-k-mooney | or well import lib in general | 18:18 |
| masahito | sean-k-mooney: hi, please review the API bug fix, again. gmaan_pto +2ed so all comments are solved. https://review.opendev.org/c/openstack/nova/+/939658 | 20:26 |
| sean-k-mooney | ah sure. im just about to finsih for todday but i can take a look quickly | 20:27 |
| sean-k-mooney | masahito: i agree it looks like gmanns comment have been addressed and i was happy with it before so +2w | 20:28 |
| masahito | sean-k-mooney: thanks! I appreciate you check it even though you're going to finish today. | 20:30 |
| opendevreview | Merged openstack/nova master: Use dict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658 | 23:16 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!