| opendevreview | Mohammed Naser proposed openstack/nova master: Add reproducer for bug#2106073 https://review.opendev.org/c/openstack/nova/+/946221 | 00:43 |
|---|---|---|
| mnaser | cardoe: well that's a reproducer alongside https://bugs.launchpad.net/nova/+bug/2106073 .. now to figure out how to nicely fix this :) | 00:44 |
| cardoe | mnaser: btw did you see my note about the release GH action not working on keystoneauth-websso? | 00:45 |
| mnaser | ahhhh sorry cardoe got distracted | 00:45 |
| mnaser | i'll add it to my tomorrow list! | 00:45 |
| cardoe | hmm. That's gonna be a tough one to solve cause config_drive is generated before the update_port_postcommit() which will resolve that deferred allocation no? | 00:46 |
| opendevreview | Mohammed Naser proposed openstack/nova master: Add reproducer for bug#2106073 https://review.opendev.org/c/openstack/nova/+/946221 | 02:36 |
| mnaser | https://bugs.launchpad.net/nova/+bug/2106073 - revised the bug, seems to be affecting nova at wide since it feeds in ports without ip allocation (and doesnt wait for it ip_allocation=deferred) and pushed another repro.. | 02:37 |
| opendevreview | Yaguang Tang proposed openstack/nova stable/2024.1: Fix deepcopy usage for BlockDeviceMapping in get_root_info https://review.opendev.org/c/openstack/nova/+/926696 | 03:14 |
| opendevreview | melanie witt proposed openstack/nova master: Call volume detach rollback API if detach fails https://review.opendev.org/c/openstack/nova/+/880399 | 03:35 |
| opendevreview | melanie witt proposed openstack/nova master: Reproducer for bug 2016173 https://review.opendev.org/c/openstack/nova/+/946222 | 03:35 |
| opendevreview | Masahito Muroi proposed openstack/nova master: Add check_instance_state validation to lock API https://review.opendev.org/c/openstack/nova/+/946223 | 03:52 |
| opendevreview | Masahito Muroi proposed openstack/nova master: Add check_instance_state validation to lock API https://review.opendev.org/c/openstack/nova/+/946223 | 04:14 |
| opendevreview | Masahito Muroi proposed openstack/nova master: Add check_instance_state validation to lock API https://review.opendev.org/c/openstack/nova/+/946223 | 08:46 |
| opendevreview | Masahito Muroi proposed openstack/nova master: Use dict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658 | 09:15 |
| masahito | gmann: sean-k-mooney: ack. thanks for the review. updated the commit. https://review.opendev.org/c/openstack/nova/+/939658 | 09:18 |
| sean-k-mooney | mnaser: that not new | 10:47 |
| sean-k-mooney | mnaser: there is already a older bug for that | 10:47 |
| sean-k-mooney | mnaser: well or at least there have been some patches floating around for that issue for a while | 10:48 |
| sean-k-mooney | mnaser: ah i twas a downstream only bug report https://bugzilla.redhat.com/show_bug.cgi?id=2276701 | 10:50 |
| sean-k-mooney | which got moved to here https://issues.redhat.com/browse/OSP-33489 | 10:51 |
| sean-k-mooney | ill add the upstream tracker to that | 10:51 |
| sean-k-mooney | sorry https://issues.redhat.com/browse/OSPRH-13144 | 10:52 |
| *** haleyb_ is now known as haleyb | 13:18 | |
| mnaser | sean-k-mooney: thanks for all those details | 13:18 |
| mnaser | I wonder if can get away with deferring config drive creation till we get vif plugged event | 13:19 |
| sean-k-mooney | for ironci we cant | 13:19 |
| sean-k-mooney | for libvirt i think yes | 13:19 |
| sean-k-mooney | the file just need to exist before we start the vm | 13:19 |
| sean-k-mooney | so we can do that later | 13:20 |
| mnaser | So then the only way we have for this in ironic would be some sort of polling for ports if they're ip address deferred | 13:20 |
| sean-k-mooney | well we can look at the ironic situration but the ironci driver is "special" | 13:20 |
| mnaser | It feels ugly but I guess we can just loop over the vifs | 13:21 |
| sean-k-mooney | for ironic we are not really generting a config drive. what we are doign is generating the content we woudl provide and then passing that to there rest api | 13:21 |
| mnaser | And check if any ports have deferred IP allocation, if so, wait for it to appear | 13:21 |
| sean-k-mooney | its possibel we could add a call back ot update ironic if the metadata changes | 13:22 |
| sean-k-mooney | but i dont knwo fi that woudl work | 13:22 |
| sean-k-mooney | ideally you would use the metadat service instead of config drive with ironic if you need it to be up to date | 13:22 |
| mnaser | That might be a lot of complexity and also still prone to race conditions cause then what will ironic do if it's mid provision and it changes? | 13:22 |
| sean-k-mooney | ill quickly take a look at the driver and see if we can generate it slightly later | 13:23 |
| mnaser | Yeah -- my issue is that I'm using bonds | 13:23 |
| mnaser | AFAIK I need config drive for those | 13:23 |
| sean-k-mooney | well bonds are not supprot in nova or neutron | 13:23 |
| mnaser | Ironic port groups? | 13:23 |
| sean-k-mooney | and its implemtned i think in ironci directly via port groups? | 13:23 |
| sean-k-mooney | ya prot groups are not a thing in nova or neutron | 13:23 |
| sean-k-mooney | its a purely ironic only network construct | 13:24 |
| mnaser | Yeah and the only place that l | 13:24 |
| mnaser | "Bond" network data is generated is config drive | 13:24 |
| mnaser | So otherwise if I use metadata ill have to do this manually after system boot | 13:25 |
| sean-k-mooney | so ironic has it own enrechment of the stand metadta https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1045-L1106 | 13:25 |
| sean-k-mooney | for the network info | 13:25 |
| sean-k-mooney | which is all custom for the ironic integration and not part of how this normally works | 13:25 |
| mnaser | The enrichment relies on the get network metadata returning the right thing and that doesn't do that so that's how we end up where we are :p | 13:26 |
| sean-k-mooney | right os most if not all other dirver use the commeon code that is shared with the api for generating this metadtaa | 13:27 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L112 | 13:27 |
| sean-k-mooney | so they generate there enriched config driver here when calling provision https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1239-L1258 | 13:29 |
| mnaser | I think attach_interface is how ports are plugged? | 13:29 |
| sean-k-mooney | so port bidnign is intened to happen in the compute manger and that is when the ip should be assigend | 13:30 |
| sean-k-mooney | and then port pluggin is where we are ment to talk to the network backend to make sure the ports are conencted on the swtich | 13:30 |
| sean-k-mooney | virutal or otherwise | 13:30 |
| sean-k-mooney | and tha tis when we are ment to waith for the network-vif-plugged evnet | 13:30 |
| sean-k-mooney | plug_vifs in the ironic driver is a noop | 13:31 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1567-L1638 | 13:31 |
| sean-k-mooney | that is breakign the virt dirver contract by how its delegating the attachment | 13:32 |
| dansmith | sean-k-mooney: juicy OTU series just waiting for +Ws :) https://review.opendev.org/c/openstack/nova/+/944148 | 13:33 |
| sean-k-mooney | dansmith: yes... im aware. im slightly anooyed at you for askign for an os-traits release when i ask not to do that unlie we landed teh vdi traits but its on my list to look at before the ptg | 13:34 |
| mnaser | Now I'm wondering where does it even get the ports from... Unless it doesn't and ironic does that stuff behind the scenes? | 13:34 |
| sean-k-mooney | mnaser: so attach_interface is ment to be for adding/removing port after the "server" is created | 13:35 |
| mnaser | That's what I thought... | 13:35 |
| dansmith | sean-k-mooney: you did? I'm sorry | 13:35 |
| mnaser | So that means the neutron vif plug happens when the spawn is called | 13:35 |
| sean-k-mooney | dansmith: its fine, release are cheap | 13:35 |
| sean-k-mooney | mnaser: ya internaly in ironic | 13:36 |
| mnaser | So I think it might be impossible to get configdrive then | 13:36 |
| dansmith | sean-k-mooney: yeah, I honestly never would have though it would be worth ever holding a release to batch up more than one | 13:36 |
| mnaser | Because the plug happens after we call ironic to spawn with configdrive included. | 13:37 |
| mnaser | I see what you mean about the whole callback thing now | 13:37 |
| mnaser | Uuuuuugh | 13:37 |
| sean-k-mooney | dansmith: well last time i ask peole said they woudl take a look at the traits patch and didnt. gibi did look this time to give them credit | 13:37 |
| sean-k-mooney | mnaser: this is one of the large pices of technial debt with the ironic driver | 13:37 |
| sean-k-mooney | its doign several things its not allowed to do | 13:37 |
| dansmith | sean-k-mooney: link me | 13:38 |
| sean-k-mooney | including changign the vnic type ot baremetal | 13:38 |
| sean-k-mooney | dansmith: its no kind of blockd on use approving the specless blueprint which si now a ptg topic but sure on sec | 13:38 |
| dansmith | sean-k-mooney: okay well if I had realized I would have argued not to block my thing on another blocked thing, especially since "releases are cheap" :) | 13:39 |
| sean-k-mooney | dansmith: its https://review.opendev.org/c/openstack/os-traits/+/940418 | 13:39 |
| sean-k-mooney | dansmith: we can wait till melwitt has a chance ot respond or till the ptg | 13:40 |
| sean-k-mooney | dansmith: anyway ill try and get to the OTU device tommorw or this evening | 13:40 |
| dansmith | yeah, sounds like that's the best idea | 13:40 |
| sean-k-mooney | mnaser: i think port bidning is still done in nova. | 13:41 |
| sean-k-mooney | mnaser: if we can confirm that we may be able ot tweak plug_vifs to refesh the cache or soemthign like that to get the ip in teh defered case | 13:41 |
| sean-k-mooney | mnaser: but its kind of building one hack on top of anohter | 13:41 |
| sean-k-mooney | unless we can do that in a common way in the compute manger of coruse | 13:42 |
| mnaser | hmm yea | 13:43 |
| mnaser | Do other drivers rely on compute manager to bind the ports? | 13:43 |
| sean-k-mooney | yes | 13:44 |
| sean-k-mooney | virt drivers are not allowed to do it | 13:44 |
| sean-k-mooney | tehy can do port pluging | 13:44 |
| sean-k-mooney | btu that a diffent thing | 13:44 |
| sean-k-mooney | as i said the ironic dirver or ironci its self is doing thing that its not technailly allowed to do like modifyiing cidner volume attachmetn or neutron ports | 13:45 |
| mnaser | I see, so then technically we should have a bound port at some point when we generate the config drive | 13:45 |
| sean-k-mooney | i dont thinke we will | 13:45 |
| mnaser | Like I know this sounds stupid but as a workaround for me now a sleep and a refresh of network info can potentially make the ip arrive? | 13:46 |
| sean-k-mooney | because im not sure any of the prot groups stuff for the bonds will be done when we bind but i might be wrong | 13:46 |
| mnaser | It doesn't matter since all I need is for the IPs to be there on the neutron port | 13:46 |
| sean-k-mooney | mnaser: ill point out that we never added supprot for l3 rounte network to the ironic driver in nova as far as i recall | 13:46 |
| sean-k-mooney | we added some generic supprpot but it was never tested with ironic | 13:47 |
| sean-k-mooney | and i doing think it was supproted in the nova spec | 13:47 |
| mnaser | The ironic code even sorta handles the port group and maps it automatically | 13:47 |
| mnaser | And updates the Mac address in the config | 13:47 |
| mnaser | So I'm pretty sure if Nova manager binds it, we should be able to fix things if we wait? | 13:48 |
| sean-k-mooney | i think we would have to call attach_interface to trigger that | 13:49 |
| sean-k-mooney | port bidnign is the process of setting a binding:host on the neutron port to the hostname of the relvent host | 13:49 |
| sean-k-mooney | that casuse the neutron ml2 driver to update the port | 13:50 |
| sean-k-mooney | with extra data like the ip | 13:50 |
| sean-k-mooney | however we dont know the mac adress of interface in nvoa unless we are looking that up form ironci or anytihng about the port groups again unless we are calling out to ironic | 13:50 |
| sean-k-mooney | the ironic driver moved all fo that to ironic so they could have a singel code path for that in ironic for standaloen mode | 13:51 |
| sean-k-mooney | mnaser: a simpler way to do this might be to modify ironic to just update the content of the config drive wehn it does all the networking setup | 13:52 |
| sean-k-mooney | that doubling down on the wrong behavior but if they are modifying networkhing out of band then updating the metadta to reflect that makes sense | 13:52 |
| dansmith | sean-k-mooney: https://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.2025-04-01.log.html#t2025-04-01T14:09:06 | 13:54 |
| dansmith | sean-k-mooney: to be fair, you were talking to gibi not me.. I did show up a few minutes later (first thing in the morning) asking gibi a question about a gerrit review, but I obviously didn't read back the scroll there | 13:54 |
| sean-k-mooney | ya thats fair. | 13:55 |
| sean-k-mooney | i expected Uggla to rely that into the release patch | 13:55 |
| dansmith | also, what's not fair is how hard it is to grep logs for something sean-k-mooney said.. "grep sean-k-mooney.*release 2025*.log" .. no results :D | 13:56 |
| sean-k-mooney | :) there use to be a hound instnace that someone ran that had all the irc logs | 13:56 |
| sean-k-mooney | liek 8-10 year ago | 13:56 |
| sean-k-mooney | it was kind of nice to be able to find thing | 13:56 |
| dansmith | sean-k-mooney: honestly, every time I add something to os-traits I get really upset about how incredibly silly the process is that we've designed for getting string constants into nova | 13:56 |
| sean-k-mooney | ya | 13:57 |
| sean-k-mooney | so that was added by mikal as a ptg topic | 13:57 |
| sean-k-mooney | askign if we can avoid the dance somehow | 13:57 |
| dansmith | write nova patch, write os-traits patch, merge os-traits, release os-traits, merge upper-constraints, bump requirements.. only then can you go back to the first step and run tests on the nova patch :( | 13:57 |
| sean-k-mooney | we coudl have nova just create the standard traits on start up if not present | 13:57 |
| dansmith | sean-k-mooney: I proposed this per gmann to cut out one step at least https://review.opendev.org/c/openstack/requirements/+/946183 | 13:58 |
| sean-k-mooney | hum that could help | 13:58 |
| dansmith | feel free to +1 to show your support :D | 13:58 |
| sean-k-mooney | we stil have an annoying coupleing dance with placeemtn too | 13:58 |
| sean-k-mooney | this applies to os-ressouce classes too. | 13:59 |
| dansmith | yes, honestly we should just squash placement and os-traits back into nova to solve it for good :D | 13:59 |
| sean-k-mooney | well we solve it for us. but then we force neutorn et all to land a patch to nova to add a triat | 13:59 |
| sean-k-mooney | what i was consdiring is allowing anytihng with a service role to add standard traits via the api | 14:00 |
| dansmith | ...which is still less work than they have to do currently with os-traits, releases, requirements, etc :) | 14:00 |
| dansmith | idk, that's a much larger step | 14:00 |
| sean-k-mooney | it is | 14:00 |
| sean-k-mooney | the other thing i codnered was sevador plugin | 14:01 |
| sean-k-mooney | i.e. have an entry poirnt for addign traits | 14:01 |
| sean-k-mooney | btu that feel more complex | 14:01 |
| sean-k-mooney | dansmith: https://etherpad.opendev.org/p/nova-2025.2-ptg#L235 that where mikal still expressed there furstration with the current workflow | 14:02 |
| dansmith | that's sort of a different complaint, but yeahj | 14:03 |
| opendevreview | Masahito Muroi proposed openstack/nova master: Use dict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658 | 14:09 |
| mnaser | sean-k-mooney: this all seems to be an ironic issue for now at the moment so maybe i'll take that there but thank you | 14:11 |
| sean-k-mooney | mnaser: ack, we do have a related issue with the generic code path for port that never have ip adress | 14:12 |
| sean-k-mooney | but that technially a differnt bug | 14:12 |
| sean-k-mooney | we shoudl be providing the mac info from neutron if the ip_allcoation policy is none but that is nto what happens today | 14:13 |
| dansmith | Uggla: by the way, on the otu session you scheduled.. even if we don't need to discuss otu specifically, we can discuss the placement bug fix that is related to it (and migration while over capacity) | 15:08 |
| dansmith | that may be contentious (not sure) but might benefit from discussion at least | 15:08 |
| Uggla | dansmith, sure. I will add a note about it. | 15:10 |
| gibi | +1 to mention that | 15:10 |
| sean-k-mooney | i think tehre are enough bugs related to it that it would be contorvisal | 15:11 |
| sean-k-mooney | but sure good to highlight it in general | 15:11 |
| dansmith | sean-k-mooney: ? | 15:11 |
| sean-k-mooney | the placement bug fix | 15:12 |
| sean-k-mooney | like we have at least 3 bugs form diffent people related to it | 15:12 |
| dansmith | "enough bugs" makes it controversial? | 15:12 |
| sean-k-mooney | sorry not controversial | 15:12 |
| dansmith | ah | 15:13 |
| sean-k-mooney | the approch to fixign it might be, i dont know but the fact the current bavhior is surpising to poeple is demonstarted by the exising bug reports | 15:13 |
| dansmith | right, I meant the actual approach might be controversial | 15:14 |
| dansmith | but I'd definitely like the opportunity to make my case for why I think this approach is the right one | 15:14 |
| sean-k-mooney | i dont really see many other options to fixing it that would be backportable so that a vote in favor of the appoch | 15:14 |
| sean-k-mooney | but ya lets see what others think next week | 15:15 |
| dansmith | yeah, I agree of course.. but people may have religious/idealistic objections, idk | 15:15 |
| sean-k-mooney | as an aside i might call it soon. im feellign progressively worse. soim going to take some panadol and get a hot drink if that does nto help ill call it a day | 15:15 |
| dansmith | ack, melwitt just approved the traits patch | 15:16 |
| opendevreview | Merged openstack/os-traits master: Add traits for sound and USB devices on instances. https://review.opendev.org/c/openstack/os-traits/+/940418 | 15:18 |
| sean-k-mooney | cool melwitt ++ | 15:24 |
| melwitt | sean-k-mooney: just in case you missed it, from your comment I added a repro func test under this and also a reno https://review.opendev.org/c/openstack/nova/+/880399 | 15:31 |
| melwitt | note that the func test doesn't cover the "old" cinder API path, I wasn't sure if it needs to i.e. I wasn't sure if the old Cinder path is something we expect to be possible at this point/release | 15:32 |
| sean-k-mooney | i had not seen that | 15:34 |
| sean-k-mooney | but cool | 15:35 |
| sean-k-mooney | on a related not i have a cinder volume multi attch pathc i need to clean up and push again.. | 15:35 |
| sean-k-mooney | https://review.opendev.org/q/topic:%22bug/2048837%22 but its in merge conflict so no need ot look now. | 15:37 |
| sean-k-mooney | there are a couple of volume related pathces in diffetn state aroudn at the moment | 15:37 |
| melwitt | ack | 15:39 |
| sean-k-mooney | weried os before we alwasy faked the volujme was attached even fi it was not assocated ot teh vm | 15:40 |
| melwitt | what? :) | 15:41 |
| sean-k-mooney | melwitt: https://review.opendev.org/c/openstack/nova/+/946222/1/nova/tests/fixtures/cinder.py#271 | 16:14 |
| sean-k-mooney | i was commenting on the addtion of the if | 16:14 |
| sean-k-mooney | not that what i orginally type convayed that particallary well | 16:16 |
| melwitt | sean-k-mooney: oh haha | 16:26 |
| melwitt | yeah the cinder fixture is a little wonky | 16:27 |
| sean-k-mooney | +1 but im not entirlly sure how stable the looping is | 16:47 |
| sean-k-mooney | comments inlien | 16:47 |
| sean-k-mooney | we often use threading.evetns of locs when we want to encfoce a specific ordering | 16:48 |
| sean-k-mooney | melwitt: im going to run your repoducer in a loop for a bit and see if its sable | 16:49 |
| sean-k-mooney | melwitt: have you done that? | 16:49 |
| melwitt | sean-k-mooney: no I didn't | 16:49 |
| melwitt | I'll adjust things based on your comments. I haven't really done a func test like this before where it is more about checking the state of a resource in a different component, so I may have done it not the best way | 16:50 |
| sean-k-mooney | well i think yoru test is fine. i just know that we have had issues with retry loops in fucntional tests before | 16:51 |
| sean-k-mooney | so if we can force the ordering more explcitly that can help | 16:51 |
| sean-k-mooney | ill let this run for a while and if it passes 50-100 times its proably ok | 16:52 |
| sean-k-mooney | i think we can impove things if we reuse some of the helpers but im no tsure we strictly need too for this to prove what it needs too | 16:52 |
| sean-k-mooney | ya the cidner fixutre behvaior is a litttel odd in places | 16:53 |
| sean-k-mooney | but its also non trivial to emulate os im not really surpised | 16:53 |
| sean-k-mooney | melwitt: ah https://review.opendev.org/c/openstack/nova/+/919979/4/nova/tests/functional/integrated_helpers.py | 16:54 |
| sean-k-mooney | i _attch_volume for my multi attach repoducer | 16:54 |
| melwitt | yeah I think my concern with it is if it could possibly "skip" the status "detaching" due to timing differences. so I won't be surprised if need to do the wait a different way | 16:55 |
| sean-k-mooney | i was very confused why i did nto find it when i went looking | 16:55 |
| sean-k-mooney | melwitt: so there are some exmples form gibi useing treading.event | 16:56 |
| sean-k-mooney | to get thisn to pause in a specific state | 16:56 |
| melwitt | oh my bad, I either didn't see that or there was some reason it didn't work for me and I forgot. but more likely the former | 16:56 |
| sean-k-mooney | mainly for networking i think | 16:56 |
| sean-k-mooney | no _attach_volume is not merged | 16:57 |
| sean-k-mooney | its in that other volume serises i mentioend to you that i need to respine | 16:57 |
| melwitt | when I first started this test I used libvirt func test base which super did not work and is not needed anyway and I changed it | 16:57 |
| melwitt | oh haha ok, didn't realize that was an unmerged patch | 16:57 |
| sean-k-mooney | so i last worked ont hat patch 6 months ago so in my brain its totally merged | 16:58 |
| melwitt | :) | 16:58 |
| sean-k-mooney | but i keep not geting around to rebaseing it | 16:58 |
| sean-k-mooney | melwitt: so this is what i was referint too https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_2085975.py | 17:00 |
| sean-k-mooney | using trheading event to allow use to pause thing in speciifc places | 17:00 |
| melwitt | ah ok, thanks | 17:00 |
| sean-k-mooney | that might not be appliable to this case but its ther if you thing it would be useful basicly you woudl set the evnet in the palce your raising | 17:01 |
| sean-k-mooney | and we woudl wait on it were we currently have the retry loop | 17:02 |
| melwitt | gotcha. yeah that might be nicer | 17:02 |
| sean-k-mooney | ====== | 17:03 |
| sean-k-mooney | Totals | 17:03 |
| sean-k-mooney | ====== | 17:03 |
| sean-k-mooney | Ran: 100 tests in 700.9413 sec. | 17:03 |
| sean-k-mooney | - Passed: 100 | 17:03 |
| sean-k-mooney | - Skipped: 0 | 17:03 |
| sean-k-mooney | - Expected Fail: 0 | 17:03 |
| sean-k-mooney | - Unexpected Success: 0 | 17:03 |
| sean-k-mooney | - Failed: 0 | 17:03 |
| sean-k-mooney | Sum of execute time for each test: 353.3871 sec. | 17:03 |
| sean-k-mooney | i mean it seam to work as it is | 17:03 |
| sean-k-mooney | so im less concerned now | 17:03 |
| melwitt | yeah I think what could mess it up is if the timing was sufficiently bad, like what if the _wait got delayed due to CI node busyness and it misses the intermediate state of "detaching". so I think you're right there is some instability possible there | 17:05 |
| sean-k-mooney | ya it could happen. we could rehceck it once or twice | 17:06 |
| sean-k-mooney | its a test only change so it does not run tempest | 17:06 |
| sean-k-mooney | so rechecking is cheap | 17:06 |
| melwitt | yeah. I'll try the event thing. oh right | 17:06 |
| sean-k-mooney | ack, no worreis if you dont hcange it. i upgraded to +2 and rechecked | 17:07 |
| melwitt | and also I was thinking future failures after it merged | 17:07 |
| sean-k-mooney | if we recheck once more after that | 17:07 |
| sean-k-mooney | i think we are good | 17:07 |
| sean-k-mooney | ya its the future case that i was thinking of | 17:08 |
| sean-k-mooney | we have loops like this today | 17:08 |
| sean-k-mooney | but we have had issues with them too | 17:08 |
| sean-k-mooney | so im alwasy cautious when adding more | 17:08 |
| melwitt | yeah. also probably wastes some time due to the loop | 17:08 |
| sean-k-mooney | technially yes but its 3.5 seccond pretty reliably on my laptop | 17:09 |
| sean-k-mooney | not amazing but not terrible | 17:09 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!