Friday, 2024-12-06

opendevreviewmelanie witt proposed openstack/nova master: libvirt: Add conf option for live migration monitor interval  https://review.opendev.org/c/openstack/nova/+/93722302:54
opendevreviewTakashi Kajinami proposed openstack/nova master: Replace deprecated FormatChecker.cls_checks  https://review.opendev.org/c/openstack/nova/+/93573303:13
opendevreviewTakashi Kajinami proposed openstack/placement master: Replace deprecated FormatChecker.cls_checks  https://review.opendev.org/c/openstack/placement/+/93573403:15
*** elodilles_pto is now known as elodilles07:23
opendevreviewKaloyan Kotlarski proposed openstack/nova master: libvirt: Fetch the available vCPUs from the respective cgroup  https://review.opendev.org/c/openstack/nova/+/92747407:59
amorinhey all, am I wrong saying that the availability-zone param set on boot is immutable? E.G. if I forgot to set it, I will end-up without any AZ pinned, nova will schedule my instance on a specific az, but I have no way to pin that later without delete/recreate?10:52
opendevreviewStephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (1/3)  https://review.opendev.org/c/openstack/nova/+/93724510:55
opendevreviewStephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (2/3)  https://review.opendev.org/c/openstack/nova/+/93724610:55
opendevreviewStephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (3/3)  https://review.opendev.org/c/openstack/nova/+/93724710:55
opendevreviewTakashi Kajinami proposed openstack/nova master: Replace deprecated FormatChecker.cls_checks  https://review.opendev.org/c/openstack/nova/+/93573311:35
opendevreviewIldiko Vancsa proposed openstack/nova master: Update contributor process documentation  https://review.opendev.org/c/openstack/nova/+/93675913:56
opendevreviewIldiko Vancsa proposed openstack/nova master: Update contributor process documentation  https://review.opendev.org/c/openstack/nova/+/93675914:18
ildikovsean-k-mooney: I saw your comment in the contributor doc patch about updating the README.rst file in the root of the nova repo. I'm a little confused in terms of having both the index.rst and contributing.rst with similar information and most places in the different READMEs point to contributing.rst.14:36
ildikovI updated the README as you suggested, but it is inconsistent with other references now. Should it still point to contributing.rst and have a direct link to process.rst in addition?14:38
opendevreviewIldiko Vancsa proposed openstack/nova master: Update contributor process documentation  https://review.opendev.org/c/openstack/nova/+/93675914:46
ildikovsean-k-mooney: gmann has a patch that adds a new link to the tracking etherpad in contributing.rst. I think that would be a better place to update links and references, and make sure that the changes are consistent throughout the Nova repo: https://review.opendev.org/c/openstack/nova/+/936776/1/doc/source/contributor/contributing.rst14:48
ildikovWhat do you all think?14:49
sean-k-mooneyyep we can do that too14:49
sean-k-mooneybut part of the problemis its quite hard to find the process doc in the contibutor docs14:50
sean-k-mooneythere is a lot of text too read through first14:50
sean-k-mooneyso that is why i wated to add riectrly links to the process doc in the readme14:50
sean-k-mooney*direct links14:51
sean-k-mooneyi dont want to link directly to the etherpad there 14:51
sean-k-mooneyildikov: developer will generally look at the git repo before anythign else so that why i wante to have this clear in the readme14:53
sean-k-mooneywe can do that as a sperate chagne if you want but it took me some time to find the prcoess doc when i wanted to find the links for the comment14:53
ildikovsean-k-mooney: I don't question the value to add links to the process doc more directly, I'm personally good with that direction14:56
sean-k-mooneyok ill just submit a patch for that later myself14:56
ildikovbased on pervious discussions, it doesn't seem like there's an overall agreement on what should be linked from where14:56
ildikovand I would like to avoid holding up landing the process documentation, because people don't agree on where to put what link :)14:57
sean-k-mooneymy main concern is peopel still wont find the procss doc 14:57
sean-k-mooneythe feed back we got was there was very littel docusmation for contibutors and as you have seen that is not the case14:58
sean-k-mooneyso +1 for makeign the exitsing docs correct14:58
ildikovI can add the process doc link back into my patch, and leave the decision to another path whether or not to update the link to contributing.rst vs contributor/index.rst14:58
sean-k-mooneybut we need to also fix the discoveray aspect14:58
ildikovwould that be a good middle ground?14:58
sean-k-mooneysure14:59
ildikovok, cool14:59
sean-k-mooneyfindig that process link was actully what took time14:59
ildikovand yes, I totally agree on the discoverability aspect14:59
sean-k-mooneyso that the part i find hard to discover14:59
ildikov+114:59
opendevreviewIldiko Vancsa proposed openstack/nova master: Update contributor process documentation  https://review.opendev.org/c/openstack/nova/+/93675915:01
ildikovsean-k-mooney: done ^^15:02
-opendevstatus- NOTICE: Gerrit on review.opendev.org is being upgraded to version 3.10 and will be offline. We have allocated an hour for the outage window lasting until 1700 UTC.15:03
ildikovI also consolidated the template part in process.rst, I missed your comment on that earlier, apologies for the delay on that.15:03
sean-k-mooneyno worries15:03
sean-k-mooneyim ok with the current version15:04
ildikovawesome, thank you for checking!15:04
sean-k-mooneyi was ok without consolidating them by the way15:04
ildikovah ok, I wasn't sure15:04
ildikovwith the comment from bauzas, I think it's better consolidated15:05
sean-k-mooneyi wanted the template but not pushed on which is more readable15:05
sean-k-mooneyso if sylvain has a prefence thats fine by me15:05
-opendevstatus- NOTICE: Gerrit on review.opendev.org is being upgraded to version 3.10 and will be offline starting at 1600 UTC. We have allocated an hour for the outage window lasting until 1700 UTC.15:06
ildikovsounds good15:13
ildikovI'll keep an eye out for his review and see if there are any more updates he would like to have15:13
opendevreviewIldiko Vancsa proposed openstack/nova master: Update contributor process documentation  https://review.opendev.org/c/openstack/nova/+/93675915:16
ildikovit looks like I got the formatting wrong in rst, haven't done rst in a while so I'm a bit rusty :)15:17
opendevreviewBalazs Gibizer proposed openstack/placement master: Add a global limit on the number of allocation candidates  https://review.opendev.org/c/openstack/placement/+/93665815:23
opendevreviewBalazs Gibizer proposed openstack/placement master: Add round-robin candidate generation strategy  https://review.opendev.org/c/openstack/placement/+/93683215:23
opendevreviewBalazs Gibizer proposed openstack/placement master: Add a global limit on the number of allocation candidates  https://review.opendev.org/c/openstack/placement/+/93665815:24
opendevreviewBalazs Gibizer proposed openstack/placement master: Add round-robin candidate generation strategy  https://review.opendev.org/c/openstack/placement/+/93683215:24
opendevreviewIldiko Vancsa proposed openstack/nova master: Update contributor process documentation  https://review.opendev.org/c/openstack/nova/+/93675915:30
gibimelwitt: thanks for volunteering of looking at the placement a_c explosion fix. The first patch of the series in https://review.opendev.org/q/topic:%22bug/2070257%22 is ready for review. The second is also already working but I still intended to clean it up so that is WIP but any feedback is highly appreciated 15:35
gibimelwitt: I'm working on getting timing and memory numbers for comparision of before / after the fix and I will add that to the commit message as soon as I can convince my test node to build not just 4 but 8 devstack VMs15:37
-opendevstatus- NOTICE: Gerrit on review.opendev.org is being upgraded to version 3.10 and will be offline momentarily. We have allocated an hour for the outage window lasting until 1700 UTC.16:01
opendevreviewMerged openstack/nova master: api: Add response body schemas for assisted volume snapshots APIs  https://review.opendev.org/c/openstack/nova/+/92458816:20
opendevreviewBalazs Gibizer proposed openstack/placement master: Add round-robin candidate generation strategy  https://review.opendev.org/c/openstack/placement/+/93683217:39
opendevreviewBalazs Gibizer proposed openstack/placement master: Factor out allocation candidate generation strategy  https://review.opendev.org/c/openstack/placement/+/93727317:39
opendevreviewBalazs Gibizer proposed openstack/placement master: DNM: test with breadth-first in tempest  https://review.opendev.org/c/openstack/placement/+/93727417:39
opendevreviewBalazs Gibizer proposed openstack/nova master: DNM: test with placement ac breadth-first  https://review.opendev.org/c/openstack/nova/+/93727517:41
gmannildikov: current version lgtm, thanks for updates18:00
ildikovgmann: great, thank you for checking!18:24
opendevreviewMerged openstack/nova master: Replace deprecated FormatChecker.cls_checks  https://review.opendev.org/c/openstack/nova/+/93573318:38
opendevreviewMerged openstack/nova master: Attach Manila shares via virtiofs (API)  https://review.opendev.org/c/openstack/nova/+/83683018:38
opendevreviewMerged openstack/nova master: Add helper methods to attach/detach shares  https://review.opendev.org/c/openstack/nova/+/88575318:39
opendevreviewArtom Lifshitz proposed openstack/nova-specs master: vTPM live migration  https://review.opendev.org/c/openstack/nova-specs/+/93677521:05
opendevreviewMerged openstack/nova master: Add instance.share_attach notification  https://review.opendev.org/c/openstack/nova/+/85050122:29

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!