Tuesday, 2024-11-19

opendevreviewmelanie witt proposed openstack/nova master: nova-manage: Add flavor scanning to migrate_to_unified_limits  https://review.opendev.org/c/openstack/nova/+/92411000:02
opendevreviewKoya Watanabe proposed openstack/placement master: Add memcached packages  https://review.opendev.org/c/openstack/placement/+/93557600:54
opendevreviewGhanshyam proposed openstack/nova master: Update gate jobs as per the 2025.1 cycle testing runtime  https://review.opendev.org/c/openstack/nova/+/93264801:12
opendevreviewGhanshyam proposed openstack/nova master: Testing doc job on Ubuntu Noble  https://review.opendev.org/c/openstack/nova/+/93557701:15
opendevreviewGhanshyam proposed openstack/os-resource-classes master: Update python classifier as per the 2025.1 cycle testing runtime  https://review.opendev.org/c/openstack/os-resource-classes/+/93557801:33
opendevreviewGhanshyam proposed openstack/osc-placement master: Update python classifier as per the 2025.1 cycle testing runtime  https://review.opendev.org/c/openstack/osc-placement/+/93557901:33
opendevreviewGhanshyam proposed openstack/os-vif master: Update gate jobs as per the 2025.1 cycle testing runtime  https://review.opendev.org/c/openstack/os-vif/+/93558001:33
opendevreviewGhanshyam proposed openstack/placement master: Update gate jobs as per the 2025.1 cycle testing runtime  https://review.opendev.org/c/openstack/placement/+/93558101:34
opendevreviewGhanshyam proposed openstack/os-traits master: Update python classifier as per the 2025.1 cycle testing runtime  https://review.opendev.org/c/openstack/os-traits/+/93558201:35
opendevreviewGhanshyam proposed openstack/python-novaclient master: DNM: Testing ubuntu noble  https://review.opendev.org/c/openstack/python-novaclient/+/93558301:50
opendevreviewGhanshyam proposed openstack/osc-placement master: Update python classifier as per the 2025.1 cycle testing runtime  https://review.opendev.org/c/openstack/osc-placement/+/93557902:24
opendevreviewTakashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support  https://review.opendev.org/c/openstack/nova/+/92568502:42
opendevreviewTakashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property  https://review.opendev.org/c/openstack/nova/+/92770602:42
opendevreviewTakashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption  https://review.opendev.org/c/openstack/nova/+/92610602:43
opendevreviewmelanie witt proposed openstack/nova-specs master: Re-propose config option for behavior of unset unified limits  https://review.opendev.org/c/openstack/nova-specs/+/93439104:29
opendevreviewGhanshyam proposed openstack/os-vif master: Update gate jobs as per the 2025.1 cycle testing runtime  https://review.opendev.org/c/openstack/os-vif/+/93558004:31
opendevreviewmelanie witt proposed openstack/nova-specs master: Re-propose config option for behavior of unset unified limits  https://review.opendev.org/c/openstack/nova-specs/+/93439105:14
zigotkajinam: sean-k-mooney: Please reconsider your review after reading my comments at https://review.opendev.org/c/openstack/nova/+/93551207:32
*** __ministry is now known as Guest16307:34
*** elodilles_pto is now known as elodilles08:03
opendevreviewzhou zhong proposed openstack/nova master: ESFIX: Add auto_converge parameters for invoking the migration  https://review.opendev.org/c/openstack/nova/+/93561409:14
opendevreviewzhou zhong proposed openstack/nova master: ESFIX: Add auto_converge parameters for invoking the migration  https://review.opendev.org/c/openstack/nova/+/93561409:15
opendevreviewzhou zhong proposed openstack/nova master: Add auto_converge parameters for invoking the migration  https://review.opendev.org/c/openstack/nova/+/93561409:17
opendevreviewzhou zhong proposed openstack/nova master: Add auto_converge parameters for invoking the migration  https://review.opendev.org/c/openstack/nova/+/93561409:23
zigo25 test failures for Nova under Python 3.13: https://bugs.launchpad.net/nova/+bug/208899910:21
zigo24 are flavor related, one must be my own patch failing.10:31
fricklerzigo: trying to run this locally I'm seeing "TypeError: 'PipeMutex' object does not support the context manager protocol" during discovery, does that ring a bell for you? do you have more fixes than just 935512?11:15
zigofrickler: The patch from tkajinam https://review.opendev.org/c/openstack/oslo.log/+/935620 fixed it for me.11:17
zigoAlso, I may have the fix for the issue I just reported ! :)11:18
zigo(my patch repaired at least one unit tests, running them all now...)11:18
opendevreviewThomas Goirand proposed openstack/nova master: Python 3.13: Repair fake_flavor_get_by_id  https://review.opendev.org/c/openstack/nova/+/93563111:25
fricklerzigo: ah, tkajinam ftw, thx11:26
zigoThis looks like failing under Py 3.13 as well:11:39
zigo        msg = _('User %(username)s not found in password file.')11:39
zigo        raise exception.NovaException(msg % username)11:39
zigowith:11:39
zigoTypeError: format requires a mapping11:39
zigoAnyone got a clue?11:39
sean-k-mooneyi think its saying that the right hand side need to be a dict11:41
sean-k-mooneyi guess in the past named parmatere i.e. %(username)s could take postional replacements and they got stricter about that in 3.1311:41
sean-k-mooneyso its expexting (msg % {'username': username})11:42
sean-k-mooneybut i would just replace %(username)s with %s11:42
zigoOk, so I should just replace username by {'username': username} ?11:43
zigoI can try ... :P11:43
sean-k-mooneythat or update msg = _('User %(username)s not found in password file.') to msg = _('User %s not found in password file.')11:43
sean-k-mooneyeither both should be useing named paramaters or both should be postional11:43
sean-k-mooneyits unhappy that we are mixing them11:43
zigoI'm trying the first solution, so it doesn't break translations.11:45
zigoDo we still care about these btw? I thought we were to just stop translating error messages ...11:45
zigosean-k-mooney: Fixed ! :)11:49
zigoNow I'm worried we have this type of raise all over the place ...11:50
zigoHum... doesn't look like it.11:51
sean-k-mooneyim kind of surprised that this was never flagged by a linter11:52
sean-k-mooneysome projects have been more agressive with replacing percent strings with fstring so that woudl also remove that issue11:52
opendevreviewThomas Goirand proposed openstack/nova master: Fix exception raising in inject_data  https://review.opendev.org/c/openstack/nova/+/93564011:54
opendevreviewThomas Goirand proposed openstack/nova master: Fix exception raising in _set_passwd()  https://review.opendev.org/c/openstack/nova/+/93564011:55
sean-k-mooneyzigo: did you hit yappi/_yappi.c:1288:5: error: implicit declaration of function ‘_PyEval_SetProfile’; did you mean ‘PyEval_SetProfile’? [-Wimplicit-function-declaration]11:56
sean-k-mooneyi was trying to run the unit test with 3.13 locally11:57
zigosean-k-mooney: Yeah, I fixed that one, you need a local rebuild of yappi probably (since it's a .so based module).11:58
zigoDebian Unstable is already fixed for that.11:58
sean-k-mooneyack im using testing so i guess i need to wait or clone and buidl that myslef11:58
sean-k-mooneyi can test this in a vm instead11:58
zigoI used version 1.6.10 instead of 1.6.<something>.11:59
zigoMaybe just bump it?11:59
sean-k-mooneyyou mean bump the distro packages or the python dep in a requirements file12:00
zigoWhatever you're using, yeah ... :P12:00
sean-k-mooneyi need to hop on a 1:1 but i can do a ful dist upgrade after the call12:00
sean-k-mooneyoh thats not for 30 mins12:00
sean-k-mooneysorry im using sid which is unstable so ok hopefuly that will fix that12:02
sean-k-mooneyzigo: do you know if the version of yappi you used is allwod by uc?12:09
sean-k-mooneythat would be a no12:10
sean-k-mooneyyappi===1.6.012:10
sean-k-mooneyok so thats why its failign localy i can overried with a different version12:10
sean-k-mooneyim not sure why that has not been bumpted recently12:12
zigoThanks for taking care of it.12:52
opendevreviewTakashi Kajinami proposed openstack/nova master: Migrate MEM_ENCRYPTION_CONTEXT from root provider  https://review.opendev.org/c/openstack/nova/+/92181413:24
opendevreviewTakashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support  https://review.opendev.org/c/openstack/nova/+/92568513:24
opendevreviewTakashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property  https://review.opendev.org/c/openstack/nova/+/92770613:25
opendevreviewTakashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property  https://review.opendev.org/c/openstack/nova/+/92770613:26
opendevreviewTakashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption  https://review.opendev.org/c/openstack/nova/+/92610613:26
opendevreviewsean mooney proposed openstack/os-vif master: address test stablity under load  https://review.opendev.org/c/openstack/os-vif/+/93565313:30
sean-k-mooneyzigo: tkajinam im hoping  ^ will fix the intermitent os-vif ci failure13:40
tkajinamsean-k-mooney, ah, thanks !13:44
sean-k-mooneyoh pep8 failure because we have not merged the pre-commit change yet...13:48
sean-k-mooneyim way to used to using pre-commit to run linting at this point13:48
sean-k-mooneyon the plus side it passed ci https://zuul.opendev.org/t/openstack/build/e2c5522cfee741dd89a731afc9c8b19e13:48
sean-k-mooneyso ill fix that locally and push again13:48
sean-k-mooneyalthough it passed with a short exectuion time so this also ran on a fast worker vif_plug_ovs.tests.functional.ovsdb.test_ovsdb_lib.TestOVSDBLib.test_create_ovs_vif_port_with_default_qos(native) [0.746099s] ... ok13:50
opendevreviewsean mooney proposed openstack/os-vif master: address test stablity under load  https://review.opendev.org/c/openstack/os-vif/+/93565313:52
tkajinamCan I ask for 2nd +2 to https://review.opendev.org/c/openstack/nova/+/930726 ? this removes eventlet related code.15:03
tkajinamand there are a few trivial cleanups pending on 2nd +2s and I appreciate any feedback   https://review.opendev.org/c/openstack/nova/+/934517 https://review.opendev.org/c/openstack/nova/+/93114615:04
sean-k-mooneyi think im already +2 on all of those but yes i think those are all easy wins15:12
tkajinamsean-k-mooney, yeah, and thanks for these +2s :-)15:26
gibitkajinam: I'm +A both. Thanks for the cleanup15:41
bauzasreminder: nova meeting in 5 mins15:55
bauzas#startmeeting nova16:00
opendevmeetMeeting started Tue Nov 19 16:00:13 2024 UTC and is due to finish in 60 minutes.  The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
opendevmeetThe meeting name has been set to 'nova'16:00
bauzashello everyone16:00
bauzas#link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting16:00
bauzaswho's around ?16:01
elodilleso/16:01
bauzaslet's wait for a few more16:01
bauzasif we don't have quorum, I'll skip the meeting16:01
s3rj1khi all16:01
tkajinamo/16:02
gibio/16:02
sean-k-mooneyo/16:03
bauzasokay we can start16:03
sean-k-mooneyi have one quick topic for the end of the meetign but i could also ask on the list. just an fyi16:04
bauzasack16:04
bauzaslet's have this meeting being quick 16:04
bauzasmy whole day was already packed with meetings16:04
bauzas#topic Bugs (stuck/critical) 16:04
bauzas#info No Critical bug16:04
bauzas#info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster16:04
bauzasnothing about bugs ?16:05
bauzasokay, let's move on16:05
tkajinamsean-k-mooney has proposed the fix for os-vif issue I raised last week16:05
tkajinamhttps://review.opendev.org/c/openstack/os-vif/+/93565316:05
bauzasah cool16:05
tkajinamif we can merge this quickly that would be nice16:06
bauzassean-k-mooney++16:06
bauzasI'm not sure I can review that patch but I'll try16:06
tkajinamI'll propose a new release of os-vif once that is merged to unblock bump of oslo.utils16:06
sean-k-mooneyi just bumpt the timeout for the retry loop16:06
sean-k-mooneyand made it configurable16:07
sean-k-mooneythe test only fails under high load16:07
sean-k-mooneyso the ohter way to fix itw as reduce concurancy but this seamed ok16:07
sean-k-mooneyif we have issues in the future ill reduce the concurancy instead16:07
bauzasnoted16:07
bauzasok moving on then16:09
bauzas#topic Gate status 16:09
bauzas#link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs 16:09
bauzas#link https://etherpad.opendev.org/p/nova-ci-failures-minimal16:09
bauzas#link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&branch=stable%2F*&branch=master&pipeline=periodic-weekly&skip=0 Nova&Placement periodic jobs status16:09
bauzas#info Please look at the gate failures and file a bug report with the gate-failure tag.16:09
Ugglao/16:09
bauzas#info Please try to provide meaningful comment when you recheck16:09
opendevreviewTakashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support  https://review.opendev.org/c/openstack/nova/+/92568516:09
bauzasall periodics are green16:09
bauzasand fwiw, the CI seems in good shape, I was recently reviewing a lot of patches and I found no massive CI failures16:10
bauzasanything else to mention ?16:10
opendevreviewTakashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property  https://review.opendev.org/c/openstack/nova/+/92770616:10
opendevreviewTakashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption  https://review.opendev.org/c/openstack/nova/+/92610616:11
bauzaslooks not16:12
bauzas#topic Release Planning 16:12
bauzas#link https://releases.openstack.org/epoxy/schedule.html16:12
bauzas#action bauzas to add Epoxy nova deadlines in the schedule16:12
sean-k-mooneyi have a minor request related to that16:13
bauzasshoot16:13
sean-k-mooneybauzas: can we put the etherpad back in the topic?16:13
sean-k-mooneyi.e. https://etherpad.opendev.org/p/nova-2025.1-status16:13
bauzasin the channel topic ?16:13
sean-k-mooneyyes16:13
bauzasI can try but I don't have op rights AFAIK16:13
sean-k-mooneyok i tought we had it there before but its fine16:14
sean-k-mooneyits in my browser history anyway but it can be nice for visiablity since we are using that as part of our release plannign/tracking16:14
sean-k-mooneywe can move on16:15
bauzascool16:15
bauzasI really need to provide the release patch to add the deadlines, as we told about a review round by mid-Dec16:15
bauzas#topic Review priorities 16:16
bauzas#link https://etherpad.opendev.org/p/nova-2025.1-status16:16
bauzasI updated it with a few blueprints that got approved16:16
bauzasbut I still need to curate it16:16
tkajinamgibi, looks like all patches for igb vif model have been merged ?16:17
gibitkajinam: yes indeed16:17
gibitkajinam: I marked the bp implemented16:17
tkajinam(then we can move it to the upper section, just fyi)16:17
tkajinam:-)16:17
bauzasI'll curate that list16:18
bauzastkajinam: ack, will do16:18
gibiI will update the etherpad...16:18
bauzasdone :)16:18
gibithanks bauzas 16:18
bauzasmoving on16:18
bauzas#topic Stable Branches 16:18
gibiyou were like 0.5 sec faster to cuting it :)16:18
bauzaselodilles: welcome back: )16:18
elodilleso/16:19
elodilles#info stable/202*.* gates seem to be OK16:19
bauzasgibi: I'm closer to my keyboard than you :p16:19
elodillesunmaintained/2023.1 was cut already and now stable/2023.1 is deleted, too 16:19
gibi:)16:19
elodilles#info stable/2024.2, stable/2024.1 and stable/2023.2 are the maintained branches from now on16:19
elodillesfor nova :)16:19
elodilles#info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci16:19
elodillesand that's all from me about stable branches16:20
bauzasthanks16:21
bauzas#topic vmwareapi 3rd-party CI efforts Highlights 16:21
bauzasfwiesel: available ?16:21
fwieselo/ 16:21
fwieselHi, no update from my side.16:21
bauzasthanks16:22
bauzas#topic Open discussion 16:22
bauzasthere was one item in the agenda16:22
bauzashttps://blueprints.launchpad.net/nova/+spec/allow-scp-ip-operations (s3rj1k)16:22
bauzass3rj1k: around ?16:22
s3rj1khere16:22
s3rj1kI think this one is obsolete, as revert mentioned in comments works fine16:23
sean-k-mooneys3rj1k: so that should not be needed after our testing last week correct if we land https://review.opendev.org/c/openstack/nova/+/90912216:23
s3rj1ksean-k-mooney: yes16:23
sean-k-mooneythen i would like to ask for another core to review ^16:23
bauzasah cok16:24
bauzasok16:24
bauzasthen moving on16:24
s3rj1kI think we did not update agenda page from last week :)16:24
sean-k-mooneyand elodilles  it would be nice if you could weigh in on if you think that is backportable16:24
elodillessean-k-mooney: ACK, will check that16:24
bauzassean-k-mooney: you had one thing to discuss 16:24
sean-k-mooneybauzas: yes. i would like to add ralonsoh to the os-vif core team16:24
* bauzas opens gerrit to see the list of os-vif cores :)16:25
sean-k-mooneyrodolfo has helpped maintained that repo on and off over the years and as a neuton core they have an invested interest in keeping it helaty as they also consume it16:25
bauzashttps://review.opendev.org/admin/groups/c113c882e5906f1b4ec806509ae59f0d363375c0,members16:26
sean-k-mooneywith watcher takeing some of my time ill have a little less time to look at issue in os-vif and i thikn they choudl be a good addtion to that team16:26
gibihaving a neutron core on the os-vif core team is not a bad idea16:26
bauzasyeah16:26
bauzasprocedure-wise, it's a lib16:26
bauzasand looking at the existing cores of os-vif, that's basically sean and the nova team16:27
sean-k-mooneymore or less jan moshe and sahid are mostly inative16:27
gibiyeah16:27
sean-k-mooneyalthough sahid has beeen around a little more lately16:27
bauzasthe usual process would to request os-vif cores to accept this nomination16:27
bauzasthru openstack-discuss16:28
sean-k-mooneycorrect i ment ot send the mail to the list last week16:28
sean-k-mooneyand then bring it up today but i didnt get arond ot sending the mail16:28
bauzasif you did and had no argument, then I'm cool16:28
bauzasah16:28
sean-k-mooneyso i can send it this week16:28
sean-k-mooneyand we can loop back next week16:28
bauzassean-k-mooney: please do so we respect the current policy16:28
sean-k-mooneyi just said i would ask ot see if there  was any objection16:29
bauzasI don't expect  any controversy but I'd like to continue doing things the normal way16:29
sean-k-mooneyok thats all form me then16:29
bauzascool then we can end this meeting16:29
bauzasthanks all !16:30
bauzas#endmeeting16:30
opendevmeetMeeting ended Tue Nov 19 16:30:06 2024 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:30
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2024/nova.2024-11-19-16.00.html16:30
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-11-19-16.00.txt16:30
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2024/nova.2024-11-19-16.00.log.html16:30
elodillesthanks o/16:30
tkajinamthank you16:30
gibithanks folks16:30
s3rj1kthanks16:30
tkajinamgibi, thanks for reviewing these (sorry for my late reply but I wanted to avoid congestion) !16:31
tkajinamgibi, and may I ask you a favor, to review https://review.opendev.org/c/openstack/nova/+/930726 , too?16:31
luca_hello, we are experimenting with GPU passtrough with nova and placement, we incurred in a strange issue, we have 2 hosts with 8 GPUs each, we managed to run VMs with 5 GPU, but as soon as we try to schedule a VM with 6 or more GPUs placement times out because of the many candidates yields (40320), i was wondering if you can help checking our configuration for fixes.16:31
gibitkajinam: sure16:32
tkajinamgibi, thanks !16:33
tkajinamluca_, which version of nova/placement are you using ?16:33
luca_we are using kolla-ansible 2024.1 quay.io/openstack.kolla/placement-api:2024.1-ubuntu-jammy and quay.io/openstack.kolla/nova-api:2024.1-ubuntu-jammy16:34
gibitkajinam: done. Thanks for all the cleanups. I really appreciate your commitment to make nova a cleaner place16:34
gibiluca_: this is a known issue, let me find the bug16:35
bauzasdo you have T4s ?16:35
sean-k-mooneyt4s would not really impact this 16:35
gibiluca_: https://review.opendev.org/c/openstack/nova/+/85588516:36
tkajinamgibi, honor to hear it :-)16:36
sean-k-mooneybauzas: this is related to the combinitorial explaiton that happens with many nestted resouce providers16:36
opendevreviewribaudr proposed openstack/nova master: Amend ShareMappingStatus due to asynchronous call  https://review.opendev.org/c/openstack/nova/+/90886416:36
opendevreviewribaudr proposed openstack/nova master: Amend DB model add a unique constraint.  https://review.opendev.org/c/openstack/nova/+/91251816:36
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction)  https://review.opendev.org/c/openstack/nova/+/83119416:36
opendevreviewribaudr proposed openstack/nova master: Use client token when talking to manila  https://review.opendev.org/c/openstack/nova/+/92527716:36
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part)  https://review.opendev.org/c/openstack/nova/+/83309016:36
opendevreviewribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process  https://review.opendev.org/c/openstack/nova/+/88007516:36
opendevreviewribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion  https://review.opendev.org/c/openstack/nova/+/88147216:36
opendevreviewribaudr proposed openstack/nova master: Add metadata for shares  https://review.opendev.org/c/openstack/nova/+/85050016:36
opendevreviewribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part)  https://review.opendev.org/c/openstack/nova/+/85482316:36
opendevreviewribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part)  https://review.opendev.org/c/openstack/nova/+/85482416:36
opendevreviewribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part)  https://review.opendev.org/c/openstack/nova/+/86028416:36
opendevreviewribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part)  https://review.opendev.org/c/openstack/nova/+/86028516:36
opendevreviewribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares  https://review.opendev.org/c/openstack/nova/+/86028616:36
opendevreviewribaudr proposed openstack/nova master: Support rescuing an instance with shares  https://review.opendev.org/c/openstack/nova/+/86028716:36
opendevreviewribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol  https://review.opendev.org/c/openstack/nova/+/88386216:36
opendevreviewribaudr proposed openstack/nova master: Check shares support (compute manager)  https://review.opendev.org/c/openstack/nova/+/88575116:37
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API)  https://review.opendev.org/c/openstack/nova/+/83683016:37
opendevreviewribaudr proposed openstack/nova master: Add helper methods to attach/detach shares  https://review.opendev.org/c/openstack/nova/+/88575316:37
opendevreviewribaudr proposed openstack/nova master: Add instance.share_attach notification  https://review.opendev.org/c/openstack/nova/+/85050116:37
opendevreviewribaudr proposed openstack/nova master: Add instance.share_detach notification  https://review.opendev.org/c/openstack/nova/+/85102816:37
opendevreviewribaudr proposed openstack/nova master: Add shares to InstancePayload  https://review.opendev.org/c/openstack/nova/+/85102916:37
opendevreviewribaudr proposed openstack/nova master: Add instance.share_attach_error notification  https://review.opendev.org/c/openstack/nova/+/86028216:37
opendevreviewribaudr proposed openstack/nova master: Add instance.share_detach_error notification  https://review.opendev.org/c/openstack/nova/+/86028316:37
opendevreviewribaudr proposed openstack/nova master: Reports instance events to the DB regarding attaching and detaching a share  https://review.opendev.org/c/openstack/nova/+/92708816:37
opendevreviewribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working.  https://review.opendev.org/c/openstack/nova/+/85208616:37
opendevreviewribaudr proposed openstack/nova master: Add virt/libvirt error test cases  https://review.opendev.org/c/openstack/nova/+/85208716:37
opendevreviewribaudr proposed openstack/nova master: Manila shares admin guide documentation  https://review.opendev.org/c/openstack/nova/+/87164216:37
bauzassean-k-mooney: ah I was doing too many things at once, I just briefly looked and saw GPU passthrough" 16:37
sean-k-mooneyluca_: gibi: i tought we had a diffent one but https://bugs.launchpad.net/placement/+bug/2070257 is the same porblem16:37
opendevreviewMerged openstack/nova stable/2024.2: Route shared storage RPC to evac dest at startup  https://review.opendev.org/c/openstack/nova/+/93430216:37
sean-k-mooneythere is an older one on the nova side somewhere16:37
sean-k-mooneyrelated to amd cpus? and numa?16:38
gibiluca_: sean-k-mooney: yeah that bug seems to report the same thing16:38
luca_i see, by any chanche using the old PciPasstroughFilter in the scheduler instead of using placement will solve this issue?16:38
sean-k-mooneyit will work around it yes16:39
sean-k-mooneyat the cost of the inablity to have quota16:39
sean-k-mooneyto do do some more advanced schduilgn16:39
sean-k-mooneyif you disable pci in placmenement then it will remove the nested resouce providers16:39
gibithis is GPU so GPU is using placement without the PCI in Placement feature enabled16:40
sean-k-mooneyand the allcoation candiate epxlotion will be mitigated16:40
gibiso this logic cannot be turned on I think16:40
gibiturned off16:40
sean-k-mooneyis it gpu or vgpu16:40
luca_GPU16:40
sean-k-mooneygpu passthough is just pci passthough16:40
luca_yeah i am passing pci-devices16:40
tkajinamgibi, sorry for asking a favor again but do you mind adding +a, too ?16:41
gibiluca_: did you enabled pci_in_placement ?16:41
luca_yes16:41
gibiluca_: ahh I see.16:41
tkajinamI wonder if adding an option to limit maximum candidates to placement resolves the issue ?16:41
gibiluca_: then yes, turning off pci_in_placement will help16:41
luca_wwhich i read is not possible to disable after enabling it :D16:41
tkajinam(I don't have full context, though)16:41
sean-k-mooneyluca_: this is the main reason that is tech preview downstream for what its worth16:41
sean-k-mooneyluca_: kind of not with workload at least16:42
luca_iyeah no problem this is a testing enviroment we can rebuild it if it is needed16:42
gibiluca_: not out of the box, you probably need to hack around I'm affraid16:42
gibitkajinam: done, sorry I missed it16:42
tkajinamgibi, np and thanks again !16:42
sean-k-mooneyluca_: you can do a few things16:42
gibiluca_: wondering about the limit tkajinam suggests16:42
sean-k-mooneygibi: that kind of works but not well16:43
tkajinamone downside of that limit is that it may not work well with randomize_allocation_candidates16:43
sean-k-mooneyif you reduce the limit you will likely only get one or two chosts16:43
tkajinamyeah16:43
sean-k-mooneytkajinam: i think by defualt we generate all the permutiaon on a per host basis16:43
sean-k-mooneywe have a downstream issue to optimise this in the future where we woudl do a barbar pole stirp16:44
gibiluca_: this is the limit config https://docs.openstack.org/nova/latest/configuration/config.html#scheduler.max_placement_results but maybe it limits after the candidates are generated :/16:44
sean-k-mooneyi.e. take the first candate for each host until we get to the limit in a round robbing fashion16:44
sean-k-mooneythe default limti is 1000 canidates i belive16:45
tkajinamgibi, it is used to determine the limit query parameter in HTTP Request16:45
tkajinamso the limit may be applied in placement (if I read the code correctly)16:45
gibitkajinam: yeah applied in placement but maybe after all the permutation is generated :/16:45
tkajinamyeah16:45
sean-k-mooneyluca_: so what i would do is the following if this is a test env, deleate any insances usign pci devices, remove all pci devices form the pci devspec, restart the comptue agents and then disble the config oprtion for pci in placmeent after they have remove the nested resouce providers16:46
sean-k-mooneythen add the pci devspecs back16:47
gibitkajinam: I don't see the limit applied directly in the permutation generaton in https://github.com/openstack/placement/blob/723da65faf66cc9b8d02f3756387dc58437e62af/placement/objects/allocation_candidate.py#L37116:47
sean-k-mooneyand try again16:47
luca_since i am asking, is it normale that a single resource provider is generated for each GPU?16:47
sean-k-mooney gibi  i think its later16:48
luca_sean-k-mooney_  thanks for the possible solution i will try it16:48
sean-k-mooneybut to fix this properly we need to adjust the nestign of those loops16:48
ishanwarHi Team, 16:48
tkajinamgibi, yeah, I see limit_results applies the limit but it is applied to the full list...16:49
sean-k-mooneyluca_: yes becasue we create 1 RP per PF16:49
sean-k-mooneyishanwar: o/16:49
sean-k-mooneytkajinam: gibi  we basically need to make the permuation generateion lazy using generators16:49
gibiluca_: as you can assign different traits to different PFs via the dev_spec we need to model them separately16:49
tkajinamsean-k-mooney, yeah I totally agree16:50
sean-k-mooneyya that or use diffent resouce classes, physnets ectra16:50
luca_i see, does this mean that if the device type is type-PCI instead of type-PF you just create 1 rp per kind?16:50
ishanwarI currently facing some issue with the dev stack setup for nova. 16:50
gibiluca_: we create one RP for each device basically where the name of the PR contains the PCI address of the device16:51
sean-k-mooneyluca_: no if tis type-PF or type-PCI we create on resouce provider per phasical device16:51
luca_oh ok16:51
sean-k-mooneyluca_: for type-VF they are all on a single RP based on the parent PF16:51
gibihttps://specs.openstack.org/openstack/nova-specs/specs/zed/approved/pci-device-tracking-in-placement.html#modeling-pci-devices-in-placement 16:51
gibidetails are here ^^16:51
ishanwar./stack.sh gets stuck here.  LOGS:  +functions:wait_for_compute:504            [[ 124 != 0 ]] +functions:wait_for_compute:505            echo 'Didn'\''t find service registered by hostname after 60 seconds' Didn't find service registered by hostname after 60 seconds +functions:wait_for_compute:506            openstack --os-cloud devstack-admin --os-region RegionOne compute service list16:54
gibiluca_: that remainds me that you can trick nova to allow disabling pci_in_placement by stoping nova-compute and removing COMPUTE_MANAGED_PCI_DEVICE traits from the rsource providers16:54
sean-k-mooneyishanwar: that typically means that there was an error that shoudl be visable in "journalctl -u devstack@n-cpu"16:55
luca_i see,  tomorrow we wil try to disable pci in plcaement as sean-k-mooney_ suggested, hopefully it will work, thanks for the help guys!16:55
gibiluca_: keep us posted.16:55
gibiand good luck16:55
luca_sure, will let you know! thanks!16:55
ishanwarsean-k-mooney: let me check. Can I ping you directly ? The docs seems to lack troubleshooting 16:56
* gibi drops16:56
sean-k-mooneyishanwar: so devstack pings are proably better in #openstack-qa16:57
opendevreviewStephen Finucane proposed openstack/nova master: Fix typo in release note  https://review.opendev.org/c/openstack/nova/+/93568116:57
opendevreviewStephen Finucane proposed openstack/nova master: zuul: Add missing context comments for nova-next  https://review.opendev.org/c/openstack/nova/+/93568216:57
sean-k-mooneyishanwar: devstack is written in bash so that its easy to read and debug. it does require some knolage of openstack but for the most part it ties ot keep the code readable and simple16:57
bauzaswell, devstack is clearly intended for dev purposes16:59
ishanwarsean-k-mooney: I see. thanks. another question. Are ppl active on #openstack-* channels only during the meetings, or are there people active during other times as well ? 16:59
bauzaspeople are expected to have a bit of knowledge about the services already16:59
sean-k-mooneyishanwar: we generally hang out here most of the time16:59
bauzasand that error self-explains : the nova-compute service didn't show up in time17:00
sean-k-mooneymost of use will hae irc open in a window while working on other stuff and check in perodically17:00
bauzaswhich means that something prevented that service to register itself17:00
bauzasand as a reminder, this channel is not intended for debugging purposes17:00
ishanwarbauzas: Thanks I see. I have some knowledge of nova only from the operational side. I am still figuring out the openstack community, as I am used to slack channels and zoom meetings for opensource in general. Will not use this channel for debugging purposes. Thanks 17:02
bauzastbc we're here to help, for sure17:04
bauzasso, for example, some operators discuss with us their pain points17:05
bauzassometimes, someone is stuck installing a devstack env and we try to also give him some help17:05
bauzasbut here, you should first look at nova-compute logs and see, most of the time, this is a config issue :)17:06
bauzasishanwar : HTH : https://docs.openstack.org/devstack/latest/systemd.html17:06
opendevreviewMerged openstack/nova master: Drop remaining logic for websockify < 0.9.0  https://review.opendev.org/c/openstack/nova/+/93451717:55
opendevreviewMerged openstack/nova master: Replace deprecated constant_time_compare  https://review.opendev.org/c/openstack/nova/+/93114617:55
opendevreviewAntony Messerli proposed openstack/nova master: docs: Corrects a typo on a placement audit command  https://review.opendev.org/c/openstack/nova/+/92285018:45
yuriyPlease correct me if I'm wrong; In a scenario where an LVM ephemeral based instance needs more ram... there doesn't seem to be a way to do that other than remake the entire VM with a flavor that has more ram. Resizing doesn't appear to be supported for LVM based instances.19:01
gmannbauzas: sean-k-mooney: on Noble migration, this is set of things we need to review. they will be merged after base jobs are migrated (I added depends-on) but advance review will be nice https://etherpad.opendev.org/p/migrate-to-noble#L64 19:01
gmanntested all repo under Nova19:01
bauzasokay, I'll add it to my TODO list19:02
* bauzas stops for the day, his 7 hours of meetings killed himself19:02
gmannthanks 19:02
gmannbauzas: I thought I only made Tuesday full of meetings (upstream + downstream total 7) :)19:03
bauzastomorrow will be better : 6 hours of meetings \o/19:04
bauzascall it a productive week19:04
gmanntake rest then :)19:04
bauzasI should consider myself becoming a MD, I'm soon about to have a 3-month delay for a meeting request :)19:05
gmanngood promotion I would say. ask for it. :)19:09
gmannsean-k-mooney: gibi: I could not find right package  for nova doc job failure 'pcre.h missing" , if you do feel free to update/test here https://review.opendev.org/c/openstack/nova/+/93557719:09
gmannas per ubuntu noble package info libpcre3-dev should be enough (tried libpcre2-dev latest one) which is already in our bindep.txt but it fail19:10
sean-k-mooneyill see if i can get to that tomorrow i belive you can use apt-cache to query which package provdies a file19:12
sean-k-mooneydpkg -S appreently works too19:13
sean-k-mooneysorry not apt-cache apt-file19:15
sean-k-mooneylibpcre3-dev: /usr/include/pcre.h19:16
gmannyeah, it gives the same19:17
sean-k-mooneyya so the doc issue must be seperate ill see fi i can repoduce that localy in my ubuntu 24.04 devstack env19:18
gmannthanks19:18
sean-k-mooneybut ya just finishing for today ping me later in the week if i have not looked at this tomorrow19:19
opendevreviewGhanshyam proposed openstack/nova master: Testing doc job on Ubuntu Noble  https://review.opendev.org/c/openstack/nova/+/93557719:43
opendevreviewmelanie witt proposed openstack/nova stable/2024.1: nova-manage: modify image properties in request_spec  https://review.opendev.org/c/openstack/nova/+/93570919:51
opendevreviewmelanie witt proposed openstack/nova stable/2023.2: nova-manage: modify image properties in request_spec  https://review.opendev.org/c/openstack/nova/+/93571119:52
melwittdansmith, sean-k-mooney: fyi I updated the flavor scanning patch to split it into helper functions and do resource requests. note that there is an unrelated bug with hw:mem_encryption that is mentioned in a try-except comment and also shown in a func test20:28
gmannmelwitt dansmith gibi can you check this easy one https://review.opendev.org/c/openstack/nova/+/934578 20:35
melwittgmann: +220:37
gmannthanks20:38

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!