| opendevreview | Luca Miccini proposed openstack/nova master: TEST DNM check CI https://review.opendev.org/c/openstack/nova/+/933702 | 07:00 |
|---|---|---|
| opendevreview | Luca Miccini proposed openstack/nova master: TEST DNM check CI https://review.opendev.org/c/openstack/nova/+/933702 | 07:08 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Route shared storage RPC to evac dest at startup https://review.opendev.org/c/openstack/nova/+/933734 | 12:33 |
| *** jcosmao is now known as Guest7955 | 13:22 | |
| *** QG8 is now known as QG | 13:32 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Route shared storage RPC to evac dest at startup https://review.opendev.org/c/openstack/nova/+/933734 | 15:29 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug 2085975 in functional https://review.opendev.org/c/openstack/nova/+/933753 | 15:29 |
| sean-k-mooney | that was fast | 15:30 |
| gibi | I had proper focus time | 15:30 |
| sean-k-mooney | :) | 15:31 |
| sean-k-mooney | skiming the repoducer the logic makes sense | 15:32 |
| sean-k-mooney | ill be interested to see if that is stable in ci as we have had issues with using condition variables like that before | 15:32 |
| sean-k-mooney | its seams reasonable to me at a glance however | 15:33 |
| sean-k-mooney | oh the rpc_exception car is set via wrapped_check_shared_storage | 15:34 |
| sean-k-mooney | i think nonlocal is only aviable in newerversion fo python but perhaps that includes 3.9 | 15:34 |
| sean-k-mooney | oh no looks like that is valid form old version of python 3 | 15:35 |
| sean-k-mooney | https://peps.python.org/pep-3104/ | 15:36 |
| gibi | yeah we will see I can run couple of rechecks to see if it is stable | 15:50 |
| gibi | without the events I cannot create a stable reproduction as I need to stop evac int he middle. So we can only have unit tests then | 15:51 |
| sean-k-mooney | gibi: so regarding https://github.com/openstack/nova/blob/110849f7f972d8cb536a9c96c4cb59f06e357eeb/nova/conf/compute.py#L1087-L1104 | 17:26 |
| sean-k-mooney | the help text is actully wrong | 17:26 |
| sean-k-mooney | nova will not update teh network info cache on its own | 17:27 |
| sean-k-mooney | it will howver react to the network-changed external event form neutron if something changes | 17:27 |
| sean-k-mooney | and update the relevent port | 17:27 |
| gibi | sean-k-mooney: I haven't looked at the impl of the heal code yet. But I can do that fur sure. If we want to change the default then we definitly need to change that conf doc as it recommends against it. | 17:29 |
| sean-k-mooney | right it was true at teh tiem becuase ther ewere many out of tree neutron drivers in production use | 17:33 |
| sean-k-mooney | that is really not the case anymore | 17:34 |
| *** amorin_ is now known as amorin | 17:35 | |
| sean-k-mooney | gibi: i cant find it but i was pretty sure i had a patch to update the text or disable it in the past | 17:41 |
| sean-k-mooney | i just cant find it in gerrit | 17:41 |
| sean-k-mooney | hum nope cant find it in my gerrtit review but i did find this https://review.opendev.org/c/openstack/nova/+/713342 | 17:56 |
| sean-k-mooney | i have some other reviw i have not touched in a long time that are fixing real bugs that i shoudl get back to eventually.. | 17:56 |
| sean-k-mooney | like https://review.opendev.org/c/openstack/nova/+/653506 | 17:58 |
| sean-k-mooney | and https://review.opendev.org/q/topic:%22bug/2074219%22 | 17:58 |
| sean-k-mooney | and this https://review.opendev.org/q/topic:%22bug/2048837%22 | 17:59 |
| opendevreview | Ghanshyam proposed openstack/nova stable/2023.1: DNM: testing tempest 41.0.0 on stable/2023.1 https://review.opendev.org/c/openstack/nova/+/933774 | 19:22 |
| *** hemna55 is now known as hemna5 | 19:30 | |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily at 20:30 utc (half an hour from now) to apply a configuration change | 20:02 | |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily to apply a configuration change | 20:31 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!