Tuesday, 2024-10-22

opendevreviewAleksandr Chudinov proposed openstack/nova master: Fix instance snapshot min disk size after instance resize  https://review.opendev.org/c/openstack/nova/+/93173706:10
opendevreviewTakashi Kajinami proposed openstack/nova master: Deprecate [wsgi] secure_proxy_ssl_header  https://review.opendev.org/c/openstack/nova/+/81792707:24
opendevreviewTakashi Kajinami proposed openstack/nova master: Deprecate [wsgi] secure_proxy_ssl_header  https://review.opendev.org/c/openstack/nova/+/81792707:24
opendevreviewTakashi Kajinami proposed openstack/nova master: Deprecate [wsgi] secure_proxy_ssl_header  https://review.opendev.org/c/openstack/nova/+/81792707:25
opendevreviewTakashi Kajinami proposed openstack/nova master: Deprecate [wsgi] secure_proxy_ssl_header  https://review.opendev.org/c/openstack/nova/+/81792707:26
opendevreviewTakashi Kajinami proposed openstack/nova master: Drop unused parameter type validation method  https://review.opendev.org/c/openstack/nova/+/90918907:29
elodillesbauzas: auniyal: Uggla: if you have some time could you please review (release liaison approve) the antelope final stable release? https://review.opendev.org/c/openstack/releases/+/93240608:09
mikalsean-k-mooney: I've reproposed https://review.opendev.org/c/openstack/nova-specs/+/932387 (spice-direct spec), just wondering if there's anything else I should do apart from put it in the status etherpad?08:14
sean-k-mooney[m]mikal:  you updated the history section so that all that was needed08:17
sean-k-mooney[m]gibi: ill fix the typos in https://review.opendev.org/c/openstack/nova/+/932931/1 once i have had coffee and am actually awake. thanks for the review08:21
sean-k-mooney[m]mikal:  i assume the rest of the pataches are ready for review?08:22
sean-k-mooney[m]im not seeing any merge conflicts or direct requests form mel that need to be  addressed but also have not looked closely at the current state08:24
gibisean-k-mooney[m]: sure, just ping me after the respin and I will re-add my +208:55
gibibauzas: when you are up, I'm wondering how much quorum the nova room will have on wednesday during the global eventlet removal discussion?09:02
bauzasI'm already up :)09:02
gibio/ :)09:02
bauzasgibi: that's a good question09:02
bauzasthat discussion will trample our own sessions09:03
gibiI would like to join to the eventlet removal discussion at least09:03
bauzasI was thinking it could be on Monday09:03
gibibut other cores might have the same plans09:03
bauzas:(09:03
bauzaslet's discuss then the agenda today09:03
bauzasI'm currently looking at the etherpad09:03
gibiyeah I think the deeper dive will be on wednesday, yesterday we only covered high level things09:03
bauzasand I'll try to provide an agenda 09:03
gibicool, thanks09:04
gibiI have no other limitation during the week as far as I see09:04
bauzasgibi: my own limitation will be on Friday due to the TC sessions :(09:10
bauzashence the agenda proposal09:11
bauzasgibi: I think we have a serious problem that we need to solve about Wed09:22
sean-k-mooneybauzas: gibi: i dont know if we want to discuss this at the ptg https://bugs.launchpad.net/nova/+bug/2076089 but it would be good if other could confirm or refute my assertion that we shoudl not be abel to force boot a new instance on a disabled compute09:41
bauzassean-k-mooney: the agenda is now fully packed tbh09:42
sean-k-mooneyas far as i am aware we made an intentional decsion to prevent this09:42
sean-k-mooneybauzas: that fine its a bug so we can discuss it async09:42
bauzasthe eventlet-removal session just ate all the left time09:42
sean-k-mooneyi just want to spread awareness of it09:42
sean-k-mooneyim basically asking for a sanity check to ensure im not off base when i say this is not a bug. we can put it on the next team meeting adgenda too if we like09:44
bauzaswell09:44
bauzasthe forced AZ hack was the usual way for ops to test new computes09:44
sean-k-mooneyright but not disabled hosts09:44
bauzasno, even disabled ones09:44
sean-k-mooneythat was definetly a bug then09:44
sean-k-mooneyi.e that that ever worked09:45
bauzasyeah, for me it looks to me a regression 09:45
sean-k-mooneyim saying we should not allow that to happen and that i dont condier this a regression09:45
sean-k-mooneyif the az hack worked in the past tha that was a bug IMO09:46
bauzasbecause when you want to verify that your new compute works fine, then you just use the AZ hack for it09:46
bauzasyou just make sure that when you create the new compute, it's disabled first09:46
sean-k-mooneyyour you regerster it as disabeld and add it to a host aggreate restricted to your tenent and then enable it09:46
bauzashum, no, in general you just disable the host, and then you create new instances using the AZ hack09:48
sean-k-mooneybauzas: the az hack is not ment to force a host bypasssing all schdulign 09:48
bauzasonce you're sure it works, then you delete the instances and the enable the host, that's it09:48
bauzassean-k-mooney: trust me, this is why I say this is a hack :)09:49
sean-k-mooneybauzas: right so i object to reintroducing that broken behavior if its what we had in the past09:49
sean-k-mooneyas i said i condier it a bug09:49
sean-k-mooneyso if we want to fix it i want to be conviced why that is accapable to bypass placment09:50
bauzashttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L59309:50
sean-k-mooneythe reporter confirmed the existing behavior (where its rejected) exists as far back as zed09:51
sean-k-mooneymeaning that all stable release have the current behavior09:51
sean-k-mooneybauzas: right i have used that in the past but that was nto inteded to ignore if its disabeld.09:52
bauzasthat's because the forced host values are not checking the filters09:53
bauzasbut... the pre-filters actually check them09:53
sean-k-mooneythe prefilters run before the filters 09:53
bauzashence the change09:53
bauzascorrect, hence the bug09:54
sean-k-mooneyyep a change that was made in train09:54
sean-k-mooneyas a result of a spec that was intened to prevent schduling to disable compute09:54
sean-k-mooneyto me this was somethign we agree to block as part of the spec09:54
sean-k-mooneyso not a bug as a result09:54
sean-k-mooneywe also added the ablity to request a host without the az hack in train for what its worth09:56
sean-k-mooneythis is the spec https://specs.openstack.org/openstack/nova-specs/specs/train/implemented/pre-filter-disabled-computes.html09:56
bauzasI just think we forgot about this UX...10:01
bauzasand honestly I agree with the solution on https://bugs.launchpad.net/nova/+bug/2076089/comments/110:01
sean-k-mooneyits possible but i dont think this shoudl be allowed wihtout a new microversion becuase honstely i think that is breaking the meaning of disbaled10:02
bauzasor indeed the workaround is to force live-migrate to the compute10:02
sean-k-mooneywe have had this behavior since train10:02
sean-k-mooneyso all cloud in produciton should expect this behavior10:02
bauzasI don't see why we need to add a microversion 10:02
bauzasbecause this is only for an admin-only AZ hack value10:02
sean-k-mooneyi do because as far as i am concerned disbaled mean you cannot schdule to this under any cuirmsutances10:03
sean-k-mooneyso if you are changing the maning of disable by allowitn this we need to have a way to request that explcitly10:03
sean-k-mooneythe az hack which is deprecated is not that IMO10:04
bauzaslet's then agree to disagree :)10:04
sean-k-mooneyif we actully want to supprot this we shoudl have --force or similar which we intentionally removed form other apis10:04
sean-k-mooneywell we can but how do we move forward with this bug close it or reintoduce the broken pre train behavior10:05
sean-k-mooneythis is why i wanted to add it to the ptg but we can disuss it in next weeks meeitng too10:05
bauzasyeah, let's discuss this then on next tuesday's meeting10:06
sean-k-mooneywe have other mandaory prefiletrs too by the way, and we also include required/forbiden triats in other ways uncondtionally10:07
sean-k-mooneyso fundementally you cant ignore the placement filtering the way you coudl before placemnt10:07
opendevreviewsean mooney proposed openstack/nova master: Fix detaching devices by alias with mdevs  https://review.opendev.org/c/openstack/nova/+/93293111:22
sean-k-mooneygibi: ^ sorry got distracted, should be good now i hope11:23
sean-k-mooneygibi: on a related note it would be good to merge https://review.opendev.org/c/openstack/nova/+/923738/2 to update to fix issues caught by the latest version of codespell and https://review.opendev.org/c/openstack/nova/+/923739/2 to bump to using that version11:27
*** iurygregory_ is now known as iurygregory11:38
gibisean-k-mooney: looks good to me12:34
bauzasnova PTG sessions starting now : https://meetpad.opendev.org/nova-2025.1-ptg13:02
bauzassean-k-mooney: want to join us ?13:07
sean-k-mooneybauzas: just finising a 1:1 ill join shortly13:07
sean-k-mooneystart without me13:08
bauzasartom: will you be able to join us today ? we have your topic for around 2.30pm UTC13:19
tkajinamhmm ok so we undefine the secret here https://github.com/openstack/nova/blob/ed2bf3699ddc360fb646b895560fa9dbcfd6beba/nova/virt/libvirt/driver.py#L8074-L807514:46
opendevreviewJulien LE JEUNE proposed openstack/nova master: Reset the mapped field of nodes at service deletion  https://review.opendev.org/c/openstack/nova/+/93302215:20
jlejeunegibi: hello, I propose that small patch to fix https://bugs.launchpad.net/nova/+bug/208513515:23
gibijlejeune: awesome, thanks you. I will take a look15:23
bauzasas a reminder, today's nova meeting is CANCELLED15:50
bauzasplease rather join the nova PTG sessions if you want to join us :) https://ptg.opendev.org/ptg.html15:51
bauzasas a reminder, nova sessions will start back tomorrow at *1400 UTC16:52
bauzas(and not 1300UTC)16:52
opendevreviewArtom Lifshitz proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node  https://review.opendev.org/c/openstack/nova/+/93292617:30
opendevreviewArtom Lifshitz proposed openstack/nova master: Add whitebox-devstack-multinode job to periodic  https://review.opendev.org/c/openstack/nova/+/83345317:53

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!