| *** mklejn_ is now known as mklejn | 07:07 | |
| *** mklejn__ is now known as mklejn | 13:01 | |
| opendevreview | Anton Kurbatov proposed openstack/nova master: Fixing the 500 HTTP code in the metadata service for incorrect queries https://review.opendev.org/c/openstack/nova/+/914249 | 13:53 |
|---|---|---|
| opendevreview | ribaudr proposed openstack/nova master: Fix: Live migrating to a host with cpu_shared_set configured will now update the VM's configuration accordingly. https://review.opendev.org/c/openstack/nova/+/903706 | 15:14 |
| opendevreview | ribaudr proposed openstack/nova master: Test live migration between hosts with differnet cpu_shared_sets https://review.opendev.org/c/openstack/nova/+/913744 | 15:14 |
| bauzas | #startmeeting nova | 16:00 |
| opendevmeet | Meeting started Tue Mar 26 16:00:40 2024 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'nova' | 16:00 |
| Uggla | o/ | 16:00 |
| auniyal | o/ | 16:01 |
| bauzas | sorry guys, I don't have the agenda prepared | 16:01 |
| grandchild | o/ | 16:01 |
| bauzas | but let's start | 16:01 |
| dansmith | o/ | 16:01 |
| bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:02 |
| bauzas | #topic Bugs (stuck/critical) | 16:02 |
| elodilles | o/ | 16:02 |
| bauzas | #info No Critical bug | 16:02 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 65 new untriaged bugs (+2 since the last meeting) | 16:02 |
| bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:02 |
| bauzas | I don't know who could be the next baton | 16:03 |
| bauzas | but I don't want to take it | 16:03 |
| bauzas | so, anyone interested ? | 16:03 |
| elodilles | next week i can take it, but not before the 2024.1 Caracal release :/ | 16:04 |
| bauzas | #info bug baton is bauzas | 16:04 |
| bauzas | I'm done, I'll take it | 16:04 |
| bauzas | moving on | 16:04 |
| bauzas | #topic Gate status | 16:05 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:05 |
| bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | 16:05 |
| dansmith | I haven't been following much gate stuff lately | 16:05 |
| bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:05 |
| dansmith | too many other things in the air | 16:06 |
| bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:06 |
| bauzas | #info Please try to provide meaningful comment when you recheck | 16:06 |
| Uggla | bauzas, I can take the bug baton | 16:06 |
| bauzas | nevermind, took it | 16:06 |
| bauzas | I really want a short meeting, I need to take a bit of time off | 16:06 |
| bauzas | moving on | 16:07 |
| bauzas | #topic Release Planning | 16:07 |
| bauzas | #link https://releases.openstack.org/caracal/schedule.html#nova | 16:07 |
| bauzas | #info Caracal GA planned next week | 16:07 |
| bauzas | nothing to relate | 16:07 |
| elodilles | and final rc week is this week | 16:07 |
| bauzas | I've started a new etherpad | 16:07 |
| bauzas | #link https://etherpad.opendev.org/p/nova-dalmatian-status | 16:08 |
| bauzas | #topic vPTG Planning | 16:08 |
| bauzas | #info The vPTG will be held on Apr 8-12 | 16:08 |
| bauzas | #info Nova sessions between Tues-Fri 1pm-5pm UTC | 16:08 |
| bauzas | #link https://etherpad.opendev.org/p/nova-dalmatian-ptg add your own PTG topics in that etherpad | 16:08 |
| bauzas | #info Don't forget to register yourselves on http://ptg2023.openinfra.dev/ | 16:08 |
| bauzas | that's it | 16:08 |
| bauzas | #topic Review priorities | 16:09 |
| bauzas | like I said, | 16:09 |
| bauzas | #link https://etherpad.opendev.org/p/nova-dalmatian-status | 16:09 |
| bauzas | #topic Stable Branches | 16:09 |
| bauzas | elodilles: your turn | 16:09 |
| elodilles | to be short: | 16:09 |
| elodilles | #info stable/202*.* branches' gates seem to be OK, but nova-ceph-multistore is constantly failing (?) on stable/zed | 16:10 |
| elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:10 |
| elodilles | EOM | 16:10 |
| bauzas | thanks | 16:10 |
| bauzas | #topic vmwareapi 3rd-party CI efforts Highlights | 16:10 |
| bauzas | fwiesel seems off | 16:10 |
| grandchild | fwiesel is out this week. there's not much to report. he's waiting on reviews on changes. presumably https://review.opendev.org/c/openstack/nova/+/909474 and https://review.opendev.org/c/openstack/nova/+/910627. that is all. | 16:10 |
| bauzas | copying his notes | 16:10 |
| bauzas | cool thanks grandchild | 16:10 |
| bauzas | #topic Open discussion | 16:11 |
| bauzas | (bauzas) Could https://blueprints.launchpad.net/nova/+spec/aggregatemultitenancyisolation-to-support-unlimited-tenant be a specless blueprint ? | 16:11 |
| bauzas | honestly, I'd like so | 16:11 |
| bauzas | this is a quick small change limited to a filter | 16:11 |
| bauzas | and sahid awaits us to approve his patch for too long | 16:11 |
| bauzas | so, controversial opinions ? | 16:12 |
| bauzas | if not, I'll approve it | 16:12 |
| sean-k-mooney | we discussed all the controverial stuff last cycle | 16:12 |
| sean-k-mooney | so im fine with it being specless this cycle | 16:13 |
| bauzas | cool | 16:13 |
| bauzas | #agreed https://blueprints.launchpad.net/nova/+spec/aggregatemultitenancyisolation-to-support-unlimited-tenant accepted as a specless blueprint | 16:13 |
| bauzas | I'll do the paperwork | 16:13 |
| bauzas | anything else for open discussion ? | 16:13 |
| bauzas | looks not | 16:14 |
| bauzas | thanks all | 16:14 |
| bauzas | #endmeeting | 16:14 |
| opendevmeet | Meeting ended Tue Mar 26 16:14:38 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:14 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-03-26-16.00.html | 16:14 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-03-26-16.00.txt | 16:14 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-03-26-16.00.log.html | 16:14 |
| * bauzas goes for a break | 16:14 | |
| elodilles | thanks bauzas o/ | 16:15 |
| sean-k-mooney | bauzas: for the vmware reviwe we proably should try and do a realtime review of those or somethign | 16:16 |
| sean-k-mooney | i have not had time to fully load the context and then look a the ci results to know if the patch fixes what it say it fixes | 16:17 |
| sean-k-mooney | but it woudl be good to adress some of those issues | 16:17 |
| melwitt | sean-k-mooney: care to revisit this nova-manage image_property fix? they updated it to address the property value printing https://review.opendev.org/c/openstack/nova/+/880557 | 19:03 |
| sean-k-mooney | i can take a look i need to recall the context | 19:23 |
| sean-k-mooney | oh i see | 19:23 |
| sean-k-mooney | melwitt: wasnt the command orgianly nova-manage property show <vm_uuid> hw_vif_multiqueue_enabled | 19:26 |
| sean-k-mooney | will we break anyoen if we fix this | 19:26 |
| sean-k-mooney | and make it nova-manage image_property show <vm_uuid> hw_vif_multiqueue_enabled | 19:26 |
| sean-k-mooney | i guess the intent was for this to be namespaced under an image_property subparser https://review.opendev.org/c/openstack/nova/+/880557/2/nova/cmd/manage.py#3360 | 19:28 |
| melwitt | sean-k-mooney: looking ... yeah, you're right, sorry 😑 | 19:28 |
| melwitt | let me update my comment and vote | 19:28 |
| sean-k-mooney | well my really question is can we create a repoducer test of some kind to validate the old/new behavior | 19:29 |
| sean-k-mooney | i might be able to check this on my home cloud quickly | 19:29 |
| melwitt | it would take some doing bc we don't currently test the CLI in that manner that exercises these decorators | 19:30 |
| melwitt | I tried briefly a long time ago when I first reviewed this and didn't come up with a good way (and i don't remember what I tried now) | 19:31 |
| sean-k-mooney | so i tought someone submited a docs fix related to this recently | 19:31 |
| melwitt | sean-k-mooney: ok so this isn't changing the subcommand, just the name of the arg. so I don't think it would break anyone? | 19:32 |
| sean-k-mooney | if its just the name of the arg in python then no | 19:33 |
| sean-k-mooney | so really i need to try and test this locally to review it | 19:33 |
| sean-k-mooney | which menas i need a devstack | 19:33 |
| melwitt | I had meant to do dest=image_property and call the arg just "property" because I was trying to avoid nova-manage image_property image_property from an aesthetic perspective | 19:33 |
| sean-k-mooney | ya | 19:34 |
| sean-k-mooney | it should be a postional arg | 19:34 |
| sean-k-mooney | to the show command after the vm uuid | 19:35 |
| melwitt | sean-k-mooney: sorry, I didn't mean for this to be involved. I think you would only need to install nova-manage and not a whole devstack bc the bug happens before anything is done, it's a parsing problem essentially | 19:35 |
| sean-k-mooney | well i have a local copy of nova i can check it out in a venv with tox and see i guess | 19:35 |
| melwitt | it is a positional arg. it's just the name of the arg doesn't match the keyword arg that goes with it. and if it isn't going to match you have to use "dest=whatever" but I messed up and didn't do that | 19:36 |
| sean-k-mooney | i tought etavar='<image_property>', was ment to be the name of the variable | 19:38 |
| sean-k-mooney | but i have not looked at the argpars docs in a while | 19:38 |
| melwitt | I might have spaced and thought so too but it isn't, that's just for what it shows in the usage or help | 19:38 |
| melwitt | dest= is what names the variable and if you omit dest= it will use the name of the positional arg | 19:39 |
| melwitt | and property != image_property | 19:39 |
| melwitt | so it either needs to be @args(property, dest=image_property, ...) or @args(image_property, ...) I think | 19:40 |
| sean-k-mooney | ok so i can confim without hte patch i get the error and with it it fixes it and i get an sql error | 19:42 |
| sean-k-mooney | but that just becasue i dont have a nova.conf with any real data for it to use | 19:43 |
| melwitt | right | 19:43 |
| sean-k-mooney | ok its on its way | 19:48 |
| melwitt | thanks, sorry for the confusion | 19:49 |
| sean-k-mooney | its ok | 19:49 |
| sean-k-mooney | so this is something we should proably add test coverage for in the functional tests at some point | 19:50 |
| sean-k-mooney | i.e. invoke nova manage in such a way that we test hte paring logic | 19:50 |
| sean-k-mooney | i think that is doable but its not reasonable to ask for that in this case | 19:50 |
| sean-k-mooney | failing that we coudl test this in the tempest jobs at some point | 19:50 |
| melwitt | yeah.. I couldn't come up with a way other than process exec or something like that, but I could just be missing something obvious | 19:50 |
| sean-k-mooney | process exec woudl work in a tempest type jobs that is kind fo what the openstck client devstack job does | 19:51 |
| sean-k-mooney | but i think we can import the nova manage parser and just give it a string | 19:51 |
| melwitt | agree it's ok in tempest, but for func tests, I would have thought to avoid that. but I dunno | 19:52 |
| sean-k-mooney | like this is the nova manage main function | 19:53 |
| sean-k-mooney | we call config.parse_args(sys.argv) to pars the cli opt | 19:53 |
| sean-k-mooney | we cab just pass an arry of stings to that | 19:53 |
| sean-k-mooney | like we can mock sys.arg an then call main | 19:54 |
| melwitt | ok, I guess I was just being dumb then 😛 what you're saying makes sense | 19:54 |
| sean-k-mooney | form a functional test | 19:54 |
| sean-k-mooney | the tricky part woudl be jsut makeing sure we have the dbfixture extra in place to make it work | 19:54 |
| sean-k-mooney | but we have a lot of that code in the fucntional tests already so it should be doable | 19:55 |
| sean-k-mooney | we would just need to find the time | 19:55 |
| melwitt | yeah. I could give it a go since it was my bug that caused this whole mess | 19:56 |
| sean-k-mooney | if you like :) i was going to finish soon so i was also going to see if i could hack somethign togehter quickly | 19:57 |
| melwitt | sean-k-mooney: please go ahead :) I will only do it if you don't want to | 20:02 |
| opendevreview | sean mooney proposed openstack/nova master: add scafolding for cmd functional tests https://review.opendev.org/c/openstack/nova/+/914408 | 21:11 |
| sean-k-mooney | melwitt: ^ somethign like that | 21:11 |
| melwitt | sean-k-mooney: that looks very nice, I'll try it out | 21:17 |
| opendevreview | sean mooney proposed openstack/nova master: add repoducer for bug 2016346 https://review.opendev.org/c/openstack/nova/+/914410 | 21:26 |
| sean-k-mooney | melwitt: so ^ is the repoducer for that bug | 21:27 |
| sean-k-mooney | i should be enabling the db mocks here but im not calling the db | 21:27 |
| sean-k-mooney | so its not need yet | 21:27 |
| sean-k-mooney | the second it would call the db we need to include the db fixture | 21:27 |
| melwitt | sean-k-mooney: nice, thanks | 22:00 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!