| opendevreview | Merged openstack/nova master: pwr mgmt: handle live migrations correctly https://review.opendev.org/c/openstack/nova/+/909806 | 00:06 |
|---|---|---|
| frickler | I see nova is still busy, but is placement ready for rc1? https://review.opendev.org/c/openstack/releases/+/912427 | 07:00 |
| bauzas | sean-k-mooney: morning, I absolutely forgot about https://review.opendev.org/c/openstack/nova/+/891289 | 08:32 |
| bauzas | sean-k-mooney: so if you want, we can merge it this morning and then I'll update https://review.opendev.org/c/openstack/nova/+/912617 | 08:34 |
| * bauzas wonders why this change wasn't in https://etherpad.opendev.org/p/nova-caracal-rc-potential#L26 | 08:34 | |
| bauzas | sean-k-mooney: gibi: the SRIOV fix for mdevs is still unapproved, could you please give it a shot ? | 09:06 |
| bauzas | https://review.opendev.org/c/openstack/nova/+/899625 | 09:06 |
| gibi | bauzas: I can be the second core there but I need Sean's or Dan's +2 first as I don't have the full context about the discussion here https://review.opendev.org/c/openstack/nova/+/899625/11#message-c3edab5a61f5dfcfc1297e2891ace5d742185f6a | 09:42 |
| bauzas | this was resolved | 09:42 |
| gibi | I haven't seen Dan's review since that discussion. | 09:44 |
| bauzas | cool enough | 09:47 |
| opendevreview | Merged openstack/nova master: Removed explicit call to delete attachment https://review.opendev.org/c/openstack/nova/+/891289 | 10:47 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Add a Caracal prelude section https://review.opendev.org/c/openstack/nova/+/912973 | 11:26 |
| sean-k-mooney | bauzas: ack i see https://review.opendev.org/c/openstack/nova/+/891289 is now merged are you going to update https://review.opendev.org/c/openstack/nova/+/912617 | 11:39 |
| sean-k-mooney | bauzas: gibi i readded my +2 but if you want to wait for dan to review that fine too | 11:47 |
| sean-k-mooney | bauzas: ignoring release stuff for a sec i assume your next priority is using the mtty devices to add basic testing in ci of creating instnaces with mdevs | 11:48 |
| sean-k-mooney | by basic i mean without live migration | 11:48 |
| sean-k-mooney | out side of perhaps the mdev persitence feature melwitt has in flight and those two bug fixes i really dont want to do anything else realted to mdevs until we have the ci job in place | 11:51 |
| gibi | I +Ad | 11:58 |
| gibi | https://review.opendev.org/c/openstack/nova/+/899625 | 11:58 |
| sean-k-mooney | https://www.youtube.com/watch?v=ixZpBOxMopc spacex are launching in an hour just an fyi | 12:00 |
| sean-k-mooney | take 3 at starship | 12:00 |
| gibi | yepp, I following it :) | 12:01 |
| bauzas | sean-k-mooney: could you please stop to ask me something when I'm off about 12:30pm ? :) | 12:19 |
| sean-k-mooney | ask you stuff only when your away aroudn 12:30 sure | 12:20 |
| bauzas | anyway thanks for the reviews :) | 12:20 |
| * bauzas goes off again for my child | 12:21 | |
| bauzas | (for going with her to her school) | 12:21 |
| artom | Huh, https://review.opendev.org/c/openstack/nova/+/877773 somehow avoided the merge conflict | 14:29 |
| artom | Weird, but yey for less work for Uggla | 14:29 |
| Uggla | artom, cool, I was about to do it, so it is useless. | 14:30 |
| sean-k-mooney | artom: it the non backporable one that was in merge conflcit | 14:34 |
| sean-k-mooney | so ya i guess that my queue to go review the backportable one | 14:35 |
| artom | They're both apparently clear | 14:35 |
| artom | Not sure how | 14:35 |
| sean-k-mooney | oh its says same topic not merge conflict | 14:35 |
| sean-k-mooney | artom: are your patches emged now | 14:35 |
| sean-k-mooney | i tought several of them were still pending | 14:36 |
| artom | Yeah, they all went through last night | 14:36 |
| sean-k-mooney | in that case would you mind starting the backport of your patches | 14:37 |
| artom | Yep | 14:44 |
| artom | To Antelope, right? When did we actually add power management? | 14:44 |
| artom | Yeah https://specs.openstack.org/openstack/nova-specs/specs/2023.1/implemented/libvirt-cpu-state-mgmt.html | 14:45 |
| sean-k-mooney | yes | 14:46 |
| sean-k-mooney | Uggla: change choudl go back futher but antelope would be ok for that too | 14:47 |
| sean-k-mooney | zed will move to unmainteined in a few weeks | 14:47 |
| artom | We'd like it downstream in 17.1 though | 14:48 |
| sean-k-mooney | basically when the offial release of caracal happens in april | 14:48 |
| sean-k-mooney | we can optionally propose it to the unmained branches if we like | 14:48 |
| sean-k-mooney | assuming that helps with the downstream backprot withc it likely will | 14:49 |
| sean-k-mooney | just saying that by default the stable/core team are not expected to do backports to unmaintained/* | 14:49 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.2: Add cpuset_reserved helper to instance NUMA topology https://review.opendev.org/c/openstack/nova/+/913193 | 14:57 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.2: Reproducer for not powering on isolated emulator threads cores https://review.opendev.org/c/openstack/nova/+/913194 | 14:57 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.2: Power on cores for isolated emulator threads https://review.opendev.org/c/openstack/nova/+/913195 | 14:57 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.2: pwr mgmt: make API into a per-driver object https://review.opendev.org/c/openstack/nova/+/913196 | 14:57 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.2: Reproducer test for live migration with power management https://review.opendev.org/c/openstack/nova/+/913197 | 14:57 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.2: pwr mgmt: handle live migrations correctly https://review.opendev.org/c/openstack/nova/+/913198 | 14:57 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: fup for power management series https://review.opendev.org/c/openstack/nova/+/913221 | 15:08 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: Add cpuset_reserved helper to instance NUMA topology https://review.opendev.org/c/openstack/nova/+/913222 | 15:08 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: Reproducer for not powering on isolated emulator threads cores https://review.opendev.org/c/openstack/nova/+/913223 | 15:08 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: Power on cores for isolated emulator threads https://review.opendev.org/c/openstack/nova/+/913224 | 15:08 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: pwr mgmt: make API into a per-driver object https://review.opendev.org/c/openstack/nova/+/913225 | 15:08 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: Reproducer test for live migration with power management https://review.opendev.org/c/openstack/nova/+/913226 | 15:08 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: pwr mgmt: handle live migrations correctly https://review.opendev.org/c/openstack/nova/+/913227 | 15:08 |
| bauzas | artom: sean-k-mooney: yeah, I'll look at the backports after GA | 15:09 |
| bauzas | (Apr 03) | 15:09 |
| artom | bauzas, sean-k-mooney, I'll cherry-pick them downstream anyways | 15:10 |
| bauzas | sure, but please don't discuss downstream usage here :) | 15:10 |
| bauzas | it's a public channel | 15:10 |
| bauzas | (and we log everything :) ) | 15:10 |
| sean-k-mooney | this is entirly approate to disucss here | 15:11 |
| bauzas | sean-k-mooney: gibi: dansmith: https://review.opendev.org/c/openstack/nova/+/912973 prelude is open for reviews | 15:11 |
| sean-k-mooney | artom was askign if we shoudl consider backportign to unmaintend branhces | 15:11 |
| sean-k-mooney | and i say we can do that if we want to for other reasons | 15:11 |
| sean-k-mooney | but form a core or stable core perspective we do not maintian those | 15:11 |
| sean-k-mooney | and are not expected to do backport to them | 15:11 |
| artom | I don't think it's a surprise that Red Hat has a downstream product, and that we do cherry-picks :) | 15:11 |
| artom | It's not like we're discussing downstream-only code changes here | 15:12 |
| sean-k-mooney | right so i was just trying to provide guidence that we shoudl default to backporting to stable/* | 15:12 |
| artom | Oh, totally | 15:12 |
| sean-k-mooney | and unmaintained/* is optional but not expected | 15:13 |
| artom | As far back as is reasonably possible. | 15:13 |
| artom | Yep. | 15:13 |
| sean-k-mooney | if we are backporting downstream past stable/* it does not hurt to provide the patches publicly but if peopel choose not to it that ok too | 15:13 |
| sean-k-mooney | i prefer when our backprots upstream or downstream are made avaiabel to as wide an audinace as possibel so i prefer upstrema first to be our default | 15:14 |
| bauzas | for sure | 15:19 |
| bauzas | I was just saying to make sure we don't need to discuss about our downstreack backports here | 15:19 |
| bauzas | not because of security, but rather Red Hat is not the only company working upstream :) | 15:20 |
| sean-k-mooney | yep i just wanted artom to start on the upstream one and we can figure out downsteam when wever that becomes relevent | 15:20 |
| bauzas | (and it was just a reminder that we log everything here : https://meetings.opendev.org/irclogs/%23openstack-nova/ ) | 15:21 |
| artom | sean-k-mooney, they're all posted anyways, even the downstream ones :) | 15:21 |
| * bauzas needs to get his child back from the school, I'll be back in 20 mins | 15:22 | |
| artom | bauzas, I know this is a public channel - again, I don't think it's a surprise to anyone, or is secret information, that Red Hat has a downstream product with cherry-picks :) And that's there the mention of it ends, nothing further will be discussed | 15:22 |
| bauzas | no worries, but maybe not all of us know about the logs :) ) | 15:23 |
| sean-k-mooney | i do and im sure artom does so is it new info to you? | 15:24 |
| artom | I was totally about to post by credit card PIN | 15:25 |
| sean-k-mooney | password: | 15:25 |
| sean-k-mooney | :) | 15:25 |
| sean-k-mooney | anyway i got distracted by thing ill go back and review Uggla patch now | 15:26 |
| artom | See, then you typed your password, I saw *****, but you saw hunter2, because IRC is smart like that | 15:32 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Update compute rpc alias for caracal https://review.opendev.org/c/openstack/nova/+/912617 | 15:59 |
| bauzas | dansmith: gibi: sean-k-mooney: yet another paperwork change for RC1 ^ | 16:00 |
| bauzas | (just updated it b/c of the new RPC version we just added) | 16:00 |
| sean-k-mooney | ack im +2 on https://review.opendev.org/c/openstack/nova/+/877773 by the way | 16:03 |
| gibi | I'm +2 the RPC alias | 16:20 |
| bauzas | elodilles: sean-k-mooney: I just figured out (my bad) that we still have a few open patches in placement that could be merged before RC1 https://review.opendev.org/q/project:openstack/placement+is:open | 17:04 |
| bauzas | https://review.opendev.org/c/openstack/placement/+/907742 seems at least nice to have | 17:04 |
| sean-k-mooney | the slurp job can merge at any point | 17:23 |
| sean-k-mooney | we can trivially just backport that to the stable branch | 17:23 |
| sean-k-mooney | but i agree it woudl be nice to have | 17:23 |
| elodilles | bauzas: ACK, thanks for signaling it on the release patch! | 17:49 |
| elodilles | (though you linked a nova patch there o:)) | 17:49 |
| melwitt | sean-k-mooney: speaking of persistent mdevs, I think it's ready for review if you were wondering https://review.opendev.org/c/openstack/nova/+/910041 | 18:37 |
| sean-k-mooney | how did testing host reboot go. were you able to do it with the sytemd service file? | 18:38 |
| sean-k-mooney | melwitt: this is for dalmation ya so i can try and review it but we need to wait for RC1 to ship before merging i guess | 18:40 |
| sean-k-mooney | this is pretty localised within the libvirt code so im not really concerned with this havign issues with other RCs so i would be ok ewith merging this once we reapprove the blueprint from a paperwork perpwective | 18:41 |
| melwitt | sean-k-mooney: yeah, no rush obvs. I've been intentionally not bringing it up but just so you're aware. I don't expect review until later on | 18:41 |
| sean-k-mooney | cool | 18:41 |
| melwitt | sean-k-mooney: I didn't think to try the systemd way for some reason. I only did it manually. I'll try systemd next | 18:42 |
| melwitt | I did remember to put the systemd mention into docs/ in that patch 😛 | 18:42 |
| sean-k-mooney | ack if your including the doc update with the systemd script then ya it would be good to test that locally | 18:42 |
| sean-k-mooney | yep its teh second ting i read after the commit message | 18:43 |
| melwitt | yeah. agree | 18:43 |
| sean-k-mooney | oh i see your supproting eithe rway based on the libvirt version | 18:45 |
| melwitt | yeah.. initially I didn't do that but realized it later. we would need a min version bump to not have to do it I think | 18:46 |
| sean-k-mooney | am that will not strictly be required as we can move to libvirt 8.0.0 next cycle | 18:46 |
| sean-k-mooney | but since you have it working we can keep it | 18:46 |
| melwitt | which we might be doing for dalamation, so I can take that out if so | 18:46 |
| melwitt | it would make the change much prettier if we bumped to 8.0.0 heh | 18:47 |
| sean-k-mooney | ya although its not terrible as is | 18:47 |
| melwitt | persistent mdevs in 7.3.0 and autostart in 7.8.0 | 18:47 |
| sean-k-mooney | autostart in this context being create them automatically on host start right | 18:48 |
| sean-k-mooney | rather then domain start | 18:48 |
| sean-k-mooney | may be worth adding follow up patches that do the min bump | 18:49 |
| sean-k-mooney | and we can then defer that choice until we decied if we bump to 8.0.0 | 18:49 |
| sean-k-mooney | it looks like there would not actully be much clean up to do fo 8.0.0 | 18:50 |
| sean-k-mooney | i mean for other feature | 18:51 |
| sean-k-mooney | all the feature gates seam to be 8.y.z | 18:52 |
| sean-k-mooney | so i dont think you will need to do much cleanup if you decied to creat that patch | 18:52 |
| melwitt | sean-k-mooney: yes autostart is the virNodeDeviceCreate happening automatically at host start | 18:55 |
| melwitt | I also added a thing to do it during init_host if for some reason there are any that are defined but not created | 18:55 |
| melwitt | it's not really related to domain start in that domain start will not start them | 18:56 |
| melwitt | the domain will fail to start until you start the nodedev | 18:56 |
| stblatzheim | anyone here who could review and give a +W for the cherrypick for 2023.1 for https://review.opendev.org/c/openstack/nova/+/911070 ? | 18:57 |
| sean-k-mooney | melwitt: well what i was really thinking about is we currenlty undefien an redefine the domain on start so we woudl recreate those i think if you had not already done it in init_host | 18:58 |
| melwitt | sean-k-mooney: oh so colocating it with the domain define/create, yeah I see what you mean | 18:59 |
| melwitt | I thought about that but forgot. I think that would be a good way too | 18:59 |
| sean-k-mooney | im not sure it required but ill try and reject on that when i get aroudn to reviewing properly | 19:00 |
| melwitt | from testing I know that it won't happen on its own but we could definitely add a check + device start before starting the domain | 19:03 |
| melwitt | *won't happen on its own without autostart on the nodedev | 19:04 |
| sean-k-mooney | ack, i think where reasonable we want to try adn get to the point where restarting a compute node does not requrie any manual intervention to sart the vms via the api provided the smi-manage thing is automated via a systemd service or similar before nova starts | 19:34 |
| sean-k-mooney | that means either creating them at init_host, or autostart or at domain start | 19:35 |
| sean-k-mooney | elodilles: would you mined reviewing https://review.opendev.org/c/openstack/nova/+/911070 for stblatzheim when you have time or other stable cores | 19:36 |
| melwitt | sean-k-mooney: I agree. I tested for example creating a nodedev without autostart on purpose, then rebooting the host, then starting the VM. the code in init_host worked to make it so all I had to do was 'server start' (after sriov-manage -e, which I will test with systemd also) | 20:03 |
| opendevreview | Merged openstack/nova master: Update compute rpc alias for caracal https://review.opendev.org/c/openstack/nova/+/912617 | 23:50 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!