| opendevreview | Takashi Kajinami proposed openstack/os-traits master: Add a new trait for AMD SEV-ES https://review.opendev.org/c/openstack/os-traits/+/908966 | 02:58 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/os-traits master: Add a new trait for AMD SEV-ES https://review.opendev.org/c/openstack/os-traits/+/908966 | 02:59 |
| opendevreview | Takashi Kajinami proposed openstack/os-traits master: Add a new trait for AMD SEV-ES https://review.opendev.org/c/openstack/os-traits/+/908966 | 03:00 |
| opendevreview | Takashi Kajinami proposed openstack/os-resource-classes master: Add MEM_ENCRYPTED_CONTEXT_V2 resource class https://review.opendev.org/c/openstack/os-resource-classes/+/908967 | 03:02 |
| opendevreview | Takashi Kajinami proposed openstack/os-resource-classes master: Add MEM_ENCRYPTED_CONTEXT_V2 resource class https://review.opendev.org/c/openstack/os-resource-classes/+/908967 | 03:49 |
| opendevreview | Amit Uniyal proposed openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824 | 05:36 |
| opendevreview | Amit Uniyal proposed openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824 | 07:23 |
| opendevreview | ribaudr proposed openstack/nova master: Amend ShareMappingStatus due to asynchronous call https://review.opendev.org/c/openstack/nova/+/908864 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860288 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Add share lock/unlock and restrict visibility https://review.opendev.org/c/openstack/nova/+/890340 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Check shares support (only API exception) https://review.opendev.org/c/openstack/nova/+/885752 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Check shares support (API) https://review.opendev.org/c/openstack/nova/+/850499 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | 07:37 |
| opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | 07:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | 07:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | 07:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | 07:38 |
| opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | 07:38 |
| opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks https://review.opendev.org/c/openstack/nova/+/884312 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: make <encryption> a sub element of <source> https://review.opendev.org/c/openstack/nova/+/905515 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: Support (resize|cold migration) with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: Support live migration with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/905512 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: Support rebuild with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870939 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/873675 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: Add backing_encryption_secret_uuid to BlockDeviceMapping https://review.opendev.org/c/openstack/nova/+/907960 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: WIP Support encrypted backing files for qcow2 https://review.opendev.org/c/openstack/nova/+/907961 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | 08:04 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | 08:04 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Modify the mdevs in the migrate XML https://review.opendev.org/c/openstack/nova/+/904258 | 09:02 |
| Uggla | gibi, I pushed an updated serie this morning. Hopefully I fixed most of your comments. | 10:08 |
| opendevreview | Nobuhiro MIKI proposed openstack/nova master: libvirt: Support maxphysaddr. https://review.opendev.org/c/openstack/nova/+/907516 | 10:12 |
| bauzas | Uggla: I'm starting to look at your series :) | 10:18 |
| Uggla | bauzas, thx | 10:18 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Added context manager for instance lock https://review.opendev.org/c/openstack/nova/+/873648 | 10:26 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Separate OSError with ValueError https://review.opendev.org/c/openstack/nova/+/908825 | 10:26 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | 10:26 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Removed explicit call to delete attachment https://review.opendev.org/c/openstack/nova/+/891289 | 10:26 |
| stephenfin | Uggla: Are you happy with https://review.opendev.org/c/openstack/openstacksdk/+/893505 now? Sounds like you figured out the issues you were having using SDK for Manila so that doc is probably correct? | 12:50 |
| Uggla | stephenfin, tbh not really I did not manage to use the service token. So for the moment I left it behind. | 12:59 |
| stephenfin | ah, okay | 12:59 |
| ganso | gibi, dansmith, sean-k-mooney: hi! could you please review this small patch when you have a few minutes? thanks in advance! https://review.opendev.org/c/openstack/nova/+/906053 | 13:11 |
| sean-k-mooney | ganso: its currenlty in merge conflict so it needs a rebase | 13:12 |
| ganso | sean-k-mooney: it is? I thought it was predicting a merge conflict with other unmerged patches. Let me rebase it and fix the conflits then, just a sec | 13:13 |
| sean-k-mooney | ganso: no when it says merge conflcit on the left like that its not mergable with master | 13:14 |
| sean-k-mooney | this is really a feature by the way but ill try and load some context | 13:14 |
| ganso | sean-k-mooney: oh I was looking at a stale page. I had to ctrl+F5 for it to show up | 13:15 |
| ganso | sean-k-mooney: a feature? you mean it wouldn't be backportable? | 13:15 |
| opendevreview | Rodrigo Barbieri proposed openstack/nova master: Use dedicated live migration network during pre-migration https://review.opendev.org/c/openstack/nova/+/906053 | 13:19 |
| sean-k-mooney | ganso: without new config option i dont think it is backportable no | 13:25 |
| sean-k-mooney | ganso: any change in what network are used could break an existing deployment | 13:26 |
| sean-k-mooney | ganso: im on a call by the way so i have only skimed the patch so perhaps that not a concern | 13:26 |
| sean-k-mooney | we ahve a new related feature | 13:26 |
| sean-k-mooney | which allows configuing what network we use for cold migration | 13:27 |
| sean-k-mooney | which is i belive the same code that is deictating what network we are usign itn pre-migration | 13:27 |
| ganso | sean-k-mooney: I understand the concern. I have a customer that is running into this issue. They have 2 networks, one for controller and one for migration. The bug causes the controller network to be used and the patch actually addresses the use of the correct migration network. It doesn't change their setup. | 13:28 |
| sean-k-mooney | we added https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.migration_inbound_addr | 13:28 |
| ganso | sean-k-mooney: yep, that is the setting my customer is using to determine the migration network. The issue is that the setting is being ignored by the pre-live-migration step | 13:29 |
| sean-k-mooney | ganso: migration_inbound_addr is somethign we are adding this cycle | 13:29 |
| sean-k-mooney | so unless they are using master they are suign live_migration_inbound_addr | 13:29 |
| ganso | sean-k-mooney: hmmmmmm let me confirm the naming, maybe it is similar to the other one I'm referring to | 13:30 |
| sean-k-mooney | which is currently only for the libvirt part | 13:30 |
| ganso | sean-k-mooney: yes! live_migration_inbound_addr | 13:31 |
| ganso | sean-k-mooney: yes they are using libvirt | 13:31 |
| sean-k-mooney | right so for cold migration there was no way to use a diffent netwrok before now | 13:31 |
| ganso | sean-k-mooney: so the pre-live-migration code is using the wrong address, derived from the same way cold migration determine its address | 13:31 |
| sean-k-mooney | yep | 13:31 |
| sean-k-mooney | so on master you could "fix this" by settin gboth option to use the migration network | 13:31 |
| sean-k-mooney | for older release it may be valid to change but it not valid to make cold migratoin use the live migration network | 13:31 |
| sean-k-mooney | based on only live_migration_inbound_addr | 13:32 |
| ganso | sean-k-mooney: I am not familiar with the patch code, I just found the fix proposal that I need, but I am a bit surprised that the fix needs an object versioning bump to make it use the correct network config instead of the wrong one | 13:32 |
| ganso | sean-k-mooney: certainly, wouldn't make sense the change the cold-migration behavior, that indeed would be a new feature | 13:32 |
| sean-k-mooney | so its not clear its using the wrong netwrok | 13:32 |
| sean-k-mooney | techncially the exisitng option is only for the libvirt traffic | 13:33 |
| ganso | sean-k-mooney: but fixing something that is a broken behavior in a previously accepted feature is kinda not really a new feature IMO | 13:33 |
| sean-k-mooney | ganso: based on the docs for live_migration_inbound_addr | 13:33 |
| sean-k-mooney | tis not broken | 13:33 |
| sean-k-mooney | there expecation is incorrect based on teh docuemtned behavior | 13:33 |
| sean-k-mooney | ganso: im not saying what you ask for is not an imporvement | 13:34 |
| sean-k-mooney | im just sayting that is not what the docs say the config option does | 13:34 |
| sean-k-mooney | """This option indicates the IP address which should be used as the target for live migration traffic when migrating to this hypervisor. This metadata is then used by the source of the live migration traffic to construct a migration URI.""" | 13:34 |
| sean-k-mooney | copying the disk for block migration is not part of the live migration traffic | 13:34 |
| ganso | well, pre-live-migration is part of live-migration, and if live-migration is not using live-migraiton-inbound-addr then it is somewhat diverging from expected behavior | 13:35 |
| ganso | sean-k-mooney: oh copying the disk is not part of live migration traffic | 13:35 |
| ganso | sean-k-mooney: I see, the devil is in the details xD | 13:35 |
| sean-k-mooney | right this option is litrrally jsut for the data copied by libvirt | 13:35 |
| sean-k-mooney | not the addtional actoins taken by nova | 13:35 |
| sean-k-mooney | but i agree the enhacment that you are asking for makes sense btu that is why its kind of a feature not a bug | 13:36 |
| ganso | sean-k-mooney: yea I understand the reasoning now. The fact that it changes the object versioning already makes it non-backportable If I understand correctly, so the fix would need to be coded differently to be backportable anyway | 13:37 |
| sean-k-mooney | yes | 13:37 |
| ganso | I need to analyze the code to see if that would be possible, but then also whether it would be acceptable as an backportable enhancement to an existing feature (pending more discussion) | 13:38 |
| sean-k-mooney | ganso: so the new feature we added https://github.com/openstack/nova/commit/6bca37e904e9e56b250b123abde1901e951c8c9a | 13:39 |
| ganso | I will talk to my customer first | 13:39 |
| sean-k-mooney | i think would solve this usecase | 13:39 |
| sean-k-mooney | and that is coded in a way that is backportable | 13:39 |
| sean-k-mooney | so we coudl disucss if we wanted to backport this upstream to adress that bug | 13:39 |
| sean-k-mooney | gibi: ^ | 13:39 |
| ganso | sean-k-mooney: it is? but it is introducing a new config option (and it is indeed a new feature) so I assumed even if the code is backportable, it wouldn't be accepted to be | 13:40 |
| sean-k-mooney | do you think https://bugs.launchpad.net/nova/+bug/1939869 is a vaild reason to backport the new migration_inboud_address config option | 13:40 |
| sean-k-mooney | ganso: we normally would not backport it unless there is a large pain point that affects operators | 13:41 |
| sean-k-mooney | we do sometime back port new config options the impoarnt thing with a backport of this kind is it must not change behaivor by default | 13:42 |
| sean-k-mooney | which is true in this case if you want to move all traffic to the migratoin network with that feature you have to set the config option to use the dedicated networks ip/fqdn/hostname | 13:42 |
| ganso | sean-k-mooney: if the default value of the new config options retains the existing behavior, that is less concerning impact for existing deployments while backporting | 13:43 |
| sean-k-mooney | yep it does which is and we also did that for upgrades | 13:43 |
| sean-k-mooney | we did not want to change the behavior on upgade for the same config file | 13:43 |
| sean-k-mooney | elodilles: ^ i know this is borderline but i think gibis feature is a more reasoable approch then https://review.opendev.org/c/openstack/nova/+/906053 | 13:44 |
| ganso | sean-k-mooney: yea if it solves the issue I am happy with backporting that instead. I need to test to be 100% sure, but it probably does as you say | 13:45 |
| ganso | that other patch may even not be that much necessary anymore | 13:45 |
| sean-k-mooney | ganso: i bleivle https://github.com/openstack/nova/commit/6bca37e904e9e56b250b123abde1901e951c8c9a#diff-486ddc37ce8e7c105a51566dd2cffbda034f28fae7eaad2e74abf470ab296352L4514 is the important part | 13:46 |
| sean-k-mooney | i belive get_host_ip_addr is the common fucntion that is causing hte current behavior so yes https://review.opendev.org/c/openstack/nova/+/906053 shoudl not be requried anymore | 13:47 |
| ganso | yep | 13:49 |
| opendevreview | Rodrigo Barbieri proposed openstack/nova stable/2023.2: [libvirt]Add migration_inbound_addr https://review.opendev.org/c/openstack/nova/+/908995 | 14:55 |
| ganso | sean-k-mooney: I proposed the backport just to get the discussion started ^. Waiting to hear gibi's thoughts on this | 14:56 |
| sean-k-mooney | ack | 14:56 |
| dougszu | Thanks for looking at https://review.opendev.org/c/openstack/nova/+/906053. It comes from a time before the other patch. I will take a look at it shortly. | 15:02 |
| *** d34dh0r5- is now known as d34dh0r53 | 15:02 | |
| elodilles | sean-k-mooney: well, if it's more like a feature than a bugfix, then best to avoid the backport, though, there can be exceptions, i mean, if the stable cores agrees that it worth the risk and most probably won't cause any regression, then it can be backported. (the only thing is NOT to change the current behaviour for existing deployments, i'd say) | 15:02 |
| sean-k-mooney | elodilles: ya for upgrade reasons when we added this it preserved the existing behavior | 15:03 |
| sean-k-mooney | elodilles: so if we were to backport it as with master you would have to modify the config option to use it | 15:04 |
| elodilles | +1 | 15:04 |
| sean-k-mooney | elodilles: tl;dr we supprot movign the libvirt traffic to a dedicate network but only for live migraton | 15:04 |
| sean-k-mooney | the feature enables that for cold migration | 15:04 |
| sean-k-mooney | and as a sideffect also move the block copy done by nova wich is common for live migration to the new network if you opt in with the config option | 15:05 |
| sean-k-mooney | not all users were aware that the live_migration_inbound_adr is just for the libvirt traffic | 15:05 |
| sean-k-mooney | not also for novas data transfers | 15:05 |
| sean-k-mooney | https://bugs.launchpad.net/nova/+bug/1939869 is partly a misundertaing of how thing work but i dont think its an unresobale expectation and other operator may have fallen faul of that too | 15:06 |
| elodilles | i see, thanks for the details | 15:08 |
| elodilles | sean-k-mooney: added my (long) comment to the backport o:) | 15:19 |
| sean-k-mooney | ack we proably should chat about this either in the channel or in the team meetign to get import form stable folks in general | 15:21 |
| elodilles | +1 | 15:22 |
| opendevreview | Merged openstack/nova master: HyperV: Add todo to remove HyperVLiveMigrateData object https://review.opendev.org/c/openstack/nova/+/906636 | 15:30 |
| dougszu | sean-k-mooney: Perhaps I missed something, but for https://bugs.launchpad.net/nova/+bug/1939869, i'm not sure how https://review.opendev.org/c/openstack/nova/+/908995 is going to 'fix' it. Since the source HV is calling the target HV by RPC, which then needs to get the IP of the source HV (not the hostname) | 16:01 |
| sean-k-mooney | dougszu: it wont because it should not | 16:04 |
| sean-k-mooney | howeve if you set the other config option then those calls shoudl use that for the data transfer | 16:05 |
| sean-k-mooney | dougszu: defiening live_migration_inbound_addr should not cause the config driver or other data to be copied via that api | 16:06 |
| sean-k-mooney | its a miss understanding fo what the config option currently is for | 16:06 |
| sean-k-mooney | the new config option https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.migration_inbound_addr | 16:07 |
| sean-k-mooney | states """ metadata is then used by the source of the migration traffic to construct the commands used to copy data (e.g. disk image) to the destination.""" | 16:07 |
| sean-k-mooney | so migration_inbound_addr should modify the adress used for the ssh/rsync | 16:08 |
| dougszu | Yeah, no problem with rejecting the bug report. | 16:08 |
| sean-k-mooney | but live_migration_inbound_addr should only modify the libvirt traffic | 16:08 |
| dougszu | This bit, from i've seen happens the other way though: "metadata is then used by the source of the migration traffic to construct the commands used to copy data (e.g. disk image) to the destination" | 16:09 |
| dougszu | I.e. the copy is initiated from the destination to the source | 16:09 |
| dougszu | Eg. this runs on the dest: https://review.opendev.org/c/openstack/nova/+/906053/4/nova/virt/libvirt/driver.py#10917 | 16:12 |
| dougszu | So there has to be some way of transferring the source IP/FQDN etc to the dest | 16:12 |
| dougszu | Apologies if I've missed something :D | 16:13 |
| ganso | dougszu: I see your point, the custom IP config set in the source would need to be propagated to the destination somehow, as it wouldn't matter that the destination has a custom migration IP too because that's not the relevant one, it is the source one | 16:19 |
| dougszu | ganso: yeah, that's it. Wondering if it's worth converting https://review.opendev.org/c/openstack/nova/+/906053 to a feature request | 16:23 |
| sean-k-mooney | thats not how this work | 16:25 |
| sean-k-mooney | the info is passed form the dest back to the souce | 16:26 |
| sean-k-mooney | as the migration is started form the soucrce | 16:26 |
| sean-k-mooney | and we copy the data form the source to test | 16:26 |
| sean-k-mooney | *dest | 16:26 |
| ganso | sean-k-mooney: the migration of VM data is, the disk copy no. In the logs that I have I see the dest ssh'ing to the src to scp the disk | 16:28 |
| dougszu | +1, I definitely see the scp initiated from the dest. Eg. for fetching config drive during live migrate. | 16:29 |
| ganso | dougszu: to be honest, if the patch already merged doesn't address the issue, then it becomes even more important that the new one does, and being a non-backportable feature prevents customers from accessing the fix unless they upgrade to caracal, which for some is a long time in the future | 16:30 |
| sean-k-mooney | hum really | 16:30 |
| dougszu | As in the bug report at the top: https://bugs.launchpad.net/nova/+bug/1939869 | 16:30 |
| sean-k-mooney | i would have to look at that again but for config dirve specificaly | 16:30 |
| dougszu | Happy to share more logs | 16:30 |
| sean-k-mooney | we dont actully need to copy it manually | 16:30 |
| sean-k-mooney | libvirt can and will do that now | 16:30 |
| sean-k-mooney | there was a bug in libvirt several year ago | 16:30 |
| sean-k-mooney | that required us to do that but i tought we removed that code | 16:30 |
| dougszu | It's also the glance image (if it's no longer available in glance) | 16:30 |
| sean-k-mooney | so that should be done form the souce to dest i tought but perhaps its on the dest | 16:31 |
| sean-k-mooney | ok lets do this | 16:31 |
| sean-k-mooney | our normall request for any complex bug | 16:32 |
| sean-k-mooney | is to first create a reproducer fucntional test showing the buggy behavior | 16:32 |
| sean-k-mooney | so it woudl be good to try and simulate this with a fuctional test to show that | 16:32 |
| ganso | sean-k-mooney: hmmmmm if it was an older libvirt bug that may not longer be valid or that version no longer used since a given version that matches recent nova version we would backport to (for example focal-zed), so maybe instead of backporting the new config option, or even going with the new patch that bumps the object version, we could perhaps shift things around and move that from the source as you say and use the | 16:38 |
| ganso | live_migration_inbound_addr instead | 16:38 |
| ganso | actually I don't think zed is used on focal, it is from jammy onwards, and in jammy it may be that every libvirt version available does not have that bug | 16:38 |
| sean-k-mooney | so there are a few issue at play here. | 16:39 |
| sean-k-mooney | first you should not be doing live migation by doing "openstack server migrate --live-migration --block-migration`" | 16:39 |
| sean-k-mooney | --block-migation was depercated about 6+ years ago | 16:39 |
| ganso | sean-k-mooney: oh I didn't know that, the customer is using --block-migration because that's the only way they can get the config drive moved. Is there a better way to do this? | 16:40 |
| sean-k-mooney | in mitaka we added auto to do the right thing | 16:42 |
| sean-k-mooney | https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#maximum-in-mitaka | 16:42 |
| ganso | sean-k-mooney: by "auto" you mean, not specifying anything? in that case the code complains that it is not in shared storage | 16:43 |
| sean-k-mooney | so if you do openstack --os-compute-api=2.25 server migrate --live <server> | 16:44 |
| sean-k-mooney | then it will just do the right thing | 16:44 |
| sean-k-mooney | and we will leave libvirt copy the config drive i belive | 16:44 |
| sean-k-mooney | ganso: there was a specific bug with libvirt and live migrating with iso files attached as a cdrom | 16:45 |
| sean-k-mooney | that requried us to copy it first | 16:45 |
| sean-k-mooney | but that was in like ubuntu 16.04 | 16:45 |
| sean-k-mooney | resolved in libvirt v1.2.17. | 16:45 |
| sean-k-mooney | https://bugs.launchpad.net/nova/+bug/1246201 | 16:46 |
| dougszu | It's this code block running on dest (contains both config drive and glance image copy): https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L10892 | 16:46 |
| dougszu | I'm not seeing where it's gated on --block-migration, but could have missed something | 16:47 |
| sean-k-mooney | right that was added by https://review.opendev.org/c/openstack/nova/+/365420/1/nova/virt/libvirt/driver.py | 16:47 |
| sean-k-mooney | that code is not needed anymore and has not been for litrally years | 16:47 |
| dougszu | For config drive yeah, but not the Glance image? | 16:48 |
| sean-k-mooney | ya so that code https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L10899-L10911 | 16:48 |
| sean-k-mooney | can be removed | 16:48 |
| sean-k-mooney | for the backing file | 16:48 |
| sean-k-mooney | we cant remvoe it but its not a bug that that does nto use the live | 16:49 |
| sean-k-mooney | *live_migrateion_inboud_adr | 16:49 |
| sean-k-mooney | im not sure if that will now work with the new migration migration_inbound_addr | 16:50 |
| sean-k-mooney | i belive it should but it it does not it would be a bug in that new feature | 16:50 |
| ganso | sean-k-mooney: ok I will ask my customer to re-test that with the --os-compute-api=2.25 --live and without --block-migration and see if that solves the issue | 16:51 |
| sean-k-mooney | ack | 16:52 |
| dougszu | Thanks, I can do some more testing. Good to know the config drive code can be removed. | 16:52 |
| ganso | sean-k-mooney: btw I thought --live was deprecated in favor of --live-migration, --live was the one that specified the dest and --live-migration leaves it to the scheduler | 16:52 |
| sean-k-mooney | oh right | 16:52 |
| sean-k-mooney | ya in either case the impoatnt point it to use a microversion >= 2.25 | 16:52 |
| sean-k-mooney | to get the auto behvior | 16:52 |
| ganso | sean-k-mooney: thanks for the explanation! :) | 16:55 |
| sean-k-mooney | a straignt revert of https://review.opendev.org/c/openstack/nova/+/365420 wont work because of merge conflcits | 16:56 |
| opendevreview | sean mooney proposed openstack/nova stable/mitaka: Revert "[libvirt] Live migration fails when config_drive_format=iso9660" https://review.opendev.org/c/openstack/nova/+/908937 | 16:56 |
| sean-k-mooney | actully never mind apprently it will work | 16:56 |
| opendevreview | sean mooney proposed openstack/nova stable/mitaka: Revert "[libvirt] Live migration fails when config_drive_format=iso9660" https://review.opendev.org/c/openstack/nova/+/908937 | 16:57 |
| sean-k-mooney | actully the striagt revert is wrong for other reason but ill see if i can remove that code properly oh also its agaisnt the wrong branch | 16:58 |
| sean-k-mooney | so ignore ^ | 16:58 |
| sean-k-mooney | dougszu: ganso what i was going to say is if either of ye feel like reverting the config drive bit on master i can review | 16:59 |
| sean-k-mooney | if not ill add this to my todo list and se if we can remove that | 17:00 |
| dougszu | I'll try and have a go tomorrow | 17:00 |
| ganso | sean-k-mooney: I rather have my customer test first to be sure there will be a code path that addresses their config drive migration. At the moment I am not sure as I am not familiar with that part of the code. It should go "auto" as you say but each case could be different | 18:13 |
| *** jph4 is now known as jph | 18:32 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!