| opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | 01:13 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | 01:13 |
| opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/903427 | 03:35 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2023.2: Allow live migrate paused instance when post copy is enabled https://review.opendev.org/c/openstack/nova/+/903834 | 08:07 |
| gibi | sean-k-mooney: elodilles: a clean cherry pick backport ^^ | 08:08 |
| opendevreview | Merged openstack/nova master: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/894288 | 08:18 |
| elodilles | gibi: +2'd | 10:40 |
| gibi | thanks | 10:42 |
| gibi | I will push it back to antelope as well when the bobcat one lands | 10:43 |
| elodilles | ++ | 10:43 |
| sean-k-mooney | gibi: you might as well bring it to zed to have it on all stable branches | 11:42 |
| opendevreview | Takashi Kajinami proposed openstack/python-novaclient master: coveragerc: Fix wrong omitted directory https://review.opendev.org/c/openstack/python-novaclient/+/903960 | 11:58 |
| opendevreview | Takashi Kajinami proposed openstack/os-vif master: coveragerc: Remove non-existent path https://review.opendev.org/c/openstack/os-vif/+/903961 | 11:59 |
| gibi | sean-k-mooney: I can | 12:03 |
| sean-k-mooney | for now thats going to be my default backport target until next it moves to unmaintened next cycle | 12:04 |
| sean-k-mooney | ^ those two patches form takashi are trival and correct by the way if anyone wants some simple reviews | 12:07 |
| gibi | done | 12:19 |
| opendevreview | Elod Illes proposed openstack/nova stable/zed: Translate VF network capabilities to port binding https://review.opendev.org/c/openstack/nova/+/899229 | 13:03 |
| opendevreview | Merged openstack/nova stable/2023.2: Allow live migrate paused instance when post copy is enabled https://review.opendev.org/c/openstack/nova/+/903834 | 13:28 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2023.1: Allow live migrate paused instance when post copy is enabled https://review.opendev.org/c/openstack/nova/+/903840 | 14:05 |
| gibi | elodilles: sean-k-mooney: ^^ moving it back to Antelope | 14:06 |
| elodilles | +2'd | 14:54 |
| *** EugenMayer440189 is now known as EugenMayer44018 | 14:59 | |
| opendevreview | Merged openstack/python-novaclient master: coveragerc: Fix wrong omitted directory https://review.opendev.org/c/openstack/python-novaclient/+/903960 | 15:20 |
| opendevreview | Merged openstack/nova stable/2023.2: Fix traits to cpu flags mapping https://review.opendev.org/c/openstack/nova/+/903443 | 15:24 |
| opendevreview | Merged openstack/nova stable/2023.1: Remove outdated comment about allocation ratios https://review.opendev.org/c/openstack/nova/+/903695 | 15:24 |
| gibi | elodilles: thanks | 15:37 |
| opendevreview | Merged openstack/os-vif master: coveragerc: Remove non-existent path https://review.opendev.org/c/openstack/os-vif/+/903961 | 15:38 |
| bauzas | reminder : nova meeting in 12 mins here | 15:48 |
| bauzas | #startmeeting nova | 16:00 |
| opendevmeet | Meeting started Tue Dec 19 16:00:06 2023 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'nova' | 16:00 |
| bauzas | howdy folks | 16:00 |
| bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:00 |
| bauzas | who's around ? | 16:00 |
| elodilles | o/ | 16:01 |
| bauzas | anybody else ? | 16:02 |
| elodilles | looks like holiday season :) | 16:02 |
| bauzas | well, yes and no :) | 16:02 |
| bauzas | not for all of us yet :) | 16:02 |
| gibi | o/ | 16:03 |
| bauzas | let's start, we'll see | 16:03 |
| bauzas | #topic Bugs (stuck/critical) | 16:03 |
| bauzas | #info No Critical bug | 16:03 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 44 new untriaged bugs (+3 since the last meeting) | 16:03 |
| bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:04 |
| bauzas | artom: could you look at some bug reports this week ? | 16:04 |
| bauzas | anyway, moving on | 16:05 |
| bauzas | #topic Gate status | 16:05 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:05 |
| bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | 16:05 |
| bauzas | fwiw, I haven't seen any CI failure this week | 16:06 |
| bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:06 |
| bauzas | all greens \o/ | 16:06 |
| bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:07 |
| JayF | I've seen a couple unrelated failures this week on patches I've pushed, but the frequency I've seen on my limited sample size has been significantly reduced. | 16:07 |
| bauzas | any CI failure you would want to discuss ? | 16:07 |
| JayF | Thank you for the improvement \o/ | 16:07 |
| bauzas | JayF: cool | 16:07 |
| * fwiesel joins late | 16:07 | |
| bauzas | shall we move ? | 16:07 |
| bauzas | #topic Release Planning | 16:08 |
| bauzas | #link https://releases.openstack.org/caracal/schedule.html#nova | 16:08 |
| sean-k-mooney | o/ | 16:08 |
| bauzas | #info Caracal-2 (and spec freeze) milestone in 3 weeks | 16:08 |
| bauzas | we still have some open specs | 16:08 |
| bauzas | so if you could review them, it would be nice : https://review.opendev.org/q/project:openstack/nova-specs+is:open+file:%5Especs/2024.1/.* | 16:09 |
| bauzas | (at least mine, it would be nice :p ) | 16:10 |
| bauzas | as a reminder, the specs freeze deadline is on January 11 (eob) | 16:10 |
| sean-k-mooney | ill do some spec reviews before i finsih up fo rthe year | 16:11 |
| bauzas | ditto | 16:11 |
| sean-k-mooney | ill then be back on the 8th | 16:11 |
| bauzas | #topic Review priorities | 16:11 |
| grandchild | o/ | 16:11 |
| bauzas | sean-k-mooney: as well, but let's discuss about when we're off by the last topic | 16:11 |
| bauzas | I added an item about that | 16:12 |
| bauzas | so, about review prios | 16:12 |
| bauzas | #link https://etherpad.opendev.org/p/nova-caracal-status | 16:12 |
| bauzas | I checked every item in the etherpad before the meeting | 16:12 |
| bauzas | as a reminder, you can use this etherpad to know which features or bug reports to review | 16:12 |
| bauzas | each of the approved bps has one item in the etherpad with the related change | 16:13 |
| bauzas | and we have a few accepted prioritied bug reports | 16:13 |
| bauzas | moving on | 16:14 |
| bauzas | #topic Stable Branches | 16:14 |
| Uggla | o/ | 16:14 |
| bauzas | elodilles: passing you | 16:14 |
| elodilles | #info stable gates don't seem blocked | 16:14 |
| elodilles | at least I'm not aware of any *constantly* failing job | 16:14 |
| elodilles | #info nova stable releases are out: 2023.2 Bobcat (28.0.1), 2023.1 Antelope (27.2.0), Yoga (25.3.0) | 16:14 |
| elodilles | note that there won't be more release out of stable/yoga as that branch will transition to Unmaintained | 16:15 |
| elodilles | #info Zed stable release is not yet approved: https://review.opendev.org/899604 | 16:15 |
| elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:15 |
| elodilles | and that's all from me regarding stable branches | 16:15 |
| bauzas | elodilles: so about yoga | 16:15 |
| bauzas | I guess we would have another change for EM ? | 16:16 |
| bauzas | I mean the tag | 16:16 |
| elodilles | nope | 16:16 |
| elodilles | it will be a different tag, | 16:16 |
| elodilles | then unmaintained/yoga will be cut from that tag | 16:16 |
| elodilles | (and stable/yoga branch will be deleted) | 16:16 |
| bauzas | okayt | 16:16 |
| elodilles | that's the plan | 16:16 |
| bauzas | JayF: I can't remember, does the TC eventually accepted the unmaintained resolution ? | 16:18 |
| * bauzas looks at https://governance.openstack.org/tc/ | 16:18 | |
| opendevreview | Merged openstack/nova-specs master: Re-submit Ironic-shards for Caracal https://review.opendev.org/c/openstack/nova-specs/+/902698 | 16:18 |
| bauzas | I mean, what do we miss for starting to use unmaintained/yoga ? | 16:19 |
| * bauzas reads now https://governance.openstack.org/tc/resolutions/20230724-unmaintained-branches.html | 16:19 | |
| elodilles | bauzas: the automation tools are missing from release tooling :) | 16:19 |
| elodilles | bauzas: i'm working on it ;) | 16:20 |
| bauzas | okay | 16:20 |
| bauzas | so, basically, people can backport some changes to stable/yoga but we shouldn't be merging them ? | 16:20 |
| elodilles | also this is a good reading for people who are interested in the topic: https://governance.openstack.org/tc/resolutions/20231114-amend-unmaintained-status.html | 16:21 |
| bauzas | now we released yoga with the last number? | 16:21 |
| sean-k-mooney | the stable/yoga branch will be deleted after the tag is created adn unmaintained/yoga is created | 16:21 |
| sean-k-mooney | one thing we need to do is update the .gitreview file | 16:21 |
| elodilles | bauzas: we can merge, the tag will be applied at the HEAD of stable/yoga (like the *-eol tag) | 16:21 |
| sean-k-mooney | once we cut the new branch | 16:21 |
| bauzas | elodilles: okay | 16:22 |
| bauzas | good to know | 16:22 |
| bauzas | so, basically, we can still backport some changes if we need (like some important fixes), but it would be better to wait until yoga is unmaintained | 16:22 |
| elodilles | +1 | 16:23 |
| bauzas | people interested in maintaining yoga would tho still want to backport changes to the stable branch, but we shouldn't be releasing it | 16:23 |
| bauzas | I'm cool with the plan then | 16:24 |
| bauzas | moving on | 16:24 |
| bauzas | #topic vmwareapi 3rd-party CI efforts Highlights | 16:24 |
| fwiesel | #Info Script installs functional devstack, starting from a blank vm snapshot in ca. 500s | 16:24 |
| bauzas | fwiesel: grandchild: if you want to tell us | 16:24 |
| bauzas | fwiesel: bravo ! | 16:24 |
| fwiesel | So, we should be able to hook now things up, but... | 16:24 |
| fwiesel | #Info Need to lock down network before hooking up CI (ETA: Roughly Mid-January due to holidays) | 16:25 |
| fwiesel | For the curious ones, the stack.log I've put here: http://sap-openstack-ci.s3-website.us-east-2.amazonaws.com/logs-stack.tar.gz | 16:25 |
| bauzas | heh, sure :) | 16:25 |
| * bauzas clicks | 16:25 | |
| fwiesel | We will probably dump there also then the output of the test-runs, so they are publically visible | 16:25 |
| bauzas | fwiesel: I got a 403 from the link | 16:26 |
| elodilles | (fwiesel: it says 403 forbidden) | 16:26 |
| fwiesel | Hmm, I'll have to check with the colleague then. Just five minutes I we fixed the permissions. And I do not have the means to change them myself | 16:27 |
| bauzas | fwiesel: no rush | 16:27 |
| sean-k-mooney | for what its worht this https://www.ovhcloud.com/en-ie/web-hosting/performance-offer/ used to be what we used to host the logs publicly in teh past | 16:27 |
| sean-k-mooney | it is much cheaper then aws | 16:27 |
| bauzas | I didn't wanted to play the French card :D | 16:28 |
| fwiesel | Not if you factor in the bureaucracy to get that through in a big company | 16:28 |
| sean-k-mooney | so its 120 euro a year so it genrelly does not require appoveal and can be expensed in most companies :) | 16:28 |
| sean-k-mooney | but sue | 16:29 |
| sean-k-mooney | *sure | 16:29 |
| bauzas | we're publicly logged here so I won't speak that much, but yeah AWS is good as being the primer | 16:29 |
| sean-k-mooney | anyway good to know | 16:29 |
| fwiesel | We probably put it behind a dns redirect, so we can switch it whenever we want. | 16:29 |
| bauzas | fwiesel: that's a good idea and you shouldn't publiclize what you use for your environment IMHO ) | 16:30 |
| bauzas | :) | 16:30 |
| bauzas | even if people can see the dns redirect :) | 16:30 |
| bauzas | anyway | 16:30 |
| bauzas | thanks for the report, and that's very good to hear that your lab is running :) | 16:31 |
| bauzas | kudos again | 16:31 |
| fwiesel | bauzas: You're welcome. Thanks for giving us the opportunity to pitch in. | 16:31 |
| bauzas | shall we move on ? | 16:31 |
| bauzas | I have an item | 16:31 |
| fwiesel | #Info Next update on 9th January | 16:31 |
| bauzas | noted. | 16:32 |
| bauzas | and it will transition to my own item actually :) | 16:32 |
| bauzas | #topic Open discussion | 16:32 |
| bauzas | (bauzas) Skip next two nova meetings ? | 16:32 |
| sean-k-mooney | i think yes | 16:32 |
| bauzas | so, I'm off from Christmas to Jan 8 | 16:32 |
| bauzas | (Jan 8 not included, tbc) | 16:33 |
| gibi | +1 on skipping | 16:33 |
| gibi | I'm back on the 15th | 16:33 |
| elodilles | +1 from me, too | 16:33 |
| bauzas | anyone having concerns and wanting to discuss the next day after Jan 1 ? :D | 16:33 |
| bauzas | looks not | 16:34 |
| bauzas | #agreed Next two nova meetings (Dec 26 and Jan 2) will be SKIPPED. Next meeting will be Jan 9 | 16:34 |
| bauzas | #action bauzas to communicate this over ML | 16:34 |
| bauzas | okay | 16:35 |
| bauzas | so, we have another item | 16:35 |
| bauzas | that we already discussed last week | 16:35 |
| bauzas | (JayF/johnthetubaguy) Specless blueprint for ironic guest metadata | 16:35 |
| bauzas | https://blueprints.launchpad.net/nova/+spec/ironic-guest-metadata | 16:35 |
| JayF | I've put a significant amount of detail in this since last week | 16:35 |
| bauzas | JayF: fancy taking the baton again ? | 16:35 |
| bauzas | cool | 16:35 |
| JayF | I'm happy to discuss here, or async in the blueprint/mailing list/etc | 16:35 |
| * bauzas reads the whiteboard | 16:35 | |
| JayF | This is mostly based on conversations with sean-k-mooney, especially the part about generalizing the libvirt code | 16:36 |
| sean-k-mooney | just readign it now | 16:36 |
| bauzas | JayF: I just have one question | 16:37 |
| JayF | I either have an answer or a clever deflection technique ;) | 16:37 |
| bauzas | with a SLURP environment consisted of Caracal controllers, Caracal computes but also Antelope computes, how Ironic could use this ? | 16:37 |
| JayF | Ironic is going to just look for the metadata provided by Nova in instnace_info | 16:38 |
| sean-k-mooney | im not sure that will matter given this will be entrily in the driver | 16:38 |
| JayF | if it's there; Ironic will add the lessee; if not, it won't | 16:38 |
| JayF | if someone is migrating, they'll migrate *after* the upgrade is complete and because the migration script is additive only, it'll make the environment consistent | 16:38 |
| sean-k-mooney | if the ironic compute are running antelope code it just wotn set that data | 16:39 |
| bauzas | JayF: here, I just want to hear that you understand that the metadata will be optional, at least until we upgrade to 2024.2 | 16:39 |
| sean-k-mooney | if its upgraded it can check the ironic api version if needed | 16:39 |
| JayF | Absolutely; 100%, ironic will opportunistically use that metadata if it exists, we will not make a hard dependency on it | 16:39 |
| JayF | it'd be an API break for us to do anything else | 16:39 |
| sean-k-mooney | the ironic script that will be created for backfilling can also be used to reconsile everythign after the upgrade is fully done | 16:40 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Resolve mypy error https://review.opendev.org/c/openstack/nova/+/903530 | 16:40 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tox: Use pre-commit for pep8 target https://review.opendev.org/c/openstack/nova/+/896227 | 16:40 |
| opendevreview | Stephen Finucane proposed openstack/nova master: pre-commit: Add mypy https://review.opendev.org/c/openstack/nova/+/896228 | 16:40 |
| opendevreview | Stephen Finucane proposed openstack/nova master: pre-commit: Bump linter versions https://review.opendev.org/c/openstack/nova/+/903749 | 16:40 |
| bauzas | JayF: then I'm cool | 16:40 |
| JayF | woo | 16:40 |
| sean-k-mooney | i think im oke with moving forward with this as a specless bluepint and movign the dicussion to the implementaion | 16:40 |
| bauzas | from a nova pov, this is just a small thing | 16:40 |
| JayF | That's sorta how I feel about it too, but it's hard for me to tell :) | 16:41 |
| bauzas | but again, I don't want Ironic to have a bug because we continue to support Antelope computes, that's it :) | 16:41 |
| bauzas | if the plan is already sorted, then yay, sounds specless | 16:41 |
| bauzas | anyone concerned by any design problem ? | 16:41 |
| bauzas | anyone thinking of some nit that would need to be discussed ? | 16:42 |
| bauzas | apparently no | 16:42 |
| bauzas | so, | 16:42 |
| JayF | I'll note Ironic team discussed this at PTG; this reflects that discussion. I'll run it by our cores as well, don't expect any contention but I'll make another round trip here if there's any change. | 16:42 |
| bauzas | #agreed https://blueprints.launchpad.net/nova/+spec/ironic-guest-metadata to be approved as a specless blueprint for 2024.1 timeframe | 16:43 |
| JayF | Thank you o/ | 16:43 |
| bauzas | I already did the paperwork stamping | 16:44 |
| bauzas | I guess we're done with the meeting | 16:44 |
| bauzas | I don't see anything else in the agenda | 16:44 |
| fwiesel | Thanks everyone and happy holidays | 16:44 |
| bauzas | so, anything anyone ? | 16:44 |
| gibi | have a nice time off folks! | 16:45 |
| elodilles | happy holidays o/ | 16:45 |
| bauzas | yeah, happy holidays to all of you and for those who take time off, have a good one :) | 16:45 |
| bauzas | see you all next year | 16:45 |
| bauzas | #endmeeting | 16:45 |
| opendevmeet | Meeting ended Tue Dec 19 16:45:50 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:45 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-12-19-16.00.html | 16:45 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-12-19-16.00.txt | 16:45 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-12-19-16.00.log.html | 16:45 |
| artom | bauzas, sorry, was AFK, yep, can look at bugs | 16:55 |
| bauzas | artom: thanks and again, as a reminder, low prio, stretch good at most | 16:58 |
| bauzas | goal* | 16:58 |
| bauzas | don't feel obliged. | 16:58 |
| artom | Well don't say that :) | 16:58 |
| bauzas | I'm just clear on the fact I can't force anyone to do upstream work if they are not recognized for that | 16:59 |
| sean-k-mooney | bauzas: https://review.opendev.org/c/openstack/nova-specs/+/900636 +1 can you review my comments | 17:03 |
| * bauzas looks | 17:03 | |
| damiandabrowski | Unfortunately, even I have cinder.cross_az_attach=False, scheduler moves VM to the other AZ during migrate/resize which breaks it. | 17:04 |
| damiandabrowski | ^ it was not intended, please let me send messages in a correct order :D | 17:04 |
| damiandabrowski | Hey! I want to deploy multi-AZ environment(shared network, separate ceph cluster in each AZ, no default_schedule_zone, no explicit AZ provided when creating VM, Zed Release). | 17:07 |
| damiandabrowski | Unfortunately, even I have cinder.cross_az_attach=False, scheduler moves VM to the other AZ during migrate/resize which breaks it. | 17:07 |
| damiandabrowski | In documentation, I found the following statement so I guess it's an expected behavior: "If the server was not created in a specific zone then it is free to be moved to other zones, i.e. the AvailabilityZoneFilter is a no-op." | 17:07 |
| damiandabrowski | Is there any way to prevent changing AZs during resize/migrate? | 17:07 |
| sean-k-mooney | damiandabrowski: if the vm was create before enabling that settign on both the comptues and contoler it wont have updated the request spec with the az | 17:08 |
| sean-k-mooney | damiandabrowski: live migration ebtween AZ is expected to work in genreal yes | 17:09 |
| sean-k-mooney | damiandabrowski: my guess is if you check the request spec of the vm in question | 17:09 |
| sean-k-mooney | it will not have an az specified | 17:09 |
| sean-k-mooney | only the az in the request spec is considerd when schduling | 17:09 |
| bauzas | sean-k-mooney: you're right on your first comment, we could return the mdev values in one step by the claim https://github.com/openstack/nova/blob/45e2349408dd3b385217066a3c5a4c29d7bdd3a0/nova/compute/manager.py#L8550 | 17:10 |
| bauzas | that's a good call | 17:10 |
| sean-k-mooney | the second change is so we know which uuid mapps to which type so that we can avoid changing the pci adress of the vgpus if we every have more then one in vm | 17:16 |
| sean-k-mooney | that way i want to map the source mdev to the dest mdev that has the same type | 17:16 |
| damiandabrowski | sean-k-mooney: thanks for reply. My test vm are created after setting cinder.cross_az_attach=False on controllers and computes. | 17:19 |
| damiandabrowski | I guess nova.instance_extra is a place where I can find instance extra specs right? | 17:19 |
| damiandabrowski | https://paste.openstack.org/show/bXZgVyObqHQfn6yAVdET/ | 17:19 |
| sean-k-mooney | bauzas: ^ you are more familar with that code path. | 17:20 |
| sean-k-mooney | damiandabrowski: yes but this is not an extra spec | 17:20 |
| sean-k-mooney | the request_spec is an object in the api db | 17:20 |
| damiandabrowski | ahh my bad, thanks! | 17:21 |
| damiandabrowski | https://paste.openstack.org/raw/bUwKEZg6FsylqJj4mDBi/ | 17:21 |
| damiandabrowski | "availability_zone": null | 17:21 |
| bauzas | strange | 17:22 |
| bauzas | if you had cross_az_attach=False, then the reqspec should have been modified | 17:22 |
| bauzas | by pinning to the volume AZ | 17:22 |
| bauzas | sean-k-mooney: noted, will change too | 17:22 |
| bauzas | damiandabrowski: sean-k-mooney: the path that's checking whether we should pin to an AZ for a volume https://github.com/openstack/nova/blob/d28a55959e50b472e181809b919e11a896f989e3/nova/compute/api.py#L1268 | 17:24 |
| JayF | bauzas: others; feedback from dtantsur in #openstack-ironic leads me to revise the ironic guest metadata spec to remove flavor since flavor name is volatile and can change while the instance is provisioned; in general can you consider us sending *less* fields to Ironic than listed in that spec an implementation detail? | 17:24 |
| bauzas | JayF: yup, no worries | 17:25 |
| sean-k-mooney | JayF: that why i was saying we should use the falvor uuid | 17:25 |
| bauzas | we said all that meat is specless | 17:25 |
| JayF | ack | 17:25 |
| JayF | sean-k-mooney: that's not in the libvirt one today, fwiw | 17:25 |
| bauzas | this is an implementation detail that will reviewed at time | 17:25 |
| sean-k-mooney | JayF: yep i know thats an oversight i wanted to fix | 17:25 |
| sean-k-mooney | we have access to it we are just not storing it right now | 17:26 |
| sean-k-mooney | JayF: flavors are imuntable (extra_spec are not) | 17:26 |
| JayF | ++ sounds good, we can easily do that with the centralization of that code | 17:26 |
| sean-k-mooney | you can recarete a flavor with the same name as previously deleted one but you cant specify a uuid | 17:27 |
| sean-k-mooney | JayF: with regards to updating the bluepint lets add a doc in the refernce/continbutor section | 17:28 |
| dtantsur | JayF: I assume the flavor uuid only fixes a half of the problem: the flavor can deleted or (?changed?) | 17:28 |
| sean-k-mooney | to detail how this works | 17:28 |
| sean-k-mooney | dtantsur: it can be but that does not make the info useless | 17:28 |
| dtantsur | sean-k-mooney: but isn't it the reason why nova provides neither name nor uuid in the newer API versions? | 17:29 |
| JayF | sean-k-mooney: I don't know what that means? | 17:29 |
| sean-k-mooney | JayF: while the flavor exist the uuid is useful for operator s to correalte nodes | 17:29 |
| dtantsur | yeah, I don't see flavor UUID in https://docs.openstack.org/api-ref/compute/#show-server-details | 17:30 |
| JayF | sean-k-mooney: the "doc in reference/contributor section" bit is what I don't understand | 17:30 |
| sean-k-mooney | dtantsur: we provide flavor.original_name i server show | 17:30 |
| JayF | If the flavor uuid/name isn't in Nova's API, it's not super useful in Ironic's API tbh | 17:30 |
| JayF | and given there's a price to putting keys in that json field, if it's not cross-referenceable, I'd rather not send it | 17:31 |
| damiandabrowski | bauzas: thanks, then something is off...I'll try to gather more details | 17:31 |
| sean-k-mooney | JayF: it is in the api up to version 2.46 | 17:31 |
| dtantsur | when you say flavor UUID, you mean its numerical ID? | 17:31 |
| dtantsur | "The ID of the flavor. While people often make this look like an int, this is really a string."? | 17:31 |
| sean-k-mooney | JayF: in 2.47 we addded flavor.original_name and remove flavor.name and flavor.id because they can be deleted but we cache a copy of hte flavor in the isntance_extra table when its created | 17:32 |
| JayF | sean-k-mooney: so it sounds like that is probably information better left for the operator to lookup in nova api | 17:32 |
| sean-k-mooney | dtantsur: flavor.id is a string filed that can be an int or any other sting. we generate a uuid if you dont provide one | 17:32 |
| dtantsur | I"m curious, why don't you publish id yourself then? | 17:33 |
| dtantsur | it's weird to add something to ironic that nova decided to remove | 17:33 |
| opendevreview | Merged openstack/nova stable/zed: Translate VF network capabilities to port binding https://review.opendev.org/c/openstack/nova/+/899229 | 17:33 |
| sean-k-mooney | we did and im not sure why we did keep it | 17:33 |
| sean-k-mooney | but you can still get it usign the old microverion | 17:33 |
| sean-k-mooney | im not sure why we dont have flavor.original_id | 17:33 |
| dtantsur | yeah, this ^^^ | 17:34 |
| opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes mdev live-migration support in libvirt https://review.opendev.org/c/openstack/nova-specs/+/900636 | 17:34 |
| bauzas | sean-k-mooney: gibi: updated based on sean-k-mooney's nice improvments | 17:34 |
| JayF | Either way, it's clear the arrows of the "latest" version of the API is that this information is best looked up and kept in nova, if it's not a first class API object in Nova that's guaranteed to be there and/or Ironic is not going to cache the flavor like nova does | 17:34 |
| JayF | this was going to be an easy win; it's not; so punt it and keep the metadata that is the easy wins IMO | 17:35 |
| JayF | our API already has enough places with weird corners, this sounds like an easy place to avoid making another one | 17:35 |
| sean-k-mooney | so looks like it was changed in pike https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id43 so there should be a spec | 17:35 |
| sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/instance-flavor-api.html#proposed-change it jsut says it could be stale but i kind of think that was a mistake | 17:36 |
| sean-k-mooney | JayF: ack i tought the falvor was the main motavator for this | 17:37 |
| dtantsur | hold on. if a user can specify the uuid, cannot they specify a uuid of an already deleted flavor? | 17:37 |
| JayF | sean-k-mooney: user_id/project_id is the primary motivator, to enable that next-step feature outlined in the blueprint (automatic_lessee) | 17:38 |
| sean-k-mooney | first flavor are admin only. and yes looking at the api they can recreate a flavor wit hteh same id and name | 17:38 |
| sean-k-mooney | JayF: oh ok | 17:38 |
| sean-k-mooney | then sure feel free to exclude flavor or any other filed not useful to you | 17:38 |
| sean-k-mooney | JayF: back to my docs comment we ahve refnece docs that detail some of the internal works of nova https://github.com/openstack/nova/tree/d28a55959e50b472e181809b919e11a896f989e3/doc/source/reference | 17:40 |
| opendevreview | Merged openstack/nova stable/wallaby: db: Resolve additional SAWarning warnings https://review.opendev.org/c/openstack/nova/+/874069 | 17:40 |
| JayF | sean-k-mooney: so you're saying "Ironic <> Nova API interactions" would be a good document for there, potentially | 17:40 |
| JayF | sean-k-mooney: including a section on metadata passed over | 17:40 |
| sean-k-mooney | JayF: they refence section is inteded for developers so i was suggesting adding a instance metadata doc ther that just says this si what ironic uses | 17:40 |
| JayF | sean-k-mooney: even if that's not what you're saying, it's what I'm saying now, because it's a good idea and might make the ironic driver generally less scary | 17:41 |
| sean-k-mooney | yep | 17:41 |
| sean-k-mooney | so im fine fi the details change as part of the impleation as long as we documetn /test the expecte behavior so we know why | 17:41 |
| sean-k-mooney | normally i woudl refer to the spec for those detail of intent | 17:41 |
| opendevreview | Merged openstack/nova stable/2023.1: Allow live migrate paused instance when post copy is enabled https://review.opendev.org/c/openstack/nova/+/903840 | 17:55 |
| sean-k-mooney | bauzas: +2 on https://review.opendev.org/c/openstack/nova-specs/+/900636 gibi if you agree can you +2w | 18:39 |
| opendevreview | Jay Faulkner proposed openstack/nova master: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | 22:57 |
| opendevreview | Jay Faulkner proposed openstack/nova master: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/903915 | 22:57 |
| opendevreview | Jay Faulkner proposed openstack/nova master: Add nova-manage ironic-compute-node-move https://review.opendev.org/c/openstack/nova/+/903916 | 22:57 |
| opendevreview | Jay Faulkner proposed openstack/nova master: Make compute node rebalance safter https://review.opendev.org/c/openstack/nova/+/903917 | 22:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!