| opendevreview | Takashi Kajinami proposed openstack/os-vif master: Clean up remaining python 2.7 support https://review.opendev.org/c/openstack/os-vif/+/896598 | 09:36 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/os-vif master: Clean up remaining python 2.7 support https://review.opendev.org/c/openstack/os-vif/+/896598 | 09:36 |
| tkajinam | wondering if placement can/should be added to https://docs.openstack.org/project-team-guide/stable-branches.html#project-teams-which-asserted-they-follow-the-stable-branch-policy | 10:40 |
| opendevreview | Rajesh Tailor proposed openstack/python-novaclient master: Fix typos https://review.opendev.org/c/openstack/python-novaclient/+/901457 | 12:26 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Detect maximum number of SEV guests automatically https://review.opendev.org/c/openstack/nova/+/899381 | 12:42 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Detect maximum number of SEV guests automatically https://review.opendev.org/c/openstack/nova/+/899381 | 12:42 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Detect maximum number of SEV guests automatically https://review.opendev.org/c/openstack/nova/+/899381 | 12:44 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Detect maximum number of SEV guests automatically https://review.opendev.org/c/openstack/nova/+/899381 | 12:48 |
| sahid | o? | 12:54 |
| sahid | o/ | 12:54 |
| sahid | if some of you have a moment to look at this one: https://review.opendev.org/c/openstack/nova/+/896512 | 12:54 |
| sahid | bauzas, dansmith ^ you already have context on it :-) | 12:55 |
| opendevreview | Danylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added. https://review.opendev.org/c/openstack/nova/+/876075 | 14:01 |
| sean-k-mooney | sahid: before proceeding with that i would like you to justify why we cant just do this with https://docs.openstack.org/nova/latest/admin/aggregates.html#tenant-isolation-with-placement | 14:27 |
| sean-k-mooney | we were ment to discuss this during the ptg but i dont recall doing it so | 14:28 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Detect maximum number of SEV guests automatically https://review.opendev.org/c/openstack/nova/+/899381 | 14:33 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Detect maximum number of SEV guests automatically https://review.opendev.org/c/openstack/nova/+/899381 | 14:34 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Detect maximum number of SEV guests automatically https://review.opendev.org/c/openstack/nova/+/899381 | 14:35 |
| sahid | sean-k-mooney: the behavior are differents, give me a moment I will point you my reponse on gerrit | 14:38 |
| sahid | sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/896512/comment/68ae77da_5f69a5f7/ | 14:40 |
| sahid | It was a concerne from dansmith | 14:40 |
| sahid | (line 39, marked as resolved) | 14:41 |
| sean-k-mooney | the flilter is know to be buggy in some cases | 14:44 |
| sean-k-mooney | i dont think we want to continue to support that buggy behavior and should remove the filter | 14:45 |
| sean-k-mooney | with the placement version you can contole if a teant must use the aggreate or not vai a config option | 14:45 |
| sahid | sean-k-mooney: I don't think it is buggy, it addresses a real use-case that the placement don't | 14:45 |
| sahid | with placement the instance *is only* scheduled on that specified az | 14:46 |
| sean-k-mooney | https://docs.openstack.org/nova/latest/configuration/config.html#scheduler.placement_aggregate_required_for_tenants | 14:47 |
| sahid | it's not the behavior that we want. We want to allow certain tenant to schedule on that specified az, which means they can be scheduled on other | 14:47 |
| sean-k-mooney | so you want all those that have not tenat assocated with them + the hosts that are allowed explcitly for this tenant | 14:51 |
| sean-k-mooney | i woudl prefer to support that in the placment version honestly then extend the filter but your correct we cant express that in teh placment version today | 14:52 |
| sahid | do you have an idea of the work needed to implement it in placement? | 14:59 |
| sahid | I don't know much about placement | 14:59 |
| sahid | As filter are standalone piece of code we can keep our change in filter as downstream only until the placement part get implemented | 15:00 |
| sean-k-mooney | the problem with the filter approch is placmenet may not return hosts that could fit the vm depening on the alocation candate limit | 15:01 |
| sean-k-mooney | i belvie the default limit is 1000 allocation candiates but we may have more then one allcoation candiate per host | 15:01 |
| sean-k-mooney | so even if you have less then 1000 host some hosts that dont have any tennated assocated with them can be filtered out before we hit the schduler filters | 15:02 |
| sean-k-mooney | this is made worse where you limit the reustls. cern limit placment ot less then 20 allcoation candiates | 15:03 |
| sean-k-mooney | in such a case it very likely that all 20 hosts would be exclude by the filter even if you have many hosts with capsity | 15:03 |
| sean-k-mooney | that woudl other wise be valid | 15:04 |
| sahid | this limittation is valable for all scheduler filters, right? | 15:05 |
| sean-k-mooney | yes which is why filters taht filter host based on critia that placement has not considerd in terms of resouce constraits can be problmatic if the placemetn limit is low | 15:06 |
| sean-k-mooney | supporting the usecase you want to enabel is not particalarly striat forward in placment | 15:07 |
| sean-k-mooney | its doable but somewhat complex. basically we would have to create a special aggreated that initally contaiend all comptues. then we would have to remove hots form that if they are later added to a tenent sepcific aggreated. | 15:09 |
| sean-k-mooney | that is non tivial to ensure is correct as new hosts are added and or as aggreates are updated. | 15:09 |
| sean-k-mooney | which is why we orginally didnt to it. | 15:09 |
| sean-k-mooney | there is perhasp another way to do it but its also not ideal | 15:10 |
| sean-k-mooney | with the placment approch we add all host assocated with a tenant aggreate to a placment aggreate. we could do two placment queries and merge the result | 15:11 |
| sean-k-mooney | well me might actully be able to do it in one request | 15:12 |
| bauzas | sean-k-mooney: you can remove your +2 lock; I just +2d https://review.opendev.org/c/openstack/nova/+/901188 :) | 15:13 |
| sean-k-mooney | btu basically we would need to get the list of all host aggates/placment aggreet related to tenatn affinity and ask for all host not in any of those placment aggreates + the one in the tenant specific aggreates | 15:13 |
| sean-k-mooney | for that tenat | 15:13 |
| sean-k-mooney | bauzas: do we know why the funtional tests failed | 15:14 |
| sean-k-mooney | i can but im going to check that first | 15:14 |
| sean-k-mooney | bauzas: nova.tests.functional.libvirt.test_power_manage.PowerManagementTests.test_hardstop_compute_service_if_wrong_opt | 15:15 |
| sean-k-mooney | need to be updated | 15:15 |
| sean-k-mooney | @gibi ^ | 15:15 |
| sean-k-mooney | gibi: ^ | 15:15 |
| bauzas | because we're changing the behaviour, voila :) | 15:16 |
| sean-k-mooney | so once that is fixed then ya ill add +2 | 15:16 |
| bauzas | sean-k-mooney: I just -1d because I wanted a relnote https://review.opendev.org/c/openstack/nova/+/901188 | 15:16 |
| sean-k-mooney | sure | 15:17 |
| sean-k-mooney | gibi: feel free to ping us when that is updated | 15:17 |
| * bauzas goes getting my child | 15:17 | |
| sahid | sean-k-mooney: from operator point of view we are far from placement, we currently run ussuri, and to be at that point of taking benefit of the change added in placement these will take time | 15:24 |
| opendevreview | Merged openstack/nova master: Enforce correct choice for [DEFAULT] enabled_ssl_apis https://review.opendev.org/c/openstack/nova/+/889787 | 15:25 |
| sahid | i have discussed that with bauzas and he told me that there is no evidence today to deprecate or even remove scheduler filter | 15:26 |
| sahid | and I think bauzas you told me that this has been discussed during meeting, no? | 15:27 |
| sahid | if you don't want the change I think we will just keep this improvement for us :-) | 15:40 |
| opendevreview | melanie witt proposed openstack/nova master: Support resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | 17:29 |
| opendevreview | Merged openstack/nova master: docs: Add documentation on server groups https://review.opendev.org/c/openstack/nova/+/899979 | 19:13 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!