Tuesday, 2023-09-12

*** bauzas_ is now known as bauzas00:40
*** bauzas_ is now known as bauzas04:59
*** bauzas_ is now known as bauzas05:08
*** bauzas_ is now known as bauzas05:50
*** bauzas_ is now known as bauzas06:06
*** bauzas_ is now known as bauzas06:51
elodillessean-k-mooney bauzas : oslo.log upper bump patch's tests are passing now \o/ https://review.opendev.org/c/openstack/requirements/+/89292807:00
elodillesthanks sean-k-mooney o/07:00
bauzasgood to hear07:26
fricklerack, thx for fixing this. sean-k-mooney would you reconsider your -1 on 892928 then?07:36
stephenfinbauzas: around now08:00
bauzasstephenfin: wrapping a few things now, but to;dr: would like to discuss any performance hit on https://review.opendev.org/c/openstack/nova/+/86082908:02
bauzasstephenfin: read above my comments08:02
bauzasmy only concern is to make sure that if land quite late in the cycle this change, we wouldn't see any performance change in terms of SQL execution plan08:03
stephenfinah, so that won't actually bump us to SQLAlchemy 2.x: it only prepares us for it08:03
bauzassince most of the calls are changing queries against instances or instance extras08:03
bauzasstephenfin: yeah yeah gotcha08:04
bauzasit's a new 1.4 feature08:04
bauzasand I've done my homework08:04
stephenfinand there should be no impact to the SQL actually generated for 1.4 as it's merely a different way to describe the same thing08:04
bauzasthe objects relationships diffezr08:04
stephenfinthe relationships haven't changed. All that has changed is how we describe them08:04
bauzasbut the docs don't tell anything about the executed JOINs08:04
bauzasstephenfin: that's my natural first thoughts, but then I wonder if the description change may arise some query modification08:05
stephenfinthis model is preferred because it's more explicit and iiuc allows for type hinting without a separate plugin08:05
bauzassince relationships are now both-ways08:05
stephenfinthey were always both ways08:06
stephenfinfor example: look at the first thing we modified in https://review.opendev.org/c/openstack/nova/+/860829/1/nova/db/api/models.py08:06
stephenfinsorry, https://review.opendev.org/c/openstack/nova/+/860829/1/nova/db/api/models.py#b150 (with anchor)08:06
stephenfinthat's saying the local side is called 'host_mapping' and the remote side is called 'cell_mapping'08:07
stephenfinas defined by the backref08:07
stephenfinnow, instead of declaring both of these on one side, we declare it on both sides08:07
stephenfinso if anything it's a bit more duplication but for the advantage of explicitness and readability/parseability08:08
stephenfinbauzas: here, compare the output of these. First, with backref: https://paste.opendev.org/show/bD4K8pJoSl212q37kvEZ/08:16
stephenfinthen, with back_populates: https://paste.opendev.org/show/bonhcuiyNJtYmM0wITE0/08:16
bauzasexcellent, that's what I was testing08:17
stephenfinthey're modified versions of my examples from https://that.guru/blog/sqlalchemy-relationships-without-foreign-keys/08:17
stephenfinspoiler: it's the same SQL08:17
bauzasso the main thing to doublecheck is that the implicit relationship that was given by the other way is now explicit in the object08:18
bauzasright?08:18
bauzasbecause if not, we regress by loosing a JOIN08:18
stephenfinyeah, that makes sense08:19
opendevreviewMerged openstack/os-vif stable/2023.2: Update .gitreview for stable/2023.2  https://review.opendev.org/c/openstack/os-vif/+/89406008:50
bauzasstephenfin: I may have spotted a problem with bdms.deleted https://review.opendev.org/c/openstack/nova/+/86082909:44
bauzasstephenfin: I need to go off the keyboard for gym reasons but I'll be back in the afternoon09:45
* bauzas drops now09:46
kashyapHehe, "gym reasons"09:50
opendevreviewStephen Finucane proposed openstack/nova master: db: Remove unused relationships  https://review.opendev.org/c/openstack/nova/+/89463510:56
bauzaskashyap: I don't know how to call what I do :) let's say physical prep :)12:25
kashyapHeh, I was just joking, dont' worry :)13:01
stephenfinbauzas: you saw my reply, I assume?13:34
stephenfini can squash if you'd like but it's much of a muchness given it's "dead code"13:35
bauzasstephenfin: I was literally seconds before pinging you13:35
bauzasstephenfin: my only concern is that I need to check why we have this bdm relationship and I don't trust our test coverage for saying whether it's unused or not13:36
bauzasat least I certainly understand why the backref was limiting to existing BDMs and not the deleted ones13:36
bauzasstephenfin: wouldn't be easier to change the relationship in your first change to continue querying the non-deleted BDMs, and *then* remove the relationship later ? 13:37
stephenfinit would but then I need to rebase and lose the +2s :)13:38
bauzasso, we could somehow merge the first one in Bobcat while the latter would be in Caracal13:38
bauzasstephenfin: if this is just about a +2, we can ping sean-k-mooney :)13:38
stephenfinOkay, once I know it won't take many months before it's looked at again :) I'll respin shortly after my current meeting13:44
bauzassure, I'll look13:48
bauzasagain, matter of priorities, y'know<13:49
opendevreviewMerged openstack/nova-specs master: Create specs directory for 2024.1 Caracal  https://review.opendev.org/c/openstack/nova-specs/+/88917714:14
opendevreviewStephen Finucane proposed openstack/nova master: db: Replace use of backref  https://review.opendev.org/c/openstack/nova/+/86082914:30
opendevreviewStephen Finucane proposed openstack/nova master: objects: Stop fetching from security_groups table  https://review.opendev.org/c/openstack/nova/+/86085014:30
opendevreviewStephen Finucane proposed openstack/nova master: db: Remove unused relationships  https://review.opendev.org/c/openstack/nova/+/89463514:30
stephenfinbauzas: sean-k-mooney: ^14:30
bauzasreminder : nova meeting in 10 mins15:50
bauzasstephenfin: saw your update, thanks, but I need to continue reviewing it15:50
bauzasshit16:03
bauzas#startmeeting nova16:03
opendevmeetMeeting started Tue Sep 12 16:03:33 2023 UTC and is due to finish in 60 minutes.  The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.16:03
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:03
opendevmeetThe meeting name has been set to 'nova'16:03
bauzassorry folks about the late start :)16:03
auniyalo/16:03
gibio/16:03
elodilleso/16:03
bauzas#link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting16:03
Ugglao/16:03
bauzas#topic Bugs (stuck/critical) 16:03
bauzas#info One Critical bug16:04
bauzas#link https://bugs.launchpad.net/nova/+bug/198386316:04
bauzasbut iiuc, the fix is now merged16:04
bauzasso, will be closed soon-ish16:04
bauzas#link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 49 new untriaged bugs (+0 since the last meeting)16:04
bauzas#info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster16:05
bauzas#info bug baton is bauzas16:05
bauzastaking the baton for this week again16:05
bauzasany bug to discuss ?16:05
auniyalbauzas, ci bug https://bugs.launchpad.net/nova/+bug/203509516:05
bauzasI've seen an excerpt of this16:06
bauzasbasically the port doesn't become active16:06
bauzaslet's discuss this gate failure in the next topic16:06
bauzas#topic Gate status 16:06
auniyalack, 16:06
gibiis it a duplicate of https://bugs.launchpad.net/neutron/+bug/1940425 ?16:06
bauzas#link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs 16:06
bauzasso16:06
bauzasauniyal: yes indeed, could you please mark it dup ?16:07
auniyalyes16:07
gmanno/16:07
bauzascool16:07
bauzas#link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status16:07
bauzas#info nova-emulation is still b0rked16:08
bauzas#info https://zuul.openstack.org/build/d2ddbb3f307549aaa0575b9ee0f1daab16:08
bauzaslots of keystone failures this time16:08
bauzasso I guess this is unfortunate16:08
bauzasmoving on then ?16:11
bauzasshall we discuss any other gate failure ?16:11
bauzaslooks not16:12
bauzas#info Please look at the gate failures and file a bug report with the gate-failure tag.16:12
bauzas#topic Release Planning 16:12
bauzas#link https://releases.openstack.org/bobcat/schedule.html16:12
bauzas#info Nova deadlines are set in the above schedule16:12
bauzas#info 2 days before RC116:12
bauzas#link https://etherpad.opendev.org/p/nova-bobcat-rc-potential Etherpad for tracking RCs16:12
bauzasbasically all the needed changes are approved now, 16:12
bauzasthe cycle highlights got a correct round of reviews16:12
bauzasso I'll prepare the reno prelude patch based on the highlights tomorrow morning16:13
bauzasok, let's jump then16:14
bauzas#topic Review priorities 16:15
bauzas#link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2)16:15
bauzas#info As a reminder, people eager to review changes can +1 to indicate their interest, +2 for asking cores to also review16:16
bauzas#topic Stable Branches 16:16
bauzaselodilles: please help me by stopping my monolog :)16:16
elodilles:)16:16
elodilles#info first stable/2023.2 branches were cut (libraries & client libraries), rest will be cut this week with rc1 patches16:16
elodilles#info all stable gates should be OK, though not much activity on stable branches these days16:16
elodilles#info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci16:16
elodillesthat's all from me16:17
auniyal#info Please{10} *review* these backport patches of stable 2023.1, zed and yoga for next minor release16:17
auniyal#info most of these already have one +2.16:17
auniyal#link https://etherpad.opendev.org/p/release-liaison-PatchesToReview16:17
bauzascool, I'll do a round of reviews16:17
bauzas#topic Open discussion 16:17
bauzasI have one16:18
bauzas(bauzas) Can't chair next meeting, who elseĀ ?16:18
bauzas(I'll need to attend a parent-teacher meeting for my daughter's class next week)16:18
bauzasso, any volunteer ?16:19
gibiif nobody else then I will16:19
bauzas1..16:19
sean-k-mooneyi have i have one or two topics to bring up quickly. thanks gibi16:19
bauzassean-k-mooney: you mean, you appreciate gibi for chairing next week ? :)16:20
sean-k-mooneyyes16:20
bauzascool16:20
bauzas2..16:20
bauzas3..16:20
bauzassold16:20
bauzas#info gibi will chair next week's meeting16:20
sean-k-mooneyi could proably do it if he is not around for any reason i just dont want too :)16:20
gibisure I will do it16:20
bauzassean-k-mooney: shoot your own topics (even if I can guess one)16:20
sean-k-mooneyfirst one is this stable only patch that we agreed to do a year ago 16:20
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova/+/82897916:21
sean-k-mooneyim reviewing it now16:21
sean-k-mooneyand it looks ok16:21
sean-k-mooneyso just wanted to highlight it to others16:21
sean-k-mooneythe second quetion is semi procedural16:21
bauzaswant it for Bobcat ?16:21
bauzasnvm, stupid me16:21
sean-k-mooneyits for victoria16:22
bauzasyeah, hence me stupid16:22
sean-k-mooneyso second question is we were discussing on the mailing list about removing the hyperv driver16:22
sean-k-mooneyand vmeare next cycle16:22
bauzasyeah and I provided my humble guts16:22
sean-k-mooneywe can chat about that in the ptg if needed16:22
sean-k-mooneybut i was wondering do we need a spec16:22
bauzaswhich are, unless extremely necessary, avoid any virt driver deprecation this cycle16:23
sean-k-mooneyor just come to agreement and specless blueprint16:23
bauzass/deprecation/removal16:23
bauzasfor removing those from our tree ?16:23
sean-k-mooneywe deprecated them in antileop and marked them experimental16:23
sean-k-mooneyso in caracal i want to remove them form the nova tree16:23
bauzasyeah I know hence my sedf16:23
gibiI don't think we need a spec to delete things16:24
bauzasyeah, so, procedurally, I'd say "mail ML ops" wins against any other paperwork16:24
bauzasI just want the ops to be aware of the cut16:24
bauzasand yeah, it doesn't require a blueprint16:24
bauzasa relnote, for sure16:24
gmannbauzas: sean-k-mooney I am planning the hyperv removal and other os-win cleanup/retirement in 2024.1 only16:25
bauzasthis is just a removal patch 16:25
sean-k-mooneyok well we can chat about it more in the ptg i guess and send a mail to that list16:25
bauzasbut yeah, communication matters16:25
gmannthis is whole stack #link https://review.opendev.org/q/topic:retire-winstackers16:25
sean-k-mooneygmann: yep this is all in the context of 2024.116:25
gmannyeah16:25
sean-k-mooneyi just wanted to know how to track this16:25
gmannand I need to add a spec also as it impact one API too16:25
gmannso all those we can discuss together in PTG16:26
bauzaswhen we removed nova-net, this wasn't tracked by a blueprint16:26
gmannsean-k-mooney: yeah, will add BP and spec16:26
bauzasand this was having API implications16:26
sean-k-mooneyim not sure what api impact this will have16:26
gmannI will propose that, its rdp console I think16:27
bauzastbc, I don't want us to paperwork any removal16:27
sean-k-mooneyah rdp 16:27
bauzasa deprecation for sure, but this was communicated way in advance16:27
sean-k-mooneyi think that kind of seperate16:27
gmannspec is worth here  so that we do not miss anything16:27
sean-k-mooneyit should be sperate commits at least but ok16:27
gmannespecially API change point of view16:27
bauzasthen, I defer this discussion to the PTG16:27
sean-k-mooneyi think we can wrap the meeting there 16:28
bauzaswe need more contact16:28
bauzascontext16:28
bauzasdoh16:28
gmannsure, will propose the spec meanhwile and can discuss in PTG16:28
bauzassean-k-mooney: wanted to discuss the SQLA 1.4 backref thing ?16:28
sean-k-mooneyam i kind of forgot16:28
bauzasto be frank, I already made a round of reviews16:28
sean-k-mooneyso stephen has updated the patchs to address the comment you raised16:28
bauzasso, yeah, this is best effort, but I have some space for this16:29
bauzasif we can have this quickwin, let's aim it16:29
bauzasbut we absolutely need to be on par with the existing 16:29
bauzasthat's why I'm OK with changing our description of the relationships in B, but not drop anything until C16:30
sean-k-mooneyack. i would be sad if this isnt included as to me it was a cycle priroty but yes. i belive the issue you raised was not actully something we needed to adress16:30
sean-k-mooneybut stephen has updated it16:30
sean-k-mooneythere are no drops in the serises16:31
bauzassean-k-mooney: well, instance.block_device_mapping may have returned the deleted BDMs after this patch16:31
sean-k-mooneyno16:31
bauzassean-k-mooney: there are, last patch of 3416:31
bauzas3*16:31
sean-k-mooneyi think stephen was correct that tnat version of the relaation was unused16:31
sean-k-mooneybut again that has been fixed in the current version16:31
sean-k-mooneyand stephen added a 3rd patch to remove the possible unused relationship mapping16:32
sean-k-mooneyin any case lets just review it as normal16:32
bauzasthat's what I'm saying16:32
bauzasI don't bet on things we may not use16:32
bauzasparticularly by relying on our CI to claim whether this is in use or not16:32
bauzasso, I'm OK with doing this kind of dumb rewriting of the relationships we have16:33
bauzaswithout touching them or asserting anything16:33
bauzasin B16:33
bauzaswhile in C, we may debate on the optimizations we may do16:33
sean-k-mooneyyep im expecting the 3 patch to be masteer only16:34
sean-k-mooneywell calacal only16:34
sean-k-mooneyi would like the first to to be in bobcat16:34
opendevreviewMerged openstack/osc-placement stable/2023.2: Update .gitreview for stable/2023.2  https://review.opendev.org/c/openstack/osc-placement/+/89406616:35
sean-k-mooneyi would also like us to offically deprcate supprot for SQA 1.4 in caracal and drop it in D but thats a wider discussion16:35
bauzassean-k-mooney: cool, then we have a consensus 16:36
bauzasany other item to discuss ?16:36
sean-k-mooneynot form me. although fyi ill be on pto the week after next16:36
gmannthat is something we discussed in TC+PTL sessions in Vancouver and moving it there is best way and hopefully in D we can remove it from requirement also but if all projects are migrated16:36
gmann++ on the plan you mentioned 16:37
JayFsean-k-mooney: gmann: I've done some research on that; no distros except Gentoo ship SQLA whatsoever right now16:37
JayFsean-k-mooney: gmann: Including e.g. Debian SID16:37
JayFsean-k-mooney: gmann: So our timing on SQLA 2.0 needs to be in line with the distros; I am personally in favor of getting there more quickly but we can't outrun the rest of the python world :D16:37
gmannyeah, that is good point16:37
JayFs/SQLA whatsoever/SQLA 2.0 whatsoever/16:38
sean-k-mooneypython3-sqlalchemy/unstable,unstable 1.4.47+ds1-1 all16:38
bauzasyeah, and that's why I'm focusing only on the backref thing which is 1.416:38
sean-k-mooneyya sid has 1.4.4716:38
JayF1.4 is going to be the bridge a lot of things are on for a while; it's the release that supports both <1.4 and 2.0+ styler16:38
bauzasenabling SQLA 2.0 is a way larger convo16:38
JayFI'm not saying OpenStack projects should wait to move to new API; I'm saying we can't flip the requirement to actual-2.0 until distros are ready16:38
bauzascool, we are on page16:39
gmannyeah, we need to wait for that16:39
bauzaslooks like we have a violent agreement, anything to add ?16:39
bauzasif not, let's pretend I'm just giving you back 20 mins of your time16:40
bauzasthanks all16:40
bauzas#endmeeting16:40
opendevmeetMeeting ended Tue Sep 12 16:40:28 2023 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:40
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2023/nova.2023-09-12-16.03.html16:40
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-09-12-16.03.txt16:40
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2023/nova.2023-09-12-16.03.log.html16:40
sean-k-mooneyJayF: given SQLAlchemy is now up to  2.0.2016:41
sean-k-mooneyi wonder how much fo the disto lag is becuase openstack and other poject have not moved yet16:41
JayFsean-k-mooney: Like I said; 1.4 is the release that spans both 1.3 and 2.0 supporting projects, so I suspect that's going to be the 'safe place' distros remain for a while16:42
JayFsean-k-mooney: especially since, unlike with some libraries, they won't be able to patch their way into newer versions for any stragglers16:42
JayFsean-k-mooney: To be clear: Ironic is 100% SQLA 2.0 compatible and I am generally a neophile so I'm all about getting on the new version; just when I did the legwork to TC-resolution it gmann and others rightfully pointed out that we can't do it until the distros do it16:43
JayFso I did the legwork and found that sadly, they are correct :(16:43
JayF(despite some folks asserting otherwise at the forum session about it)16:44
sean-k-mooneyi think that feedback we shoudl be bringing to our downstream disto contacts16:44
opendevreviewMerged openstack/osc-placement stable/2023.2: Update TOX_CONSTRAINTS_FILE for stable/2023.2  https://review.opendev.org/c/openstack/osc-placement/+/89406716:44
sean-k-mooneycurrenly nova requires SQLAlchemy>=1.4.1316:45
sean-k-mooneybut i am hopign we can get to and stay at 2.0 compatiblity soon16:45
JayFsean-k-mooney: it's tough because it cuts both directions; we have to ensure *all* openstack projects can run on 2.0 when distros move, and I'm not sure all our projects are going to be able to get there without outside help16:45
JayFso on one hand, faster is better, on the other, having more time to migrate is nice (not that I have real expectation those underresourced projects will prioritize it until it becomes breaky)16:46
sean-k-mooneywell i think stephenfin already spend a time moving a lot of projects16:46
JayFget that man a cape with "OSLO" on the back :D 16:46
JayFsean-k-mooney: fwiw, I assume you likely know this, but you can make 1.4 warn about 2.0-breaky things in tests: https://github.com/openstack/ironic/blob/master/tox.ini#L1716:47
sean-k-mooneyJayF: yep we already doo16:47
JayFnice16:48
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/tox.ini#L2316:48
sean-k-mooneyJayF: for what its worth there is an experimal 2.0.19 build in debian https://packages.debian.org/source/experimental/sqlalchemy16:54
JayFzigo: ^ do you have any idea for a timeline or liklihood for sqlalchemy hitting 2 in debian?16:55
sean-k-mooneyfedora have this tracker https://bugzilla.redhat.com/show_bug.cgi?id=2134559 but it does not seam to be active16:57
sean-k-mooneythe kogi build is failing however https://koji.fedoraproject.org/koji/taskinfo?taskID=10489323716:58
sean-k-mooneyJayF: looks like tumbleweed are one of the first to ship it https://opensuse.pkgs.org/tumbleweed/opensuse-oss-x86_64/python311-SQLAlchemy-2.0.19-3.1.x86_64.rpm.html17:00
sean-k-mooneyah they aslso ship python311-SQLAlchemy1 which is 1.417:02
JayFThat is brand new. I checked there before abandoning my TC resolution a weekish ago17:02
JayFbut I might have been looking for sqlalchemy named packages and missed it, with that in mind17:02
sean-k-mooneythey ship 2 packages now at least17:03
sean-k-mooneythe main package python311-SQLAlchemy is now 2.0 and they have python311-SQLAlchemy1 is 1.4.4617:04
opendevreviewJay Faulkner proposed openstack/nova master: [ironic] Query for shards with proper, plural key  https://review.opendev.org/c/openstack/nova/+/89483321:42
JayFSorry about ^ that, details are in the bug and on the change. Glad I hooked it all up in CI instead of relying on my manual testing.21:48
zigoJayF: It's simply waiting for OpenStack to be released, as Antelope is not SQLA 2.x compatible, the maintainer is waiting on me ...23:12
zigoIf you guys need it now, I can ask for an upload to Unstable right away...23:12
zigoThough I'd prefer for the release to happen.23:13
zigoWhat's the situation on Bobcat? Are we 100% SQLA 2.x compatible already?23:13
zigoIf not, it's going to be huge troubles for me (unless there's patches I can apply on top of Bobcat).23:14

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!