Friday, 2023-08-25

opendevreviewmelanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks  https://review.opendev.org/c/openstack/nova/+/88431201:07
opendevreviewsean mooney proposed openstack/nova master: remove untils.spawn_n  https://review.opendev.org/c/openstack/nova/+/89272201:59
opendevreviewNatz cheng proposed openstack/nova master: Updated links in documentation to be safe links  https://review.opendev.org/c/openstack/nova/+/89272402:51
opendevreviewOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/nova/+/89164803:33
opendevreviewmelanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks  https://review.opendev.org/c/openstack/nova/+/88431203:54
dvo-plvsean-k-mooney, Hello08:07
dvo-plvI would like to talk regarding issue, which you mentioned here: https://review.opendev.org/c/openstack/neutron/+/86951008:08
kashyapgibi: Just saw your ping earlier; will check (the bug https://bugs.launchpad.net/nova/+bug/2023035)08:12
gibikashyap: thanks!08:13
kashyapgibi: Related: Can you get unblock the Workflow-1 here? : https://review.opendev.org/c/openstack/nova/+/87196808:20
kashyapElod is on PTO and that W-1 doesn't apply (as he did based on a comment from Amit, and Amit took back his -1)08:21
opendevreviewRyota, Ochiai proposed openstack/nova master: doc: Update the installation guide for RHEL and CentOS  https://review.opendev.org/c/openstack/nova/+/89260708:28
gibikashyap: do I understand correctly that we don't want to backport https://review.opendev.org/c/openstack/nova/+/869950 just https://review.opendev.org/c/openstack/nova/+/871968 ?08:49
gibibtw I cannot remove elodilles_pto's -w you need infra's help for that08:53
gibikashyap: according to my sources Elod is back on Monday09:03
auniyalyes kashyap, I was in doubt if this need to be backported too - https://review.opendev.org/c/openstack/nova/+/869950,   09:12
auniyalso the reason to remove +1 is to get attention of cores, as there was no backport patch for 86995009:12
auniyalgibi, can you please review this - https://review.opendev.org/q/topic:dangling-volumes09:14
kashyapgibi: Yes, your understanding is correct.  Only https://review.opendev.org/c/openstack/nova/+/87196809:20
kashyapauniyal: (It - 869950 - is not required.)09:20
opendevreviewRyota, Ochiai proposed openstack/nova master: doc: Update the installation guide for RHEL and CentOS  https://review.opendev.org/c/openstack/nova/+/89260709:20
auniyalack09:25
dvo-plvsean-k-mooney, I found that socket can be different for vendors. So I would like to use something like that https://paste.opendev.org/show/bKfuy2TzkygTyLtyW8TE/09:48
dvo-plvthis method creates scoket name accodring to the formula which user can provide via binding port profile. So in the result we will get multinic support and each nix can have uniq socket name09:49
dvo-plvthis method we can call here to format correct socket name https://review.opendev.org/c/openstack/neutron/+/869510/13/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#22109:50
opendevreviewMerged openstack/nova master: Fix exception catch when volume mount fails  https://review.opendev.org/c/openstack/nova/+/85279510:44
sean-k-mooneyspeaking of +1... gibi care to take a look at https://review.opendev.org/c/openstack/nova/+/873061/912:50
sean-k-mooneyi dont know if we need more disucssion on that in general but i also too a swing at removing spwan_n entirly in the followup patch12:51
sean-k-mooneymelwitt: ^12:51
sean-k-mooneythat might need more discusion but i think its proably a good idea in the long run.12:52
gibisean-k-mooney: I will check. I see that it was improved since I last read it12:58
*** TheJulia is now known as needs_brains_and_sleep13:04
*** needs_brains_and_sleep is now known as TheJulia13:23
opendevreviewBalazs Gibizer proposed openstack/nova master: [functional] Avoid leaking greenlet in UnifiedLimits tests  https://review.opendev.org/c/openstack/nova/+/89279113:55
auniyalHi dansmith, can you please have another look on https://review.opendev.org/c/openstack/nova/+/88145713:56
opendevreviewBalazs Gibizer proposed openstack/nova master: [functional]Fix remaining greenlet leaks  https://review.opendev.org/c/openstack/nova/+/89279314:17
gibisean-k-mooney: fixed the remaining functional leaks and set the env variable for the functionl env to enforce we don't introduce new ones.14:18
gibiso we can patch the leaks without switching to spawn or using cast as call14:23
sean-k-mooneywe can yes14:23
sean-k-mooneyi just fixed them becuase i was force to do it when swaping to spawn14:23
sean-k-mooneyso i did it in one pathc14:23
sean-k-mooneyi was not swaping to spwan to fix tehm i was fixing them so we could swap to spawn form spawn_n14:24
sean-k-mooney i am fine to proceed with your leak fix for the final test14:25
sean-k-mooneyand then rebase the spawn change on top14:25
sean-k-mooneyso it clearer what is required for that14:25
sean-k-mooneyyour fixes are less invasive then mine14:25
gibicool14:26
gibiin the long run I have no problem removing the spawn_n usage from nova14:26
gibias far as I remember there was no good reason to have it in the first place14:26
gibiit is less resource to use spawn_n but I don't think it is significant compared to spawn14:27
sean-k-mooneyso thats the thing14:28
sean-k-mooneytechnially since its just a greenlet it shoudl be14:28
sean-k-mooneybut i dont think in reality it has any really difference14:28
sean-k-mooneyand melwitt pointed out a thing i forgot14:29
sean-k-mooneywhen we were talking to the eventlet maintainers14:29
sean-k-mooneythey mentioned that there was some undefiend behavior with raw greenlets14:29
sean-k-mooneyso im hoping there will be no effective difference performance wise14:29
sean-k-mooneyand correctness wise im hopeing for less edgecases by this change14:29
gibiit is less resource to use spawn_n but I don't think it is significant compared to spawn15:23
gibisorry15:23
gibiyeah I agree with the overall direction15:24
dansmithauniyal: is it passing tests now?15:33
auniyalyes CI passing :) 15:34
dansmithauniyal: one very small (but weird) formatting nit15:47
dansmithauniyal: if you can fix that real quick I'll +215:47
opendevreviewDan Smith proposed openstack/nova master: VERYWIP: Support setting alias on libvirt disks  https://review.opendev.org/c/openstack/nova/+/89280015:48
opendevreviewDan Smith proposed openstack/nova master: VERYWIP: Set libvirt device alias for volumes  https://review.opendev.org/c/openstack/nova/+/89280115:48
dansmithoh I guess kashyap isn't here15:49
sean-k-mooneyany reason for the ua- prefix for the volume id15:56
dansmithauniyal: comments on the reproducer too15:56
dansmithsean-k-mooney: required by libvirt (as noted in the commit message)15:56
dansmithsean-k-mooney: interestingly if you omit that, it just ignores what you gave it and uses its own value with no warning :/15:56
sean-k-mooney.. of couse it does15:57
sean-k-mooneyim debating in my head the value fo doint that in the call site as you did vs prefixing it here https://review.opendev.org/c/openstack/nova/+/892800/1/nova/virt/libvirt/config.py#120515:57
dansmithwell, one reason is that libvirt gives everything auto-generated aliases if you don't specify one,15:58
dansmithand so we'd need to strip out the ua- from the parsing if we do it on the input, and then there's no way to tell from the higher layers if it's one we set or libvirt set15:59
dansmithdefault looks like:15:59
dansmith      <alias name='virtio-disk0'/>15:59
sean-k-mooneyok thats good to know.15:59
sean-k-mooneythen one suggestion would be add a is a uuid_to_alais funciton16:00
sean-k-mooneyso we can just use taht everywhere16:00
sean-k-mooneybut thats a minor nit16:00
sean-k-mooneyi guess we wont alwasy have a uuid16:01
dansmithright16:01
sean-k-mooneyfor pci devie form flavor alaises for example16:01
dansmithand root disk, if we wanted to set that16:01
dansmithanyway, I mostly just wanted to make sure we could plumb that through and it would stick in libvirt16:01
sean-k-mooneyim not sure if we dont because we dont supprot detaching that but it would help for swap on reize perhaps16:01
sean-k-mooneyya its good to get this basic proof of concept and find the "ua-" issue16:02
dansmithI don't know that we need it at all, I'm just saying if we set the alias for those devices, we won't have a uuid16:02
sean-k-mooneyrelated question16:03
sean-k-mooneydo we know if libvirt has an api to get/remove a device via the alais16:03
sean-k-mooneyit would be nice if it did but probaly does not16:03
dansmithidk, but it's not required I think16:03
sean-k-mooneyya its likely not but it would be nice just to detach a volume by doing libvir.detach_device(alias=<volume uuid>)16:04
dansmithhttps://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDetachDeviceAlias16:04
dansmiththat will be *very* nice, IMHO16:04
sean-k-mooney oh perfect16:04
sean-k-mooneyya so that is what i was hoping for i think16:05
sean-k-mooneyit also renforice the idea that this is how libvirt want use to name/specify things to detatch ectra16:05
dansmithup16:05
dansmithalso yup16:05
sean-k-mooneyso this was added in 3.9.0 which was released in late 2017 so when we first started lookign at teh lun issue it did not exist and when we looed at them last i dont know if we have a high enough min libvirt16:07
sean-k-mooneybut for master this looks like a nice cleanup over all16:07
sean-k-mooneythanks for starting a poc of this16:07
dansmithyeah, I'll get going on a spec just to lay some of this otu16:08
kashyapdansmith: Hi!  I hear you were looking for me :)16:09
dansmithI'll have to survey where all we look up devices to see where we need to convert them to use this16:09
dansmithkashyap: was just going to point you at this: https://review.opendev.org/q/topic:libvirt-dev-alias16:09
dansmithand sean-k-mooney and I were chatting about it briefly just now16:09
kashyapYeah, just found 'em16:10
kashyapdansmith: Just added a small comment here - https://review.opendev.org/c/openstack/nova/+/89280016:13
kashyapMy guess is you already know it16:14
dansmithkashyap: it's in the commit message16:14
dansmithwell, the ua- part is anyway16:15
kashyapOhh, I read the commit message, but I didn't see the "ua-" part explicitly called out.  Blind me16:17
kashyap(Oh, it's in the other commit message.  Just saw it)16:19
auniyaldansmith, ack, will update , thanks16:21
sean-k-mooneydansmith: looking out our downstream multi attach volume docs it says "Live migration of multi-attach volumes is not available" that cinder volume migration right16:22
sean-k-mooneyill check our upstrema docs but as far as i am aware we supprot live migration of vms with multi attach16:22
dansmithsean-k-mooney: no idea16:22
kashyapsean-k-mooney: dansmith: I just read your brief discussion on the upstream log.  (I agree that we should indeed retain the prefix or else ... the odd behavior Dan noted is not nice.)16:23
opendevreviewMerged openstack/nova master: introduce global greenpool  https://review.opendev.org/c/openstack/nova/+/87306116:28
opendevreviewDan Smith proposed openstack/nova-specs master: WIP: Add libvirt-dev-alias spec  https://review.opendev.org/c/openstack/nova-specs/+/89280616:33
dansmithsean-k-mooney: kashyap^ just brain dump level to get it started16:34
kashyapNice; the outline looks already quite good to me.  Cced myself, will do a concetrated read on Mon16:41
kashyapHeh, how plainly you write the alternative "We could maintain our own mapping in our database for those device types"16:41
kashyap(I mean, I like the matter-of-factly stating)16:41
opendevreviewAmit Uniyal proposed openstack/nova master: Add function to get all attachments in Cinder.API module  https://review.opendev.org/c/openstack/nova/+/88145716:46
opendevreviewAmit Uniyal proposed openstack/nova master: Reproducer for dangling bdms  https://review.opendev.org/c/openstack/nova/+/88994716:46
opendevreviewAmit Uniyal proposed openstack/nova master: Delete dangling bdms  https://review.opendev.org/c/openstack/nova/+/88228416:46
dansmithauniyal: looks like you committed a bunch of extra changes into that base patch?16:50
auniyalyes, that was a pep8 fix I have to do after rebase16:52
auniyalI added a note in commit msg for same16:52
dansmithauniyal: they're in files you haven't touched16:52
dansmiththey should not be in that patch16:53
auniyalack, will remove them, 16:53
opendevreviewAmit Uniyal proposed openstack/nova master: Add function to get all attachments in Cinder.API module  https://review.opendev.org/c/openstack/nova/+/88145717:03
opendevreviewAmit Uniyal proposed openstack/nova master: Reproducer for dangling bdms  https://review.opendev.org/c/openstack/nova/+/88994717:03
opendevreviewAmit Uniyal proposed openstack/nova master: Delete dangling bdms  https://review.opendev.org/c/openstack/nova/+/88228417:03
auniyalthanks dansmith17:11
sean-k-mooneydansmith: this wont shock you but since we are discussin cinder voluems in varios place i cam acroos an unsupproted edgecase a while back17:24
sean-k-mooneyif you have an image of format=iso you can both a vm form it and then install to a cinder data volume17:24
sean-k-mooneyhowever you cant do that if you try to do bfv17:24
sean-k-mooneyas we assume all bfv case are block devices not "cd-roms"17:25
sean-k-mooneyso we try to use the volume contianign the iso data  as a block device17:25
sean-k-mooneyso wehn the vm boot it cant actully load the bootload/root filesytem17:25
sean-k-mooneyi feel like that should be simple to fix if we ever had time to do it17:26
sean-k-mooneyas a result you cant actully use cidner volumes as "dirver disks" or install media today without somehow converting the iso to a bootable filesystem17:27
dansmithwhy would you bfv with the root disk as the iso?17:30
dansmithyou want bfv with the root disk as a volume and the iso as a secondary non-root device right? same for driver disks17:30
sean-k-mooneywell that also wotn work volume created form iso just dont work when attach to a vm17:31
sean-k-mooneybut my usecase was installing openshift on openstack using the installer iso17:31
sean-k-mooneymy home cloud is configured ot only do bfv17:32
sean-k-mooneyi worked aroudn it by temproy addign a flavor with some local storage and then did the install to a cienr volume and then booting another vm form that data volume after the fact17:32
dansmithyeah I think the iso-on-volume thing is known,17:33
dansmithIm just not sure that it has anything to do with bfv necessarily except that's the situation you need it for more I uess17:33
sean-k-mooneyit actully woudl be fairly simple to fix just add metadata on teh volume to say it not a block device but rather a cd/removal media17:33
sean-k-mooneyoh its not its just  if you dont do boot form volume17:34
sean-k-mooneythe workflow of boot form iso and then install do data volume works17:34
sean-k-mooneythe gap/bug is just we cant take a cinder volume and attach it as a cd to the vm17:34
sean-k-mooneythat is totally fixable with metadta if we wanted too17:35
dansmithhow do you do boot from iso if it's not the image and not in a volume/17:35
sean-k-mooneythe iso data woudl be in the volume17:36
sean-k-mooneywe just need metadata do say use device=cdrom17:37
dansmithI'm talking about currently, you said you can currently boot from iso17:37
sean-k-mooneyactully you could probly do that today by setting type=cdrom in the bdms17:38
sean-k-mooneyoh right i booth form an image17:38
sean-k-mooneybut we have code to handel if they image type in glance is iso17:38
sean-k-mooneyand we attach it as a cdrom in that case17:38
sean-k-mooneyactully so ya lookign at our docs17:40
sean-k-mooneyif you manually specifed the bdm on the api request it would work17:40
sean-k-mooneythis is just an issue if you use --volume i think17:40
sean-k-mooneywe docuemnt  device_type may be disk, cdrom, floppy, lun17:41
dansmith...right17:41
sean-k-mooneyi have not seen that menetion in other docs so i either forgat the that or the doc i was followign didnt mention that17:42
sean-k-mooneydansmith: so i think my main issue was a i was trying to do this via horizon which cant do ti and b i forgot about that field in the mappigns thanks for talkign this true18:10
dansmithgui strikes again :)18:10
sean-k-mooneystill proably a docs bug but ill try doing it proplry and might submit a docs patch if it work18:10
sean-k-mooneyi feel like addign device_type to the image or voluem would still be nicer long term but that a seperate topic18:11
*** tbachman_ is now known as tbachman18:31
opendevreviewMerged openstack/nova master: [functional] Avoid leaking greenlet in UnifiedLimits tests  https://review.opendev.org/c/openstack/nova/+/89279118:44
atmarkhello, I'm getting this error failing to delete a compute node using `openstack compute service delete X` 19:18
atmarkFailed to delete compute service with ID 'X': HttpException: 500: Server Error for url:19:18
atmarkRunning stable/victoria19:18
sean-k-mooneythat not really enough info for use to comment19:18
sean-k-mooneyyou will need to look at the nova-api log to see what the actula error is19:18
atmarkk, one sec19:19
atmarkhitting same issue https://bugs.launchpad.net/nova/+bug/196413719:19
atmarkhttps://paste.openstack.org/show/bIU0SLPjbnkWSFzFHaFu/19:22
sean-k-mooneyok so its sayign the placement resouce provider was delete19:24
sean-k-mooneydid you perhaps manually delete it at some point19:24
sean-k-mooneyteh compute serivce delete also cleans it up19:24
atmarkyes, I manually deleted it from db cuz it won't let me delete via API19:25
atmarkstill seeing the compute when running `openstack compute service list` 19:25
atmarkthis is a dev env 19:26
sean-k-mooneyok so you  porblay could not delete it form the api because it had allcoation assocated with it19:26
atmarkhow can I totally clean this up?19:26
sean-k-mooneyasuming you have stoped nova-compute on the host in your dev env19:26
atmarkyep it's stopped19:27
sean-k-mooneythen you will likely need to delete the compute service in the cell 1 db 19:27
sean-k-mooneyis this devstack or somethign else19:27
atmarkkolla-ansible19:27
sean-k-mooneyok i need to check the db name but it will likely be either nova_cell1 or just nova19:27
atmarkthere's no nova19:28
atmarknova_cell1 and nova_cell019:28
sean-k-mooneyya so in nova_cell1 there is a comptue service table and a compute nodes table and you will need to mark the relevent row as deleted in both19:28
atmarkcompute_nodes ?19:29
atmarkis that the table name ?19:29
atmarkthat's the only table name that starts with compute_* 19:30
sean-k-mooneyhum i guess that is a recent change my home kolla ansibel has nova isntead of nova_cell119:31
sean-k-mooneyone sec while i check19:31
sean-k-mooneyso you will have a table called services19:31
atmarkyeah, my prod env has three nova tables, nova, nova_cell0 and nova_cell1 19:32
atmarkdev only has two19:32
atmarkthis isn't any issue right ?19:33
sean-k-mooneyyou should really have nova_api nova_cell1 and nova_cell019:33
atmarki have nova_api all envs19:33
atmarkin all envs*19:33
sean-k-mooneyah ok19:33
sean-k-mooneyya so the nova cell1 db used to be called nova19:33
atmarkbut no 'nova' db in dev 19:33
sean-k-mooneywe recommend however that you call it nova_cell119:33
sean-k-mooneythat fine they proably just change the defautl name to follow our recomendations19:34
sean-k-mooneyselect count(*) from nova_cell1.services;19:34
sean-k-mooneyif you do that you will have multiple rows19:34
atmarkhttps://paste.openstack.org/show/b5Sy9Ww7HUGcRG7zWKhc/19:35
sean-k-mooneyso if you do "select * from nova.services s where s.binary='nova-compute';" you will see the compute node records19:36
sean-k-mooneyand you will need to clean up the one for the host you removed19:36
atmarkgot it19:36
sean-k-mooneyyou shoudl also do the same in the compute_nodes table but it the service table that is used when you do a openstack compute service list19:36
atmarknova_cell1.services and nova_cell0.services right ?19:37
sean-k-mooneythe compute_nodes table is use by openstack hypervisor list19:37
sean-k-mooneyno you only need to remove the compute record form cell 119:37
sean-k-mooneydont remove them all19:37
sean-k-mooneytechnially you actully want ot set deleted=id for that specific row19:38
atmarkok nova_cell0 table are controllers services19:39
atmarkmake sense19:39
sean-k-mooneyyes19:39
sean-k-mooneycell0 is special and never has computes19:39
sean-k-mooneycell1 is the first "real" cell in that it the first cell that can have computes19:40
sean-k-mooneythe name does not actully matter but cell0 or rhat the cell with the all 0 uuid is special in nova19:40
opendevreviewJay Faulkner proposed openstack/nova master: [ironic] Optionally set lessee on deployment  https://review.opendev.org/c/openstack/nova/+/88829020:08
opendevreviewMerged openstack/nova master: [functional]Fix remaining greenlet leaks  https://review.opendev.org/c/openstack/nova/+/89279320:31
opendevreviewJay Faulkner proposed openstack/nova master: [ironic] Optionally set lessee on deployment  https://review.opendev.org/c/openstack/nova/+/88829020:48
JayFhttps://review.opendev.org/c/openstack/nova/+/888290 is tested in devstack, working, simple, and limited to Ironic's virt driver. Your reviews are appreciated :)20:50
atmarksean-k-mooney: what should be id for deleted in compute_nodes table ? 20:57
atmarkthe id between services and compute_nodes table don't match https://paste.openstack.org/show/b2yJiggYenod3SoioAyo/20:57
atmarki'm trying to get rid of compute05.dev20:58
atmarksean-k-mooney: figured it out. I matched the value in id and deleted in compute_nodes table21:38
atmarkThanks for your help21:38
opendevreviewsean mooney proposed openstack/nova master: remove untils.spawn_n  https://review.opendev.org/c/openstack/nova/+/89272223:57

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!