Friday, 2023-08-11

*** dmellado819 is now known as dmellado8106:55
auniyalHey gibi, can you please have a look on https://review.opendev.org/c/openstack/nova/+/882920 mostly good just a backpot for yoga08:19
tobias-urdintwo small doc/log fixes when somebody has some seconds to review https://review.opendev.org/c/openstack/nova/+/880819 https://review.opendev.org/c/openstack/nova/+/87384609:03
opendevreviewDanylo Vodopianov proposed openstack/nova master: Napatech SmartNIC support  https://review.opendev.org/c/openstack/nova/+/85957709:22
opendevreviewDanylo Vodopianov proposed openstack/os-vif master: Openvswitch driver was extended  https://review.opendev.org/c/openstack/os-vif/+/85957409:24
tobias-urdinanother one https://review.opendev.org/c/openstack/nova/+/87408309:24
auniyalthanks gibi 10:20
opendevreviewDanylo Vodopianov proposed openstack/os-vif master: Openvswitch driver was extended  https://review.opendev.org/c/openstack/os-vif/+/85957411:33
opendevreviewMerged openstack/nova stable/yoga: Have host look for CPU controller of cgroupsv2 location.  https://review.opendev.org/c/openstack/nova/+/88292011:53
opendevreviewViktor Křivák proposed openstack/nova-specs master: Add availability zone-aware affinity filter to the scheduler  https://review.opendev.org/c/openstack/nova-specs/+/89077912:54
opendevreviewViktor Křivák proposed openstack/nova-specs master: Add availability zone-aware affinity filter to the scheduler  https://review.opendev.org/c/openstack/nova-specs/+/89077913:15
opendevreviewDan Smith proposed openstack/nova master: WIP: Support glance's new location API  https://review.opendev.org/c/openstack/nova/+/89103614:56
dansmithabhishekk: ^ untested, but that's part of your patch but with some new-or-old logic in it and less change overall as I think we can just ignore the return from that operation14:56
dansmithwe'll see how that goes, not sure I'll have a change to test locally today but we can iterate from that14:57
abhishekklooking14:57
abhishekkI didn't understood raise exc part at line #57115:00
dansmithabhishekk: oh that was supposed to end up under the badrequest thing15:03
dansmithah right but I need to test15:03
dansmithso the goal is to try each of those interfaces, but if neither work, raise the error we got from the last one15:03
dansmithso we might be able to just raise the badrequest whenever we get it, but I need to test glance's behavior with each of the new stuff missing and the old stuff disabled15:04
abhishekkack, so you need another plain Exception block as well15:04
abhishekk?15:04
dansmithso that _reraise was supposed to be a pass and replace the raise below15:04
dansmithno, I think we want to try both and raise the last one15:05
dansmithand we need to catch whatever expected exceptions will come from trying the new interface if it's missing15:05
abhishekkack, because what I understood is lien #571 might express as raise None15:05
dansmithshould just be notfound right?15:05
dansmithoh, two notfounds could raise none, yeah you're right15:06
dansmithanyway, like i said, untested, just kinda what I'm thinking :)15:06
abhishekk:D15:06
abhishekkI am not sure client will be updated today to raise Notfound if version is less than 2.1715:07
dansmithif glance is not updated, the URL should generate a notfound, no?15:07
dansmithyou think glanceclient will translate that into something else?15:08
abhishekkNO, as you added depends on in commit message, it will call add_image_location, right?15:08
dansmithright, but we need to handle the case where glance is not upgraded15:09
abhishekkyes,15:09
dansmithso actually, let me change this so it's clearer15:09
abhishekkthat needs to be there in client patch, but since your patch has glance and client dependency it will call new API i guess15:09
opendevreviewDan Smith proposed openstack/nova master: WIP: Support glance's new location API  https://review.opendev.org/c/openstack/nova/+/89103615:10
opendevreviewDan Smith proposed openstack/nova master: DNM: Test glance new location api  https://review.opendev.org/c/openstack/nova/+/89120715:10
dansmiththis stack needs to work ^15:11
dansmither, well, actually,15:11
dansmiththe glanceclient depends-on should go in the first patch I guess.15:11
dansmithwe can require glanceclient version, but we can't require glance version15:11
abhishekkright15:11
opendevreviewDan Smith proposed openstack/nova master: WIP: Support glance's new location API  https://review.opendev.org/c/openstack/nova/+/89103615:13
opendevreviewDan Smith proposed openstack/nova master: DNM: Test glance new location api  https://review.opendev.org/c/openstack/nova/+/89120715:13
dansmithfirst depends on glanceclient, second depends on glance15:14
abhishekkThis looks good now15:17
abhishekkthank you for your time !!15:17
dansmithack, I'll try to poke more at it on monday15:17
abhishekkCool, will be around as well15:17
*** ykarel is now known as ykarel|away15:59
abhishekkdansmith, nova-ceph-multistore passed on both the patches17:35
dansmithyeah I saw17:36
dansmithdid you confirm in the glance log that it's hitting the new one?17:37
abhishekklooking for it now,17:40
abhishekkhttps://zuul.opendev.org/t/openstack/build/9c045d22dee34b08bb8767a1f972db09/log/job-output.txt#22303 this is the test right?17:40
dansmithI see location_import task running so I assume that means it is17:42
dansmithabhishekk: any server snapshot task should trigger it17:42
abhishekkyeah17:42
abhishekkme too17:42
abhishekklocation_import-CalculateHash17:44
abhishekkat least some positive signs :D17:45
dansmithyup, I definitely expected more fails for sure17:47
abhishekkon that note, I am stepping in the weekend mood 17:52
dansmithenjoy ;)17:53
abhishekkSee you monday, happy weekend o/~17:53
opendevreviewGhanshyam proposed openstack/nova master: DNM: testing py3.11 job  https://review.opendev.org/c/openstack/nova/+/89122819:42
opendevreviewGhanshyam proposed openstack/nova stable/2023.1: DNM: testing py3.11 job not running on 2023.1 template  https://review.opendev.org/c/openstack/nova/+/89111319:43
opendevreviewGhanshyam proposed openstack/nova master: DNM: testing some zuul template config  https://review.opendev.org/c/openstack/nova/+/89123520:43
opendevreviewGhanshyam proposed openstack/nova stable/2023.1: DNM: testing some zuul template config  https://review.opendev.org/c/openstack/nova/+/89111420:43
opendevreviewmelanie witt proposed openstack/nova master: Use futurist.ThreadPoolExecutor in scatter_gather_cells  https://review.opendev.org/c/openstack/nova/+/65017220:50
opendevreviewGhanshyam proposed openstack/nova master: DNM: testing some zuul template config  https://review.opendev.org/c/openstack/nova/+/89123521:14
opendevreviewGhanshyam proposed openstack/nova stable/2023.1: DNM: testing some zuul template config  https://review.opendev.org/c/openstack/nova/+/89111421:14
opendevreviewTakashi Natsume proposed openstack/nova master: Update contributor guide for 2023.2 Bobcat  https://review.opendev.org/c/openstack/nova/+/87644721:34

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!