Wednesday, 2023-07-26

opendevreviewMerged openstack/nova master: Add dest_compute_id to Migration object  https://review.opendev.org/c/openstack/nova/+/87968202:04
*** ministry is now known as __ministry04:40
carlosso/ Uggla I believe we finally have some testable code in the Manila side for the VirtioFS implementation10:41
carlossthe Manila changes:10:42
carlosshttps://review.opendev.org/c/openstack/manila/+/887115 - Resource Locks: Support for share deletion lock10:42
carlosshttps://review.opendev.org/c/openstack/manila/+/887725 - Allow restricting access rules fields and deletion10:42
carlossOSC changes in case you want to interact with manila through the CLI:10:43
carlosshttps://review.opendev.org/c/openstack/python-manilaclient/+/888006 - Support for resource locks10:43
carlosshttps://review.opendev.org/c/openstack/python-manilaclient/+/888355 - Allow restricting access rules10:43
carlossand finally, the SDK part of the implementation:10:43
carlosshttps://review.opendev.org/c/openstack/openstacksdk/+/889519 - Resource locks and access rules restrictions10:43
carlossplease let me know if I can help with something :)10:44
carlossyou'll notice some of the changes are still WIP, but that is mostly for some missing coverage in unit/functional tests10:44
opendevreviewsean mooney proposed openstack/nova master: use disk caching to hide slow cinder performance  https://review.opendev.org/c/openstack/nova/+/88938310:57
sean-k-mooneycarloss: cool the nova code shoudl use the sdk not the manilaclient11:00
sean-k-mooneyso we actully only depend on the maniala change and the sdk changes11:00
sean-k-mooneyits cutting it kind of tight to get this all landed this cycle11:01
carloss> carloss: cool the nova code shoudl use the sdk not the manilaclient11:03
carlossyep... the sdk change should be in a good shape as well... I did some testing on it yesterday and it behave fine when I did stuff with it manually11:03
carloss> its cutting it kind of tight to get this all landed this cycle11:03
carlosssean-k-mooney: ack - we'll do our best to have it landing asap in manila11:03
sean-k-mooneyat least with depend on we can test some of this before its landed11:04
carloss++11:04
carlossI think both manila side changes are ready for some feedback as well, so if you want to share your thoughts, please do so11:04
sean-k-mooneyhave you considered addding tempest coverage?11:04
sean-k-mooneyor testing it in the manila ci beyond unit/funcitonal tests11:05
carlossyeah, we have some changes up for functional testing on manila-tempest-plugin as well:11:06
carlosshttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/888618 - Test resource locks11:06
carlosshttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/889331 - Add access rules restriction tests11:06
carlossresource locks is failing because of a known issue in our CI11:06
carlossand access rules restrictions is on me... I need to fix some issues with testing, but I also tested it locally and it worked11:07
carlossI should figure out such issues with access rules restriction testing over the course of this week11:07
carlosss/locally/in a devstack env11:08
carlosssean-k-mooney: forgot to share those changes in advance with the other ones I sent, sorry 😅11:09
sean-k-mooneyno worries im sure they will be useful for Uggla as a refernce for how to use the apis11:37
UgglaHey carloss, thanks for the information. As sean-k-mooney said I'm currently moving from the manilaclient to sdk. As soon as ready (soon). I will try to implement and test the new "lock and restricted access rules" features.12:36
Ugglacarloss, also thanks for the hard work, I can't stand to integrate that.12:38
opendevreviewStephen Finucane proposed openstack/nova master: Remove unused mocks  https://review.opendev.org/c/openstack/nova/+/86778912:41
opendevreviewStephen Finucane proposed openstack/nova master: Use SDK for add/remove instance info from node  https://review.opendev.org/c/openstack/nova/+/65969112:41
opendevreviewStephen Finucane proposed openstack/nova master: Use SDK for getting network metadata from node  https://review.opendev.org/c/openstack/nova/+/67021312:41
opendevreviewStephen Finucane proposed openstack/nova master: Use SDK for volume_target.*  https://review.opendev.org/c/openstack/nova/+/86779012:41
opendevreviewStephen Finucane proposed openstack/nova master: Use SDK for node.set_provision_state  https://review.opendev.org/c/openstack/nova/+/86779112:41
opendevreviewStephen Finucane proposed openstack/nova master: Use SDK for node.set_power_state  https://review.opendev.org/c/openstack/nova/+/86779212:41
opendevreviewStephen Finucane proposed openstack/nova master: Use SDK for node.vif*  https://review.opendev.org/c/openstack/nova/+/86779312:41
opendevreviewStephen Finucane proposed openstack/nova master: Use SDK for remaining network operations  https://review.opendev.org/c/openstack/nova/+/86779412:41
opendevreviewStephen Finucane proposed openstack/nova master: Use SDK for remaining ironic driver calls  https://review.opendev.org/c/openstack/nova/+/86779512:41
opendevreviewStephen Finucane proposed openstack/nova master: Use SDK for deprecated baremetal proxy API  https://review.opendev.org/c/openstack/nova/+/86779612:41
opendevreviewStephen Finucane proposed openstack/nova master: Remove Ironic client wrapper  https://review.opendev.org/c/openstack/nova/+/86779712:41
opendevreviewStephen Finucane proposed openstack/nova master: Remove unnecessary aliasing  https://review.opendev.org/c/openstack/nova/+/86779812:42
opendevreviewStephen Finucane proposed openstack/nova master: Use real SDK objects in tests  https://review.opendev.org/c/openstack/nova/+/86779912:42
sean-k-mooneystephenfin: just one or two ptaches ya12:42
sean-k-mooneyis that all of the convertion to the sdk12:42
stephenfinonly two changed, yes 😇 (the rest are just rebases)12:43
stephenfinyup, full conversion of ironic calls to SDK12:43
sean-k-mooneyoh just ironic i tough ti say some neutron ones12:43
stephenfinnah, the network operations referred to are still ironic calls12:44
stephenfinneutron is a much bigger fish12:44
sean-k-mooneyok and same for volume it just the ironic volume bits12:44
sean-k-mooneystill woul be nice to get that done this cycle12:45
carlossUggla: yw - happy to help... gouthamr and I did our best to get this to a testable state, so have fun testing! :D12:45
stephenfinyup, ironic volumes12:45
Ugglacarloss, \o/ 12:46
opendevreviewMerged openstack/nova master: db: Store unmasked password  https://review.opendev.org/c/openstack/nova/+/88066914:40
*** d34dh0r5- is now known as d34dh0r5315:01
opendevreviewVladislav Belogrudov proposed openstack/nova master: Nova instance snapshot should wait for volumes  https://review.opendev.org/c/openstack/nova/+/84863815:11
opendevreviewStephen Finucane proposed openstack/nova master: Use real SDK objects in tests  https://review.opendev.org/c/openstack/nova/+/86779915:49
sean-k-mooneytest_get_console_output_server_id_in_shutoff_status is failling alot i nthe nova_lvm job16:17
dansmithbauzas: are you around?16:32
opendevreviewDan Smith proposed openstack/nova master: Add upgrade check for compute-object-ids linkage  https://review.opendev.org/c/openstack/nova/+/88974017:24
dansmithsean-k-mooney: ^17:24
dansmithI wonder if you could proxy bauzas' +2 on this patch, since he's already +2d the followup which was his reason for not +2ing the first place: https://review.opendev.org/c/openstack/nova/+/884752/217:25
dansmiththat way I can continue my slow grind to recheck these mofos through the gate :/17:25
sean-k-mooney[m]im kind of done for today so ill review the final patch tomorrow but maybe melwitt can take a look17:27
dansmithack, I won't need that +2 for probably several more weeks, but I just want to be able to land it without asking in case I get super lucky ;)17:28
dansmithto be clear, the proxy vote is on a patch you already +2d, not the new one17:30
-opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline briefly for a minor upgrade at 21:00 utc, approximately an hour from now20:03
-opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline briefly for a minor upgrade, but should return shortly21:02

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!