| opendevreview | Maxim Monin proposed openstack/nova master: Server Rescue leads to Server ERROR state if original image is deleted https://review.opendev.org/c/openstack/nova/+/872385 | 06:22 |
|---|---|---|
| opendevreview | Amit Uniyal proposed openstack/nova master: Added context manager for instance lock https://review.opendev.org/c/openstack/nova/+/873648 | 10:50 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | 10:50 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | 12:00 |
| opendevreview | Takashi Natsume proposed openstack/nova-specs master: Create specs directory for 2024.1 Caracal https://review.opendev.org/c/openstack/nova-specs/+/889177 | 13:32 |
| opendevreview | Takashi Natsume proposed openstack/nova master: Update contributor guide for 2023.2 Bobcat https://review.opendev.org/c/openstack/nova/+/876447 | 13:36 |
| dansmith | bauzas: can you fix these nits real quick and I'll +2+A? https://review.opendev.org/c/openstack/nova/+/886232 | 13:41 |
| dansmith | or I can do it | 13:41 |
| bauzas | dansmith: sure, lemme look | 13:41 |
| bauzas | dansmith: ack, thanks for reviewing, will do | 13:42 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Add a new NumInstancesWeigher https://review.opendev.org/c/openstack/nova/+/886232 | 13:51 |
| auniyal | dansmith and all continuing to lock discussion - what type of action can be prevented on instance if instance is locked. | 13:52 |
| dansmith | auniyal: anything with this, AFAIK: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2701 | 13:54 |
| auniyal | th deorator is with stop and reboot as well, but I was able to reboot and stop locked instance | 14:00 |
| dansmith | as admin or user? | 14:00 |
| auniyal | yes admin | 14:00 |
| *** d34dh0r5- is now known as d34dh0r53 | 14:00 | |
| dansmith | auniyal: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L240 | 14:00 |
| dansmith | admins are not bothered by the lock | 14:00 |
| auniyal | ack, | 14:01 |
| auniyal | nova-manage can be run by user right | 14:01 |
| dansmith | no | 14:02 |
| dansmith | nova-manage requires physical access to the backend infrastructure | 14:02 |
| dansmith | it's almost entirely direct-to-db, bypassing all of this sort of stuff in almost all cases | 14:02 |
| dansmith | https://docs.openstack.org/nova/rocky/cli/nova-manage.html | 14:03 |
| dansmith | "nova-manage controls cloud computing instances by managing various admin-only aspects of Nova." | 14:03 |
| auniyal | thanks dansmith, | 14:12 |
| auniyal | dansmith, I am facing this issue right now - https://review.opendev.org/c/openstack/nova/+/873648/comment/af765efc_a7161f39/ | 14:25 |
| auniyal | so this is when the instance is not locked already. | 14:25 |
| auniyal | however when I tested it by manually locking before running nova-manage cmd, db query went fine and there were no err msg. | 14:25 |
| auniyal | even though in both cases while running instance_action.finish, instance was locked, query context and query values were same as required. | 14:25 |
| dansmith | sorry, I'm not sure what context manager you mean you've removed, but action.finish failing means action_start never actually hit the DB, and none of that should have anything to do with lock as noted above | 14:29 |
| dansmith | I've got to jump on a meeting now | 14:30 |
| auniyal | okay, it did not thorugh any error, will check for if it action_start, thanks | 14:31 |
| opendevreview | Merged openstack/nova master: Add a new policy for cold-migrate with host https://review.opendev.org/c/openstack/nova/+/881562 | 16:52 |
| dansmith | holy crap, something merged | 16:56 |
| gmann | heh | 17:13 |
| sean-k-mooney | 17:46 | |
| melwitt | it's a christmas miracle! (that something merged) | 18:26 |
| *** melwitt is now known as jgwentworth | 18:26 | |
| sean-k-mooney | hehe | 18:27 |
| dansmith | jgwentworth: jokes on you, that was so delayed it's *last* christmas' miracle | 18:27 |
| jgwentworth | :) | 18:28 |
| opendevreview | Felipe Reyes proposed openstack/nova master: Add RISCV64 support. https://review.opendev.org/c/openstack/nova/+/889137 | 19:34 |
| *** haleyb is now known as haleyb_out | 21:54 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!