Monday, 2023-07-17

opendevreviewefineshi proposed openstack/nova master: Not destroy the vm as it migrate back before evacuate clean  https://review.opendev.org/c/openstack/nova/+/88756401:26
*** elodilles_pto is now known as elodilles06:16
opendevreviewsuzhengwei proposed openstack/nova-specs master: spec: evacuate api return migration  https://review.opendev.org/c/openstack/nova-specs/+/88810106:27
opendevreviewsean mooney proposed openstack/nova master: Remove deprecated AZ filter.  https://review.opendev.org/c/openstack/nova/+/88677911:20
opendevreviewsean mooney proposed openstack/nova master: Remove deprecated AZ filter.  https://review.opendev.org/c/openstack/nova/+/88677911:22
sean-k-mooneystephenfin: thanks for the review nits adressed and rebased :)11:22
sean-k-mooneydansmith: gmann  if ye are devstack cores can ye look at https://review.opendev.org/c/openstack/devstack/+/886972 to unblock ^11:23
opendevreviewAmit Uniyal proposed openstack/nova master: Added context manager for instance lock  https://review.opendev.org/c/openstack/nova/+/87364811:45
opendevreviewAmit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host  https://review.opendev.org/c/openstack/nova/+/87744611:45
auniyalHi sean-k-mooney11:50
auniyalregarding AZ filter removal from devstack11:50
auniyalafter devstack deployment tempest tests runs right ? so we need to remove AZ test from tempest as well?11:50
sean-k-mooneyno11:50
auniyaloh okay, thanks11:50
sean-k-mooneyi replied to your comment11:50
sean-k-mooneywe are not removing the az support11:50
sean-k-mooneywe have 2 implematnions11:50
sean-k-mooneywe are just remvoing the older one11:51
sean-k-mooneythe same functionality exits11:51
sean-k-mooneyso there is no visable change form tempest11:51
auniyalack11:51
*** iurygregory_ is now known as iurygregory12:08
opendevreviewElod Illes proposed openstack/nova stable/victoria: [stable-only] Cap virtualenv/setuptools  https://review.opendev.org/c/openstack/nova/+/88868112:14
opendevreviewElod Illes proposed openstack/nova stable/victoria: [stable-only] Cap virtualenv/setuptools  https://review.opendev.org/c/openstack/nova/+/88868113:18
opendevreviewMerged openstack/nova master: db: Avoid relying on autobegin  https://review.opendev.org/c/openstack/nova/+/88066814:37
*** iurygregory_ is now known as iurygregory14:59
opendevreviewKashyap Chamarthy proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Bobcat"  https://review.opendev.org/c/openstack/nova/+/88725515:06
kashyapgibi: Hey, later when you get a min, with the latest revision of the above, this UT is still failing for me: test_compare_cpu_aarch64_skip_comparison15:16
kashyap(Since you have the env locally, I'd appreciate a second look.  Don't worry if you're short on time; I'll take a deeper look tomm)15:16
gibikashyap: please ping me tomorrow15:43
kashyapSure, thx! 15:43
melwittsean-k-mooney: I dunno if you remember this but awhile back someone reported a bug downstream where they got a "QueuePool limit of size 5 overflow 50 reached, connection timed out, timeout 30.00" database error after calling the os-extra_specs API repeatedly over time. I think I figured out what was causing it and proposed a patch here https://review.opendev.org/c/openstack/nova/+/888513 I didn't include test coverage bc I'm not sure15:59
melwitt how to test that ... feel free to suggest if you know a way15:59
sean-k-mooneyi vaguly recall that but not the details16:03
gmannsean-k-mooney: just saw your message and devstack change is merged already. ping me anything else pending on devstack side16:16
sean-k-mooneygmann: cool i think if that is merge to stop addign it by default we can proceed on the nova side16:34
dansmithmelwitt: I've been seeing an increase in frequency of that mkfs timeout thing lately...16:48
melwittdansmith: me too. I feel like I see it hit most changes. do you always see it in test_stamp_pattern or any other test? I tried a tempest change to add "no discard" to the command and it didn't help16:49
dansmithmelwitt: yep that's the one I just saw fail, not sure if the others are the same or not16:50
dansmiththis one I did see IO errors in the console log though,16:50
dansmithso perhaps it's something more going on than just the discard thing16:50
dansmith[  289.096098] Buffer I/O error on dev vdb, logical block 6, lost async page write16:51
melwittdansmith: this was the change I tried https://review.opendev.org/c/openstack/tempest/+/886991 I have never seen it hit any other test. and I don't see what is unique about this test to be the only one exhibiting this?16:51
dansmithack16:51
melwittthere's definitely something else going on than discard imho but I hadn't noticed the IO errors16:52
melwittthe test isn't trying to do anything weird, I'm stumped as to why it's only test_stamp_pattern16:53
dansmithyeah16:54
dansmithJul 17 16:01:08 np0034696204 kernel: iSCSI Login timeout on Network Portal 10.209.97.252:326016:55
dansmithseveral iscsi errors there in the log16:57
dansmithdo you have another example log to look at? this one was nova-multi-cell and it was on the compute worker node in the syslog around the time of the failure16:57
gmannsean-k-mooney: lgtm, one question regarding copy/mentioning the upgrade notes to next SLURP release https://review.opendev.org/c/openstack/nova/+/886779/4/releasenotes/notes/az-filter-removal-587f7337040b6216.yaml#216:59
gmannI am not sure we have figured that out in TC but in case we need to tag/make a note somehere to remember it for C release17:00
gmannsean-k-mooney: I am +1 and can convert to +2 as ^^ should not be blocker for it. just bringing it here and in TC also to finalize the guidelines. added this in next TC meeting agenda 17:13
melwittdansmith: maybe this one https://zuul.opendev.org/t/openstack/build/f8734471732246aaab8a8c41e3761af3/logs17:14
melwittand I had opened this bug about it and put an opensearch query in the first comment https://bugs.launchpad.net/tempest/+bug/202485917:15
dansmithmelwitt: yeah that one has the login timeout message in the controller's syslog17:20
gmannsean-k-mooney: can you check this again as you were +2 already. I asked ykarel to change the exception type to raise (after checking meeting discussion I am ok now to raise exception instead of warning) https://review.opendev.org/c/openstack/nova/+/86841917:20
dansmithso that could be the common link17:20
sean-k-mooneygmann: it depend if we raise and excption we woudl ant it to stop the agent form startign right17:31
sean-k-mooneyi think that is ok for invalid config i.e. enabling this if the min version is not met17:31
opendevreviewAmit Uniyal proposed openstack/nova master: Delete dangling bdms  https://review.opendev.org/c/openstack/nova/+/88228417:38
auniyalhi elodilles17:48
auniyalhere https://review.opendev.org/c/openstack/nova/+/882914 17:48
auniyalyou meant until "enable validations in nova-lvm"  get merged in zed right ?17:48
auniyalthis: https://review.opendev.org/q/Ia198f712e2ad277743aed08e27e480208f463ac717:48
auniyaldansmith , melwitt can these get merged https://review.opendev.org/q/Ia198f712e2ad277743aed08e27e480208f463ac7 ? 17:51
melwittauniyal: yeah I can review17:54
opendevreviewMerged openstack/nova stable/wallaby: Remove deleted projects from flavor access list  https://review.opendev.org/c/openstack/nova/+/88833319:35
elodillesauniyal: yes, those are the gate fixing patches19:37
auniyalthanks melwitt, ack elodilles 19:50
auniyalstable/2023.1 will be merged in some time, can you please merge this as well - https://review.opendev.org/c/openstack/nova/+/88823019:50
auniyalmelwitt, regarding your comment https://review.opendev.org/c/openstack/nova/+/873648/comment/e8d05cbb_aa954e91/ in "Added context manager for instance lock" as per lyarwood Note we need to create new context to unlock the instance.19:57
melwittauniyal: yeah, we'll do that one next19:59
melwittauniyal: oh, hm. sorry I didn't notice that comment, on the surface, I'm not sure why we would need or want a new request-id for the unlock19:59
melwittso let me think on that for a bit20:00
auniyalack, thanks, will fix rest meanwhile20:00
melwitt++20:00
auniyalif you have time today, can you have another look on resize one as well; I think its somewhat better now; I have documented alot in it for now intentionally will remove them once good from review side.20:02
melwittok, I'll try to get to that today20:02
melwittauniyal: I just added another comment on the review. thanks for pointing out about the unique request-id's20:46
dansmithauniyal: can you please respond to all comments and/or mark them as resolved when they're no longer relevant? You never responded to my question about needing to target in one place and not another, pushed up another rev, and asked me to re-review..21:12
dansmithit's hard to know whether you intended to change what I commented about because the old comment had no reply and is still unresolved, on a nonsense line in the new patcheset now21:12
opendevreviewmelanie witt proposed openstack/nova stable/train: Enforce quota usage from placement when unshelving  https://review.opendev.org/c/openstack/nova/+/88850922:20
opendevreviewMerged openstack/nova master: Add config option to configure TB cache size  https://review.opendev.org/c/openstack/nova/+/86841923:44

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!