| *** Continuity_ is now known as Continuity | 08:58 | |
| opendevreview | Nobuhiro MIKI proposed openstack/nova master: libvirt: Add 'COMPUTE_ADDRESS_SPACE_*' traits support https://review.opendev.org/c/openstack/nova/+/873221 | 09:49 |
|---|---|---|
| opendevreview | Kashyap Chamarthy proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Bobcat" https://review.opendev.org/c/openstack/nova/+/887255 | 13:07 |
| kashyap | sean-k-mooney: --^ Hope that looks better; I'd also like a closer look at the MIN_LIBVIRT_AARCH64_CPU_COMPARE const removal code (Cc: gibi) | 13:11 |
| dansmith | bauzas: I'd really like to get some review on this while I have time to address any concerns and so there's some soak time before release: https://review.opendev.org/q/topic:bp/compute-object-ids+status:open | 14:42 |
| dansmith | if I should just stop asking for this release let me know :) | 14:42 |
| bauzas | dansmith: no no, sorry, last week I was focusing on spec | 14:51 |
| bauzas | this week, I'll start to look on the series :) | 14:51 |
| dansmith | thanks | 14:52 |
| auniyal71 | hey dansmith, can you please have another look on this - Refactoring CinderFixture - https://review.opendev.org/c/openstack/nova/+/885756/6 | 15:30 |
| dansmith | auniyal71: yep, I will.. I haven't yet processed my review email from being on PTO :) | 15:31 |
| auniyal71 | ack, yes, was waiting for you :) thanks | 15:31 |
| opendevreview | Dan Smith proposed openstack/nova master: Refactor CinderFixture https://review.opendev.org/c/openstack/nova/+/885756 | 16:24 |
| dansmith | auniyal71: fixed ^ | 16:24 |
| auniyal71 | ack, thanks, how did you knew it failed at _test_attach_volume_error | 16:49 |
| auniyal71 | dansmith, did it show in error | 16:50 |
| auniyal71 | with tox | 16:51 |
| dansmith | auniyal71: you saw what I saw, which is what was shown in CI | 16:51 |
| auniyal71 | yes | 16:52 |
| dansmith | the problem was not *your* autospec=False thing, it was that case of the test was attempting to re-mock something you already had mocked and *that* was the failing autospec | 16:52 |
| dansmith | i.e. the mock decorator on that test sub-case that I removed | 16:52 |
| auniyal71 | okay, | 16:54 |
| auniyal71 | yes, I understood , it was re-mocking and thats problem but couldn't find at what place. | 16:56 |
| dansmith | to find that, I added a try..except around the action() call, and then if failed, printed which one of those in the list was causing the problem | 16:56 |
| dansmith | then going to that, it was clear to find that decorator mock | 16:56 |
| auniyal71 | oh okay, got it, thanks dansmith | 16:57 |
| auniyal71 | dansmith, can you please review these as well: | 17:02 |
| auniyal71 | https://review.opendev.org/c/openstack/nova/+/873648 | 17:02 |
| auniyal71 | https://review.opendev.org/c/openstack/nova/+/877446 | 17:02 |
| dansmith | auniyal71: yep I have them on my list but it looks like still some outstanding replies from others are expected | 17:07 |
| auniyal71 | ack, | 17:07 |
| opendevreview | sean mooney proposed openstack/os-vif stable/train: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/841779 | 18:40 |
| opendevreview | sean mooney proposed openstack/os-vif stable/train: only register tables used by os-vif https://review.opendev.org/c/openstack/os-vif/+/841780 | 18:40 |
| opendevreview | sean mooney proposed openstack/os-vif stable/ussuri: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/841777 | 18:53 |
| opendevreview | sean mooney proposed openstack/os-vif stable/ussuri: only register tables used by os-vif https://review.opendev.org/c/openstack/os-vif/+/841778 | 18:53 |
| opendevreview | sean mooney proposed openstack/os-vif stable/train: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/841779 | 19:08 |
| opendevreview | sean mooney proposed openstack/os-vif stable/train: only register tables used by os-vif https://review.opendev.org/c/openstack/os-vif/+/841780 | 19:08 |
| opendevreview | melanie witt proposed openstack/nova master: Improve logging at '_numa_cells_support_network_metadata' https://review.opendev.org/c/openstack/nova/+/860930 | 22:05 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!