| bauzas | folks, I have a couple of review requests, is there anyone fancy to do it ? | 08:56 |
|---|---|---|
| bauzas | first one is an easy peasy, it just adds some functional verification for cross_az_attach https://review.opendev.org/c/openstack/nova/+/878948 | 08:57 |
| bauzas | I need a second core ^ | 08:57 |
| bauzas | second one is important for fixing a cpu power management issue, should be easy to review too https://review.opendev.org/c/openstack/nova/+/885352 | 08:58 |
| bauzas | needs a second core as well ^ | 08:58 |
| opendevreview | John Garbutt proposed openstack/nova master: Deprecate ironic.peer_list https://review.opendev.org/c/openstack/nova/+/883346 | 08:59 |
| bauzas | third one is a specless bp change, simple for just adding a new cod-migrate policy https://review.opendev.org/c/openstack/nova/+/881562 | 08:59 |
| bauzas | so, who can help me ? :) | 08:59 |
| gibi | bauzas: o/ remind me, did we discussed that specless on the meeting? | 09:06 |
| bauzas | gibi: it was approved IIRC, but lemme double-check | 09:06 |
| bauzas | https://blueprints.launchpad.net/nova/+spec/cold-migrate-to-host-policy correct it was | 09:06 |
| gibi | bauzas: thanks | 09:07 |
| bauzas | https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-25-16.00.log.html#l-203 | 09:07 |
| bauzas | gibi: thanks for doing this round of reviews, I know you're busy | 09:07 |
| gibi | ohh sh*t now I have to do these reviews :D | 09:08 |
| bauzas | gibi: nah, don't feel pressured | 09:14 |
| bauzas | I'm thinking of creating an etherpad of code reviews either way :) | 09:14 |
| gibi | done :D | 09:15 |
| gibi | I mean with the reviews | 09:15 |
| sean-k-mooney | i can review some of them while i wait for my dev env to deploy | 09:23 |
| sean-k-mooney | there is one minor english issue in https://review.opendev.org/c/openstack/nova/+/881562/2/api-ref/source/servers-admin-action.inc and a slight nit later | 09:26 |
| sean-k-mooney | but im +2 on it | 09:26 |
| sean-k-mooney | i held +w in case you want to quickly fix it? | 09:26 |
| bauzas | sean-k-mooney: sorry was working on updating some change | 09:30 |
| bauzas | sean-k-mooney: sure, I can quickly respin for that english point | 09:31 |
| sean-k-mooney | ack ill fast approve once its ready | 09:31 |
| bauzas | should be better than a FUP | 09:31 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Add a new policy for cold-migrate with host https://review.opendev.org/c/openstack/nova/+/881562 | 09:34 |
| bauzas | sean-k-mooney: gibi: ^ | 09:34 |
| * bauzas goes back on https://review.opendev.org/c/openstack/nova/+/845757 which sounds eventually nice for operators given the Summit and the ML :) | 09:35 | |
| opendevreview | sean mooney proposed openstack/nova master: Remove deprecated AZ filter. https://review.opendev.org/c/openstack/nova/+/886779 | 10:02 |
| sean-k-mooney | bauzas: speaking of easy reviews can you hit this https://review.opendev.org/c/openstack/nova/+/886596 to drop fedora form teh experimental pipeline | 10:11 |
| sean-k-mooney | the infra team are woking on droping the fedora images from ci | 10:11 |
| opendevreview | John Garbutt proposed openstack/nova master: WIP: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/886980 | 11:00 |
| opendevreview | John Garbutt proposed openstack/nova master: Deprecate ironic.peer_list https://review.opendev.org/c/openstack/nova/+/883346 | 11:09 |
| opendevreview | John Garbutt proposed openstack/nova master: WIP: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/886980 | 11:10 |
| opendevreview | Merged openstack/nova master: Verify a move operation for cross_az_attach=False https://review.opendev.org/c/openstack/nova/+/878948 | 11:44 |
| opendevreview | Danylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added. https://review.opendev.org/c/openstack/nova/+/876075 | 12:15 |
| * bauzas wraps his head with all the VGPU limitations :( | 14:24 | |
| dansmith | bauzas: I would sure love to have some review on my compute object id set | 15:07 |
| dansmith | I wrote it a long time ago, but I barely remember what's in it anymore, so addressing feedback becomes more and more expensive as time goes on... :/ | 15:08 |
| bauzas | dansmith: aha, right, I need to look at your series | 15:08 |
| bauzas | reminder : tomorrow will be our spec review day | 15:29 |
| bauzas | (adding this reminder also for me :) ) | 15:29 |
| opendevreview | John Garbutt proposed openstack/nova master: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/886980 | 16:00 |
| opendevreview | John Garbutt proposed openstack/nova master: WIP: Add nova-manage ironic-compute-node-move https://review.opendev.org/c/openstack/nova/+/886989 | 16:42 |
| gmann | bauzas: dansmith: can either of you approve this, adding py310 func job on gate pipeline too https://review.opendev.org/c/openstack/nova/+/881339 | 17:56 |
| dansmith | approved, but I guess I'm not sure it's really important to run on so many python versions | 17:58 |
| dansmith | it's not likely that python version problems will crop up between check and gate :) | 17:59 |
| gmann | nova-tox-functional-py39 can be removed as py38 and py310 can cover it | 18:00 |
| dansmith | definitely seems prudent to do that yeah | 18:01 |
| opendevreview | melanie witt proposed openstack/nova-specs master: Re-propose spec for ephemeral storage encryption https://review.opendev.org/c/openstack/nova-specs/+/887011 | 23:00 |
| opendevreview | melanie witt proposed openstack/nova-specs master: Re-propose spec for ephemeral encryption for libvirt https://review.opendev.org/c/openstack/nova-specs/+/887012 | 23:14 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!