| LarsErikP | frickler: (reading backlog) - ok, thanks =) | 06:23 |
|---|---|---|
| opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884808 | 07:40 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884808 | 07:44 |
| bauzas | elodilles: gibi: could you please give a swing to https://review.opendev.org/c/openstack/nova/+/883724 as a stable/yoga patch ? It would be nice thanks | 07:46 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883725 | 07:47 |
| gibi | bauzas: I guess you mean the stable/zed first) | 07:48 |
| gibi | :) | 07:48 |
| bauzas | gibi: indeed | 07:49 |
| bauzas | + yoga | 07:49 |
| bauzas | I'm trying to backport https://review.opendev.org/c/openstack/nova/+/883725 down to wallaby but I also need to create some backport for https://review.opendev.org/c/openstack/nova/+/884808 down to Wallaby too | 07:50 |
| gibi | bauzas: it seems that unit test errors in https://review.opendev.org/c/openstack/nova/+/883726 are relevant | 07:51 |
| bauzas | gibi: indeed, I'm working atm on this | 07:52 |
| bauzas | we need a dependent backport | 07:52 |
| bauzas | https://review.opendev.org/c/openstack/nova/+/705792 hits me hard | 07:53 |
| bauzas | that's why I sometimes hate to just modify a lot of methods :( | 07:53 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884808 | 08:17 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883725 | 08:17 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883726 | 08:26 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884830 | 08:26 |
| *** Continuity_ is now known as Continuity | 08:28 | |
| bauzas | gibi: thanks for the stable reviews, could you also please look at https://review.opendev.org/c/openstack/nova/+/884808 ? | 08:43 |
| bauzas | and I think I fixed the wallaby issues for https://review.opendev.org/c/openstack/nova/+/883726 | 08:44 |
| gibi | bauzas: I have a request in https://review.opendev.org/c/openstack/nova/+/884830 | 08:50 |
| bauzas | gibi: easy request | 08:51 |
| bauzas | gibi: in general, we don't remove that in the backports, amarite elodilles ? | 08:51 |
| bauzas | but sure, I can do it | 08:51 |
| gibi | I think we do, but I deffer to elodilles | 08:51 |
| bauzas | I can hold until he replies | 08:54 |
| bauzas | or the other way | 08:55 |
| elodilles | o/ | 09:02 |
| elodilles | what is the question? :) | 09:03 |
| elodilles | yepp, the conflicts that are not valid anymore just confuse reviewers, so best to drop them | 09:04 |
| bauzas | cool, will do | 09:09 |
| bauzas | elodilles: thanks | 09:09 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884830 | 09:14 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883726 | 09:14 |
| elodilles | np | 09:14 |
| bauzas | elodilles: your help would be appreciated :) | 09:14 |
| elodilles | i need to be AFK, but sure, when i'll be back i'll review it o:) | 09:15 |
| bauzas | elodilles: could you please look at https://review.opendev.org/c/openstack/nova/+/883724 and then https://review.opendev.org/c/openstack/nova/+/884808/ ? | 09:15 |
| bauzas | elodilles: tl;dr: we want to backport a bugfix down to Wallaby | 09:15 |
| bauzas | and we need to backport a dependent change | 09:15 |
| elodilles | ACK, added to my TODO :) | 09:16 |
| bauzas | thanks | 09:17 |
| gibi | bauzas: could you look at the backports of https://review.opendev.org/q/topic:bug%252F1941005 I think stable/wallaby is the next one | 10:52 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | 12:12 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | 12:12 |
| bauzas | gibi: I'll try to look at those patches for sure | 13:10 |
| sean-k-mooney | bauzas: gibi can one of ye review https://review.opendev.org/c/openstack/nova/+/873216 | 13:22 |
| bauzas | sean-k-mooney: it seems a legit bug | 13:22 |
| bauzas | I'll review it | 13:23 |
| sean-k-mooney | bug/feature but its a bug that was reported downstream, which was then fixed by our customer and has been waiting for upstream review for a while | 13:23 |
| sean-k-mooney | we did a downstream bug scub yesterday and this was one of the ones that we decied to try and move forward since it was passing ci and bacially ready to go | 13:24 |
| bauzas | sean-k-mooney: I just Review-Prio +1d it | 13:50 |
| sean-k-mooney | thanks | 13:50 |
| opendevreview | Dan Smith proposed openstack/nova master: Populate ComputeNode.service_id https://review.opendev.org/c/openstack/nova/+/879904 | 14:13 |
| opendevreview | Dan Smith proposed openstack/nova master: Add compute_id columns to instances, migrations https://review.opendev.org/c/openstack/nova/+/879499 | 14:13 |
| opendevreview | Dan Smith proposed openstack/nova master: Add dest_compute_id to Migration object https://review.opendev.org/c/openstack/nova/+/879682 | 14:13 |
| opendevreview | Dan Smith proposed openstack/nova master: Add compute_id to Instance object https://review.opendev.org/c/openstack/nova/+/879500 | 14:13 |
| opendevreview | Dan Smith proposed openstack/nova master: Online migrate missing Instance.compute_id fields https://review.opendev.org/c/openstack/nova/+/879905 | 14:13 |
| opendevreview | Dan Smith proposed openstack/nova master: Add online migration for Instance.compute_id https://review.opendev.org/c/openstack/nova/+/884752 | 14:13 |
| dansmith | well, rebasing a migration due to a conflict is nicer under alembic, that's for sure | 14:13 |
| sean-k-mooney | i have not looked at the delta too closely but i assuem with alembic ist largely just updating some hashes liek this https://review.opendev.org/c/openstack/nova/+/879499/9..10/nova/db/main/migrations/versions/1acf2c98e646_add_compute_id_to_instance.py#26 | 14:21 |
| sean-k-mooney | """Another thing to notice is the down_revision variable. This is how Alembic knows the correct order in which to apply migrations. When we create the next revision, the new file’s down_revision identifier would point to this one:""" | 14:23 |
| dansmith | this is all I had to do: https://review.opendev.org/c/openstack/nova/+/879499/9..10/nova/db/main/migrations/versions/1acf2c98e646_add_compute_id_to_instance.py | 14:23 |
| sean-k-mooney | so i guess if a migration has landed in teh interm you just need to update that but your migration will still refer to the same revision ids in the pater patches | 14:24 |
| sean-k-mooney | ya thats what i ment | 14:24 |
| sean-k-mooney | it makes sens that that just need to be updated to refernce the latest revision | 14:24 |
| *** Continuity__ is now known as Continuity | 15:15 | |
| opendevreview | Merged openstack/nova stable/zed: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883723 | 15:46 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!