| lajoskatona | bauzas: Hi, I opened a bug against Neutron/Nova/Tempest to track what we do with tests like the ones under tempest/api/compute/security_groups | 07:43 |
|---|---|---|
| lajoskatona | bauzas: here's the bug: https://bugs.launchpad.net/neutron/+bug/2017023 | 07:44 |
| lajoskatona | bauzas: I also noted kopecmartin to think about it from tempest perspective, and I plan to check what coverage we have in tempest/api/network or tempest/scenario | 07:44 |
| lajoskatona | bauzas: so if you have some free time please check it. | 07:45 |
| bauzas | lajoskatona: ack, I'll take a look | 07:45 |
| lajoskatona | bauzas: thanks | 07:45 |
| bauzas | lajoskatona: fwiw, I'd also like us to sit down in a room during the PTG to see all the failures we have in CI, and see how we can fix that | 07:46 |
| bauzas | like a war room if you prefer | 07:46 |
| lajoskatona | bauzas: I added a line to the Neutron etherpad: https://etherpad.opendev.org/p/neutron-vancouver-2023#L41 | 07:54 |
| bauzas | oh wow, you already have an etherpad :) | 07:54 |
| lajoskatona | bauzas: I am still not sure if I will be personally there | 07:54 |
| bauzas | I know | 07:54 |
| bauzas | this is a difficult problem | 07:55 |
| bauzas | we will mostly miss the quorum | 07:55 |
| gibi | based on the current state of affairs nova will be far from quorum :/ | 07:58 |
| bauzas | gibi: ship hasn't fully sailed yet, but anyway we'll miss a lot of contributors indeed | 08:10 |
| opendevreview | xielijie proposed openstack/nova master: Correct retry interval during attach volume https://review.opendev.org/c/openstack/nova/+/880921 | 08:46 |
| opendevreview | Merged openstack/nova stable/yoga: Fix rescue volume-based instance https://review.opendev.org/c/openstack/nova/+/872118 | 11:08 |
| sean-k-mooney | lajoskatona: im not sure we shoudl remove those tempest test while we still have supprot for them in nova | 11:58 |
| sean-k-mooney | we deprecated there use years ago but since we have never risen our min microversion they are still fuly supported | 11:58 |
| sean-k-mooney | we deprecated the apis in 2.36 as part of the newton release https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#microversion | 11:59 |
| lajoskatona | sean-k-mooney: ahh, ok, thanks, this is why I added Nova also the the bug to have all parties on the table | 12:06 |
| lajoskatona | sean-k-mooney: so till the mi microversion is not bumped higher that 2.36 we have to keep these proxy APIs and the tests? | 12:07 |
| sean-k-mooney | if i can leverage this as a forcing funciton to actully raise our min microversion then i would be happy to raise it above where those were decpreated and delete the code | 12:07 |
| sean-k-mooney | lajoskatona: yes i think we do because they are still fully supproted and i think horizon might still be using some of them | 12:08 |
| lajoskatona | sean-k-mooney: I see you also commented on the bug, thanks, it will help everybody to see the whole picture | 12:10 |
| sean-k-mooney | i have no partically issue with skiping the nova test by defualt in most jobs | 12:10 |
| sean-k-mooney | but the nova gate still need to test it | 12:10 |
| * sean-k-mooney by nova tests i mean test of the proxy apis | 12:12 | |
| sean-k-mooney | lajoskatona: we also have proxy apis for cinder and glance that we unfortunetlly still need to test | 12:12 |
| sean-k-mooney | for basically the same reason | 12:13 |
| sean-k-mooney | lajoskatona: im not that familar with horizon but https://github.com/openstack/horizon/commit/9067ae8b0fe6dd57906d0eb5fe31ee96eb021fd4 it looks like they have actully converted to usign neutron instead | 12:15 |
| lajoskatona | sean-k-mooney: anyway I still think it is worth to discuss if we have to test these APIs for all patch, and instead run these tests against a really used API (Neutron in this this case but can be true for Glance or Cinder also) | 12:15 |
| sean-k-mooney | well that is why i suggested not testign them in gates other then nova | 12:20 |
| sean-k-mooney | so neutron cinder and glance coudl perhaps stop testign them but i think nova still needs too | 12:20 |
| sean-k-mooney | i woudl suggest usign the Intergrated-Compute job to test them | 12:21 |
| sean-k-mooney | bauzas: gibi ^ does that sound reasonable to ye | 12:21 |
| sean-k-mooney | i wont be at the physical ptg but once we have one job on nova testing the proxy apis then i think thats enough | 12:22 |
| lajoskatona | sean-k-mooney: sonds reasonable, keep the tests and execute them in a Nova only job, and do not test these "legcy" API from other projects | 12:32 |
| sean-k-mooney | that does mean if cidner or neutron breaks these ye wont see that breakage but we will | 12:33 |
| sean-k-mooney | that said i dont think that has ever happened | 12:33 |
| sean-k-mooney | so im not realy worreid about that | 12:33 |
| sean-k-mooney | pluse we will see it and we can let ye know if it happens | 12:34 |
| bauzas | sean-k-mooney: can you summarize your opinion please ? | 12:41 |
| bauzas | (just to make sure I understand it correctly) | 12:41 |
| sean-k-mooney | tl;dr we cant stop testing proxy api unless we rais our min microversion but we dont need to test it in project other then nova | 12:42 |
| sean-k-mooney | so im fine with not running the proxy api test in other proejct jobs and i think testing it only in the intergarte-compute jobs woudl be enough coverage for our gate | 12:42 |
| sean-k-mooney | i.e. one job to smoke test that they still work as expected on our side but no expectation for other project to continue testing the proxy apis | 12:43 |
| bauzas | sean-k-mooney: sure, those are deprecated | 12:43 |
| sean-k-mooney | yep but fully supported | 12:43 |
| sean-k-mooney | deprecation in this case just means we wont extend them and you should not build new uasge of them | 12:44 |
| sean-k-mooney | i would love to delete the code but to do that we really need to raise our min microversion | 12:44 |
| sean-k-mooney | i think we should do that regardelss of this effort but i dont think we shoudl remove all testing in tempest if we report our min microvstion as 2.1 | 12:45 |
| sean-k-mooney | anyway hopefully that is a sufficent summary if not ask away and i can clarify | 12:46 |
| bauzas | cool | 12:50 |
| sean-k-mooney | bauzas: gibi im doing some jira cleanup this morning... so ill reping the weigher patch in the next hour or so | 13:09 |
| sean-k-mooney | thanks for the reviews | 13:09 |
| gibi | sean-k-mooney: cool. I can +2 it quickly as I'm OK with the content | 13:14 |
| *** ministry is now known as __ministry | 13:31 | |
| opendevreview | Merged openstack/nova stable/zed: Handle InstanceInvalidState exception https://review.opendev.org/c/openstack/nova/+/872115 | 17:15 |
| opendevreview | sean mooney proposed openstack/nova master: add hypervisor version weigher https://review.opendev.org/c/openstack/nova/+/880231 | 18:34 |
| sean-k-mooney | gibi: bauzas sorry that took me longer then it should have but its there for you in the morning | 18:34 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!