| opendevreview | Konrad Gube proposed openstack/nova-specs master: Re-propose using extend volume completion action for 2023.2 https://review.opendev.org/c/openstack/nova-specs/+/877233 | 08:29 |
|---|---|---|
| opendevreview | Merged openstack/nova stable/xena: db: Resolve additional SAWarning warnings https://review.opendev.org/c/openstack/nova/+/874066 | 10:43 |
| *** ministry is now known as __ministry | 10:55 | |
| opendevreview | Merged openstack/nova stable/wallaby: Reattach mdevs to guest on resume https://review.opendev.org/c/openstack/nova/+/821978 | 12:44 |
| *** blarnath is now known as d34dh0r53 | 13:15 | |
| opendevreview | ribaudr proposed openstack/nova stable/yoga: Don't provide MTU value in metadata service if DHCP is enabled https://review.opendev.org/c/openstack/nova/+/879740 | 13:19 |
| opendevreview | ribaudr proposed openstack/nova stable/yoga: Don't provide MTU value in metadata service if DHCP is enabled https://review.opendev.org/c/openstack/nova/+/879740 | 13:38 |
| opendevreview | ribaudr proposed openstack/nova stable/yoga: Don't provide MTU value in metadata service if DHCP is enabled https://review.opendev.org/c/openstack/nova/+/879701 | 13:42 |
| opendevreview | ribaudr proposed openstack/nova stable/ussuri: Don't provide MTU value in metadata service if DHCP is enabled https://review.opendev.org/c/openstack/nova/+/879702 | 13:45 |
| opendevreview | ribaudr proposed openstack/nova stable/xena: Don't provide MTU value in metadata service if DHCP is enabled https://review.opendev.org/c/openstack/nova/+/879703 | 13:51 |
| opendevreview | ribaudr proposed openstack/nova stable/wallaby: Don't provide MTU value in metadata service if DHCP is enabled https://review.opendev.org/c/openstack/nova/+/879704 | 13:52 |
| opendevreview | ribaudr proposed openstack/nova stable/victoria: Don't provide MTU value in metadata service if DHCP is enabled https://review.opendev.org/c/openstack/nova/+/879705 | 13:52 |
| opendevreview | ribaudr proposed openstack/nova stable/train: Don't provide MTU value in metadata service if DHCP is enabled https://review.opendev.org/c/openstack/nova/+/879706 | 13:54 |
| opendevreview | liang jiechao proposed openstack/nova-specs master: Generic vdpa spec https://review.opendev.org/c/openstack/nova-specs/+/879338 | 13:58 |
| stephenfin | bauzas: Think you could hit this up https://review.opendev.org/c/openstack/nova/+/872429/ ? | 14:07 |
| opendevreview | Dan Smith proposed openstack/nova-specs master: Add compute-object-ids spec for 2023.2 https://review.opendev.org/c/openstack/nova-specs/+/877291 | 14:22 |
| dansmith | sean-k-mooney: added a bunch more meat to this ^ around migration handling | 14:22 |
| dansmith | as I'm working through the actual implementation I'm finding that we throw node names around more than I was really thinking, because of the migrations | 14:23 |
| dansmith | sean-k-mooney: also, see my comment here: | 14:46 |
| dansmith | https://review.opendev.org/c/openstack/nova/+/878238 | 14:46 |
| dansmith | I don't want to recheck that and make it merge if you disagree, but.. I'm pretty sure that's not related since that same failure has been happening a lot | 14:46 |
| opendevreview | Dan Smith proposed openstack/nova-specs master: Add compute-object-ids spec for 2023.2 https://review.opendev.org/c/openstack/nova-specs/+/877291 | 16:26 |
| opendevreview | Merged openstack/nova stable/yoga: Reproduce live migration rollback w/o multi port bindings error https://review.opendev.org/c/openstack/nova/+/839921 | 16:49 |
| sean-k-mooney | dansmith: ill be aroudn for a litle bit but before i finsih for the long weekend i wante to checkback with you for the laze load patch | 17:13 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/878238 | 17:13 |
| sean-k-mooney | you mentioned you see the same failure in other runs | 17:13 |
| sean-k-mooney | given that its proably unrelated just looks suspcious given what you were updateing | 17:14 |
| sean-k-mooney | i cna read +2 and recheck it | 17:14 |
| sean-k-mooney | but i was wondering if you had filed a gate bz or anything for this | 17:15 |
| sean-k-mooney | *gate bug | 17:15 |
| dansmith | no, I haven't noticed it before this, I just went looking to see if it was really new here | 17:15 |
| dansmith | I'm not sure why we'd see it for scheduler and not conductor, which already added the singleton infra | 17:15 |
| sean-k-mooney | so i think i have seen this before but not consitently | 17:15 |
| sean-k-mooney | well the base class is also alredy resting the singelton | 17:16 |
| sean-k-mooney | all you changed is doing it via the property | 17:16 |
| sean-k-mooney | which is even more strange | 17:16 |
| sean-k-mooney | like i dont know why calling the singelton later would chagne the behavior | 17:16 |
| dansmith | ...right | 17:16 |
| sean-k-mooney | so the hits you found seam to be for 878763, 875621, 879500 and now 878238 | 17:19 |
| sean-k-mooney | dansmith: so other then the fact that two of these were submited by you id dont see anything quicly that woudl make me think this is specific to your change | 17:30 |
| sean-k-mooney | so i think this is an exting issue so we can proceed with the lazy loading | 17:30 |
| sean-k-mooney | the first hit in the lst 30 days was Mar 28, 2023 @ 12:58:01.786 | 17:31 |
| sean-k-mooney | so maybe we could see what merged just before that | 17:31 |
| dansmith | but we're also not hitting them very often, so I'm not sure looking at temporal merges is likely to be very fruitful | 17:31 |
| opendevreview | Dan Smith proposed openstack/nova master: Add compute_id to Instance object https://review.opendev.org/c/openstack/nova/+/879500 | 17:32 |
| sean-k-mooney | fair i guess we can just keep an eye out and see if this starts happening more often | 17:32 |
| dansmith | sean-k-mooney: based on this I'm assuming you didn't see my ping about it above, which means you likely didn't see my ping before that about the spec? | 17:32 |
| sean-k-mooney | correct but scrolling up i see them | 17:33 |
| dansmith | no rush, so don't worry about it today | 17:33 |
| dansmith | just fyi for tomorrow or next week | 17:33 |
| sean-k-mooney | ya proably next week | 17:35 |
| sean-k-mooney | skiming it i did not think about migration being affect by this durign the ptg | 17:35 |
| sean-k-mooney | but ya it would make sesne if we are addign the srive_id to the instace | 17:35 |
| dansmith | me either, but we update host and node from migration a LOT | 17:35 |
| sean-k-mooney | before the ptg i was not expectign to update the instnace in this cycle | 17:36 |
| dansmith | my patch actually makes us do that less, updating it to be "this node here" instead of "whatever the migration said" in several places | 17:36 |
| sean-k-mooney | i assumed it was just going ot be the compute but there is value in doing both | 17:36 |
| sean-k-mooney | ack | 17:36 |
| sean-k-mooney | ya so jira has eaten all my brin power so im not digesting the spec reading it | 17:37 |
| sean-k-mooney | so ya ill take a look on tueday and just assume your right :) | 17:37 |
| sean-k-mooney | i did see you had started the work on it | 17:38 |
| dansmith | yep, np | 17:38 |
| dansmith | as noted in the ptg, | 17:38 |
| dansmith | I think we should do more developing the code and spec in parallel, after initial sign-off on the idea | 17:38 |
| dansmith | so I'm trying to keep my spec updated with the wrinkles I'm finding | 17:38 |
| dansmith | and just hope that bauzas will approve me before the spec lands :) | 17:38 |
| sean-k-mooney | ill reply on artom patch | 17:42 |
| sean-k-mooney | but if i recall corectly its because this is invoked in the perodic task asn we are trying to avoid loading all of the instnace numa toplogy blob form the data base | 17:42 |
| dansmith | but we're iterating it already no? | 17:43 |
| sean-k-mooney | this is invoked in the update_avaiable_resouces periodic | 17:43 |
| dansmith | it seems like we're just creating a new topology by iterating the old one, then doing the math | 17:43 |
| dansmith | like, instead of obj_clone() (if we need to be doing it on a copy) | 17:44 |
| sean-k-mooney | i also dont have this fully loaded in cache but i think we are actully iterating over the domains intially rather then having a fully set of instance objects | 17:45 |
| dansmith | we're iterating over host topology, AFAICT | 17:45 |
| dansmith | but not important right now, I was just asking | 17:45 |
| dansmith | (as noted in my reply) | 17:45 |
| sean-k-mooney | so im not saying this cant be recactored but if i recall correctly its becasue of this https://github.com/openstack/nova/blob/49aa40394a4857a06191b05ea3b15913f328a8d0/nova/compute/resource_tracker.py#L1334-L1371 code path | 17:47 |
| dansmith | right, it's making a copy, modifying it and returning | 17:48 |
| dansmith | obj_clone() is the way to do that to avoid silly omissions like this bug | 17:48 |
| sean-k-mooney | ya | 17:49 |
| dansmith | anyway, as I said, I'm not saying it needs to be refactored right now, I was just wondering why we were doing it the most laborious and error-prone way possible | 17:49 |
| sean-k-mooney | so this comes form the initall commit it seams | 17:55 |
| sean-k-mooney | https://github.com/openstack/nova/commit/b11dbfa4902cdd74bad3745db177d80b1c8b07c6 | 17:55 |
| sean-k-mooney | https://github.com/openstack/nova/blob/b11dbfa4902cdd74bad3745db177d80b1c8b07c6/nova/virt/hardware.py#L1121-L1151 | 17:57 |
| sean-k-mooney | that predates OVOs being split out of nova i think i wonder if it just the clone did not exist then | 17:58 |
| dansmith | no, it did | 17:59 |
| dansmith | perhaps just an omission | 17:59 |
| sean-k-mooney | https://github.com/openstack/nova/blob/b11dbfa4902cdd74bad3745db177d80b1c8b07c6/nova/objects/base.py#L370-L372 | 17:59 |
| sean-k-mooney | so ya it did | 18:00 |
| sean-k-mooney | and since it worked we just didnt clean it up | 18:00 |
| sean-k-mooney | anyway i woudl prefer to proceed with the small fix and maybe swap to that on master in a followup | 18:00 |
| sean-k-mooney | we would ahve to see if there are any field that should not be cloned | 18:01 |
| sean-k-mooney | liek we want to reset the usage filed | 18:01 |
| dansmith | ...that's what I said | 18:01 |
| sean-k-mooney | oh i know im just confirming that looking at the git history its not obvious why that approch was nto taken orginally | 18:02 |
| dansmith | okay | 18:02 |
| sean-k-mooney | ok im going to finish for today. if i dont get to your spec on tuesday feel free to remind me | 18:03 |
| sean-k-mooney | enjoy your weekend o/ | 18:03 |
| opendevreview | Merged openstack/nova stable/xena: Add debug log for scheduler weight calculation https://review.opendev.org/c/openstack/nova/+/879404 | 18:04 |
| dansmith | ack, thanks, later | 18:04 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline for extended periods between 22:00 and 00:00 UTC for software upgrades and project renames: https://lists.opendev.org/archives/list/service-announce@lists.opendev.org/thread/VW2O56AXI4OX34CWDNRNZDCWJDZR3QJP/ | 21:05 | |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline for extended periods over the next two hours for software upgrades and project renames: https://lists.opendev.org/archives/list/service-announce@lists.opendev.org/thread/VW2O56AXI4OX34CWDNRNZDCWJDZR3QJP/ | 21:59 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!