Thursday, 2023-03-16

opendevreviewHiroki Narukawa proposed openstack/nova master: libvirt: retry libvirt connection on live_migration_monitor  https://review.opendev.org/c/openstack/nova/+/86707706:07
opendevreviewHiroki Narukawa proposed openstack/nova master: Reproducer for bug 1999607  https://review.opendev.org/c/openstack/nova/+/87758206:07
opendevreviewHiroki Narukawa proposed openstack/nova master: Reproducer for bug 1999607  https://review.opendev.org/c/openstack/nova/+/87758206:39
opendevreviewHiroki Narukawa proposed openstack/nova master: libvirt: retry libvirt connection on live_migration_monitor  https://review.opendev.org/c/openstack/nova/+/86707706:39
opendevreviewHiroki Narukawa proposed openstack/nova master: Reproducer for bug 1999607  https://review.opendev.org/c/openstack/nova/+/87758207:22
opendevreviewHiroki Narukawa proposed openstack/nova master: libvirt: retry libvirt connection on live_migration_monitor  https://review.opendev.org/c/openstack/nova/+/86707707:22
opendevreviewAmit Uniyal proposed openstack/nova master: Allow swap resize from non-zero to zero  https://review.opendev.org/c/openstack/nova/+/85733907:58
*** gibi_pto is now known as gibi08:04
opendevreviewAmit Uniyal proposed openstack/nova master: Allow swap resize from non-zero to zero  https://review.opendev.org/c/openstack/nova/+/85733908:04
opendevreviewAlexey Stupnikov proposed openstack/nova master: Preserve cached base images for failed resize ops  https://review.opendev.org/c/openstack/nova/+/87741008:23
*** thelounge554 is now known as thelounge5508:37
*** elodilles_pto is now known as elodilles09:26
opendevreviewDanylo Vodopianov proposed openstack/nova-specs master: VirtIO PackedRing Configuration support  https://review.opendev.org/c/openstack/nova-specs/+/86837709:30
*** EugenMayer46 is now known as EugenMayer410:02
songwenpingsean-k-mooney: hi, i have two same gpus on one host and want to passthrough two vms, my passthrough_whitelist is set {'vendor_id':'10de','product_id':'1e04'} and alias is set {"vendor_id":"10de","product_id" : "1e04","name": "gpu"}, but i can only create one vm, the other failed with no valid host filetered by pcipassthroughfilter. so how can i make the configuration?10:20
bauzassongwenping: which version and what says the filter ?10:31
songwenpingRocky and PciPassthroughFilter: (start: 1, end: 0)10:33
sean-k-mooneythat should work10:34
bauzasyou would need DEBUG levels10:34
sean-k-mooneysongwenping: can you check the pci_devices table in the nova cell db10:35
sean-k-mooneyand make sur eboth are there10:35
sean-k-mooneysongwenping: you alos need to make sure xorg (if its installed) is not using one of the gpus10:35
sean-k-mooneyi.e. make sure they are both bound to vfio_pci10:35
songwenpingpci_devices table has two gpu record.10:35
sean-k-mooneyok10:36
sean-k-mooneyand one is aviable10:36
sean-k-mooneyand the other asigned to the first vm10:36
bauzassean-k-mooney: that's a scheduler filter issue10:36
bauzasso not related to the driver10:36
sean-k-mooneyya it is but i dont think its a bug10:36
bauzasyup10:37
sean-k-mooneybauzas: right i jsut mentioned the driver for after this is fixed10:37
bauzasanyway, I need to get off the keyboard10:37
songwenpingi am opening the debug level to get more info10:37
sean-k-mooneysongwenping: are you useing numa by the way10:37
sean-k-mooneyi.e. cpu pinning or hugepages10:37
songwenpingno using numa10:37
sean-k-mooneyok10:37
sean-k-mooneyif you can pastebin the entires for the pci_devices  and debug secduler logs we can take a look10:38
sean-k-mooneyi just want to look at the 2 for the gpu10:39
sean-k-mooneyits odd that one worked and the other is failing10:39
sean-k-mooneyi would have expect both to fail or both to work10:39
sean-k-mooneyim wonderign what device_type is set to i assum type-PCI but it could be type-PF depending on the type of gpu10:40
songwenpingsean-k-mooney,bauzas: that's becuase the disk is not enough, i use the local disk. thanks a lot.10:55
sean-k-mooneyhuh the pci filter shoudl not be10:56
sean-k-mooneyoh the disk filter elimiated the host that had the free pci device10:56
sean-k-mooneyand then the pci filter elimiated the remaining host because there was not a free gpu there10:56
sean-k-mooneyok makes sense10:56
songwenpingyes, the filter error is mislead.10:57
sean-k-mooneyya you bacially need to look at the set of all filters when debugging it10:57
sean-k-mooneynot just the last one that elimiated the final hosts10:57
songwenpingyeah the debug info is very useful.10:58
sean-k-mooneysome operators run with dbug on all the time for what its worth10:58
sean-k-mooneyyou might now want it enabeld on all the services10:59
sean-k-mooneybut i like having it on for the scheduler at least10:59
bauzasok gtk10:59
sean-k-mooneythere is an argument to be made for moving those specific logs to info level10:59
sean-k-mooneywe didnt in the past because it can be a bit noisy but its a trade off11:00
Ugglasean-k-mooney, gibi, bauzas Hi, is the a way to disable a flag set with self.flags(...) ?11:11
sean-k-mooneyUggla: well you can just set it to what you want but if you mean you want to revert it to the unset state then you likely need to do thave via oslo11:15
sean-k-mooneyhttps://docs.openstack.org/oslo.config/latest/reference/locations.html11:16
sean-k-mooneyso flags i think is calling set_override11:16
sean-k-mooneyhttps://docs.openstack.org/oslo.config/latest/reference/api/oslo_config.html#oslo_config.cfg.ConfigOpts.reset11:17
sean-k-mooneythere is a reset funciton11:17
sean-k-mooneyso you would do CONF.my_section.my_var.reset()11:17
Ugglasean-k-mooney, cool I'm going to have a look. Thanks11:17
sean-k-mooneythat will clear any orverdie ro default value11:17
sean-k-mooneyreset()ΒΆ11:18
sean-k-mooney    Clear the object state and unset overrides and defaults.11:18
sean-k-mooneyUggla: feel free to wrap that up in a reset_flags helper funciton if you want to use it11:19
sean-k-mooneyi have never needed to od this in a test before so before you do are you sure you need this11:20
sean-k-mooneyusually i woudl sugges makeign sure the parent of your test class does not do thing you dont need11:20
sean-k-mooneyinstead of trying to reset teh config state11:21
Ugglasean-k-mooney, I'm not sure I try to have a src node configure with a flag and a dest node without. But it seams that flags are 'global' in functional test.11:23
sean-k-mooneyoh you cant do that11:24
sean-k-mooneyits a limiation of our test infra11:24
sean-k-mooneythere is a way to make it work with context manger which i demonstarted a few years ago but we decided not to do that11:24
sean-k-mooneyif your doing this in a functional test you will need to mock it differntly11:25
Ugglasean-k-mooney, the idea is to simulate a live migration from src node with a flag to dst node without this flag11:25
sean-k-mooneyyes you cant do that today in our func tests without a lot of hacks11:26
Ugglasean-k-mooney, yes I manage to do what I wanted with mock. But I was wondering if something simpler can be used.11:29
UgglaIs the reset proposed above a potential way to do that ?11:29
sean-k-mooneynot really11:30
sean-k-mooneywhen you reset it it will reset it for both computes11:30
Ugglasean-k-mooney, in my case I think it will be ok, I'll try11:31
sean-k-mooneyit likely will be racy11:32
sean-k-mooneybasicaly this is something we currently try not to do 11:32
sean-k-mooneyso if you get ti workign we will have to review it very carefully11:32
sean-k-mooneyUggla: https://stackoverflow.com/questions/33504543/passing-import-context-variables-to-decorators/33507308#3350730811:38
sean-k-mooneythats not quite what you want but i had an example for this in nova somewhere in gerrit with context manager but i cant find it11:42
opendevreviewAlexey Stupnikov proposed openstack/nova stable/victoria: Cleanup old resize instances dir before resize  https://review.opendev.org/c/openstack/nova/+/86473013:02
opendevreviewAmit Uniyal proposed openstack/nova master: Added context manager for instance lock  https://review.opendev.org/c/openstack/nova/+/87364813:33
opendevreviewAmit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host  https://review.opendev.org/c/openstack/nova/+/87744613:33
opendevreviewAmit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host  https://review.opendev.org/c/openstack/nova/+/87744613:37
opendevreviewAmit Uniyal proposed openstack/nova master: Allow swap resize from non-zero to zero  https://review.opendev.org/c/openstack/nova/+/85733917:32
darkhorsehi team, i noticed that the periodic tasks defined with @periodic_task decorator at scheduler/manager.py performs tasks on all workers instead of running once at defined spacing. is that a bug or a designed behavior?18:12
darkhorsehi team, i noticed that the periodic tasks defined with @periodic_task decorator at scheduler/manager.py performs tasks on all workers instead of running once at defined spacing. is that a bug or a designed behavior?18:12
dansmithdarkhorse: which periodic are you looking at? but yes, it's *expected* and the periodic should use some locking to prevent it from running simultaneously if need-be18:24
darkhorsedansmith: thank you for clarification. i have added a custom periodic task that should run every minute. will you point me to an example code that uses locking?18:26
dansmithdarkhorse: oslo lockutils :)18:27
dansmithwith external=true so it uses a lock file, which all the others will see18:27
dansmithif not external, then it'd just be per-process, which wouldn't help18:27
darkhorseok thank you!18:29
*** artom_ is now known as artom21:15

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!