Thursday, 2023-03-09

opendevreviewOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/nova/+/87693103:13
opendevreviewRajesh Tailor proposed openstack/nova master: Fix duplicate cell creation with same name  https://review.opendev.org/c/openstack/nova/+/87694007:08
dvo-plvHello, Could you please help me with zuul regression. https://review.opendev.org/c/openstack/nova/+/876075/ I have two components, nova depends on os-traits. I use Depends-on variable to link them, but it does not work for me.08:37
opendevreviewMerged openstack/nova master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/nova/+/87693109:02
elodillesbauzas: hi, fyi, reno workaround was released and upper constraints was bumped, so this is good to go now: https://review.opendev.org/c/openstack/nova/+/87655309:34
gibielodilles: +210:48
opendevreviewDanylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added.  https://review.opendev.org/c/openstack/nova/+/87607510:52
elodillesthx :]10:56
bauzaselodilles: sent to the gate10:58
bauzasUggla: btw. not sure you've seen my comment https://review.opendev.org/c/openstack/releases/+/87675810:58
bauzasUggla: you probably need to update both your Gerrit config and your git ownership10:59
UgglaHello bauzas , not yet I will have a look10:59
bauzasUggla: tl;dr your git user.email is different from your gerrit config11:00
bauzasand make sure you have a full name in https://review.opendev.org/settings/#Profile11:01
Ugglabauzas, yes I use my personal one for the fondation and gerrit11:01
bauzasUggla: cool, so please changing your git user.email value for this repo11:02
bauzasI'll myself update then the liaison email to be your personal email11:03
Ugglabauzas, ok I will check after lunch.11:03
bauzasUggla: elodilles: updated https://review.opendev.org/c/openstack/releases/+/87675811:05
elodillesbauzas: +2'd. let me know if we can merge that.11:26
sean-k-mooneyelodilles: from my perspective yes that is suitable to merge12:19
ratailor_sean-k-mooney, elodilles bauzas gibi can I get reviews on my patches https://review.opendev.org/c/openstack/nova/+/873901 https://review.opendev.org/c/openstack/nova/+/860938 https://review.opendev.org/q/Id4c8c5f3b32985ac7d3d7c833b82e0876f7367c1 https://review.opendev.org/q/Ia738a0972b050f549f446c85171d3f33e60ada4f saome are under review since long time. 12:41
sean-k-mooneywe are currently minimising the patches we merge to master until after the final RC deadline12:42
sean-k-mooneywhich is march 20th12:42
sean-k-mooneywe technically could merge this now but we likely will wait until after that12:43
ratailor_sean-k-mooney, ack. sure. Thanks!12:43
sean-k-mooneyill see if i can find tiem to review but we will likely hold +w for another week or so12:43
ratailor_sean-k-mooney, ack. np. 12:43
bauzaswe can merge some bugfixes if we want, that's not a problem12:50
dvo-plvHello, Could you please help me with zuul regression. https://review.opendev.org/c/openstack/nova/+/876075/ I have two components, nova depends on os-traits. I use Depends-on variable to link them, but it does not work for me.12:51
dvo-plvI found that it install os-trait from pip12:52
dvo-plv2023-03-09 11:15:37.630 | Collecting os-traits===2.10.0 2023-03-09 11:15:37.634 |   Downloading https://mirror-int.dfw.rax.opendev.org/pypifiles/packages/77/ce/66b9fc86ab69e4ad60d07901e9324cb44d72c75b9b0a989bfef0fc4ad4e3/os_traits-2.10.0-py3-none-any.whl (41 kB)12:52
dvo-plvthis log from here12:52
dvo-plvhttps://6e5de493453a596bf54b-e12a251c5f6363a4d35eb8aac39c4442.ssl.cf2.rackcdn.com/876075/3/check/tempest-integrated-compute-ubuntu-focal/270fa66/controller/logs/devstacklog.txt12:52
sean-k-mooneyif its not listed as a required project depends on does not work12:55
sean-k-mooneyi would guess that that is the isseu there with that job12:55
sean-k-mooneylooking at the parent of the job that is indeed the case12:57
sean-k-mooneyyou could add it as a required project here https://opendev.org/openstack/tempest/src/branch/master/zuul.d/integrated-gate.yaml#L146-L16612:58
sean-k-mooneyyou woudl add12:59
sean-k-mooneyrequired-projects:12:59
sean-k-mooney - openstack/os-traits12:59
opendevreviewJorge San Emeterio proposed openstack/nova master: Re-enable "test_tagged_attachment" test.  https://review.opendev.org/c/openstack/nova/+/87669913:04
opendevreviewMerged openstack/nova master: Update master for stable/2023.1  https://review.opendev.org/c/openstack/nova/+/87655313:06
dvo-plvSean, do I need to fix all gates or only for integrated-compute. Because it looks like depends-on veriable does not work for all tempest jobs13:41
sean-k-mooneyit will work only for required proejct im not sure we want to supprot it in general for os-vif14:26
sean-k-mooney*os-traits14:26
sean-k-mooneytis somethign we shoud discuss 14:26
sean-k-mooneyif we were to fix it for all tempet jobs we woudl do so in the devstack base job14:26
sean-k-mooneyhowever os-traits is a libary and we normally want ot only use that from pypi release14:27
sean-k-mooneydvo-plv: it is expected that your code will fail until an os-traits release is doen14:27
sean-k-mooneyi woudl focuse on the reapoval of the spec and we can do an os-traits release with teh traits after march 20th14:28
sean-k-mooneythat will fix all the jobs with out always installing os-traits form git14:28
sean-k-mooneyif we add os-traits as a required proejct it will always beinstalled form git instead of the most recent release even when we dont have a depens-on14:29
sean-k-mooneywhich is not what we want in general14:29
bauzassean-k-mooney: well, we could ask devstack to run our librairies from git14:32
bauzasbut I'm not super OK if this is about ci jobs14:32
bauzasit's simplier to release a library if needed14:32
sean-k-mooneybauzas: we alredy can do this14:38
sean-k-mooneybtu we intentionally dont14:38
bauzasI know and I agree14:38
bauzashence the "could"14:38
sean-k-mooneyack14:38
bauzasdvo-plv: if you get stuck by a lagging os-traits, come to us14:39
sean-k-mooneydvo-plv: the other thing you can do is for now just use a custome trait in the nova code and you can update it to the real one later but it woudl be simpler ot just approvhe the spec agains and merge the trait and do a release in 2 weeks14:39
bauzasbut I think we recently released the last traits update14:39
sean-k-mooneybauzas: the new triat is not merged yet becuase the spec need to be aprpoved first14:40
bauzassean-k-mooney: maybe we could have an experimental job that would pull os-traits from git14:40
bauzasif that helps14:40
sean-k-mooneythat wont help they wanted to get a clen ci run14:40
bauzassean-k-mooney: ah I see, that's for a new feature14:40
sean-k-mooneyyep https://review.opendev.org/c/openstack/nova/+/876075/14:41
dvo-plvI will re-execute all tests locally to be sure that all works properly and will wait for spec approve and os-traits merge. Thnak you14:41
sean-k-mooneydvo-plv: for now you could just use a custom trait and or comment it out 14:41
bauzasis it for helping to implement ?14:42
bauzasor is it for us reviewing ?14:42
bauzasif the former, nothing prevents you to test your patch against a running devstack which pulls ostraits from git14:42
sean-k-mooneyi.e more the request filter and traits reproting to a seocnd patch14:42
bauzasif the latter, add a bit fat comment in the commit msg saying the CI is broken because of the missing release14:43
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova/+/876075/3/nova/scheduler/request_filter.py is just brekign things currently14:43
sean-k-mooneysince os_traits.COMPUTE_NET_VIRTIO_PACKED does not exist yet14:43
dvo-plvyes, exactly14:43
bauzasyeah got it14:43
bauzasbut again, nothing prevents you to test this filter with a devstack having a LIBS_FROM_GIT14:44
*** sfinucan is now known as stephenfin14:44
bauzasonce the spec is approved, we could move forward and release ostraits soon14:45
dvo-plvI just wanted to be sure that all works properly with zull environment. But I will wait for approve and do best to fix all problems, what I will find locally14:45
bauzasdvo-plv: if you really want to make yourself confident of your patch, then use a custom trait indeed14:46
bauzasbut this will have to be cleaned up before review time14:46
bauzasgibi: a quick swing would be appreciated on https://review.opendev.org/c/openstack/nova/+/87451514:48
gibibauzas: looks good14:49
bauzasthanks14:49
bauzasgibi: sean-k-mooney: I have a few other nitty changes in my gerrit that are overdue14:49
bauzasstay around :)14:50
dvo-plvbtw, we already update and move packed virtqueue support spec file to the 2023/2 https://review.opendev.org/c/openstack/nova-specs/+/868377 14:53
sean-k-mooneyi need to go to the chemeyist and pick up my perscirption but ill be back in a while and can take a look then14:54
bauzasdvo-plv: this week, I'm overbusy with PTL scrubbing tasks, but I'll give a round on reviews next week14:55
bauzas(specs reviews I mean)14:55
dvo-plvThank you14:56
-opendevstatus- NOTICE: Yesterday's change to Gerrit configs to use submit-requirements had a boolean logic bug. This has now been corrected and any changes that did not merge as a result can be rechecked. We have reenqueued the changes we identified as being affected.17:24
spatelsean-k-mooney Quick question related nova-schedule not able to find sriov nodes. I do have this in nova - https://paste.opendev.org/show/bASaMtV2z9K8N24FZAk4/18:41
spatelI have created AZ group and added single compute node to that AZ 18:41
opendevreviewMerged openstack/nova master: fup for power management series  https://review.opendev.org/c/openstack/nova/+/87451518:41
spatelIn flavor i didn't specify any properties 18:41
spatelDoes placement has any entry of PCI_DEVICE? 18:45
*** thelounge553 is now known as thelounge5520:41

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!