Friday, 2023-02-17

opendevreviewMerged openstack/nova master: libvirt: Add configuration options to set SPICE compression settings  https://review.opendev.org/c/openstack/nova/+/82867501:45
opendevreviewmelanie witt proposed openstack/nova master: doc: Add details about the behavior of server delete  https://review.opendev.org/c/openstack/nova/+/87418803:07
opendevreviewAmit Uniyal proposed openstack/nova master: Added context manager for instance lock  https://review.opendev.org/c/openstack/nova/+/87364807:10
opendevreviewAmit Uniyal proposed openstack/nova master: Added context manager for instance lock  https://review.opendev.org/c/openstack/nova/+/87364807:58
bauzasbrightning new day, and brighting new CI failure \o/08:32
opendevreviewAmit Uniyal proposed openstack/nova master: Remove "see nova-manage.log" str from console msg  https://review.opendev.org/c/openstack/nova/+/87420608:46
opendevreviewNobuhiro MIKI proposed openstack/nova master: libvirt: Add 'COMPUTE_ADDRESS_SPACE_*' traits support  https://review.opendev.org/c/openstack/nova/+/87322109:02
samuelkunkel[m]Good morning, I have a question regarding AMD SEV. I am running into an issue where the the first check of hardware.get_mem_encryption_constraint is working properly (machine type correct, uefi boot check etc). further down the line nova runs libvirt_utils.get_flags_by_flavor_specs. In this function we try to fetch the ResourceRequest via scheduler_utils. At this state we only have the information about the flavor. Not the image.10:18
samuelkunkel[m]During the the execution of this nova will run res_req._translate_memory_encryption(request_spec.flavor, image) where the image is a just a plain objects.ImageMeta(properties=objects.ImageMetaProps())... and now nova fails (its running the function now for the second time)  _check_mem_encryption_uses_uefi_image as the image does not contain useful information at all and therefore we never can create an instance as nova assumes in10:18
samuelkunkel[m]this stage we use an image without uefi boot.10:18
samuelkunkel[m]Am I missing something here?10:19
samuelkunkel[m]If I adjust the conditions in _check_mem_encryption_uses_uefi_image (basically if the image is just plain and does not contain any information at all) I just return (basically mocking that we use uefi here)10:25
samuelkunkel[m]then it works properly10:26
bauzasgibi: I may have spotted some eventlet threading issue https://paste.opendev.org/show/bFU6z82FyLG12FKMJzdN/10:33
gibibauzas: ack, I have some backlog work through so I haven't looked at the result from that yet. If you can identify the leaking test based on the new log the you can run that tests multiple times in the same executor by duplicating the test case to see if it helps reproducing locally10:40
bauzasgibi: for the moment, we don't have a lot of issues with it10:41
bauzasgibi: so if I have time, yeah I'll try to reproduce it10:41
bauzasgibi: (it was just for telling it for you ;) )10:42
gibithanks10:42
opendevreviewAlexey Stupnikov proposed openstack/nova stable/train: Test aborting queued live migration  https://review.opendev.org/c/openstack/nova/+/87357810:56
opendevreviewAlexey Stupnikov proposed openstack/nova stable/train: Test aborting queued live migration  https://review.opendev.org/c/openstack/nova/+/87357810:58
opendevreviewAlexey Stupnikov proposed openstack/nova stable/train: Add functional tests to reproduce bug #1960412  https://review.opendev.org/c/openstack/nova/+/87357911:01
opendevreviewAlexey Stupnikov proposed openstack/nova stable/train: Test aborting queued live migration  https://review.opendev.org/c/openstack/nova/+/87357811:52
opendevreviewAlexey Stupnikov proposed openstack/nova stable/train: Test aborting queued live migration  https://review.opendev.org/c/openstack/nova/+/87357812:13
opendevreviewAlexey Stupnikov proposed openstack/nova stable/train: Test aborting queued live migration  https://review.opendev.org/c/openstack/nova/+/87357812:28
*** artom_ is now known as artom12:31
artombauzas, actually let me ask here - do we have an etherpad for Bobcat already? I want to have a cross-project with the Manilla folks about what we need for Uggla's virtiofs attach feature12:32
artom*Bobcat PTG, I should say12:32
bauzasartom: yes we have12:33
bauzashttps://etherpad.opendev.org/p/nova-bobcat-ptg12:33
artomCheers!12:34
bauzasManila* dude12:35
bauzasnot the town :p12:35
bauzashttps://docs.openstack.org/manila/latest/12:35
bauzaswtf, are we using cirros-0.6.1 in nova-ceph-multistore jobs ?12:48
bauzashmm no12:49
bauzashmmm, yes12:50
bauzas 2023-02-17 09:45:15.491046 | controller | === cirros: current=0.6.1 uptime=103.58 ===12:50
bauzashttps://f89b63837ed61d9739ac-76da2058f7382f685ecdff725a6049b3.ssl.cf1.rackcdn.com/821228/7/check/nova-ceph-multistore/6617ac9/job-output.txt12:50
bauzasdespite the image being 0.5.212:50
* bauzas is lost 12:50
kashyapbauzas: So you're saying the image is 0.5.2, but it logs it as 0.6.1?12:56
bauzaskashyap: the guest console, yes13:22
bauzasand it uses the dhcpcd client for getting the lease13:22
* bauzas just checking the kernel version difference between cirros 0.5.2 and 0.6.113:23
bauzas"use Ubuntu 22.04 (5.15) kernels for aarch64, arm, ppc64le, x86_64"13:24
opendevreviewSamuel Kunkel proposed openstack/nova master: fix: handle missing img properties  https://review.opendev.org/c/openstack/nova/+/87424813:24
bauzascompared to 0.5.0 "Linux kernel 5.3.0-26.28~18.04.1 for aarch64, arm, i386, ppc64le, x86_64 (Ubuntu 18.04 HWE)"13:25
samuelkunkel[m]please have a look and provide me some feedback if the approach is correct. With that "fix" everything works properly for deploying AMD SEV13:25
bauzasso, yeah the guest that was booted was using 0.6.113:25
bauzas2023-02-17 09:45:15.450272 | controller | [    0.000000] Linux version 5.15.0-48-generic (buildd@lcy02-amd64-080) (gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #54-Ubuntu SMP Fri Aug 26 13:26:29 UTC 2022 (Ubuntu 5.15.0-48.54-generic 5.15.53)13:26
bauzassamuelkunkel[m]: I'm not really knowing about AMD SEV but I'll try to review your change13:26
kashyapbauzas: Hmm, thx for the kernel comparision.13:29
samuelkunkel[m]thanks bauzas  I am also not that familiar but I tried to describe the implications13:30
kashyapbauzas: I see the code from samuelkunkel[m] is not in core SEV functionality itself, but in sched/utils13:31
kashyapsamuelkunkel[m]: What triggerred this change?  Would be useful if you could write-up a small bug report / tracker13:32
samuelkunkel[m]I can write up a bug report13:34
samuelkunkel[m]yes, its with in the scheduler utils but its triggert by the AMD SEV implementation13:34
samuelkunkel[m]This fix "could" (in a somewhat similar way) also be moved to the memory encryption section13:35
samuelkunkel[m]e.g. directly into _check_mem_encryption_uses_uefi_image where its triggered13:35
kashyapsamuelkunkel[m]: I see, then what made you move it scheduler/utils?   If it could be dealt with in nova/virt/hardware.py)13:37
kashyapThanks for writing it!  (And link it in the commit message on your next respin, plese)13:38
opendevreviewKashyap Chamarthy proposed openstack/nova stable/wallaby: Add a workaround to skip hypervisor version check on LM  https://review.opendev.org/c/openstack/nova/+/85120613:41
opendevreviewKashyap Chamarthy proposed openstack/nova stable/wallaby: libvirt: At start-up rework compareCPU() usage with a workaround  https://review.opendev.org/c/openstack/nova/+/87240213:41
opendevreviewAndre Aranha proposed openstack/nova stable/yoga: [stable-only] Test setting the nova job to centos-9-stream  https://review.opendev.org/c/openstack/nova/+/86008713:59
opendevreviewAndre Aranha proposed openstack/nova stable/yoga: [stable-only] Test setting the nova job to centos-9-stream  https://review.opendev.org/c/openstack/nova/+/86008714:00
opendevreviewAndre Aranha proposed openstack/nova stable/yoga: [stable-only] Test setting the nova job to centos-9-stream  https://review.opendev.org/c/openstack/nova/+/86008714:00
*** dasm|off is now known as dasm14:11
samuelkunkel[m]https://bugs.launchpad.net/nova/+bug/200769714:27
samuelkunkel[m]I hope I got everything. I will try to move the fix into the virt/hardware.py. It should not a big issue to just exclude the uefi check if no image informations are present at all14:27
bauzaswas fucking close to get merged https://review.opendev.org/c/openstack/nova/+/872413 :cries:15:22
opendevreviewSamuel Kunkel proposed openstack/nova master: fix: handle missing img properties  https://review.opendev.org/c/openstack/nova/+/87424815:23
gibibauzas: I will look at the etherpad during the weekend and try to recheck-in thigns we already approved15:24
opendevreviewSamuel Kunkel proposed openstack/nova master: fix: handle missing img properties  https://review.opendev.org/c/openstack/nova/+/87424815:24
bauzasgibi: meh, don't do this, you'll waste your weekend time15:24
bauzasI'm trying to merge changes since one week, and about only one change is done15:25
gibibauzas: I will do it as part of any slack time, I won't reorg my weekend around it :)15:25
bauzasmeh15:26
opendevreviewSamuel Kunkel proposed openstack/nova master: fix: amd-sev handle missing img properties  https://review.opendev.org/c/openstack/nova/+/87426415:27
samuelkunkel[m]hope I got it now everything. Reviews appreciated, this approach to the fix also works properly in our setup15:28
opendevreviewAlexey Stupnikov proposed openstack/nova stable/train: Add functional tests to reproduce bug #1960412  https://review.opendev.org/c/openstack/nova/+/87357915:31
opendevreviewAlexey Stupnikov proposed openstack/nova stable/train: Test aborting queued live migration  https://review.opendev.org/c/openstack/nova/+/87357815:40
opendevreviewAlexey Stupnikov proposed openstack/nova stable/train: Test aborting queued live migration  https://review.opendev.org/c/openstack/nova/+/87357816:03
sean-k-mooney samuelkunkel[m]  i dont have time to review that today but i dont think we can just skip it like that16:47
opendevreviewAlexey Stupnikov proposed openstack/nova stable/train: Test aborting queued live migration  https://review.opendev.org/c/openstack/nova/+/87357816:48
samuelkunkel[m]I thought so. No worries - for now it runs just patched in our environment16:56
samuelkunkel[m]just let me know how I can make it better. Next week is enough :)16:56
opendevreviewArtom Lifshitz proposed openstack/nova master: DNM: Try out new flake8  https://review.opendev.org/c/openstack/nova/+/87429619:09
opendevreviewmelanie witt proposed openstack/nova master: doc: Add details about the behavior of server delete  https://review.opendev.org/c/openstack/nova/+/87418819:57
fnordahlfungi: apologies for the tardy response, you would need to add jammy-proposed to your sources.list to get the package before it is promoted to -updates, yes.20:43
fnordahlfungi: once a package is in -proposed it will normally be promoted to -updates within a week or two, but due to the interdependencies between OVS and OVN this specific package will most likely take a bit longer.20:44
fnordahlfungi: once https://launchpadlibrarian.net/646504743/openvswitch_2.17.5-0ubuntu0.22.04.1_source.changes is accepted into -proposed we should have both packages in -updates within a couple of weeks.20:46
fnordahlfungi: the bug to track for that one is https://bugs.launchpad.net/ubuntu/+source/openvswitch/+bug/200306020:46
fungifnordahl: noted, thanks for the details!20:50
fungiso anyone looking for a sooner resolution to the ovn-related job failures may want to have devstack add jammy-proposed to the sources.list temporarily20:51

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!