| sean-k-mooney | gibi: bauzas if you could take a look at this in ye're morning or melwitt if your around https://review.opendev.org/c/openstack/nova/+/867324 | 00:33 |
|---|---|---|
| melwitt | sean-k-mooney: these options don't follow how [workarounds] is supposed to be a False/True do this or don't thing :/ but I see why it's being done | 00:43 |
| sean-k-mooney | i dont wnat to put them in the libvirt section as the workaround they are extending was ment to be deleted eventually | 00:44 |
| sean-k-mooney | and when you use it it "taints" the domain | 00:44 |
| sean-k-mooney | so at least downstream we had to get approval form our virt team to have this not "viod the warrenty" when it comes to support | 00:45 |
| sean-k-mooney | i would be fine with moving them to the libvirt section if the libvirt api we asked for was actully added to libvirt | 00:46 |
| sean-k-mooney | we ask for a top level api to do the exact same thing that did not mark the domain as tainted | 00:46 |
| sean-k-mooney | so if that ever becomes a thing i would be happy to move the optiosn to the libvirt section | 00:46 |
| melwitt | yeah, I saw you mentioned that in the comments. I understand why but it is kinda weird the concept of fine-tuning [workarounds] and I hope that's not going to become a thing | 00:47 |
| sean-k-mooney | you are right about it not just being a bool however. it is still guarded by one however | 00:47 |
| sean-k-mooney | the thing its most similar too is the interval and retires we have for volume detach | 00:48 |
| melwitt | yeah, it's clear it's not a thing that we want to be permanent and why it wouldn't go into the normal configs | 00:48 |
| sean-k-mooney | i did consider just suggesting hardcoding to 3 with a longer interval | 00:49 |
| sean-k-mooney | but they already had the config option when i review for the interval | 00:49 |
| sean-k-mooney | so i kind fo didnt wnat to have anouther patch tweeking this again later | 00:50 |
| sean-k-mooney | https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.device_detach_attempts and https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.device_detach_timeout are the detach/attach options we added that are kind of like it | 00:51 |
| melwitt | yeah, would've been ideal to hardcode it but if it's that fiddly then I see why we wouldn't want to have to do future tweaks to it | 00:51 |
| sean-k-mooney | it kind of sucks that the workaround is needed but ya i expected when we added the orgianal workaround ot not need to do more then one addtional GARP | 00:52 |
| sean-k-mooney | qemu is already doing 3 before we do anything | 00:53 |
| melwitt | ack, I don't think the concept is itself weird, it's that you get a lot of fine-grained tuning for your one workaround 😆 I'm not suggesting blocking it but just saying it looks quite odd to me | 00:53 |
| sean-k-mooney | i agree on the odd but its pargmatic | 00:53 |
| sean-k-mooney | its kind of like shouting at the network to say hay i really reallly really am over here now | 00:54 |
| melwitt | lol :) | 00:54 |
| sean-k-mooney | anyway its like 1am for me so im going to sleep came onlien to check something breilfy and got distracted with geting my email inbox to 0 | 00:55 |
| melwitt | k g'night! o/ | 00:56 |
| sean-k-mooney | o/ | 00:56 |
| *** blarnath is now known as d34dh0r53 | 06:37 | |
| tobias-urdin | eu people might start their day now :) please have a look at getting a release for the CVE out https://review.opendev.org/c/openstack/releases/+/871802 | 07:57 |
| frickler | gibi: bauzas: sean-k-mooney: ^^ I kind of agree with tobias-urdin that there is a bit of urgency behind this. not sure if release team could skip ptl approval in this case, though? | 08:43 |
| kashyap | Is it just me or the "tempest-integrated-compute" is timing out often for others too? | 08:43 |
| bauzas | frickler: I'm here | 08:44 |
| bauzas | frickler: we said we were trying to also merge another CVE fix before we release this | 08:44 |
| bauzas | ok, the other cve bug is fixed down to xena, so yeah, we can have releases | 08:50 |
| * bauzas will look at the change | 08:50 | |
| frickler | that other CVE was https://review.opendev.org/c/openstack/nova/+/859315, right? | 08:56 |
| bauzas | yup, just checked, reviewing now the releases patch | 09:04 |
| bauzas | gibi: frickler: I was torn with the proposed semver of https://review.opendev.org/c/openstack/releases/+/871802 which was doing .y releases but I can live with that | 09:09 |
| bauzas | tobias-urdin: ^ anything in particular you had in mind when you did set the releases for a .y bump ? | 09:10 |
| bauzas | the fact that it was exposing a new conf knob, I guess ? | 09:10 |
| gibi | I'm fine with the minor bump | 09:14 |
| bauzas | that seems a bit agressive but thinking out more, that means that distros have to adapt their toolings if they wanna set the new conf knob | 09:15 |
| bauzas | so yeah a .y bump seems ok | 09:15 |
| bauzas | even if semantically, we're sending a wrong signal | 09:15 |
| gibi | we are removing functionality with a knob by default so I'm OK to y bump it | 09:17 |
| gibi | I double checked it seems both cve is in the release (the vnit_type on was in zed when it was master) | 09:17 |
| gibi | so I think we are good to go | 09:18 |
| tobias-urdin | i pretty much followed cinder that bumped minor, I guess it wouldn't hurt indicating to operations that a minor version that should be upgraded to because of CVE | 09:20 |
| tobias-urdin | but yeah we can change if required, just wanted to make it a priority to release it so downstream can start building stuff new versions as well | 09:20 |
| bauzas | gibi: yeah, checked the other CVE, was my main original driver for the check | 09:20 |
| bauzas | tobias-urdin: no worries, as I said, I can live with that | 09:21 |
| gibi | next is stable/wallaby but that needs the tempest pin first. https://review.opendev.org/q/topic:wallaby-pin-tempest | 09:21 |
| bauzas | in theory a CVE fix doesn't require a y versioning but meh | 09:21 |
| tobias-urdin | bauzas: ack, thanks, i will keep that in mind for the future | 09:21 |
| bauzas | gibi: correct, I +2/+Wd a patch this morning | 09:21 |
| bauzas | tobias-urdin: np, not anyone needs to know anything :) but if you wanna know more about semver, this is the reference page https://docs.openstack.org/pbr/latest/user/semver.html | 09:22 |
| bauzas | gibi: do you know if gmann did the tempest patch ? | 09:23 |
| bauzas | I can check, I just didn't had the time yet | 09:23 |
| gibi | bauzas: here is the tempest pin series https://review.opendev.org/q/topic:wallaby-pin-tempest it needs love | 09:23 |
| bauzas | I can surely provide love | 09:23 |
| gibi | the DNM test patches are failing | 09:23 |
| bauzas | then I guess the love has to be on finding why the DNM patches are failing | 09:24 |
| bauzas | lovely | 09:24 |
| bauzas | that's just 12 hours I haven't looked at zuul files | 09:24 |
| * bauzas grabs a coffee and steps into it | 09:25 | |
| bauzas | mmm | 09:48 |
| bauzas | gibi: does those skipttest exceptions in tempest look correct to you ? | 09:48 |
| bauzas | 2023-01-26 01:06:13.455899 | controller | unittest2.case.SkipTest: Identity api v2 is not enabled | 09:48 |
| bauzas | I have seen gmann rechecking on such errors | 09:48 |
| bauzas | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0a4/871782/2/check/tempest-full-py3/0a42465/job-output.txt | 09:49 |
| gibi | it does not look good, but maybe gmann rechecked on it as he changed one of the depends-ons | 09:49 |
| bauzas | I just asked for a recheck | 09:50 |
| bauzas | on the devstack patch | 09:50 |
| bauzas | anyway, the changes themselves on both tempest and devstack seem logic to me | 09:51 |
| gibi | we will see | 09:51 |
| bauzas | so I guess this is just a transient issue | 09:51 |
| bauzas | at least keystone was running | 09:52 |
| sahid | o/ sean-k-mooney, bauzas I have noticed your new comments | 09:53 |
| sahid | working on it ! | 09:53 |
| sahid | thanks | 09:53 |
| bauzas | sahid: thanks | 09:54 |
| bauzas | sahid: ping me when you're done with those, and I'll rereview | 09:54 |
| sean-k-mooney[m] | the rpc pin case is not something i orginally tought of but i dont think its a large change to just make sure we dont retrun a 500 from the api and add a test for that so hopefully it wont take too much to adress that | 09:55 |
| bauzas | sahid: to clarify, sorry but you don't need to change the RPC client, just make sure that on the API you can verify it | 09:55 |
| sean-k-mooney[m] | yep so add a functional test that pins to 6.0 | 09:56 |
| sean-k-mooney[m] | use the new microversion | 09:56 |
| sean-k-mooney[m] | and assert an excption is raised | 09:56 |
| sean-k-mooney[m] | ideally it should be a 409 | 09:56 |
| sean-k-mooney[m] | the same as when the compute is not upgraded | 09:57 |
| sean-k-mooney[m] | you should not expose the crrent RPC pin in the excption | 09:57 |
| sean-k-mooney[m] | just that the could does not meet the requirements for the new microversion and you should use the old one like the other exception | 09:58 |
| sean-k-mooney[m] | bauzas actully is there any reason not to use the same excpetion here as in the api when the compute service is to low | 09:59 |
| bauzas | good question | 10:00 |
| bauzas | problem is, evacuation is defined by policy, right? | 10:00 |
| sean-k-mooney[m] | i guess its and admin api and they might want to know but if they manually pinned. perhapse its diffent admins that do upgrade vs day to day | 10:00 |
| sean-k-mooney[m] | well all apis are controlable by policy | 10:01 |
| bauzas | so you can change the policy to have evacuation (without a host param) be supported for endusers | 10:01 |
| bauzas | if so, we could return something like 'sorry, compute service is too low' | 10:01 |
| sean-k-mooney[m] | you could | 10:01 |
| bauzas | I don't know whether it would be a problem for our operators then | 10:01 |
| kashyap | This timeout is blocking a couple of patches. /me is trying to find where exactly is the time_out -- https://zuul.opendev.org/t/openstack/build/453f991eeeb34498b132eb84de3301db/logs | 10:01 |
| sean-k-mooney[m] | sound like just a slow node to be honest | 10:02 |
| sean-k-mooney[m] | and that job might be hitting up agagisnt the timeout anyway but lests see what the normal runtime is | 10:03 |
| kashyap | So only a full recheck is the only option? :( | 10:03 |
| kashyap | (Already did it once) | 10:03 |
| sean-k-mooney[m] | normally 90 mins or so | 10:03 |
| kashyap | sean-k-mooney[m]: For the full recheck? | 10:03 |
| sean-k-mooney[m] | that job normally takes 90 mins | 10:04 |
| sean-k-mooney[m] | https://zuul.opendev.org/t/openstack/builds?job_name=tempest-integrated-compute&project=openstack/nova | 10:04 |
| sean-k-mooney[m] | there have been 5 time outs in the last 300 runs of that job | 10:05 |
| sean-k-mooney[m] | the 3 time outs are form 4 providers so i dont really see any corralation | 10:10 |
| sean-k-mooney[m] | it would be good to see if there is anything odd in the devstack or tempet runs | 10:10 |
| sean-k-mooney[m] | but something took more time then normal | 10:10 |
| sean-k-mooney[m] | so yes a recheck is the way to proceed but it would be good to see if say a lot of swap was used or an image/pacakge download was slow | 10:11 |
| sean-k-mooney[m] | looking at a passing run vs failing devstack too ~900 seconds vs ~1200 | 10:18 |
| sean-k-mooney[m] | its seams to be pretty even across apt install pip install and osc | 10:19 |
| sean-k-mooney[m] | so i think this is diskio or just general cpu/disk/net performace related | 10:19 |
| sean-k-mooney[m] | if the devstack install is 33% slower the tempest execation will likely be similarly reduced in perfromace | 10:20 |
| sean-k-mooney[m] | and a normal run is at 75% of the build limit so it cant really tollerate that much of a slow down | 10:20 |
| sahid | bauzas, sean-k-mooney[m] humm i may missing somethinhg, this is not what you are looking for? https://review.opendev.org/c/openstack/nova/+/858384/34/nova/tests/unit/api/openstack/compute/test_evacuate.py#431 | 10:26 |
| sahid | that is when using microversion 2.95 with a hosts that are not fully upgraded | 10:27 |
| sean-k-mooney[m] | no | 10:27 |
| sean-k-mooney[m] | that is pininng the min compute service version | 10:27 |
| sean-k-mooney[m] | we were talking about the rpc version pin | 10:27 |
| sean-k-mooney[m] | the ones you pin in https://docs.openstack.org/nova/latest/configuration/config.html#upgrade-levels | 10:28 |
| sean-k-mooney[m] | so [upgrade_levels]/compute=6.0 | 10:29 |
| bauzas | sahid: the missing unittest I was referring was to verify that you return an exception if you set the parameter and call a old compute | 10:30 |
| bauzas | sahid: for the functest in the other change (the microversion one), yeah, what sean-k-mooney said | 10:31 |
| sahid | bauzas: this part? https://review.opendev.org/c/openstack/nova/+/858383/25/nova/compute/manager.py#3831 | 10:32 |
| bauzas | sahid: no sorry | 10:33 |
| bauzas | sec | 10:33 |
| bauzas | sahid: in https://review.opendev.org/c/openstack/nova/+/858383/25/nova/compute/rpcapi.py#1108 | 10:33 |
| bauzas | sahid: you return an exception | 10:33 |
| bauzas | and I'm eventually OK with it (sorry for the comments) | 10:34 |
| bauzas | sahid: butn | 10:34 |
| bauzas | sahid: I don't see any unittests for verifying the RPC call | 10:36 |
| sahid | yes good point | 10:36 |
| bauzas | and we also need to have unittests for the conductor RPC API, unfortunately :( | 10:37 |
| bauzas | sahid: sec, will find you where we have unittests for both | 10:37 |
| bauzas | sahid: one example of a simple unittest for testing it https://github.com/openstack/nova/blob/master/nova/tests/unit/conductor/test_conductor.py#L4734-L4752 | 10:42 |
| bauzas | gosh, our tests are so horrible to read :( | 10:43 |
| bauzas | https://github.com/openstack/nova/blob/master/nova/tests/unit/conductor/test_conductor.py#L4754-L4788 are also good examples | 10:43 |
| bauzas | just add two checks there and I'm all good (for the conductor API) | 10:43 |
| bauzas | (even if we apparently missed the other version checks...) | 10:43 |
| sahid | working on it! thank for you help guys | 10:44 |
| bauzas | sahid: for the compute RPC API, here is the existing test https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_rpcapi.py#L883-L916 | 10:45 |
| bauzas | HTH | 10:45 |
| bauzas | sahid: np, you're next in my review queue once you're all set | 10:45 |
| kashyap | sean-k-mooney[m]: Sorry for my delay, just reading back the scroll of your analysis | 10:51 |
| sean-k-mooney | tl;dr the io on those nodes that timeed out looks like its about 33% slower then normal. we are normally at 75% of the timeout so we dont have the headroom in that case | 10:54 |
| sean-k-mooney | gibi: bauzas can we land gmann's placement service role patch https://review.opendev.org/c/openstack/placement/+/865618 | 11:09 |
| opendevreview | Merged openstack/nova master: Handle InstanceInvalidState exception https://review.opendev.org/c/openstack/nova/+/861738 | 12:41 |
| kashyap | sean-k-mooney: Thanks for the summary. It's nearly 2-ish hours, and still no sign of a vote - https://review.opendev.org/c/openstack/nova/+/870794 | 13:15 |
| sean-k-mooney | its in gate | 13:16 |
| sean-k-mooney | its been runing for 1hr 46mins | 13:16 |
| sean-k-mooney | and tempest-integrated-compute passed already | 13:17 |
| sean-k-mooney | you can watch it here if you like https://zuul.openstack.org/status#870794 | 13:17 |
| kashyap | sean-k-mooney: Thank you :) | 13:21 |
| ierdem | Hi, when I try to cold migrate VMs via cli by specifying destination host, it throws an exception after first migrate "No valid host was found" -no more details, just this message-, but destination host has enough resource. Does nova-scheduler cause this? If is, how can I force it to migrate more than one VMs to the same host? Thanks for all your assistance. (I have kolla-ansible stein-eol) | 13:33 |
| bauzas | gmann: sean-k-mooney: dansmith: sorry, but maybe I'm confused but I thought system readers can scope resources of a deployment. If so, why are we returning HTTP403 on https://review.opendev.org/c/openstack/placement/+/865618 ? | 13:35 |
| * bauzas reads and rereads https://specs.openstack.org/openstack/keystone-specs/specs/keystone/rocky/define-default-roles.html#system-reader and this appears to me Alice should know which resource providers exist, etc. | 13:36 | |
| bauzas | (Alice in the spec, obviously) | 13:36 |
| kashyap | (Third time lucky, the job indeed passed) | 13:37 |
| kashyap | (We'll see if everythig else succeeds.) | 13:38 |
| bauzas | oh wait | 13:38 |
| bauzas | "Alice can list or retrieve specific endpoints. Alice cannot do any project specific operations since her authorization is limited to the deployment system." | 13:38 |
| bauzas | including list, IIRC | 13:38 |
| sean-k-mooney | bauzas: we are remvoing system reader form the placment polices | 13:43 |
| sean-k-mooney | for most project we are geting rid fo scope entirly based on operator feedback in yoga? | 13:44 |
| * bauzas is lost in translation | 13:45 | |
| bauzas | but okay | 13:46 |
| bauzas | I can understand we restrict the roles then | 13:46 |
| * bauzas wishes we have some docs about roles which isn't a rocky spec | 13:46 | |
| bauzas | and which can be updated as long as we implement the features | 13:46 |
| opendevreview | Merged openstack/nova master: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/870794 | 13:48 |
| kashyap | Christ, it merged at last | 13:50 |
| gibi | kashyap: it wasn't that long:) | 13:53 |
| kashyap | gibi: You're right though. I tend to be a bit of a drama queen sometimes; please ignore me :) | 13:53 |
| kashyap | gibi: Thank you both for the help! Now hope the API replacement patch goes through soon | 13:54 |
| bauzas | sean-k-mooney: any docs you could point me out on the new direction for system roles ? | 13:54 |
| kashyap | (Thanks, sahid for rechecking it while I was away :)) | 13:54 |
| sean-k-mooney | bauzas: gmann might have the links more redilaly but i think we updated the goal with it too | 13:56 |
| sean-k-mooney | bauzas: like this was a very very big thing that we have talked about before | 13:56 |
| sean-k-mooney | https://github.com/openstack/governance/commit/1909d4f7a0dc2920fc04ab5bfac112a671547cee | 13:56 |
| bauzas | " In yoga cycle, we redefined this goal with the changes mentioned above so that allowing system administrators to access system level resources APIs only and allow project users to access project-level resource APIs. These changes have been done for nova and neutron. " | 13:56 |
| bauzas | sean-k-mooney: problem is, sometimes my brain splits | 13:57 |
| sean-k-mooney | it was actully in zed | 13:57 |
| bauzas | so it looks to me I probably heard about it, but then it wasn't ringing the bell in my brain when I saw today's change | 13:57 |
| sean-k-mooney | well it depnes but that commit has the relevent info in it | 13:57 |
| sahid | kashyap: sure :-) | 14:01 |
| *** dasm|off is now known as dasm | 14:03 | |
| sean-k-mooney | kashyap: now all you have to do is backport it all the way to train and then cerry pick it downstream :P | 14:10 |
| sean-k-mooney | so for 2 patchs that only 20 ish commits to create and review | 14:11 |
| sean-k-mooney | with that said im not sure we need to backport the second patch | 14:11 |
| sean-k-mooney | the frist we should but using the new api is less imporant | 14:12 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/zed: Remove deleted projects from flavor access list https://review.opendev.org/c/openstack/nova/+/870053 | 14:18 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | 14:26 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | 14:26 |
| sahid | ^ fixed compute part, and owrking on the API one | 14:27 |
| sahid | for the API part, is a BadRequest returned sounds good? in case that the rpc is not right and user is using new version? | 14:29 |
| sahid | or do you have in mind an other http status? | 14:30 |
| sahid | sean-k-mooney, bauzas ^ if you have a sec | 14:30 |
| bauzas | sahid: we agreed yesterday on returning a HTTP409 Conflict | 14:31 |
| sahid | ack | 14:31 |
| bauzas | I think we have existing exceptions that do those | 14:31 |
| sean-k-mooney | we do | 14:46 |
| sean-k-mooney | we use 409 conflict anythime we dont meet the required min compute service version and in a few other cases | 14:46 |
| sean-k-mooney | we used to have a mix of code but we normalised on 409 about 3 cyles ago | 14:46 |
| sean-k-mooney | it used to be diffent between pmem cyborg, numa/sriov migrations ectra | 14:47 |
| kashyap | sean-k-mooney: Heh, on the backports ... I need a bit of a breather for a few hours first from it | 14:49 |
| sean-k-mooney | no worries but please propose them upstream before the downstream ones so we get the ci coverage | 14:49 |
| kashyap | Ah, definitely | 14:50 |
| kashyap | How far back we wanna go upstream? | 14:50 |
| sean-k-mooney | so 16 is train if you want to go to 16 downstream then please do it upstream to trian too | 14:51 |
| sean-k-mooney | if this is just for 17/wallaby you can stop there | 14:51 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | 14:51 |
| sean-k-mooney | this change shoudl be pretty safe to backprot and i dont really expect confligt | 14:52 |
| kashyap | Yep | 14:52 |
| sean-k-mooney | so hopefully its simple to do | 14:52 |
| kashyap | I only wonder about the small logical change of the switch to using _get_cpu_model_mapping() | 14:54 |
| sean-k-mooney | not using that in my view was an existing bug that shoudl have been fixed anyway | 14:55 |
| sean-k-mooney | so i think its ok | 14:55 |
| sean-k-mooney | we can see what elodilles thinks | 14:55 |
| sean-k-mooney | or other stable cores when the first review is up | 14:55 |
| sahid | sean-k-mooney, bauzas ok so i fixed the tests on compute and conductor, and changed the s/NovaException/... then i fixed REST API + tests with a HTTPConflict | 14:56 |
| sean-k-mooney | sahid++ | 15:00 |
| sean-k-mooney | i am just joinging a call but ill look when im free | 15:00 |
| sahid | sean-k-mooney: cool thanks you, but let me ping you when CI is green, no need that you lost your time if something fails that i have not noticed ;) | 15:01 |
| sean-k-mooney | sure im in calls for the hour or two | 15:03 |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: Add functional tests to reproduce bug #1994983 https://review.opendev.org/c/openstack/nova/+/863416 | 15:20 |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: Log some InstanceNotFound exceptions from libvirt https://review.opendev.org/c/openstack/nova/+/863665 | 15:20 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/845753 | 15:38 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/845754 | 15:38 |
| gmann | bauzas: gibi: for tempest pin on wallaby, skiptest exception is due to incompatible version of stestr in constraints. I am checking it with what tempest version work on wallaby stestr constraint. | 16:45 |
| bauzas | gmann: ack thanks | 16:46 |
| gmann | bauzas: for placement rbac system scope, in zed cycle direction of RBAC we have decided to drop the system scope from services that is why every policy is made to project scoped https://github.com/openstack/governance/commit/1909d4f7a0dc2920fc04ab5bfac112a671547cee | 16:46 |
| gibi | gmann: thanks | 16:46 |
| bauzas | gmann: yup, my brain dumped this | 16:46 |
| bauzas | sahid: you made a wrong assumption when writing the conductor unittest https://review.opendev.org/c/openstack/nova/+/858383/26/nova/tests/unit/conductor/test_conductor.py#4775 | 16:57 |
| bauzas | the test should pass with the call be accepted without this parameter | 16:57 |
| sahid | bauzas: hum let me check | 17:00 |
| sahid | hum right we should not raise an exception here, I have done that too fast and for some reason when i have executed them locally i did not noticed.. | 17:03 |
| sahid | bauzas: have you noticed something else that I can fix in that same time> | 17:03 |
| sahid | ? | 17:03 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | 17:11 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | 17:11 |
| dansmith | sean-k-mooney: btw I think the stable compute series is ready for serious review and/or merging with two exceptions 1. some nits from gibi I will do as a FUP, and 2. working on trivial unit tests for the top rename patch | 17:30 |
| dansmith | but it passes with the experimental ironic job and everything | 17:31 |
| dansmith | I guess maybe a test patch against ironic to run all their jobs might be prudent, let me get that in the pipe | 17:31 |
| opendevreview | Ghanshyam proposed openstack/placement master: Modify the placement API policies defaults and scope_type https://review.opendev.org/c/openstack/placement/+/865618 | 17:32 |
| opendevreview | Merged openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | 17:50 |
| *** EugenMayer42 is now known as EugenMayer4 | 18:12 | |
| sean-k-mooney | dansmith: i saw gibis review earlier ya and was wondering about the rest of the sereise | 18:27 |
| sean-k-mooney | gibis comment was about using a fixutre right | 18:27 |
| gibi | yeah I had testing nits | 18:29 |
| gibi | nothing serious | 18:29 |
| sean-k-mooney | dansmith: ok ill review the seriese tomorrow. im planning to deploy devstack tomorrow anyway so ill try the stable uuid series after i get that deployed and do a full pass on it | 18:30 |
| dansmith | sean-k-mooney: cool, sounds like a plan thanks | 18:30 |
| dansmith | the ironic test job on top is about half done, all green so far | 18:30 |
| * sean-k-mooney also has not deployed devstack since november... | 18:30 | |
| sean-k-mooney | dansmith: oh you have a dnm patch for that already cool | 18:31 |
| dansmith | yeah I'll paste a link in the last patch when it's done if it looks good | 18:34 |
| sean-k-mooney | dansmith: one thing about the series. i dont see a release note and i dont think you have docs for this do you? | 18:37 |
| dansmith | sean-k-mooney: no and no | 18:37 |
| dansmith | sean-k-mooney: I'll get going on that, but let's not hold up on that, if possible :) | 18:37 |
| sean-k-mooney | ok so maybe another patch on the end for that or put it in the WIP patch | 18:38 |
| sean-k-mooney | i think we can proceed before that i do trust you to write those just something that jumped out at me when i skimmed over the seriese | 18:38 |
| dansmith | I'll put the reno in the current last patch and then docs after yeah | 18:38 |
| sean-k-mooney | cool works for me | 18:38 |
| dansmith | I need to push up the unit tests I have, just waiting for ironic to finish, so reno can go in there and then I'll do the docs after | 18:39 |
| sean-k-mooney | i dont think any of this code really does anything until "Persist existing node uuids locally" so we can proably merge the first three tomrrow gibi is already +2 on those | 18:40 |
| sean-k-mooney | i need to go push something else but i might start on the first 3 this evening | 18:41 |
| dansmith | sure, that sounds good | 18:42 |
| sean-k-mooney | but im only around for another 30 mins or so today then i need to go eat something | 18:42 |
| dansmith | the persist one is also not super impactful, but it does do stuff | 18:42 |
| dansmith | the resource tracker one is where the rubber meets the road for the first time | 18:42 |
| *** EugenMayer46 is now known as EugenMayer4 | 19:04 | |
| opendevreview | Dan Smith proposed openstack/nova master: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | 19:14 |
| opendevreview | Dan Smith proposed openstack/nova master: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | 19:47 |
| opendevreview | Dan Smith proposed openstack/nova master: Fixup patch for stable-compute-uuid series https://review.opendev.org/c/openstack/nova/+/871848 | 19:47 |
| sean-k-mooney[m] | dansmith: i did a first pass i have one or two question later in the series the first 3 should be in the gate | 21:50 |
| dansmith | sean-k-mooney: ack, thanks, I saw the first three, I'll look at the others in a bit or tomorrow | 21:51 |
| gmann | gibi: updated the placement RBAC change https://review.opendev.org/c/openstack/placement/+/865618 | 22:30 |
| opendevreview | Merged openstack/nova master: Add virt/node module for stable uuids https://review.opendev.org/c/openstack/nova/+/863915 | 22:48 |
| opendevreview | Merged openstack/nova master: Pass service ref to init_host(), if exists https://review.opendev.org/c/openstack/nova/+/863916 | 22:48 |
| *** dasm is now known as dasm|off | 23:13 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!