| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | 08:50 |
|---|---|---|
| opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/870794 | 10:28 |
| opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | 10:28 |
| kashyap | sean-k-mooney: --^ Good catch in the workaround patch; addressed your remarks. When you can, lemme know if that looks fine :) | 10:29 |
| sean-k-mooney[m] | sure ill review it now | 10:31 |
| kashyap | sean-k-mooney: Also: the bug reporter from the downstream also tested it on a real machine and it works | 10:31 |
| sean-k-mooney[m] | nice am if you respin add a release note but im +2 on it | 10:33 |
| kashyap | sean-k-mooney: I'm not sure if this warrants a release note? I don't mind adding, though. Thank you! | 10:43 |
| kashyap | gibi: --^ Please have a gander when you can (the WA patch) | 10:43 |
| sean-k-mooney[m] | i like to have release notes for most of the changes we make that might be of interest to operators | 10:44 |
| kashyap | sean-k-mooney: The API replacement patch lost your +2, can you also re-look at it when you can? - https://review.opendev.org/c/openstack/nova/+/869950/9 | 10:44 |
| kashyap | (And also it lost +W due to rebase) | 10:44 |
| sean-k-mooney[m] | sure i tought it still had it when i looked but ill look again | 10:44 |
| kashyap | Thx! | 10:44 |
| sean-k-mooney[m] | +2 was still there it lost +w | 10:45 |
| sean-k-mooney[m] | i have added that but its obviously pendeing the first change having both | 10:45 |
| sean-k-mooney[m] | ok i think its time for coffee brb | 10:50 |
| kashyap | Yeah, it won't merge anyway until the predicated patch is merged | 10:55 |
| ratailor | sean-k-mooney[m], gibi Could you please review https://review.opendev.org/c/openstack/nova/+/852737 and https://review.opendev.org/c/openstack/nova/+/861738 | 11:00 |
| sean-k-mooney | ratailor: i started looking at that yesterday actully i just got pulled into other discussions | 11:09 |
| ratailor | sean-k-mooney, ack. np. Thanks! | 11:10 |
| opendevreview | Merged openstack/nova stable/zed: Correct config help message related options https://review.opendev.org/c/openstack/nova/+/871247 | 11:18 |
| opendevreview | Merged openstack/nova stable/train: func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/c/openstack/nova/+/865382 | 11:45 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | 12:14 |
| sean-k-mooney | bauzas: ^ can you look at shaid's seriese i think its ready to go | 13:04 |
| sean-k-mooney | zuul is still running on the last revision but the func test fix was trivial so i expect it to pass | 13:05 |
| sean-k-mooney | dansmith: can you send this on its way https://review.opendev.org/c/openstack/nova/+/865071 that the last patch for the new defaults | 13:08 |
| bauzas | sean-k-mooney: was on my todolist | 13:29 |
| bauzas | btw. thanks for the first thoughts on my series | 13:30 |
| sean-k-mooney | more or less it made sense to me | 13:30 |
| sean-k-mooney | i just needed to figure out how you had it split up | 13:31 |
| bauzas | sean-k-mooney : the 3rd patch was too large for the CI | 13:32 |
| bauzas | hence the split | 13:32 |
| sean-k-mooney | so i can generate a smaller set of files for you if you like | 13:33 |
| sean-k-mooney | many of the files in that are not used | 13:33 |
| sean-k-mooney | if you look you are only using a small subset of sysfs currenly | 13:33 |
| sean-k-mooney | and most of the fiels are symlinks | 13:34 |
| bauzas | yep I know | 13:35 |
| bauzas | like in general sysfs btw ;-) | 13:36 |
| sean-k-mooney | yep | 13:36 |
| sean-k-mooney | it took a while to figureout how to make a copy that worked the same | 13:37 |
| sean-k-mooney | if i rememebr correctly my first attempt flatened the symlinks and resulted in things getting out of sync | 13:37 |
| *** dasm|off is now known as dasm | 13:58 | |
| opendevreview | Jorge San Emeterio proposed openstack/nova master: [DNM] Testing effects on privsep on a build. https://review.opendev.org/c/openstack/nova/+/871607 | 14:04 |
| opendevreview | Jorge San Emeterio proposed openstack/nova master: [DNM] Testing effects on privsep on a build. https://review.opendev.org/c/openstack/nova/+/871607 | 14:05 |
| dansmith | sean-k-mooney: yep | 14:56 |
| opendevreview | Dan Smith proposed openstack/nova master: Check VMDK create-type against an allowed list https://review.opendev.org/c/openstack/nova/+/871612 | 15:01 |
| opendevreview | Dan Smith proposed openstack/nova master: Check VMDK create-type against an allowed list https://review.opendev.org/c/openstack/nova/+/871612 | 15:01 |
| opendevreview | Dan Smith proposed openstack/nova stable/zed: Check VMDK create-type against an allowed list https://review.opendev.org/c/openstack/nova/+/871616 | 15:02 |
| opendevreview | Dan Smith proposed openstack/nova stable/xena: Check VMDK create-type against an allowed list https://review.opendev.org/c/openstack/nova/+/871622 | 15:03 |
| opendevreview | Dan Smith proposed openstack/nova stable/yoga: Check VMDK create-type against an allowed list https://review.opendev.org/c/openstack/nova/+/871624 | 15:03 |
| dansmith | bauzas: your help on these quickly is appreciated ^ | 15:03 |
| bauzas | dansmith: kk, I've seen it before | 15:05 |
| bauzas | sean-k-mooney: dansmith: I have a bit thoughts on upgrades for sahid's new API microversion https://review.opendev.org/c/openstack/nova/+/858384 | 15:06 |
| bauzas | dansmith: +2d the master one | 15:06 |
| sean-k-mooney | evacuate will work but not with the latest microverion until you are fully upgraded | 15:12 |
| sean-k-mooney | so the only way around that is a new paramater in the api | 15:13 |
| bauzas | sean-k-mooney: I know, see my comments | 15:13 |
| dansmith | wow, that patch | 15:13 |
| bauzas | sean-k-mooney: my only comment is to say we should at least explain it more | 15:13 |
| sean-k-mooney | but that kind of defeats the idea of always pwowering off unless the new parmater default to powering off if not set | 15:13 |
| sean-k-mooney | bauzas: is the concern mainly for nova-client | 15:14 |
| bauzas | sean-k-mooney: sure, and again, I'm not *against* the new behaviour | 15:14 |
| sean-k-mooney | openstack client need explcit opt in | 15:15 |
| sean-k-mooney | baiscally im wondiering are you ok with just docs | 15:15 |
| bauzas | sean-k-mooney: my only concern is that IMHO we don't really explain it correctly, at least we need an upgrade section | 15:15 |
| sean-k-mooney | or do you want a design change | 15:15 |
| sean-k-mooney | ok so you would like better docs and beeter release note to call that out | 15:15 |
| bauzas | sean-k-mooney: at least I can accept the new behaviour, but I want to make sure that people know it | 15:16 |
| bauzas | as you said, by default OSC will return an exception if you evacuate an instance on Antelope without upgrading all computes | 15:16 |
| sean-k-mooney | no | 15:16 |
| sean-k-mooney | by default it will evacuate | 15:16 |
| sean-k-mooney | because it does not use the latest microverions | 15:16 |
| sean-k-mooney | its only an issue for nova client which woudl use the latest microversion automatically | 15:17 |
| bauzas | I thought that now OSC defaults to the latest | 15:17 |
| sean-k-mooney | nope | 15:17 |
| sean-k-mooney | 2.1 | 15:17 |
| bauzas | sean-k-mooney: this is an issue for any client asking the latest | 15:17 |
| sean-k-mooney | if you want anything else you have to choose it by env var, cli flag or in your clouds.yaml | 15:17 |
| bauzas | point. | 15:17 |
| bauzas | hence me saying I'm OK (again, see my comments) | 15:18 |
| sean-k-mooney | bauzas: right which we tell them not to do to avoid this exact type of issue | 15:18 |
| bauzas | but we correctly need to document it | 15:18 |
| sean-k-mooney | sure | 15:18 |
| sean-k-mooney | tottaly fine wiht adding more docs | 15:18 |
| bauzas | and having a better returned exception | 15:18 |
| sean-k-mooney | we can explictly say use a microversion before X (2.95?) to evacuate until upgades are complete | 15:19 |
| bauzas | like "heh, we don't accept your parameters for the new feature" doesn't really explain *why* the exception was returned | 15:19 |
| bauzas | sean-k-mooney: true, that's what I'm asking | 15:19 |
| sean-k-mooney | this is also an adming only api so the impact is much less | 15:19 |
| bauzas | again, I've said it : it's admin-only hence why I'm OK | 15:20 |
| sean-k-mooney | but we still need to tell them about it so ya | 15:20 |
| bauzas | if this was an enduser API, then definitely -1 and asking for another design | 15:20 |
| bauzas | because endusers don't know the environment was upgraded | 15:20 |
| sean-k-mooney | im not sure i would agree | 15:21 |
| bauzas | and actually, even API admins couldn't be knowing itr | 15:21 |
| sean-k-mooney | but i would say if that how you felt giving that feedback now instead of in the spec review is unfortunet | 15:21 |
| bauzas | sometimes, environment operators and API admins are different people | 15:21 |
| bauzas | sean-k-mooney: again, I'm not against the desing | 15:21 |
| bauzas | we discussed it at the PTG | 15:21 |
| bauzas | and the spec was there, agreed | 15:22 |
| sean-k-mooney | we did and the spec had 4 +2s too | 15:22 |
| bauzas | I'm just explaining that this could have been different if the API was enduser, that's it | 15:22 |
| bauzas | and see "could" | 15:22 |
| bauzas | not saying I would disagree | 15:22 |
| sean-k-mooney | we have microversion to allow this so we could but i dont think we should even for an end user api | 15:22 |
| sean-k-mooney | anyway lets work on the release note and excetion message so | 15:23 |
| bauzas | anyway, I think we both agree : it needs a better explanation | 15:23 |
| sean-k-mooney | thanks for taking a look | 15:23 |
| sean-k-mooney | yep | 15:23 |
| dansmith | no, it's already +2 | 15:25 |
| dansmith | https://review.opendev.org/c/openstack/nova/+/871612 | 15:25 |
| dansmith | whoops | 15:25 |
| sean-k-mooney | differnt patch :) | 15:25 |
| dansmith | wrong window, sorry | 15:26 |
| sean-k-mooney | shall i send that through the gate given what it is | 15:26 |
| dansmith | I would | 15:26 |
| sean-k-mooney | on its way | 15:27 |
| sean-k-mooney | brb | 15:28 |
| bauzas | as a reminder, nova meeting in 7 mins | 15:53 |
| * bauzas rushes to amend the agenda | 15:54 | |
| bauzas | #startmeeting nova | 16:00 |
| opendevmeet | Meeting started Tue Jan 24 16:00:18 2023 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'nova' | 16:00 |
| bauzas | hey everyone | 16:00 |
| dansmith | o/ | 16:01 |
| gibi | o/ | 16:01 |
| bauzas | I guess we can start, as we can make it quick | 16:01 |
| bauzas | #topic Bugs (stuck/critical) | 16:02 |
| elodilles | o/ | 16:02 |
| bauzas | #info One Critical bug | 16:02 |
| bauzas | same than last week | 16:02 |
| bauzas | #link https://bugs.launchpad.net/nova/+bug/2002951 | 16:02 |
| bauzas | AFAICT, gibi's skip patch is now merged, so we can put it to High | 16:03 |
| bauzas | fine ? | 16:03 |
| bauzas | dansmith's series is on the fly | 16:03 |
| gibi | fine | 16:03 |
| bauzas | #link https://review.opendev.org/c/openstack/tempest/+/870974 skipping now the failing test | 16:03 |
| bauzas | #link https://review.opendev.org/c/openstack/tempest/+/871000 proposal for fixing the test issue | 16:04 |
| bauzas | dansmith: can I review it ? looks so | 16:04 |
| dansmith | bauzas: you can review whatever you want :) | 16:05 |
| bauzas | excellenbt | 16:05 |
| dansmith | but yeah need gmann and kopecmartin to hit that I think | 16:05 |
| bauzas | yup, can't +2 tempest | 16:05 |
| dansmith | oh, | 16:05 |
| dansmith | I need to unskip so he can see, I'll do that after this | 16:05 |
| bauzas | ok, I can hold then | 16:06 |
| bauzas | moving on | 16:06 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 26 new untriaged bugs (-1 since the last meeting) | 16:07 |
| bauzas | thanks gibi for the triage, any bug you wanted to raise ? | 16:07 |
| gibi | bauzas: I triaged ~5 bugs, nothing serious popped up | 16:07 |
| bauzas | cool | 16:08 |
| * gibi had not enough time for triage | 16:08 | |
| bauzas | I think we can easily put the number down when I look at the open ones | 16:08 |
| bauzas | gibi: no worries | 16:09 |
| bauzas | easy transition : | 16:09 |
| bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:09 |
| bauzas | melwitt: are you around ? | 16:09 |
| bauzas | she's the next in the roster | 16:09 |
| bauzas | looks not | 16:10 |
| bauzas | no worries, I'll try to reach her later | 16:10 |
| bauzas | #topic Gate status | 16:10 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:10 |
| bauzas | so the gate is still a bit funky | 16:10 |
| dansmith | yeah | 16:10 |
| dansmith | lots of sporadic fails still | 16:10 |
| bauzas | https://bugs.launchpad.net/nova/+bug/2002782 needs help | 16:11 |
| bauzas | I'll try to add more logs in some DNM to try to see whether we have more explanations | 16:11 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | 16:11 |
| bauzas | anything people wanna discuss about it ? | 16:12 |
| gibi | I have no extra input to it | 16:12 |
| bauzas | gibi: I've seen you updated the bug report, thanks | 16:12 |
| gibi | no worries | 16:12 |
| gibi | that was part of my triage round | 16:13 |
| bauzas | I just triaged it to Confirmed/High fwiw | 16:13 |
| gibi | ack | 16:13 |
| gibi | I did not want to triage my one bug | 16:14 |
| Uggla | o/ | 16:14 |
| bauzas | https://zuul.openstack.org/builds?job_name=nova-tox-functional&job_name=nova-tox-functional-py310&project=openstack%2Fnova&skip=0 | 16:14 |
| bauzas | this is wedgy | 16:14 |
| bauzas | but at least the gate isn't hold | 16:14 |
| bauzas | (assuming we have true positives in that list) | 16:14 |
| gibi | filtering that to the gate pipeline is a bit better | 16:15 |
| bauzas | true, it avoids the true positives | 16:15 |
| gibi | but that does not show patches that are good but fail on check | 16:15 |
| gibi | so meh | 16:15 |
| bauzas | ideally, we should filter on the right exception :) | 16:15 |
| bauzas | hence not with zuul :) | 16:16 |
| bauzas | but meh, moving on | 16:16 |
| gibi | yeah yeah | 16:16 |
| gibi | :) | 16:16 |
| bauzas | hear hear | 16:16 |
| bauzas | all periodic jobs turn green this week \o/ | 16:16 |
| bauzas | https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly | 16:16 |
| bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:17 |
| bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:17 |
| bauzas | and as a reminder | 16:17 |
| bauzas | #info STOP DOING BLIND RECHECKS aka. 'recheck' https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures | 16:17 |
| bauzas | I haven't looked at the percentage number of blind rechecks since last year | 16:17 |
| bauzas | but hopefully, should be super small given I say it literally everyweek, eh ? | 16:18 |
| gibi | I did 0 blind one an a ton of proper one :) | 16:18 |
| * bauzas just hopes anyone working on Nova reads the meeting minutes | 16:18 | |
| bauzas | :) | 16:18 |
| gibi | so at least the statistic will be nice :) | 16:18 |
| sean-k-mooney | maybe | 16:18 |
| sean-k-mooney | you put the messasge on the next line a few times | 16:18 |
| sean-k-mooney | not sure if the script takes that into account | 16:19 |
| sean-k-mooney | you did provide a reason in all the ones i saw | 16:19 |
| * bauzas actually wonders how many of our contributors know we have a weekly meeting, but I side-track | 16:19 | |
| bauzas | moving on | 16:19 |
| bauzas | #topic Release Planning | 16:19 |
| gibi | sean-k-mooney: good point, the issue is we have multiple failed jon in a single run :) | 16:19 |
| bauzas | #link https://releases.openstack.org/antelope/schedule.html | 16:19 |
| bauzas | #info Antelope-3 is in 3 weeks | 16:19 |
| bauzas | #link https://blueprints.launchpad.net/nova/antelope All accepted blueprints for 2023.1 | 16:20 |
| bauzas | use this loudly ^ | 16:20 |
| bauzas | as a reminder, not all blueprints have specs, so this is the single source of truth for the featurefreeze | 16:20 |
| bauzas | and I have a question | 16:21 |
| bauzas | should I somehow put something explicit against blueprints that have API impact (ie. a microversion support) ? | 16:21 |
| bauzas | in order to ease people's thoughts on what to review | 16:21 |
| bauzas | my proposal would be to use the Priority flag which is honestly not in use today | 16:22 |
| bauzas | I can't add tags on a blueprint | 16:22 |
| sean-k-mooney | i think we have 3 with api changes | 16:22 |
| sean-k-mooney | im not sure we should nessisarly priortiese them by default | 16:22 |
| sean-k-mooney | but we could | 16:22 |
| sean-k-mooney | too basd we cant add a generic tags filed in that view | 16:22 |
| bauzas | technically the priority flag would just be a 'flag' for saying this is a api change | 16:22 |
| sean-k-mooney | that is what i would prefer honestly | 16:23 |
| bauzas | I can modify the blueprint name | 16:23 |
| sean-k-mooney | i would perhaps just not track this in launchpad | 16:23 |
| bauzas | by adding some [api] prefix | 16:23 |
| bauzas | if that helps | 16:24 |
| sean-k-mooney | that will break the specs | 16:24 |
| sean-k-mooney | what is show there is the name that is used in the url | 16:24 |
| bauzas | I don't think so | 16:24 |
| sean-k-mooney | not the title | 16:24 |
| sean-k-mooney | we have a tox target | 16:24 |
| bauzas | the link is made on the link, not on the title | 16:24 |
| sean-k-mooney | to move implemtned blueprints in teh specs repot | 16:24 |
| bauzas | I know, I was referring to this script | 16:25 |
| sean-k-mooney | the first one in the list is https://blueprints.launchpad.net/nova/+spec/ephemeral-storage-encryption | 16:25 |
| sean-k-mooney | what we see for bluepint is the bit acter spec/ | 16:25 |
| bauzas | and iirc (because I used it), we map blueprints with specs using the bp link, not the bp title | 16:25 |
| bauzas | we lookup the bp link in the spec file | 16:25 |
| sean-k-mooney | no its based on the name of the file in the specs repo | 16:25 |
| bauzas | and then we pull it | 16:25 |
| sean-k-mooney | we are not parsing it out if i recall | 16:25 |
| bauzas | anyway, let's not discuss that much | 16:26 |
| sean-k-mooney | anyway i woudl prefer not to add [api] to it | 16:26 |
| bauzas | I can do like every cycle and write an etherpad | 16:26 |
| sean-k-mooney | lets just put them in an etherpad | 16:26 |
| sean-k-mooney | yep | 16:26 |
| bauzas | and I guess this is what I'll end up with | 16:26 |
| bauzas | ok | 16:26 |
| bauzas | #action bauzas to create an etherpad for tracking blueprints and their progress | 16:27 |
| bauzas | there we go | 16:27 |
| bauzas | #info As a reminder, Feature Freeze is in 3 weeks, be sure your patches are up to review sooner than later | 16:27 |
| bauzas | moving on | 16:28 |
| bauzas | #topic Review priorities | 16:28 |
| bauzas | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2) | 16:28 |
| bauzas | #info As a reminder, cores eager to review changes can +1 to indicate their interest, +2 for committing to the review | 16:28 |
| bauzas | which is interesting in order to make sure we don't overlap cores's bandwidth by having the vast majority of cores looking at the same feature patches while we're so close to the feature delivery deadline | 16:29 |
| bauzas | this is said. | 16:29 |
| bauzas | #topic Stable Branches | 16:30 |
| bauzas | elodilles: happy to pass the mic to you | 16:30 |
| elodilles | #info stable branches seem to be unblocked / OK back till wallaby | 16:30 |
| elodilles | #info ussuri and train might be broken ('Could not build wheels for bcrypt, cryptography' errors) | 16:30 |
| elodilles | at least i saw some failures like that ^^^ | 16:30 |
| zigo | Can we talk a little bit about CVE-2022-47951 / OSSA-2023-002 ? That's related: I'm trying to backport the patches up to Rocky... | 16:30 |
| elodilles | rocky is End of Life already from nova perspective | 16:31 |
| bauzas | zigo: if you don't mind, let's discuss this properly in the open discussion | 16:31 |
| zigo | Ok. | 16:31 |
| bauzas | elodilles: thanks for thze summaru | 16:32 |
| gibi | isn't that a private bug we should not talk about publicly yet? | 16:32 |
| bauzas | summary* even | 16:32 |
| bauzas | gibi: this is public now | 16:32 |
| dansmith | gibi: public as of an hour ago | 16:32 |
| bauzas | since 1600UTC | 16:32 |
| gibi | dansmith: ahh, OK then | 16:32 |
| zigo | Since 15:00 UTC | 16:32 |
| bauzas | stupid French TZ which confuses me | 16:32 |
| bauzas | elodilles: damn about ussuri and train, ping me tomorrow if you wish, I could try to look at the problems | 16:33 |
| bauzas | sounds vaguely familiar | 16:33 |
| elodilles | bauzas: ack, thanks, I'll try to look into it, too | 16:33 |
| elodilles | though it's not familiar to me O.o | 16:33 |
| bauzas | I'm pretty sure we had the same issues in the past | 16:34 |
| elodilles | anyway, last but not least: | 16:34 |
| elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:34 |
| elodilles | i've added it to the pad ^^^ | 16:34 |
| elodilles | bauzas: if you remember something regarding this error then it would be awesome :) | 16:35 |
| bauzas | cool | 16:35 |
| elodilles | i think that's all from me | 16:35 |
| bauzas | ack | 16:35 |
| bauzas | #topic Open discussion | 16:36 |
| zigo | Now? :) | 16:36 |
| bauzas | no items in the agenda | 16:36 |
| bauzas | zigo: so, your turn | 16:36 |
| zigo | I've tried backporting to Train the official patch, though for Train, it would need these to be backported (in this order if I'm not mistaking): | 16:36 |
| zigo | I5ac03f923d9d181d22d44d8ec8fbc31eb0c3999e If878a023c69f25a9ea45b7de2ff9eb1976aaeb8c I56676713571e79f05ee3f0bffc5da8386e02c5d4 | 16:36 |
| zigo | Can someone help? Or is it out of scope of the team? | 16:36 |
| bauzas | (the volume detach issue, we can discuss it later) | 16:36 |
| bauzas | zigo: ideally, gerrit links may help :) | 16:36 |
| zigo | https://review.opendev.org/c/openstack/nova/+/706897 | 16:37 |
| zigo | https://review.opendev.org/c/openstack/nova/+/710239 | 16:37 |
| zigo | https://review.opendev.org/c/openstack/nova/+/711679 | 16:37 |
| zigo | I tracked them using "git blame" and didn't try doing a backport of them to Train though ... | 16:38 |
| elodilles | so this is fixed in Ussuri and newer | 16:38 |
| zigo | Yeah, Ussuri and up are fine. | 16:38 |
| bauzas | sec | 16:38 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | 16:38 |
| elodilles | so from upstream perspective Train is the only target | 16:38 |
| bauzas | we have a series up | 16:38 |
| zigo | But Train and before would need either such a backport, or something else to get the VMDK extended infos. | 16:38 |
| bauzas | that's proposed to fix the CVE | 16:38 |
| bauzas | oh, this is down to yoga | 16:39 |
| elodilles | zigo: Nova's stable/stein and stable/rocky is End of Life already | 16:39 |
| bauzas | I guess zigo wants at least Train | 16:39 |
| elodilles | so that needs to be handled downstream as branches are deleted already | 16:39 |
| bauzas | correct | 16:40 |
| zigo | elodilles: Yeah, but Debian is doing LTS for Rocky, so I will need to do the patch backport. And so probably is Red Hat for its customers, etc. | 16:40 |
| bauzas | those are tagged eol | 16:40 |
| zigo | Ok, so out of scope for the team, and I'm on my own ... :P | 16:40 |
| dansmith | zigo: you might need something more bespoke if backporting all the dependencies isn't possible | 16:40 |
| zigo | Oh, also, when I'm at it ... | 16:40 |
| zigo | This also need another patch in oslo.utils | 16:40 |
| dansmith | but it is clearly out of scope for us, which doesn't necessarily mean we won't help you, but... | 16:41 |
| zigo | Ok, thanks. :P | 16:41 |
| zigo | FYI, that's the oslo.utils patch that I backported already: https://review.opendev.org/c/openstack/oslo.utils/+/706880 | 16:42 |
| zigo | That fixed one of the unit tests... | 16:42 |
| dansmith | so with that, | 16:42 |
| zigo | (for train and below) | 16:42 |
| bauzas | dansmith: I guess there is no plan to backport https://review.opendev.org/c/openstack/nova/+/871624 downer than Yoga ? | 16:42 |
| dansmith | even if you don't backport the privsep stuff, you should have the data you need I think | 16:42 |
| dansmith | bauzas: I backported to xena, | 16:43 |
| dansmith | I think because xena was still in scope at the time and I was asked | 16:43 |
| dansmith | it was the only one with a conflict, trivial because of the config | 16:43 |
| bauzas | I'm actually surprised than backporting requires pulling more deps | 16:43 |
| dansmith | because of privsep conversions | 16:44 |
| dansmith | this was run within nova before IIRC | 16:44 |
| bauzas | dansmith: mmm, OK, can't see it proposed in the list of cherry-picks of https://review.opendev.org/c/openstack/nova/+/871624 | 16:44 |
| dansmith | and probably not with json output or something | 16:44 |
| dansmith | bauzas: https://review.opendev.org/c/openstack/nova/+/871622 | 16:44 |
| bauzas | I'm fucking blind | 16:45 |
| bauzas | it's on the list | 16:45 |
| * bauzas facepalms | 16:45 | |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | 16:45 |
| sean-k-mooney | that does not need any dep changes does it | 16:45 |
| bauzas | after being deaf when dansmith speaks, I'm now blind | 16:45 |
| dansmith | sean-k-mooney: not package deps, dependent patches | 16:45 |
| bauzas | correct | 16:45 |
| bauzas | but should be honestly minimal | 16:46 |
| bauzas | the patch itself is well self-contained | 16:46 |
| dansmith | but listen to what zigo is saying | 16:46 |
| sean-k-mooney | but it does not have depend on so you mena we need to backprot each branch or changes in other repos | 16:46 |
| dansmith | the information we need was not being exposed out of oslo utils before the patch he referenced | 16:46 |
| sean-k-mooney | ok then thats kind of a problem | 16:46 |
| sean-k-mooney | the olso backports would have to happen first | 16:47 |
| dansmith | I don't think he's suggesting it upstream | 16:47 |
| sean-k-mooney | and we would need to be able to work with older oslo | 16:47 |
| opendevreview | Merged openstack/nova master: Make tenant network policy default to PROJECT_READER_OR_ADMIN https://review.opendev.org/c/openstack/nova/+/865071 | 16:47 |
| dansmith | he's talking about old and crusty packages debian is keeping on life support | 16:47 |
| bauzas | oh | 16:48 |
| sean-k-mooney | ok we can propably talk about this out of the meeting | 16:48 |
| bauzas | that's gonna be fun then | 16:48 |
| dansmith | yes, especially since it's out of our support scope, very clearly | 16:48 |
| sean-k-mooney | https://review.opendev.org/c/openstack/oslo.utils/+/706880 is in ussuri and above | 16:48 |
| dansmith | he's talking about rocky | 16:48 |
| sean-k-mooney | so i think train is the only supported release without it | 16:48 |
| sean-k-mooney | dansmith: right but we have one release that does not have the oslo patch | 16:49 |
| * dansmith wonders if everyone else is able to read all the messages in this channel | 16:49 | |
| dansmith | sean-k-mooney: who is we? not upstream openstack | 16:49 |
| zigo | I don't suggest it upstream, just trying to share my findings at the moment (I don't have any blockers ... yet, if I do I'll let you know). | 16:49 |
| sean-k-mooney | we still supprot train for nova | 16:49 |
| sean-k-mooney | and https://review.opendev.org/c/openstack/oslo.utils/+/706880 is not in it | 16:49 |
| dansmith | elodilles: ? | 16:50 |
| zigo | Rocky, I haven't started working on it yet... | 16:50 |
| sean-k-mooney | based on the gerrit included in output | 16:50 |
| zigo | sean-k-mooney: Correct. (but not really a pb for me...) | 16:50 |
| sean-k-mooney | anywya lets loop back to this after the meeting | 16:51 |
| sean-k-mooney | if we need it for train then we can backport it to train in oslo | 16:52 |
| sean-k-mooney | but there are plenty of branches to get through first | 16:52 |
| bauzas | is it me or there was a typo in the oslo.utils patch ? https://review.opendev.org/c/openstack/oslo.utils/+/706880/4/oslo_utils/imageutils.py#88 | 16:52 |
| sean-k-mooney | not that i see | 16:52 |
| bauzas | appened ? | 16:52 |
| sean-k-mooney | its a list so i think that valid | 16:53 |
| bauzas | I know I'm not a python expert, but I didn't know that a list object was having an 'appened' method | 16:53 |
| sean-k-mooney | https://docs.python.org/3/tutorial/datastructures.html#more-on-lists | 16:53 |
| bauzas | append, eyes | 16:53 |
| sean-k-mooney | """Add an item to the end of the list. Equivalent to a[len(a):] = [x].""" | 16:53 |
| bauzas | append, yes | 16:54 |
| bauzas | appened, doesn't exist | 16:54 |
| sean-k-mooney | oh | 16:54 |
| bauzas | which tends me thinking this patch is nice but unsufficient | 16:54 |
| sean-k-mooney | ya thats wrong i think but i shoudl not try and spot typos :) | 16:55 |
| sean-k-mooney | that presumably was fixed | 16:55 |
| bauzas | correct, probably in a fup | 16:55 |
| zigo | Well, in this specific case, the code is executed in the format == 'json' path, so it *is* enough ... (but still wrong in that other case) | 16:55 |
| bauzas | so it would require the fup to be dragged down too | 16:55 |
| sean-k-mooney | aparenlty not https://github.com/openstack/oslo.utils/blob/stable/ussuri/oslo_utils/imageutils.py#L89 | 16:56 |
| bauzas | zigo: correct, the bug is only on the string definition | 16:56 |
| zigo | Well, stable/zed has the typo ... :/ | 16:56 |
| bauzas | when you str() | 16:56 |
| bauzas | or you print | 16:56 |
| bauzas | so, technically, you don't need the fix | 16:56 |
| sean-k-mooney | https://github.com/openstack/oslo.utils/commit/d49d5944824f15d00e04e1b9c7f8c3b03b440c95 | 16:56 |
| sean-k-mooney | it was fixed 2 months ago | 16:57 |
| bauzas | anyway, the meeting is close to the end | 16:57 |
| bauzas | how to wrap up on this ? | 16:57 |
| dansmith | I suggest #endmeeting | 16:57 |
| sean-k-mooney | +1 | 16:57 |
| elodilles | :) | 16:57 |
| bauzas | then | 16:57 |
| bauzas | thanks all | 16:57 |
| bauzas | #endmeeting | 16:57 |
| opendevmeet | Meeting ended Tue Jan 24 16:57:58 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:57 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-24-16.00.html | 16:57 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-24-16.00.txt | 16:57 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-24-16.00.log.html | 16:57 |
| bauzas | wasn't that quick, unfortunately | 16:58 |
| opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Check shares support https://review.opendev.org/c/openstack/nova/+/850499 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860285 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860288 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Change microversion to 2.XX https://review.opendev.org/c/openstack/nova/+/852088 | 17:00 |
| opendevreview | ribaudr proposed openstack/nova master: Documentation https://review.opendev.org/c/openstack/nova/+/871642 | 17:00 |
| priteau | dansmith: Hello. Is there a reason for no backport of https://review.opendev.org/c/openstack/nova/+/871622 to wallaby yet? It seems to backport cleanly with the resolution done in xena. | 17:21 |
| dansmith | priteau: yes, because wallaby is EOL | 17:22 |
| dansmith | well, EM | 17:22 |
| priteau | But you will still propose a patch for it or not at all? | 17:23 |
| dansmith | priteau: you go ahead :) | 17:23 |
| priteau | OK | 17:23 |
| priteau | The backports don't have the "cherry picked from commit" line by the way | 17:24 |
| priteau | (maybe because it wasn't a cherry pick at all) | 17:24 |
| opendevreview | Pierre Riteau proposed openstack/nova stable/wallaby: Check VMDK create-type against an allowed list https://review.opendev.org/c/openstack/nova/+/871557 | 17:25 |
| priteau | Hum, maybe it is new Gerrit behavior? | 17:26 |
| dansmith | priteau: because they were all pre-canned ahead of time yeah | 17:30 |
| gibi | priteau: I think the cherry picked from line is comfing from git cherry-pick -x | 17:31 |
| priteau | No, I know what's happening. Gerrit only adds it when you cherry-pick a *merged* change. | 17:31 |
| priteau | I cherry-picked from stable/xena to get the conflict resolution, this hasn't merged yet. | 17:32 |
| gibi | priteau: true. if you want to add it then you can by doing the cherry-pick with git and using -x | 17:33 |
| opendevreview | Pierre Riteau proposed openstack/nova stable/wallaby: Check VMDK create-type against an allowed list https://review.opendev.org/c/openstack/nova/+/871557 | 17:34 |
| priteau | Yes, I've done this many times. Here we go. | 17:34 |
| gibi | Uggla: I re-reviewd the first half of the manial series mostly OK with it buth johnthetubaguy had some valid questions there so I left -1 to have the visibility | 18:21 |
| gibi | I will continue tomorrow | 18:21 |
| gibi | Uggla: do you have a set of functional tests added to the series? | 18:22 |
| *** dasm is now known as dasm|off | 23:09 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!