Friday, 2023-01-06

opendevreviewNobuhiro MIKI proposed openstack/nova-specs master: Add PXB support for libvirt  https://review.opendev.org/c/openstack/nova-specs/+/86941602:35
*** blarnath is now known as d34dh0r5307:01
opendevreviewAaron S proposed openstack/nova master: Add further workaround features for qemu_monitor_announce_self  https://review.opendev.org/c/openstack/nova/+/86732411:03
*** dasm|off is now known as dasm14:14
stephenfingibi: No point rechecking jobs that exhibit this failure14:46
stephenfintox.tox_env.python.api.NoInterpreter: could not find python interpreter matching any of the specs functional-py3914:46
gibiahh14:46
stephenfinit's another tox 4 bug14:46
gibinice14:46
stephenfinhttps://github.com/tox-dev/tox/issues/281114:46
gibiwhat can we do?14:47
stephenfinI've happened to expose it by fixing another bug that resulted in us using the wrong interpreter version14:47
stephenfin:(14:47
sean-k-mooneyi have been seeing it since before you fix14:48
sean-k-mooneybut ya all the gates are currently blocked14:48
stephenfinyeah, most likely on projects without base_python set14:48
sean-k-mooneyi saw it on nova yesterday and i think on older builds form durign the week14:49
sean-k-mooneywe have base_python set14:49
sean-k-mooneywe dont actully need to have it set anymore since we are python3 only14:49
stephenfinthe fix to tox merged yesterday so it was probably that14:49
sean-k-mooneyya the release happend 19 hours ago but i toughthe builds were older then that14:50
sean-k-mooneyi saw it on gibis seriese14:50
sean-k-mooneyim wondering if we shoudl repin to tox <4.0 tempoerally14:51
sean-k-mooneywe can proably wait another week but if we cant resolve the issue by the end of next week i think we should14:52
gibisean-k-mooney, stephenfin: is there a mail thread about the gate block on the ML yet or should I send one?14:59
stephenfinThere isn't. The fix is here https://github.com/tox-dev/tox/pull/2828 though if you want to send one and point to that14:59
gibiI will send one14:59
dansmithsean-k-mooney: tox has been slowly breaking everything for weeks now.. pinning to <4 temporarily seems futile15:01
sean-k-mooneydansmith: im currently trying to fix some os-vif tox issues related to ubuntu 22.0415:08
sean-k-mooney4.0 is after that on my list15:09
sean-k-mooneydansmith: we had a pin in place until recently to prevent the gate block15:16
dansmithyeah and we're pinning on stable, I'm just saying I don't think _temporarily_ pinning and expecting things to stabilize is realistic15:16
sean-k-mooneyi understand why they remvoed it but i dont think we shoudl block the gate while we are fixing it15:16
dansmithit's not like they broke a bunch of backwards compat in 4.0 and now things are stable.. they *keep* breaking things15:17
dansmithalso for the reason that tox will auto-upgrade itself in certain scenarios (which is like ....)15:18
sean-k-mooneyi havent really had issue  wiht tox but also havnt been using it much in the last while as i have not been really coding in python for a few months15:18
sean-k-mooneydansmith: apprently you can force it to install iseslf in a venv and use that version to run things15:18
dansmithsean-k-mooney: it will do that itself if it decides to15:18
dansmithbut only the latest, not a specific version15:19
sean-k-mooneynot according to  Brian Rosmaita's latest email15:19
sean-k-mooneyyou can force the version via requires in tox.ini15:19
dansmith" it doesn't ensure that the available tox is that version."15:20
dansmithoh, there's two pins, with different behaviors15:20
dansmithhe's talking about requires, but there are projects with ensure15:21
dansmithit's really a mess15:22
sean-k-mooneyyep 15:23
sean-k-mooneythe reason i was suggestign we wait a week is at that poitn we would be 4 weeks form FF15:23
sean-k-mooneyand dont really wnat to still have the gates blocked by this at that point15:23
sean-k-mooneyi.e. lets see if we can fix it next week and if not pin it so we can continue merging things and work on it in parallel15:24
sean-k-mooneygmann: stephenfin i have got the os-vif fucntional test workign locally18:02
sean-k-mooneyit looks like we need CAP_DAC_OVERRIDE on ubuntu 22.0418:03
sean-k-mooneywithout that vsctl and some other commands fail18:03
sean-k-mooneyCAP_NET_ADMIN used to work18:03
sean-k-mooneyi have some other chagne locally so im going to see if they are required or not18:04
sean-k-mooneyits proably because i am not a meber of the openvswitch group but it also fails for ip link commands18:04
sean-k-mooneyso i think this has to do with disto packaging and how the goups are configured18:05
sean-k-mooneyso while i dont like adding CAP_DAC_OVERRIED that is proably what we will need to do 18:05
sean-k-mooneywhat im less happy about is this is only required when using the vsctl ovs backend which is deprecated18:06
sean-k-mooneyso i might us a diffferent privsep context based on the driver to limit the scope of the change.18:07
sean-k-mooneyactully i think the cahnge is less in vasive then that and only in the test code 18:20
opendevreviewsean mooney proposed openstack/os-vif master: add CAP_DAC_OVERRIDE to test privsep contexts  https://review.opendev.org/c/openstack/os-vif/+/86950018:34
sean-k-mooneygibi: stephenfin gmann ^ i think that will fix the functional job and unblock https://review.opendev.org/c/openstack/os-vif/+/868420 and https://review.opendev.org/c/openstack/os-vif/+/86146818:35
sean-k-mooneyonce we have those 3 commits merged we may want to consider an os-vif release18:36
gmannsean-k-mooney: thanks, will keep eyes on gate result18:54
darkhorseHi team, I would like to resize an shelved_offloaded instance. The use case is that when an instance with pci device is shelved_offloaded and the device is broken, it fails to unshelve. However, as a user, I would like to recover my data in the instance so I would like to change the flavor with a new one that does not have pci cards.19:09
darkhorseIs there a quick workaround to this?19:09
darkhorseThank you in advance for any help!19:10
opendevreviewDanylo Vodopianov proposed openstack/nova master: Napatech SmartNIC support  https://review.opendev.org/c/openstack/nova/+/85957719:19
dansmithmelwitt: around?19:24
melwittdansmith: o/19:35
dansmithhey so,19:35
dansmithI don't really know what I was going to say19:35
dansmithpart of it was that now that I've implemented compute undelete later in the series,19:35
dansmithI'm failing a couple more regression tests,19:35
dansmithbut around ironic because of all the hash ring rebalance weirdness19:36
dansmithunfortunately I think those are going to have to change a bit as well, which makes me nervous,19:36
dansmithbut they're asserting things like "this shouldn't create another thing, but it does, so assert that it happens, and then assert that it goes away later" sort of stuff19:36
dansmithwhich is kinda expected and kinda why we're doing this, and the ironic hash-ring-ectomy thing19:37
dansmithbut I dunno, I guess I just want to say... I hope you're going to check all my work :P19:37
melwittdansmith: ack, that's the intent (to check everything) :) thanks for the heads up19:40
dansmithI know19:40
dansmithbut this rabbit hole is deep, the tea tastes funny, and everyone is wearing strange hats19:41
melwitthaha, I hear you (and am not surprised)19:42
opendevreviewDanylo Vodopianov proposed openstack/nova master: Napatech SmartNIC support  https://review.opendev.org/c/openstack/nova/+/85957719:49
sean-k-mooneydarkhorse: no quick workaround. resize is currently not supproted while shelve_offloaded but we have discussed that it could be supported in the future 19:52
sean-k-mooneydarkhorse: i think artom has already fixed the issue with pci device shelve however19:53
sean-k-mooneyso i dont think that happens any more19:53
darkhorsesean-k-mooney: do you have a link to the patchset? when you say the issue is fixed, does that mean you can unshelve instances even if pci card is broken or unavailable?20:06
opendevreviewDanylo Vodopianov proposed openstack/nova master: Napatech SmartNIC support  https://review.opendev.org/c/openstack/nova/+/85957720:12
artomsean-k-mooney, IIUC darkhorse wants to resize a shelved_offloaded instance20:14
artomWhich IIUC is... not a thingÉ20:14
artom?20:14
artomAs in, you have to unshelve first, and then resize?20:14
artomAnd yeah, unshelve with PCI has been backported to... I want to say Ussuri?20:14
artomOr maybe wallaby20:14
darkhorsesean-k-mooney: If you can share the link of the discussion of the resize support for shelved instances, it would be helpful. I will take a look and work on it.20:14
darkhorseartom: Do you mean you can unshelve instance when pci card is broken/unavailable in Ussuri or Wallaby?20:15
artomdarkhorse, https://review.opendev.org/q/Icfa8c1d6e84eab758af6223a2870078685584aaa20:16
artomwallaby20:16
darkhorseartom: We are operating on xena. So if I understood you correct, all I need to do to allow users to unshelve pci instance even if card is broken/unavailable is to backport this patch to xena, is that correct?20:19
artomdarkhorse, no, you should be set. Xena is after wallaby :)20:19
artomWhen the master patch merged, master was xena20:20
artomdarkhorse, hold on though - define "card is broken/unavailable"?20:20
artomThe unselve will attempt to find a PCI card that fits the port (if it's Neutron SRIOV)/flavor20:20
artomBut... if no such cards are available, then it will (legitimately) fails to schedule20:21
darkhorseartom: not neutron SRIOV but fpga device.20:21
artomSo flavor PCI passthrough...20:21
darkhorseright!20:21
artomThat should just... work. Off the top of my head I don't recall any issues with PCI and unshelve20:22
darkhorseartom: no it fails to unshelve because the pci device is unavailable.20:23
artomUnavailable how? It got pulled from the server? :)20:23
darkhorsein that case, i would like to either snapshot or resize the instance so that I don't lose the data inside it.20:23
darkhorseeither because the card is occupied by another instances or physically broken20:24
darkhorseartom: did i answer your question?20:32
artomdarkhorse, ah, I think I see. If you can't unshelve the instance because the cloud lacks the resources the instance needs (in this case, a PCI card), you'd like to be able to boot it regardless with its disk intact, just without the PCI device20:34
artomSo a shelved_offloaded instance lives as an image in Glance20:34
artomIIRC you should just be able to boot a new instance from that image?20:34
artomIf keeping the same UUID is important to you though, you're out of luck I believe :(20:35
darkhorseartom: the point is i want to recover the data inside the instance. if i boot a new instance, i think i am not able to get the data?20:36
artomIf it's been shelved offloaded, its disk has been uploaded to Glance as an image.20:37
artomBut... if you want data to persist, the "real" solution is to use volumes20:37
darkhorseartom: will you elaborate? i was thinking of snapshotting or resizing with a new flavor that does not have pci so that i can unshelve.20:38
artomdarkhorse, elaborate on which aspect? Volumes, or booting from the Glance image?20:39
darkhorse1. if booting from glance image will save the data 2. volumes 20:40
darkhorseartom:1. if booting from glance image will save the data 2. volumes 20:41
artomdarkhorse, it's been a while since I've done this, but a shelved_offloaded image will have its disk uploaded as image in Glance20:42
artomI believe you can just boot from that image with `openstack server create --image <image uuid> <etc>`20:42
artomAnd for volumes... you create a volume, attach it to your instance20:42
artomInside the guest you mount it as /data or whatever20:43
artomAnd then anything in /data will live on the volume, so even if the instance is deleted, that volume persists and can be attached to other instances20:43
darkhorseartom: the point is to recover the data in the instance. what should i do when instance is not able to get unshelved?20:44
artomI'm not sure how much more clear I can be20:45
artom<artom> darkhorse, it's been a while since I've done this, but a shelved_offloaded image will have its disk uploaded as image in Glance20:45
artom<artom> I believe you can just boot from that image with `openstack server create --image <image uuid> <etc>`20:45
darkhorseartom: ok thank you! let me try that.20:46
opendevreviewDanylo Vodopianov proposed openstack/os-vif master: MTU support for DPDK port added  https://review.opendev.org/c/openstack/os-vif/+/85957421:01
*** dasm is now known as dasm|off21:37
opendevreviewGhanshyam Mann proposed openstack/python-novaclient master: DNM: test tox<4 pinning in stable branches  https://review.opendev.org/c/openstack/python-novaclient/+/86951623:57
opendevreviewGhanshyam Mann proposed openstack/osc-placement stable/zed: DNM: test tox<4 pinning in stable branches  https://review.opendev.org/c/openstack/osc-placement/+/86951723:59

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!