| *** akekane is now known as abhishekk | 05:36 | |
| opendevreview | Hiroki Narukawa proposed openstack/nova master: libvirt: add sftp driver https://review.opendev.org/c/openstack/nova/+/866672 | 08:32 |
|---|---|---|
| sahid_ | o/ sorry to annoy guys any chance to get somes reviews regarding the impl of evacuate spec? https://review.opendev.org/c/openstack/nova/+/858383 there are lot of files updated but just small changes | 09:08 |
| sean-k-mooney | sahid_: i dont know if i will get to them today but i will get to them before i go on pto for the year | 09:12 |
| sean-k-mooney | im here until friday next week | 09:12 |
| sean-k-mooney | i suspect we can likely get this merged before then | 09:13 |
| bauzas | yup, I'll try too | 09:15 |
| bauzas | I personnally need to rush on implementing the cpu offlining feature | 09:15 |
| bauzas | before the xmas period | 09:15 |
| sean-k-mooney | if its aviable next week ill have time to start reviewing | 09:21 |
| zigo | sahid_: Hi there! Would you have the URL of the bp handy? | 09:22 |
| zigo | Back to the bug report from yesterday: https://bugs.launchpad.net/python-novaclient/+bug/1998856 | 09:24 |
| zigo | It appears cinderclient has the same exact bug (the 2 broken tests are looking very similar if not completely identical) | 09:24 |
| sahid_ | Hey zigo, https://github.com/openstack/nova-specs/blob/master/specs/2023.1/approved/allowing-target-state-for-evacuate.rst | 09:37 |
| sahid_ | sean-k-mooney: hey! no worries, just that more we can have it soon in the tree more we can fix any bugs it could have :-) (and also safe am I we have it merged for antelope :p) | 09:54 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Reproducer for bug 1951656 https://review.opendev.org/c/openstack/nova/+/866157 | 10:52 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866158 | 10:52 |
| opendevreview | sean mooney proposed openstack/nova stable/wallaby: refactor: remove duplicated logic https://review.opendev.org/c/openstack/nova/+/865334 | 10:59 |
| opendevreview | sean mooney proposed openstack/nova stable/wallaby: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/865336 | 10:59 |
| opendevreview | sean mooney proposed openstack/nova stable/wallaby: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/865571 | 10:59 |
| opendevreview | sean mooney proposed openstack/nova stable/wallaby: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/865572 | 10:59 |
| opendevreview | sean mooney proposed openstack/nova stable/wallaby: Reproducer for bug 1951656 https://review.opendev.org/c/openstack/nova/+/866157 | 10:59 |
| opendevreview | sean mooney proposed openstack/nova stable/wallaby: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866158 | 10:59 |
| zigo | sahid_: If I understand correctly, the goal is to have a instance go from ACTIVE to SHUTOFF during the evacuate ? | 11:11 |
| sahid_ | zigo: yes exactly | 11:18 |
| zigo | Thanks. Though I don't really understand why one would do that ... :P | 11:18 |
| sahid_ | now when we do evacuate (maintenance operation) instances on dest get stopped | 11:18 |
| sahid_ | yea.. there are several use-cases, also that for operators that do prefer kept the previous behavior they can use microversion | 11:19 |
| zigo | I'm not a fan of using microversions to have change of behavior, tbh... but ok. | 11:20 |
| sahid_ | sean-k-mooney: regarding that tiny one, https://review.opendev.org/c/openstack/os-vif/+/866102 i would tend to accept it, i comment on it, are you ok or do you feel like we should find an other solution | 11:20 |
| sahid_ | zigo: yeah, it's really for operators to handle resources and things like that, I think that has been discussed previously during PTG | 11:22 |
| sean-k-mooney | so i kind of disagree on the parsablity argument as if you cant parse multiline output you cant actully parse logs properly | 11:23 |
| sahid_ | sean-k-mooney: sure, fair enough | 11:24 |
| sean-k-mooney | sahid_: we also use multi line strings in nova for the deprecated_reason extensivly and im not infavor fo changing it in nova | 11:24 |
| sean-k-mooney | for example https://github.com/openstack/nova/blob/6ba6d86e9c2ab44752d87f070ce5e1ce00a48301/nova/conf/glance.py#L34-L39 | 11:25 |
| sahid_ | yes i understand your point no worries | 11:26 |
| sean-k-mooney | with all that said we could actully remove those deprecated optoins this cycle | 11:27 |
| sahid_ | I was seeing that more like, we could keep some sort of coherence with the other multiline strings we have in this set of options | 11:27 |
| sean-k-mooney | its been several years at thsi point | 11:27 |
| sahid_ | interesting point | 11:28 |
| sean-k-mooney | we could be if we were to do that i woudl change all the rest to multi line | 11:28 |
| sean-k-mooney | that woudl be more consitent with the wider code base | 11:28 |
| sahid_ | good point :-) | 11:28 |
| sean-k-mooney | we have moved away form sting conatination like that over the last few years | 11:28 |
| sahid_ | but that would not help the contributor which have noticed that multiline thing in its logs | 11:29 |
| sahid_ | i would vote in favor of removing that deprecating message if i may | 11:29 |
| sean-k-mooney | by the way https://review.opendev.org/c/openstack/os-vif/+/854486 i generally see a a nuisance commit | 11:29 |
| sean-k-mooney | im going to merge it to not have to deal with it again but i have seen a bunch of people submiting patch to remove the u prfix and it is somethign we shoudl discurage | 11:30 |
| sahid_ | yes i was considering to see whether we could or not add a hacking rule for that sort of change | 11:34 |
| sahid_ | yes you are certainly dealing with such changes often that me :-) | 11:35 |
| opendevreview | Merged openstack/os-vif master: remove unicode from code https://review.opendev.org/c/openstack/os-vif/+/854486 | 11:40 |
| opendevreview | sean mooney proposed openstack/nova stable/wallaby: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/865572 | 13:15 |
| opendevreview | sean mooney proposed openstack/nova stable/wallaby: Reproducer for bug 1951656 https://review.opendev.org/c/openstack/nova/+/866157 | 13:16 |
| opendevreview | sean mooney proposed openstack/nova stable/wallaby: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866158 | 13:16 |
| *** dasm|off is now known as dasm | 14:04 | |
| *** akekane is now known as abhishekk | 14:05 | |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Reproducer for bug 1951656 https://review.opendev.org/c/openstack/nova/+/866157 | 14:12 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866158 | 14:13 |
| kgube | sean-k-mooney, melwitt, Regarding the assisted volume extend API: I have now proposed an alternative spec for an async solution to Cinder: https://blueprints.launchpad.net/cinder/+spec/extend-volume-completion-action | 14:22 |
| opendevreview | alecorps proposed openstack/nova master: Add mksproxy files https://review.opendev.org/c/openstack/nova/+/863090 | 14:24 |
| kgube | sean-k-mooney, this does not require an API change in Nova, just a change in how "volume-extended" events are processed, should I create a nova-spec anyway? | 14:24 |
| kgube | sean-k-mooney, the changes for Nova are described in a "Nova" subsection of the "Proposed change" section of the cinder-spec | 14:27 |
| bauzas | reminder: nova meeting in 10 mins | 15:49 |
| * bauzas needs to quickly update the agenda | 15:49 | |
| bauzas | #startmeeting nova | 16:01 |
| opendevmeet | Meeting started Tue Dec 6 16:01:28 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:01 |
| opendevmeet | The meeting name has been set to 'nova' | 16:01 |
| bauzas | sorry, was late | 16:01 |
| bauzas | howdy everyone | 16:01 |
| bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:02 |
| elodilles | o/ | 16:02 |
| Kirill_ | o/ | 16:03 |
| bauzas | looks like we maybe not have a lot of quorum | 16:03 |
| bauzas | but let's start | 16:03 |
| bauzas | #topic Bugs (stuck/critical) | 16:03 |
| bauzas | #info No Critical bug | 16:03 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 18 new untriaged bugs (+2 since the last meeting) | 16:03 |
| bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:03 |
| bauzas | elodilles: anything to discuss about bugs ? | 16:03 |
| elodilles | maybe one question | 16:04 |
| elodilles | had a bug: explicit fixed ip request assigns random ip: https://bugs.launchpad.net/nova/+bug/1998927 | 16:04 |
| elodilles | this is i think python-openstackclient | 16:04 |
| elodilles | how can i reroute this? o:) | 16:04 |
| * bauzas clicks | 16:04 | |
| bauzas | elodilles: yup, looks to me an OSC issue | 16:06 |
| bauzas | "the fixed ip command assigns random IP even if we ask an IP explicitly" | 16:06 |
| bauzas | you mean, because of OSC ? | 16:06 |
| bauzas | if so, we need to change the project in Launchpad | 16:06 |
| elodilles | i think so | 16:06 |
| bauzas | lemme do it | 16:06 |
| bauzas | "also affects project" > openstackclient | 16:06 |
| elodilles | oh, cool, thanks | 16:07 |
| bauzas | oh snap | 16:07 |
| bauzas | "python-openstackclient doesn't use Launchpad to track its bugs. If you know this bug has been reported in another bug tracker, you can link to it; Launchpad will keep track of its status for you. " | 16:07 |
| bauzas | StoryBoard my love | 16:07 |
| bauzas | then you should close the bug | 16:08 |
| bauzas | and ask the report to create a Storyboard issue for osc | 16:08 |
| bauzas | lemme find it | 16:08 |
| elodilles | bauzas: ack, will do that | 16:08 |
| elodilles | bauzas: i'll do that after the meeting | 16:08 |
| elodilles | bauzas: no need to spend time with it now :) | 16:08 |
| bauzas | https://storyboard.openstack.org/#!/project/975 | 16:09 |
| elodilles | thx :) | 16:09 |
| bauzas | it was simple to find https://docs.openstack.org/python-openstackclient/latest/#contributing | 16:09 |
| bauzas | elodilles: ok, I'll then let you triage this bug | 16:09 |
| bauzas | and thanks for it | 16:09 |
| elodilles | np | 16:10 |
| bauzas | moving on then | 16:10 |
| bauzas | #info bug baton is being passed to bauzas | 16:10 |
| bauzas | I'll try to triage it, but I have a lot of other priorities | 16:11 |
| bauzas | anyway | 16:11 |
| bauzas | #topic Gate status | 16:11 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:11 |
| bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:11 |
| bauzas | #link https://review.opendev.org/c/openstack/tempest/+/866049 proposal to add more delay for centos9s-fips job | 16:11 |
| bauzas | I'd appreciate if some people like sean-k-mooney or others could review this change ^ | 16:11 |
| bauzas | mkopec had a thought to skip some tests for this job instead of adding more delays | 16:12 |
| bauzas | anyway, moving | 16:16 |
| bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:16 |
| bauzas | #info STOP DOING BLIND RECHECKS aka. 'recheck' https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures | 16:16 |
| bauzas | #topic Release Planning | 16:16 |
| bauzas | tick-tock | 16:16 |
| bauzas | #link https://releases.openstack.org/antelope/schedule.html | 16:16 |
| bauzas | #info Antelope-2 is in 4 weeks | 16:16 |
| bauzas | 4 weeks and in between a xmas period | 16:16 |
| bauzas | so you know. | 16:17 |
| bauzas | I forgot to write the email for next week's review day, I'll do it tomorrow hopefuly | 16:17 |
| bauzas | moving on ? | 16:17 |
| bauzas | looks so | 16:18 |
| bauzas | #topic Review priorities | 16:18 |
| bauzas | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2) | 16:19 |
| bauzas | #info As a reminder, cores eager to review changes can +1 to indicate their interest, +2 for committing to the review | 16:19 |
| bauzas | anything to discuss about priorities ? | 16:19 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Reproducer for bug 1951656 https://review.opendev.org/c/openstack/nova/+/866157 | 16:20 |
| opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866158 | 16:20 |
| bauzas | nevermind the above ^ (doing two things at same time) | 16:20 |
| bauzas | looks not, moving on | 16:20 |
| bauzas | #topic Stable Branches | 16:20 |
| bauzas | elodilles: you could have an opportunity to not lemme discuss alone :) | 16:21 |
| elodilles | :) | 16:21 |
| elodilles | yepp | 16:21 |
| elodilles | actually stable gates were quiet | 16:21 |
| elodilles | i mean patches merged :) | 16:21 |
| bauzas | correct, I worked on the stable branches | 16:21 |
| elodilles | #info stable branches seem to be unblocked / OK | 16:21 |
| bauzas | and I haven't seen any problems so far | 16:21 |
| elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:21 |
| bauzas | down to wallaby at least | 16:21 |
| elodilles | neither have i | 16:21 |
| elodilles | i've seen merged patches even older than wallaby | 16:22 |
| bauzas | you know, nothing to tell is better than saying anything here in this section :) | 16:22 |
| elodilles | yepp :) | 16:22 |
| bauzas | moving on then, and profit. | 16:22 |
| elodilles | ++ | 16:22 |
| elodilles | :) | 16:22 |
| bauzas | #topic Open discussion | 16:22 |
| Kirill_ | can someone review this: https://review.opendev.org/c/openstack/nova-specs/+/863773 . sean-k-mooney already reviewed and and set +1, need more reviews for setting +2, right? | 16:23 |
| bauzas | I had a question but I don't see a quorum | 16:23 |
| bauzas | Kirill_: nod, lemme see | 16:23 |
| Kirill_ | thanks | 16:23 |
| bauzas | ah that one | 16:23 |
| bauzas | sure, I'll do some review | 16:23 |
| sahid_ | o/ then, i have one regarding review priority | 16:23 |
| bauzas | sahid_: sure, shoot | 16:24 |
| sahid_ | thanks | 16:24 |
| sahid_ | it's just to know, we have this that had the bit Review-Priority | 16:24 |
| sahid_ | https://review.opendev.org/c/openstack/nova-specs/+/857838 | 16:24 |
| sahid_ | I'm wondering whtehr the impl can I have also that bit, or if it's a different process? | 16:25 |
| sahid_ | :-) | 16:25 |
| bauzas | sahid_: surely, you can ask for it :) | 16:25 |
| bauzas | sahid_: ping us tomorrow and we'll see | 16:25 |
| bauzas | looks there are not a lot of people around atm | 16:25 |
| sahid_ | yeah... no worries, will see that tomorrow | 16:26 |
| sahid_ | thanks a lot | 16:26 |
| bauzas | np | 16:27 |
| bauzas | so let's end this meeting for now, I'll ask about which meetings to skip during the xmas period next week | 16:27 |
| bauzas | anyone having anything to raise before we say it's a wrap ? | 16:27 |
| bauzas | looks not, | 16:28 |
| bauzas | thanks all | 16:28 |
| bauzas | #endmeeting | 16:28 |
| opendevmeet | Meeting ended Tue Dec 6 16:28:43 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:28 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-12-06-16.01.html | 16:28 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-12-06-16.01.txt | 16:28 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-12-06-16.01.log.html | 16:28 |
| elodilles | thanks bauzas o/ | 16:29 |
| * bauzas goes back playing with the wallaby branch | 16:29 | |
| sean-k-mooney | kgube: we generally do not like tracking changes to nova in other projects specs | 16:29 |
| elodilles | that sounds fun :D | 16:29 |
| * bauzas wonders if someone says that wallaby hops | 16:30 | |
| sean-k-mooney | kgube: if you are chaing the sematics or the extend voluem external event even if that does not change the content passed to the api we shoudl still have a spec to dicuss that | 16:30 |
| kgube | sean-k-mooney, alright! | 16:30 |
| sean-k-mooney | Kirill_: i wanted gmann or other to confirm my reasoning on https://review.opendev.org/c/openstack/nova-specs/+/863773/10/specs/wallaby/approved/nova-vnc-support-for-ironic.rst#134 | 16:30 |
| sean-k-mooney | Kirill_: i.e. that we do not need a microversion for this change and there is no other upgrade impact for the reasons is stated in the commnet | 16:32 |
| gmann | sean-k-mooney: I kept it open but somehow got distracted. It is in my list. | 16:35 |
| Kirill_ | per my understanding, we don't need any miniversions cause if nova does not support my changes the result will be the same as now, if ironic does not support - again we will catch error - vnc is unsupported. i'll try such scenarios tomorrow. | 16:35 |
| sean-k-mooney | Kirill_: ya so part of what im wondering is changing form a 400 to a 200 ok | 16:36 |
| sean-k-mooney | and i think it is because if it was a libvirt instance then a 200 would have been valid | 16:37 |
| sean-k-mooney | or possible for the same api request | 16:37 |
| sean-k-mooney | so to me there is no need for a microverion | 16:37 |
| Kirill_ | ++ | 16:38 |
| opendevreview | Merged openstack/nova stable/wallaby: Test aborting queued live migration https://review.opendev.org/c/openstack/nova/+/841483 | 20:22 |
| opendevreview | Merged openstack/nova stable/wallaby: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/841760 | 20:22 |
| opendevreview | Merged openstack/nova stable/wallaby: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/841736 | 20:48 |
| *** dasm is now known as dasm|off | 22:51 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!