| *** akekane is now known as abhishekk | 04:51 | |
| *** akekane is now known as abhishekk | 06:09 | |
| whoami-rajat | hey #openstack-nova , nova-ceph-multistore is failing on wallaby gate, can anyone take a look at this patch fixing it? https://review.opendev.org/c/openstack/nova/+/866326 | 09:30 |
|---|---|---|
| bauzas | whoami-rajat: haha, I saw the problem | 09:51 |
| bauzas | whoami-rajat: thanks for your change, but I have a question | 09:52 |
| bauzas | why couldn't we have a new os-brick version ? | 09:53 |
| bauzas | because Wallaby is on EM ? | 09:53 |
| whoami-rajat | bauzas, yes, the only way (I know of) is to take os-brick from source, I talked to the release team and not possible to release another os-brick for wallaby | 10:07 |
| bauzas | whoami-rajat: which release model do you have for os-brick ? | 10:10 |
| bauzas | lemme check actually | 10:10 |
| bauzas | https://releases.openstack.org/teams/cinder.html#os-brick hah, you're not using the independent model | 10:16 |
| bauzas | ok, so I understand then | 10:16 |
| bauzas | we can't release a new version in the wallaby branch indeed as it's EM | 10:16 |
| * bauzas wonders if that's the only solution | 10:27 | |
| bauzas | but given it's on EM... | 10:27 |
| bauzas | gibi: sean-k-mooney elodilles: if you could quickly review https://review.opendev.org/c/openstack/nova/+/866326 that'd be loved | 10:30 |
| sean-k-mooney | oh the os brick change | 10:31 |
| sean-k-mooney | sure | 10:31 |
| sean-k-mooney | done | 10:33 |
| bauzas | thanks | 10:37 |
| whoami-rajat | bauzas, nope, we use cycle-with-intermediary https://github.com/openstack/releases/blob/4f29f584f85a7b26b69f6b5f8e47af4026dea686/deliverables/antelope/os-brick.yaml#L4 | 11:01 |
| whoami-rajat | thanks bauzas and sean-k-mooney for the quick reviews! | 11:01 |
| sean-k-mooney | its the same as os-vif | 11:04 |
| sean-k-mooney | cycle-with-intermediary is the default and most useful release model we have | 11:04 |
| whoami-rajat | yep, works good for client/non-client libraries | 11:05 |
| opendevreview | Jorge San Emeterio proposed openstack/nova-specs master: Review usage of oslo-privsep library on Nova https://review.opendev.org/c/openstack/nova-specs/+/865432 | 11:29 |
| *** sfinucan is now known as stephenfin | 11:42 | |
| elodilles | bauzas: sean-k-mooney: i think that patch is not needed: https://review.opendev.org/c/openstack/nova/+/866326 | 12:14 |
| elodilles | i mean the above fixed already the issue ^^^ | 12:14 |
| elodilles | so this is not needed and does not change anything: https://review.opendev.org/c/openstack/nova/+/866326 | 12:15 |
| elodilles | by default the 'required project' is checked out with the matching branch | 12:15 |
| elodilles | the override-branch is needed only if we run the job from a different branch, which we don't do | 12:17 |
| opendevreview | Merged openstack/nova stable/wallaby: [stable-only] Use os-brick from source in wallaby https://review.opendev.org/c/openstack/nova/+/866326 | 12:21 |
| opendevreview | Merged openstack/nova stable/wallaby: Add nova-ovs-hybrid-plug job https://review.opendev.org/c/openstack/nova/+/828418 | 12:21 |
| sean-k-mooney | elodilles: oh sorry your right | 12:21 |
| sean-k-mooney | its not | 12:21 |
| sean-k-mooney | elodilles: i miss read it i tought it was adding os-brick | 12:22 |
| sean-k-mooney | not adding the branchi missed that because of the comment | 12:22 |
| sean-k-mooney | actully its also using the explit fully quallifed version which we shoudl revert | 12:22 |
| sean-k-mooney | opendev.org/openstack/os-brick make it harder for third party cis | 12:23 |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: Don't ignore InstanceNotFound exception by libvirt https://review.opendev.org/c/openstack/nova/+/863665 | 12:23 |
| opendevreview | Merged openstack/nova stable/wallaby: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/c/openstack/nova/+/828419 | 12:24 |
| opendevreview | sean mooney proposed openstack/nova stable/wallaby: Revert "[stable-only] Use os-brick from source in wallaby" https://review.opendev.org/c/openstack/nova/+/866454 | 12:25 |
| sean-k-mooney | elodilles: ^ bauzas ^ | 12:25 |
| sean-k-mooney | elodilles: the other disadvantage of the patch we just merged is i think override-branch: takes precidence over depneds on but not 100% sure about that | 12:26 |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: Don't ignore InstanceNotFound exception by libvirt https://review.opendev.org/c/openstack/nova/+/863665 | 12:29 |
| elodilles | sean-k-mooney: thanks, +2'd | 12:32 |
| sean-k-mooney | whoami-rajat: ^ just so you are aware we are reverting that patch since we already had an equivlanet merged | 12:33 |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: Don't ignore InstanceNotFound exception by libvirt https://review.opendev.org/c/openstack/nova/+/863665 | 12:35 |
| whoami-rajat | sean-k-mooney, not sure what's the reason of revert since the gate on devstack is still broken with existing changes -- as mentioned in my commit message | 12:54 |
| whoami-rajat | which my patch intended to fix | 12:55 |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: Log some InstanceNotFound exceptions from libvirt https://review.opendev.org/c/openstack/nova/+/863665 | 12:57 |
| elodilles | whoami-rajat: are you sure? | 13:01 |
| whoami-rajat | elodilles, well, it was broken when i proposed the patch, checking again | 13:01 |
| elodilles | whoami-rajat: our fix landed on Nov 22nd, ~ 7 pm | 13:01 |
| sean-k-mooney | whoami-rajat: the two shoudl mostly be the same exactp you are forcing the branch to be stable/wallaby | 13:02 |
| sean-k-mooney | which is the default that will be used by zuul on the stable brnach | 13:02 |
| sean-k-mooney | the only other change is you are explcitly referncing the connection that provides the repo | 13:03 |
| whoami-rajat | ah i see now | 13:04 |
| whoami-rajat | the gate report on this is 11:49 (my time) 22nd november | 13:05 |
| whoami-rajat | and the patch you've referenced merged 11:48 22nd november https://review.opendev.org/c/openstack/nova/+/865134 | 13:05 |
| whoami-rajat | let's see if the gate is green on devstack after the revert | 13:06 |
| *** akekane is now known as abhishekk | 13:40 | |
| bauzas | whoami-rajat: sean-k-mooney: elodilles: sorry was doing other things | 13:54 |
| bauzas | +Wd the revert | 13:54 |
| bauzas | thanks elodilles for the spotting, gtk that by default we don't use a release | 13:55 |
| sean-k-mooney | if you add it to requried project it add it to devstackts LIBS_FROM_GIT config option | 14:00 |
| sean-k-mooney | and it also make zuul prepare the git repo in the corerct location | 14:01 |
| sean-k-mooney | inclduing resloveing any depends on | 14:01 |
| sean-k-mooney | by default the same branch as the job will be used for the branch of any required proejct | 14:01 |
| sean-k-mooney | so branch-override is only need for thinks like tempest athat are branchless | 14:02 |
| *** dasm|off is now known as dasm | 14:14 | |
| opendevreview | Merged openstack/nova stable/wallaby: Revert "[stable-only] Use os-brick from source in wallaby" https://review.opendev.org/c/openstack/nova/+/866454 | 15:37 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!