| opendevreview | Takashi Natsume proposed openstack/nova master: Add a hacking rule for the setDaemon method https://review.opendev.org/c/openstack/nova/+/854653 | 02:55 |
|---|---|---|
| Uggla | Good morning Nova. | 08:40 |
| gibi | Uggla: o/ | 09:00 |
| elodilles | bauzas sean-k-mooney[m] : last meeting i was mostly focusing on the stein-queens EOL'ing that i forgot about nova's Wallaby-EM transition :/ | 09:59 |
| elodilles | bauzas sean-k-mooney[m] : the transition patch was proposed 2 weeks ago, but now i realized that we have some merged patch to release as well: https://zuul.opendev.org/t/openstack/build/ff461f8d94b640c2a055935f3ca620bb/log/tox/list-changes-results.log#707-762 | 10:00 |
| elodilles | bauzas sean-k-mooney[m] : so when you have time could you please decide whether we need this final-wallaby-release? it is a bit risky as the deadline was yesterday for the transition, so what we release will be the 'final', so we should be sure not to introduce regression in the final release | 10:02 |
| elodilles | this is the release patch by the way: https://review.opendev.org/c/openstack/releases/+/863490 | 10:03 |
| sean-k-mooney[m] | ack ill take a look | 11:08 |
| sean-k-mooney[m] | elodilles: i am going to propose a release for os-vif on stable wallaby soon by the way. there isnt really any impoarnt patche except the ones that updated the upper constraits but it would be nice to use the correct one in the os-vif package. | 11:09 |
| sean-k-mooney[m] | elodilles: what is that zuul link is that what we last released or is that the pending changes | 11:12 |
| bauzas | sorry, I was on meetings this morning | 11:13 |
| sean-k-mooney[m] | looking at the review its what is pending right | 11:13 |
| bauzas | I'll try to look at that yes | 11:13 |
| sean-k-mooney[m] | looking at the commits in the review i think its a good idea to do a final release yes | 11:14 |
| sean-k-mooney[m] | the bdm patch is important if you host mount ceph volumes the evaucate path is also useful for operators, the ironic plug_vifs change is an important performance enhancement when restartign the nova compute agaent | 11:16 |
| sean-k-mooney[m] | all of these are operational enhancments that operators will like to recive | 11:16 |
| elodilles | sean-k-mooney[m]: OK, thanks, then let's release this and then do the EM transition \o/ | 12:28 |
| elodilles | sean-k-mooney[m]: about the os-vif: upper-constraints won't be part of the package so it will be the very same as the previous release, thus i'd say it is not worth to release | 12:29 |
| sean-k-mooney[m] | no worries my office is currently being used for an interview so im using the mornign to do reviews anyway | 12:29 |
| darkhorse | Hi team - I have published a patchset https://review.opendev.org/c/openstack/nova/+/862404. It has passed CI build test and is still pending. | 12:45 |
| darkhorse | Can anyone guide me what I should do to get it approved/merged? | 12:46 |
| dansmith | darkhorse: can you add the assertions I just commented? | 13:48 |
| dansmith | darkhorse: do that and add the bug link and I'll approve | 13:48 |
| dansmith | bauzas: can you +W this so we can enable some more tests? https://review.opendev.org/c/openstack/nova/+/860863/2 | 13:55 |
| dansmith | (or gibi or sean-k-mooney[m] ) | 13:56 |
| bauzas | dansmith: done | 14:22 |
| dansmith | bauzas: thanks | 14:22 |
| dansmith | bauzas: I'm going to be back here asking for this one later, once a devstack patch merges: https://review.opendev.org/c/openstack/nova/+/860864/13 | 14:22 |
| dansmith | but that ^ gets us a little more normalish behavior because the image can be more like a normal sized one.. meaning image operations don't take zero time like they do with cirros | 14:23 |
| ralonsoh | gibi, hi, whenever you can, please check https://review.opendev.org/c/openstack/neutron-specs/+/860859/4/specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst#95 | 14:25 |
| ralonsoh | (no rush) | 14:25 |
| *** dasm|off is now known as dasm | 14:28 | |
| sean-k-mooney[m] | oh right i rebooted i need to open irc on my main laptop https://review.opendev.org/c/openstack/nova/+/860863/2 looks like it shoudl be on its way to merging | 14:49 |
| dansmith | yep | 14:49 |
| opendevreview | Alex Chan proposed openstack/nova master: record action log when deleting shelved instance https://review.opendev.org/c/openstack/nova/+/862404 | 15:02 |
| darkhorse | dansmith: I added the bug link but I did not get the other comments? Will you give me some examples? | 15:11 |
| gibi | ralonsoh: done | 15:11 |
| dansmith | darkhorse: https://review.opendev.org/c/openstack/nova/+/862404/2/nova/tests/unit/compute/test_api.py#1260 | 15:15 |
| dansmith | darkhorse: also, you need to add the bug reference in the exact format that was suggested | 15:16 |
| ralonsoh | gibi, thanks! | 15:16 |
| sean-k-mooney | ralonsoh: you know tunneled supprot was in scope fo the orginal bandwith in placment spec right | 15:19 |
| ralonsoh | sean-k-mooney, I don't remember that (and I created the spec) | 15:19 |
| ralonsoh | maybe for Nova | 15:19 |
| sean-k-mooney | it definetly was | 15:20 |
| sean-k-mooney | i have left some comments on teh new spec but i dont have time to do a full review right now | 15:20 |
| sean-k-mooney | am other thign gibi you support tunnteled networks for pps too right | 15:24 |
| sean-k-mooney | we we dont we shoudl fix both at the same time | 15:24 |
| sean-k-mooney | darkhorse: this might be worth reading over when you have time https://wiki.openstack.org/wiki/GitCommitMessages | 15:26 |
| sean-k-mooney | also https://docs.opendev.org/opendev/infra-manual/latest/developers.html#working-on-bugs | 15:26 |
| darkhorse | sean-k-mooney: thank you for the links about commit messaging. | 15:31 |
| darkhorse | dansmith: Excuse me and thank you for your patience. I am still not understanding how I can add assert. Is there an example code that does something similar? | 15:32 |
| opendevreview | Merged openstack/nova master: Enable glance location tests on ceph-multistore https://review.opendev.org/c/openstack/nova/+/860863 | 15:56 |
| dansmith | darkhorse: well, here's an example: https://review.opendev.org/c/openstack/nova/+/862404/3/nova/tests/unit/compute/test_api.py#1271 | 16:06 |
| dansmith | if it gets called more than once, mock.has_calls() | 16:07 |
| gibi | sean-k-mooney: I'm not sure we have explicit tunelled network support but I 70% sure that the nova code does not make any assumption about the port.resource_request | 17:19 |
| gibi | so what neutron try to do is probably work with the existing nova support out of the box | 17:19 |
| sean-k-mooney | proably but i tought we benchmarked it with tunnels at one point | 17:20 |
| sean-k-mooney | i think your are right that the nova side will work | 17:20 |
| sean-k-mooney | what then need to be carful of is not assuming the tunnel bandwith is independnet of the physnet bandwith | 17:21 |
| sean-k-mooney | it can be | 17:21 |
| sean-k-mooney | but it would be the less common deployment model | 17:22 |
| gibi | yeah, if the tunelled networks using the same phyiscal interface than a physnet uses then the currently proposed model doesn't work as the physnet and the tunelled bandwidth then cannot be represented separately | 17:23 |
| sean-k-mooney | well that is what ooo should be doing today (sharing one interface for tunneled and notn tunneled traffic) by default | 17:25 |
| opendevreview | Dan Smith proposed openstack/nova master: Test ceph-multistore with a real image https://review.opendev.org/c/openstack/nova/+/860864 | 17:28 |
| gibi | sean-k-mooney: OK, I see you highlighted that in a comment. cool. the current proposal only works if the tunelled traffic has its own dedicated interface | 17:33 |
| sean-k-mooney | that wont work for ovs-dpdk or hardware offloads really | 17:38 |
| sean-k-mooney | you can confirue it so that they could use a dedicated interface but not without more work and cost | 17:39 |
| sean-k-mooney | im actully not sure about hardwar offloaded ovs | 17:39 |
| gibi | if they share interface then the deployer should statically split bw inventory between the RPs representing the physnet and the tunnel | 17:40 |
| gibi | sean-k-mooney: could there be more than one interface for the tunneled traffic ? | 17:41 |
| opendevreview | Alex Chan proposed openstack/nova master: record action log when deleting shelved instance Closes-Bug: #1993736 Change-Id: I9ce18cbba5083c55d15d9b7c2a89133d227754ea https://review.opendev.org/c/openstack/nova/+/863547 | 17:43 |
| sean-k-mooney | gibi: there is only one local tunnel ip | 17:46 |
| sean-k-mooney | gibi: so yes but its defiend by the routing table which interface is used | 17:46 |
| sean-k-mooney | there are two way to do this | 17:46 |
| sean-k-mooney | either you have a singel intterface (can be a bond or bridge) that has the tunnel local ip | 17:47 |
| sean-k-mooney | and you confiure the route to all remote host via that | 17:47 |
| sean-k-mooney | the simples way is to use a single subnet for all compute/network nodes | 17:47 |
| sean-k-mooney | or you can deviced your tunneld network in to multipel l3 subnets | 17:47 |
| sean-k-mooney | in which case if you have a multi homed server the multipel interface can be used | 17:48 |
| sean-k-mooney | i dont see a go way to suppor the multi homed case simply | 17:48 |
| sean-k-mooney | how the tx path works is ovs pushes a vxlan/geneve header on the packet and looks at a cache of the host routing tabel to 1 determin the source interface to use to reach the destination tunnel endpoint | 17:49 |
| sean-k-mooney | if the source interafeace is an ovs bridge it just uses the normal action to transmit the tunneld packet onto the physical netowrk via normal mac larning | 17:50 |
| sean-k-mooney | if the tunnel local ip is not assocated with an ovs brige it passes the encpsulated packet to the host kernel netowrk stack and it routes it | 17:51 |
| sean-k-mooney | passing it to the host kernel routign stack is best avoided becasue its slower and hard to do qos for if there are potitally mulitiple paths | 17:52 |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: Add functional tests to reproduce bug #1994983 https://review.opendev.org/c/openstack/nova/+/863416 | 18:03 |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: Add functional tests to reproduce bug #1994983 https://review.opendev.org/c/openstack/nova/+/863416 | 18:06 |
| sean-k-mooney | gibi: i linked to this converation in the spec ill try and find time to follow up with rodolfo next week some time | 18:10 |
| gibi | cool, thanks | 18:10 |
| opendevreview | Alex Chan proposed openstack/nova master: record action log when deleting shelved instance https://review.opendev.org/c/openstack/nova/+/862404 | 18:19 |
| *** gibi is now known as gibi_pto | 19:15 | |
| dansmith | remember when I volunteered to do the stable compute uuid thing at ptg? | 19:30 |
| dansmith | why TF didn't anyone slap me? | 19:30 |
| darkhorse | dansmith: I added the assert as you suggested. https://review.opendev.org/c/openstack/nova/+/862404 | 20:19 |
| dansmith | darkhorse: yeah, just to the first one.. is the second one just as easy? | 20:20 |
| dansmith | I was also waiting to see tests pass | 20:20 |
| darkhorse | excuse me I did not know there was second one. it should be as easy. let me check and add assert to second too. | 20:22 |
| dansmith | darkhorse: I said "same below" in my comment, but I should have been more explicit | 20:23 |
| dansmith | darkhorse: https://review.opendev.org/c/openstack/nova/+/862404/4/nova/tests/unit/compute/test_api.py#7914 | 20:24 |
| dansmith | that ^ one | 20:24 |
| darkhorse | dansmith: thank you for clarification. | 20:25 |
| opendevreview | Alex Chan proposed openstack/nova master: record action log when deleting shelved instance https://review.opendev.org/c/openstack/nova/+/862404 | 20:47 |
| dansmith | darkhorse: it's on its way | 20:56 |
| *** dasm is now known as dasm|off | 22:58 | |
| opendevreview | Merged openstack/nova master: record action log when deleting shelved instance https://review.opendev.org/c/openstack/nova/+/862404 | 23:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!