| opendevreview | melanie witt proposed openstack/nova master: Add mock to avoid loading guestfs in unit test https://review.opendev.org/c/openstack/nova/+/862769 | 02:26 |
|---|---|---|
| *** dasm|rover is now known as dasm|off | 03:50 | |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | 08:12 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | 08:12 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova-specs master: spec: allowing target state for evacuate https://review.opendev.org/c/openstack/nova-specs/+/857838 | 08:19 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce PCI pool filtering bug https://review.opendev.org/c/openstack/nova/+/855649 | 08:56 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Strictly follow placement allocation during PCI claim https://review.opendev.org/c/openstack/nova/+/855650 | 08:56 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Show candidate combinatorial explosion by dev number https://review.opendev.org/c/openstack/nova/+/855885 | 08:56 |
| gibi | bauzas: a procedural question. We have the RFE bug filed for the port route metric support https://bugs.launchpad.net/nova/+bug/1994137 it is a whislist so that part is OK. Should I simply set it to Triaged or we want to discuss it in the next meeting before I set Triaged? | 09:01 |
| bauzas | gibi: no, we agreed on it so Triage it directly ;) | 09:02 |
| gibi | OK. | 09:02 |
| * bauzas will create other rfe bugs we agreed at the PTG | 09:02 | |
| auniyal_ | Hi bauzas, gibi, sean-k-mooney | 09:04 |
| auniyal_ | can you please review theses - these are backports | 09:05 |
| auniyal_ | 09:05 | |
| auniyal_ | https://review.opendev.org/c/openstack/nova/+/861856 | 09:05 |
| auniyal_ | https://review.opendev.org/c/openstack/nova/+/861857 | 09:05 |
| auniyal_ | 09:05 | |
| auniyal_ | https://review.opendev.org/c/openstack/nova/+/861871 | 09:05 |
| auniyal_ | https://review.opendev.org/c/openstack/nova/+/861872 | 09:05 |
| auniyal_ | 09:05 | |
| auniyal_ | https://review.opendev.org/c/openstack/nova/+/862604 | 09:05 |
| auniyal_ | https://review.opendev.org/c/openstack/nova/+/862603 | 09:05 |
| auniyal_ | 09:05 | |
| auniyal_ | mostly clean cherry-pick | 09:05 |
| amorin | hello nova team, when using ovs backend, nova plugs interface in ovs using vif_plug_ovs python module | 09:35 |
| amorin | I was expecting to find the vif_plug_ovs option available in the config reference: | 09:36 |
| amorin | https://docs.openstack.org/nova/latest/configuration/config.html | 09:36 |
| amorin | but it's not | 09:36 |
| amorin | https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py#L54 | 09:36 |
| amorin | is that normal? | 09:37 |
| sean-k-mooney | its a know issue | 09:45 |
| sean-k-mooney | so technically os-vif is not part of nova | 09:45 |
| sean-k-mooney | to have it incldued in novas docs | 09:45 |
| bauzas | I was about to say it :) | 09:45 |
| sean-k-mooney | we need to list it in the generation command | 09:45 |
| bauzas | this is not a middleware we import | 09:45 |
| sean-k-mooney | someone was goign to fix it a while ago | 09:45 |
| sean-k-mooney | feel free to if you want | 09:45 |
| sean-k-mooney | bauzas: actully it is | 09:45 |
| sean-k-mooney | but not in the docs | 09:46 |
| bauzas | sean-k-mooney: this is a lazy import ? | 09:46 |
| sean-k-mooney | vif_plug_ovs is import when we init os-vif | 09:46 |
| bauzas | correct, so a lazy import | 09:46 |
| sean-k-mooney | its the in tree ovs plugin | 09:46 |
| bauzas | hence me wondering how we could generate the config without importing it directly | 09:47 |
| sean-k-mooney | ya but when we generate the config refence we need to list the namespaces to generate | 09:47 |
| sean-k-mooney | and we dont | 09:47 |
| bauzas | without not* | 09:47 |
| gibi | auniyal_: left +2s on the first and left some feedback in https://review.opendev.org/c/openstack/nova/+/862603 | 09:48 |
| sean-k-mooney | amorin: anyway back to yoru question its just a case of we never got aroudn to it | 09:49 |
| sean-k-mooney | so patches are welcome i was just loking for where to chagne it but i dont rememebr off the top of my head | 09:50 |
| sean-k-mooney | i think you need to add it here https://github.com/openstack/nova/blob/master/etc/nova/nova-config-generator.conf#L18 | 09:50 |
| bauzas | https://github.com/openstack/nova/blob/master/etc/nova/nova-config-generator.conf | 09:50 |
| sean-k-mooney | ya | 09:50 |
| amorin | ack, perfect | 09:50 |
| bauzas | damn, again, beated | 09:50 |
| amorin | I will try to propose a change then | 09:50 |
| bauzas | amorin: test it locally | 09:51 |
| bauzas | amorin: you have a tox target | 09:51 |
| sean-k-mooney | can you add all the in tree plugsin so also linux bridge | 09:51 |
| bauzas | tox -egenconfig | 09:51 |
| amorin | ok | 09:51 |
| sean-k-mooney | the noop pluging does not have config so you can ignore it | 09:51 |
| amorin | so it's os-vif + linux-bridge | 09:53 |
| amorin | is the list somewhere? | 09:53 |
| sean-k-mooney | https://github.com/openstack/os-vif | 09:53 |
| sean-k-mooney | there are 3 plugins the vif_plug diretories | 09:54 |
| sean-k-mooney | and the ovs and linux bridge ones have config options | 09:54 |
| sean-k-mooney | amorin: this is how the cofnig is regestered https://github.com/openstack/os-vif/blob/master/os_vif/plugin.py#L71-L89 | 09:55 |
| sean-k-mooney | the linux bridge name is https://github.com/openstack/os-vif/blob/b0298b5350f21f858f2bf72c5d18e3019a696514/vif_plug_linux_bridge/constants.py#L13 | 09:57 |
| sean-k-mooney | os os_vif_linux_bridge | 09:57 |
| sean-k-mooney | that i think will be the namespace you need to list but i have not tried that to see if that is correct or if the namespace shoudl just be os_vif or something like that | 09:58 |
| darkhorse | sean-k-mooney: thank you for responding to the issue that I have reported to launchpad. https://bugs.launchpad.net/nova/+bug/1993736 | 10:09 |
| darkhorse | I think I did not make clear description there. I have updated the description and put a link to a patchset that I have published. | 10:10 |
| darkhorse | Will you take a look at it when you find a moment? | 10:11 |
| amorin | ack, thanks sean-k-mooney | 10:12 |
| amorin | and bauzas | 10:12 |
| auniyal_ | thanks gibi | 10:51 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova-specs master: spec: allowing target state for evacuate https://review.opendev.org/c/openstack/nova-specs/+/857838 | 11:28 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova-specs master: spec: allowing target state for evacuate https://review.opendev.org/c/openstack/nova-specs/+/857838 | 11:44 |
| songwenping_ | sean-k-mooney: hi, in our Rocky version env, placement integrate with nova, placement-api service comes across this error https://bugs.launchpad.net/nova/+bug/1314554/, and return 500 when call its api. do you have any idea? | 11:51 |
| sean-k-mooney | i dont think we support nosetests in rocky by the way but that not really the issue | 11:53 |
| sean-k-mooney | well it might be related | 11:55 |
| sean-k-mooney | songwenping_: do you get the same issue if you use stestr or tox to run the tests | 11:56 |
| songwenping_ | our tests cannot run, we have give up the test in our product env. | 12:02 |
| sean-k-mooney | we will be end of lifing the rocky branch shortly with no other release planned | 12:03 |
| sean-k-mooney | if this is broken its likely not a recent breakage | 12:03 |
| sean-k-mooney | the last commit to stable rocky was the 22nd of april this year | 12:04 |
| sean-k-mooney | so your product tests have been broken since then or longer | 12:04 |
| songwenping_ | yes we have broken for long time | 12:06 |
| sean-k-mooney | im running the test locally now to confirm but this could be due to a downstream change you have in your product | 12:06 |
| sean-k-mooney | songwenping_: so the test pass correctly with tox using stestr | 12:14 |
| sean-k-mooney | nosetest was never supported in the rocky release so this might be just down to using the incorrect test runner | 12:14 |
| sean-k-mooney | so this sound like its either a downstream bug or a bug in how you are runnign the tests | 12:14 |
| sean-k-mooney | sahid: comments left on https://review.opendev.org/c/openstack/nova-specs/+/857838 | 12:21 |
| songwenping_ | sean-k-mooney: i'm finding the lastest changid for our code. | 12:23 |
| darkhorse | Hi team Can I get someone's attention on https://bugs.launchpad.net/nova/+bug/1993736? | 12:32 |
| sean-k-mooney | darkhorse: ah you got the test passign | 12:39 |
| darkhorse | yes | 12:39 |
| darkhorse | sean-k-mooney: yes | 12:39 |
| sean-k-mooney | so just lookign at it quickly | 12:41 |
| sean-k-mooney | it woudl be nice to add a functional test | 12:41 |
| sean-k-mooney | and assert teh instance action log now has the deelted action | 12:41 |
| sean-k-mooney | you just fixed the existing test but did not add any to test the change you made | 12:41 |
| sean-k-mooney | as in there is no test to actully ensure the instnace action log now has the deleted actions | 12:42 |
| darkhorse | sean-k-mooney: will you give me some more details/examples? i think there are already functional tests for deleting shelve offloaded instances. | 12:47 |
| darkhorse | excuse me this is my first time committing to upstream | 12:48 |
| sean-k-mooney | darkhorse: yes there shoudl be an existing one that you can just add a rest call to get the list of instance action events and check that the deleted on is in the list | 13:06 |
| sean-k-mooney | ill see if i can fidn one quickly | 13:06 |
| darkhorse | sean-k-mooney: thank you! | 13:07 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L2578-L2598 | 13:08 |
| sean-k-mooney | thats a simple shelve unshleve test with delete at teh end | 13:08 |
| sean-k-mooney | so you can copy that skip the unshelve step and then add a call to the event list api | 13:09 |
| sean-k-mooney | and assert delete is there | 13:09 |
| sean-k-mooney | let me see if there is an existing server event list test you could copy form | 13:09 |
| *** dasm|off is now known as dasm|rover | 13:10 | |
| sean-k-mooney | darkhorse: yes ok so there are example here https://github.com/openstack/nova/blob/master/nova/tests/functional/test_instance_actions.py | 13:12 |
| sean-k-mooney | so you coudl add a new test case by modifying https://github.com/openstack/nova/blob/master/nova/tests/functional/test_instance_actions.py#L96 | 13:13 |
| darkhorse | sean-k-mooney: thank you! I will take a look and add functional test for shelved instance deletion. | 13:14 |
| sean-k-mooney | so you really just need this https://github.com/openstack/nova/blob/master/nova/tests/functional/test_instance_actions.py#L229-L234 | 13:14 |
| sahid | sean-k-mooney: ack thank you | 13:14 |
| sean-k-mooney | darkhorse: i would put this test in the other file test_servers | 13:15 |
| sean-k-mooney | and just copy the shelve_unshelve test as i said and add in this check | 13:15 |
| sean-k-mooney | then it would be good | 13:15 |
| darkhorse | sean-k-mooney: ok thank you | 13:16 |
| opendevreview | Elod Illes proposed openstack/nova stable/wallaby: Retry image download if it's corrupted https://review.opendev.org/c/openstack/nova/+/819180 | 13:21 |
| opendevreview | Elod Illes proposed openstack/nova stable/victoria: Retry image download if it's corrupted https://review.opendev.org/c/openstack/nova/+/819181 | 13:23 |
| *** knikolla[m] is now known as knikolla | 14:38 | |
| melwitt | sean-k-mooney[m]: this is what I came up with for that unit test loading guestfs issue, also put some repro steps in the referenced lp bug if you want to see https://review.opendev.org/c/openstack/nova/+/862769 | 15:59 |
| sean-k-mooney[m] | cool ill take a look in a while | 16:00 |
| sean-k-mooney[m] | ok ya that looks interesting | 16:03 |
| sean-k-mooney[m] | i set rp+1 on it so ill come back to it in a bit. deliveray arriving shortly | 16:04 |
| sean-k-mooney[m] | so need to step away for a few minutes | 16:04 |
| melwitt | k. no rush of course, just wanted to show you it | 16:06 |
| sean-k-mooney[m] | so its a slightly difffernt approch then our other poison fixtures but its also a slight different usecase | 16:07 |
| melwitt | if you have suggestions lmk. that's just the best I could think of at the time :P | 16:08 |
| sean-k-mooney[m] | the only thing i was thinking about really is this only works if we use the oslo import utils funciton | 16:09 |
| sean-k-mooney[m] | and not a import statement | 16:09 |
| melwitt | yes. I tried to make __import__ work but failed. if you know how, lmk | 16:10 |
| melwitt | I didn't find a way to monkey patch it. I also haven't really monkey patched built ins before that I can remember | 16:11 |
| sean-k-mooney[m] | i feel like i have look it up before but i dont rememebr how to do it currelty | 16:11 |
| sean-k-mooney[m] | we can always make it more robost later so we can likely start with this | 16:12 |
| sean-k-mooney[m] | https://stackoverflow.com/a/63320902 | 16:14 |
| sean-k-mooney[m] | we could try doing that ^ | 16:16 |
| melwitt | thanks! that looks promising | 16:16 |
| sean-k-mooney[m] | not sure if that will have the opisite probalem and only work for import but i think it should work for both | 16:16 |
| melwitt | I'll try it | 16:16 |
| gibi | we could poison VFSGuestFS.__init__ | 16:25 |
| gibi | but that is more specific to the current code than the import poison | 16:26 |
| gibi | so I'm fine with both | 16:26 |
| opendevreview | Amit Uniyal proposed openstack/nova master: DOC update remote console access https://review.opendev.org/c/openstack/nova/+/860687 | 18:01 |
| opendevreview | John Garbutt proposed openstack/nova-specs master: WIP: Ironic shards to replace peer_list https://review.opendev.org/c/openstack/nova-specs/+/862833 | 18:07 |
| opendevreview | John Garbutt proposed openstack/nova-specs master: WIP: Ironic shards to replace peer_list https://review.opendev.org/c/openstack/nova-specs/+/862833 | 18:08 |
| opendevreview | John Garbutt proposed openstack/nova-specs master: WIP: Ironic shards to replace peer_list https://review.opendev.org/c/openstack/nova-specs/+/862833 | 18:10 |
| opendevreview | melanie witt proposed openstack/nova master: Add mock to avoid loading guestfs in unit test https://review.opendev.org/c/openstack/nova/+/862769 | 19:00 |
| *** dasm|rover is now known as dasm|off | 19:21 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!