| *** bhagyashris|ruck is now known as bhagyashris | 05:13 | |
| opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/861871 | 07:14 |
|---|---|---|
| opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: [compute] always set instance.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/861872 | 07:14 |
| opendevreview | Slawek Kaplonski proposed openstack/nova master: Don't provide MTU value in metadata service if DHCP is enabled https://review.opendev.org/c/openstack/nova/+/855664 | 09:14 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/zed: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/861856 | 09:41 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/zed: [compute] always set instance.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/861857 | 09:41 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/861871 | 09:46 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/861871 | 12:52 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: [compute] always set instance.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/861872 | 12:52 |
| bauzas | reminder : we start now our last PTG day, just sayin' :) | 13:01 |
| sean-k-mooney | oh | 13:03 |
| sean-k-mooney | ah ill get coffee then join | 13:03 |
| sean-k-mooney | feel free to start without me | 13:03 |
| sean-k-mooney | ill be 5 minutes | 13:03 |
| bauzas | cool | 13:03 |
| bauzas | stephenfin: we're about to discuss your OSC topic next in a second | 13:55 |
| stephenfin | bauzas: I'm in the SDK/OSC session :( Can you take notes and I can address async? | 13:56 |
| bauzas | stephenfin: oh, when is this session done ? | 13:56 |
| stephenfin | 1 hour | 13:56 |
| bauzas | stephenfin: I see, ending at 3pm UTC ? | 13:56 |
| stephenfin | yes | 13:57 |
| *** dasm|off is now known as dasm|rover | 14:16 | |
| darkhorse | Hi team | 14:30 |
| darkhorse | File "/home/zuul/src/opendev.org/openstack/nova/nova/tests/fixtures/nova.py", line 224, in _poison_configure | 14:30 |
| darkhorse | raise Exception('This test uses methods that set internal oslo_db ' | 14:30 |
| darkhorse | Exception: This test uses methods that set internal oslo_db state, but it does not claim to use the database. This will conflict with the setup of tests that do use the database and cause failures later. | 14:30 |
| darkhorse | I have committed a patchset to fix the issue that I reported [here] (https://bugs.launchpad.net/nova/+bug/1993736) | 14:31 |
| darkhorse | I am getting a CI build error above. | 14:31 |
| darkhorse | What does that exception mean and how can I fix it? | 14:32 |
| gibi | darkhorse: you have a unit test case that actaully try to hit the DB | 14:33 |
| gibi | could you point to the failure in CI? | 14:33 |
| darkhorse | yes my patch is trying to add delete action log for shelved instances. when an instance is deleted at shelved_offloaded state, delete action is not added to action-list. | 14:37 |
| darkhorse | https://review.opendev.org/c/openstack/nova/+/861951 | 14:38 |
| darkhorse | here is the patchset | 14:38 |
| darkhorse | and this is the failure in CI | 14:38 |
| darkhorse | https://zuul.opendev.org/t/openstack/build/0ed00dd1d0354da9b7724f32339f063e | 14:38 |
| darkhorse | gibi: thank you for replying to my questions. | 14:39 |
| gibi | darkhorse: so that unit test case https://github.com/openstack/nova/blob/b1958b7cfa6b8aca5b76b3f133627bb733d29f00/nova/tests/unit/compute/test_api.py#L7908 is set up in a way that it mocks out every call that touches the DB. But the patch https://review.opendev.org/c/openstack/nova/+/861951 added a new call _record_action_start that is eventually write to the DB | 14:43 |
| gibi | darkhorse: so you have to change the test to also mock _record_action_start | 14:45 |
| darkhorse | gibi: will you point me how to do that? | 14:46 |
| gibi | darkhorse: you can look at the other tests in https://github.com/openstack/nova/blob/b1958b7cfa6b8aca5b76b3f133627bb733d29f00/nova/tests/unit/compute/test_api.py#L7908 how mocking is doen | 14:47 |
| gibi | done | 14:47 |
| gibi | for example https://github.com/openstack/nova/blob/b1958b7cfa6b8aca5b76b3f133627bb733d29f00/nova/tests/unit/compute/test_api.py#L8090-L8102 is mocking _record_action_start | 14:47 |
| darkhorse | gibi: thank you so much!! | 14:58 |
| bauzas | thanks folks, was a productive PTG | 15:23 |
| gibi | bauzas: thanks for running it | 15:37 |
| melwitt | bauzas: thank you for connecting me with whoami-rajat for ptg, cinder team were able to fit me in the agenda and we had a good chat and a way forward | 15:39 |
| bauzas | ++ | 15:39 |
| whoami-rajat | melwitt, thanks for joining and discussing it | 17:02 |
| melwitt | ++ | 17:02 |
| opendevreview | Alex Chan proposed openstack/nova stable/xena: fix instance action log when deleting shelved instance https://review.opendev.org/c/openstack/nova/+/861951 | 18:37 |
| opendevreview | Erlon R. Cruz proposed openstack/nova stable/wallaby: Fix pre_live_migration rollback https://review.opendev.org/c/openstack/nova/+/836016 | 19:14 |
| opendevreview | Erlon R. Cruz proposed openstack/nova stable/wallaby: Adds regression test for bug LP#1944619 https://review.opendev.org/c/openstack/nova/+/862401 | 19:14 |
| opendevreview | Erlon R. Cruz proposed openstack/nova stable/wallaby: Adds regression test for bug LP#1944619 https://review.opendev.org/c/openstack/nova/+/838332 | 19:18 |
| opendevreview | Erlon R. Cruz proposed openstack/nova stable/wallaby: Fix pre_live_migration rollback https://review.opendev.org/c/openstack/nova/+/836016 | 19:18 |
| opendevreview | Alex Chan proposed openstack/nova master: record action log when deleting shelved instance https://review.opendev.org/c/openstack/nova/+/862404 | 20:14 |
| *** dasm|rover is now known as dasm|off | 22:09 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!