| opendevreview | Jorhson Deng proposed openstack/nova master: Allow user defined stop type https://review.opendev.org/c/openstack/nova/+/861333 | 01:55 |
|---|---|---|
| opendevreview | Jorhson Deng proposed openstack/nova master: Allow user defined stop type https://review.opendev.org/c/openstack/nova/+/861333 | 02:17 |
| opendevreview | Jorhson Deng proposed openstack/nova master: Allow user defined stop type https://review.opendev.org/c/openstack/nova/+/861333 | 05:44 |
| opendevreview | Jorhson Deng proposed openstack/nova master: Allow user defined stop type https://review.opendev.org/c/openstack/nova/+/861333 | 05:54 |
| *** bhagyashris is now known as bhagyashris|ruck | 06:24 | |
| sahid | o/ | 07:53 |
| sahid | any chance that you have a second look at https://review.opendev.org/c/openstack/nova-specs/+/857838 sean-k-mooney? I hope to have addressed most of your comments I just have kept open one to ensure that this is addressed in the right way | 07:54 |
| opendevreview | Jorhson Deng proposed openstack/nova master: Allow user defined stop type https://review.opendev.org/c/openstack/nova/+/861333 | 08:02 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/zed: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/861856 | 09:21 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/zed: [compute] always set instance.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/861857 | 09:21 |
| mnasiadka | Hello - any reason backport https://review.opendev.org/c/openstack/nova/+/829804 is hanging so long? | 10:25 |
| sean-k-mooney | mnasiadka: it just needs review it fell off my radar so i can take a look now | 10:28 |
| mnasiadka | sean-k-mooney: thanks! | 10:29 |
| sean-k-mooney | in general if a patch is up and not reviewd for a period of tiem we expect the autorp or backporteer to ping us | 10:29 |
| sean-k-mooney | we will eventualy get to it otherwise but the more vocal people are the more likely we are to see it | 10:29 |
| sean-k-mooney | elodilles: if you have time can you take a look at https://review.opendev.org/c/openstack/nova/+/829804 | 10:33 |
| mnasiadka | sean-k-mooney: Actually I need it in Wallaby, will do a cherry-pick today as well | 10:52 |
| sean-k-mooney | ack | 10:52 |
| opendevreview | Michal Nasiadka proposed openstack/nova stable/wallaby: Fix to implement 'pack' or 'spread' VM's NUMA cells https://review.opendev.org/c/openstack/nova/+/861832 | 10:53 |
| mnasiadka | actually it was clean, so simple as a click in Gerrit UI | 10:53 |
| sean-k-mooney | mnasiadka: you might also want the caching change we merged backported | 10:53 |
| sean-k-mooney | mnasiadka: gerrit wont set teh cherry-picked line correctly | 10:53 |
| sean-k-mooney | it only has one | 10:54 |
| sean-k-mooney | it should have one per branch | 10:54 |
| sean-k-mooney | so gerrit only works the first time | 10:54 |
| mnasiadka | ok, I'll update | 10:55 |
| mnasiadka | sean-k-mooney: caching change? which one is that? | 10:55 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/861871 | 10:55 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: [compute] always set instance.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/861872 | 10:55 |
| sahid | thank you sean-k-mooney[m], I have replied to one of you question, I'm not sure that we need to update the virt driver api but I may have missed something. At leaast the current impl that I have is working as expected for our usage | 11:30 |
| sahid | for the other I will address them when i will get more reviews for sure | 11:30 |
| sean-k-mooney1 | sahid: i belive you will need to chnage rebuild_instance to add the target state | 11:31 |
| *** sean-k-mooney1 is now known as sean-k-mooney | 11:31 | |
| sean-k-mooney | so that the driver does not try to start the vm | 11:31 |
| sahid | I have reused the way that we currently handle evacuated instance that are stopped | 11:31 |
| sahid | the driver start the instance and tjere is a process to stop it | 11:32 |
| sean-k-mooney | we should not do that really | 11:32 |
| sean-k-mooney | since the start is going to fail | 11:32 |
| sean-k-mooney | at least in teh encypted volume case | 11:33 |
| sean-k-mooney | ideally you would pass the target state in and only start it if required | 11:33 |
| sean-k-mooney | we can see what others think but if you say targetState=stop i would consider it a bug to attepmt to start it and then stop it | 11:34 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/858383/14/nova/compute/manager.py#3826 might be ok | 11:36 |
| sean-k-mooney | no looking at the workflow | 11:37 |
| sean-k-mooney | im pretty sure if you try that with an encypted volume the spawn will fail | 11:37 |
| sean-k-mooney | the admin wont be abel to retirve the key form barbican | 11:38 |
| sahid | sean-k-mooney: oh i see, at least in our use-case it's fine as everything is done using cloud-init and we don't wait for that to happen | 12:04 |
| sahid | I'm wondering whether it's not mandotary to have the vm started to libvirt would have installed the tap and qemu sent the arp, we also know that ovs agent needs to see net devices to configure network | 12:06 |
| sean-k-mooney | that woudl all happen when the user starts the vm | 12:07 |
| sean-k-mooney | we shoudl perhaps discuss this in the ptg or at least get more eye on the review | 12:08 |
| sean-k-mooney | binding the port in neutron makes sense im not sure that plugging the prot into ovs shoudl be done at this point | 12:08 |
| sean-k-mooney | we need to prepare the disk image/instance direcotry | 12:09 |
| sean-k-mooney | but im not sure we should go as far ad defining the domain | 12:09 |
| sean-k-mooney | we could maintain the current beahivor of powering it off after but that does not fell correct to me | 12:10 |
| sahid | i also had this feeling when I have noticed it but then I felt like this was perhaps a necessity | 12:11 |
| sahid | i can make some tests but that will be difficult for me to test all the combinaisons | 12:12 |
| sahid | for the case that is open in your side, does that can be tested easily? | 12:12 |
| sean-k-mooney | if we do that we need to catch the expction form looking up the key | 12:13 |
| sean-k-mooney | and basically ignore it in this case and proceed to powering it off. | 12:13 |
| sahid | i see, i can for sure doing that, but as you mention we probably first have to see whether we want to avoid the vm to be started at driver side, which could brings others implications | 12:15 |
| * sahid has some connectivity issues... | 12:24 | |
| opendevreview | ribaudr proposed openstack/nova-specs master: Draft spec to support scaphandre https://review.opendev.org/c/openstack/nova-specs/+/861881 | 12:27 |
| opendevreview | ribaudr proposed openstack/nova-specs master: Draft spec to support scaphandre https://review.opendev.org/c/openstack/nova-specs/+/861881 | 12:38 |
| bauzas | reminder : our PTG sessions start in 5 mins, see you there in the bexar room | 12:55 |
| bauzas | started ^ | 13:01 |
| bauzas | folks, we need you ! | 13:01 |
| bauzas | we'll start with discussing about ELO'ing stable branches for stein and older | 13:05 |
| bauzas | now* | 13:06 |
| *** dasm|off is now known as dasm | 13:55 | |
| bauzas | chateaulav: I know you're in the zoom room, but we are just discussing secure RBAC | 14:23 |
| bauzas | to sure you are listening | 14:23 |
| bauzas | not* sure | 14:23 |
| stephenfin | sean-k-mooney: Your background blur feature is going nuts :) | 14:30 |
| chateaulav | bauzas: thanks | 14:30 |
| sean-k-mooney | fixed by trunig it off | 14:39 |
| gibi | vmaccel: we will discuss the PCI in placement stuff in https://www.openinfra.dev/ptg/rooms/bexar in 3 minutes | 14:47 |
| opendevreview | Merged openstack/nova-specs master: Update the PCI in placement spec https://review.opendev.org/c/openstack/nova-specs/+/855218 | 15:00 |
| bauzas | sean-k-mooney: your audio becomes a bit robotic | 15:12 |
| stephenfin | sean-k-mooney: Y̶o̶u̶'̶r̶e̶ ̶a̶ ̶w̶i̶z̶a̶r̶d̶,̶ ̶H̶a̶r̶r̶y̶!̶ You're a robot, Sean! 🤖 | 15:15 |
| sean-k-mooney | still ok i might have to try treaking something | 15:17 |
| *** dasm is now known as dasm|off | 22:19 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!