Wednesday, 2022-09-14

obreHi all! I wonder if it is possible for me to propse a small change to nova? In short I would like to add a config-option allowing us to specify the value nova-compute reports to placement for VCPU:max_unit. The use-case is to avoid having instances consuming all CPU's of a compute-node (ex: I do not want instances using 24 cores to end up on my hypervisor with 24 cores; Id07:38
obrerather want them on larger hypervisors). Does it make sense?07:38
obreI am able to write the changes needed in nova/virt/libvirt/driver.py and nova/conf/compute.py, I just wonder if this is something that makes sense for me to try push upstream; or if there are obvious blockers I dont see?07:40
gibiobre: I'm wondering. it might be already possible with a provider.yaml file https://docs.openstack.org/nova/latest/admin/managing-resource-providers.html 07:40
gibibut if not, then I would enhance that facility to configure max_unit 07:41
obregibi: Only for resources named CUSTOM_*07:41
obregibi: AFAIK07:41
gibicould be. so I would suggest to extend that for non CUSTOM_ resources too07:41
gibiso if somebody wants to do the max_unit on memory tomorrow then we have a generic solution07:42
obreI think the reason for only allowing CUSTOM is to avoid having conflicts within nova; as nova already reports values for VCPU, MEMORY_MB and DISK_GB in its virt drivers. 07:43
obreSo I guess that if we extend the provider.yaml to also allow setting these we need to do major work to ensure that it does not create conflicts?07:44
obreThats why I am basicly thinking that something similar to reserved_host_memory_mb, reserved_host_cpus and reserved_host_disk_mb is tempting for min/max_unit for these values. 07:45
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db)  https://review.opendev.org/c/openstack/nova/+/83119307:47
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects)  https://review.opendev.org/c/openstack/nova/+/83940107:47
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction)  https://review.opendev.org/c/openstack/nova/+/83119407:47
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part)  https://review.opendev.org/c/openstack/nova/+/83309007:47
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api)  https://review.opendev.org/c/openstack/nova/+/83683007:47
opendevreviewribaudr proposed openstack/nova master: Bump compute version and check shares support  https://review.opendev.org/c/openstack/nova/+/85049907:47
opendevreviewribaudr proposed openstack/nova master: Add metadata for shares  https://review.opendev.org/c/openstack/nova/+/85050007:47
opendevreviewribaudr proposed openstack/nova master: Add instance.share_attach notification  https://review.opendev.org/c/openstack/nova/+/85050107:47
opendevreviewribaudr proposed openstack/nova master: Add instance.share_detach notification  https://review.opendev.org/c/openstack/nova/+/85102807:48
opendevreviewribaudr proposed openstack/nova master: Add shares to InstancePayload  https://review.opendev.org/c/openstack/nova/+/85102907:48
opendevreviewribaudr proposed openstack/nova master: Add instance.power_on_error notification  https://review.opendev.org/c/openstack/nova/+/85208407:48
opendevreviewribaudr proposed openstack/nova master: Add instance.power_off_error notification  https://review.opendev.org/c/openstack/nova/+/85227807:48
opendevreviewribaudr proposed openstack/nova master: Add helper methods to attach/detach shares  https://review.opendev.org/c/openstack/nova/+/85208507:48
opendevreviewribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working.  https://review.opendev.org/c/openstack/nova/+/85208607:48
opendevreviewribaudr proposed openstack/nova master: Add virt/libvirt error test cases  https://review.opendev.org/c/openstack/nova/+/85208707:48
opendevreviewribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part)  https://review.opendev.org/c/openstack/nova/+/85482307:48
opendevreviewribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part)  https://review.opendev.org/c/openstack/nova/+/85482407:48
opendevreviewribaudr proposed openstack/nova master: Change microversion to 2.94  https://review.opendev.org/c/openstack/nova/+/85208807:48
obregibi: I am unable to find the real reason to only allow specifying CUSTOM inventories/traits through provider.yaml, but I guess there is a reason for this limitation? And that you not really want me to create a patch simply removing the check that traits/inventories specified in provider.yaml starts with "CUSTOM_"?08:16
gibiobre: good point about the possible conflict. 08:17
gibiobre: I think max_unit will not be a conflict as nova never specify that other than 108:17
gibiobre: as of why we have the limitation today, I think we wanted to avoid thinking through all the possible conflict scenarios when we first introduced the provider.yaml to limit the scope of that first step.08:18
gibiobre: I agree that defining VCPU.total via provider.yaml needs thinking and some agreement what does that mean, which input has higher priority the virt driver or the provider.yaml one08:19
gibibut I don't think you need VCPU.total you only need RC.max_unit to be allowed for your use case 08:19
obreYes; it is basiclu max_unit which is relevant; but the driver sets that to the same value as "total" quite explicitly:08:20
obrehttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8797-L880408:22
obreAnd since we have the CONF.reserved_host_cpus, it seemed like a similar solution for max_unit (and even min_unit) would make sense, and be consistent with something that already exists. 08:23
opendevreviewAmit Uniyal proposed openstack/nova master: Adds check if blk_dev_info has correct flavor.swap  https://review.opendev.org/c/openstack/nova/+/85733908:50
gibiobre: I'm not saying having a dedicated CONF is not a valid alternative. I think both direction worth thinking.09:05
gibiobre: there are couple of ways to get a bit wider input for the ideas09:05
gibii) try to put it on the agenda of the next nova meeting https://wiki.openstack.org/wiki/Meetings/Nova 2) try to file a blueprint and a spec describing the alternatives https://specs.openstack.org/openstack/nova-specs/#process 3) raise this as a Project Team Gathering topic in https://etherpad.opendev.org/p/nova-antelope-ptg09:07
auniyal_O/09:12
opendevreviewEigil Obrestad proposed openstack/nova master: Config parameters for min/max cpu/memory allocation.  https://review.opendev.org/c/openstack/nova/+/85759509:12
auniyal_please review this -https://review.opendev.org/c/openstack/nova/+/85273709:12
auniyal_https://review.opendev.org/c/openstack/nova/+/85733909:13
obregibi: I submitted a change to illustrate what I consider to be the simplest solution. Ill have a look at your three alternatives in a little while. First I need to eat and do a little bit of other work.09:14
gibiobre: sure :)09:15
opendevreviewGhanshyam proposed openstack/osc-placement master: Switch to 2023.1 Python3 unit tests and generic template name  https://review.opendev.org/c/openstack/osc-placement/+/85678709:25
opendevreviewGhanshyam proposed openstack/os-vif master: Switch to 2023.1 Python3 unit tests and generic template name  https://review.opendev.org/c/openstack/os-vif/+/85678309:28
opendevreviewGhanshyam proposed openstack/python-novaclient master: Switch to 2023.1 Python3 unit tests and generic template name  https://review.opendev.org/c/openstack/python-novaclient/+/85679109:29
obregibi: To "try to put it on the agenda of the next nova meeting"; is that simply updating the agenda on the wikipage? 10:15
gibiobre: there is an #topic Open discussion  and under that you can add your topic10:15
opendevreviewTakashi Natsume proposed openstack/nova master: Update min supported service version for Zed  https://review.opendev.org/c/openstack/nova/+/85689511:32
sean-k-mooneybauzas: gibi  can we land this before RC1 https://review.opendev.org/c/openstack/nova/+/83184411:32
sean-k-mooneyits addign the centos 9 fips job to the weekly periodic11:33
sean-k-mooneypipelien and experimental11:33
sean-k-mooneyits finally passing again so it woudl be nice to include that so it can run on stable11:33
sean-k-mooneywithout having to backport it explcitly to stable when the branch is cut11:34
sean-k-mooneygmann:^ you have reviewd that before11:34
gmannsean-k-mooney: +W11:36
sean-k-mooneygmann++ many thanks11:37
sean-k-mooneygmann: did you see my question here https://review.opendev.org/c/openstack/os-vif/+/856783/2#message-3aaeaa39501922e15ae5bfebb78fdf8e5c4c262c11:37
sean-k-mooneyare we goign to branch the openstack-python3-jobs via job vairiant11:38
sean-k-mooneyto make sure that the jobs in that template do not change on stable branches11:38
gmannsean-k-mooney: yes, replied, like this we can do - https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/856903/2/zuul.d/project-templates.yaml#160011:41
gmannwe will pin the changed job for stable and master once new release and change in python version jobs11:41
sean-k-mooneyack thats all i needed to know. i assuemd ye would use job variant and the branches key11:44
sean-k-mooneygmann: so with this change if we do it on nova and all the other compute deliverable we never need to review/merge these defualt job template paches again right :)11:46
sean-k-mooneyits just the central review going forward for the job variant11:46
gmannsean-k-mooney: right. we do not need to update template name in nova side11:55
sean-k-mooneythat will be nice11:56
sean-k-mooneyits not like this takes much time but less manual stuff every release it a good thing11:56
bauzascores, can we please review https://review.opendev.org/c/openstack/nova/+/857467 (prelude)13:09
bauzasthis becomes critical13:09
bauzassean-k-mooney: gibi: others13:09
* gibi clicks13:09
sean-k-mooneyoh the prelude13:09
sean-k-mooneysure ill do it now13:09
bauzasgracias and danke13:10
sean-k-mooneyi tought we had already merge that but it was the release highlights i was thinking of13:10
sean-k-mooneyfor marketing13:10
bauzascorrect13:10
bauzascycle highlights go to some other website13:11
bauzashere, the prelude is just for ops not wanting to read the long list of things we have in the relnotes13:11
sean-k-mooney-1 i think you ment zed https://review.opendev.org/c/openstack/nova/+/857467/1/releasenotes/notes/zed-prelude-a3cddb8b2ac8e293.yaml13:11
sean-k-mooneyotherwise i think it looks ok to me13:12
sean-k-mooneyif you fix that im +113:13
sean-k-mooneyor +2 i guess13:13
sean-k-mooneyalso set review priorty lable on that13:13
sean-k-mooneybauzas: you were on pto when i had this converstaion with gibi and stephenfin 13:14
bauzassean-k-mooney: I can respin quickly13:14
sean-k-mooneybauzas: but the tl;dr is that review priorty is a littel weird for core so i use it slightly differnt then the doc13:14
bauzassean-k-mooney: honestly, I was about to write a topic for the PTG agenda about the use of review-prio13:15
sean-k-mooneybauzas: if i set +1 it means im looking at it but im not askign other cores to look at it if i set +2 it means im looking at it and would like other cores to look at it too13:15
bauzasand how we could make this better13:15
sean-k-mooneyso im using +1 to comunicate to the author that they have my attention13:15
sean-k-mooneyand +2 to comunciate to the core team that i think its imporant for them to look at too13:16
opendevreviewSylvain Bauza proposed openstack/nova master: Prelude section for Zed release  https://review.opendev.org/c/openstack/nova/+/85746713:16
sean-k-mooneyim not commiting them to but usign it to signal asyc that i think its more important for wider review13:16
bauzassean-k-mooney ack, then let's discuss this at the PTG13:16
sean-k-mooneycool13:16
bauzassean-k-mooney: gibi: updated prelude ^13:16
sean-k-mooneyim trying to decople priorty from quality13:16
sean-k-mooneyi.e. rp +2 my be with a buch of -1 but may have topic that need wider input13:17
sean-k-mooneybauzas: when will that move to zed https://6bc7844fa7b995ed5b77-cdf523d3b16150ab0b9ddc512a79d512.ssl.cf2.rackcdn.com/857467/1/check/build-openstack-releasenotes/b8db3f7/docs/unreleased.html should that also be in the patch or is it when we cut the stable branch13:19
bauzassean-k-mooney: ah13:20
sean-k-mooneystephenfin: ^ pbr has some magic based on commit messages right it it tied into that or do we need to do somethign esle13:20
bauzasyou mean when it will be told "zed"13:20
sean-k-mooneyyep13:20
bauzassean-k-mooney: that's because reno works with git branches13:20
sean-k-mooneythis shoudl be rended under zed in rc1 right13:20
bauzasfor the moment, we haven't released zed13:20
bauzaseven with rc113:21
sean-k-mooneyso on stable zed this will render under zed automatically13:21
sean-k-mooneyhave you checked that locally?13:21
bauzasyup, because it branches13:21
bauzasno, this is just the releases team which creates the correct new pages13:21
bauzashttps://6bc7844fa7b995ed5b77-cdf523d3b16150ab0b9ddc512a79d512.ssl.cf2.rackcdn.com/857467/1/check/build-openstack-releasenotes/b8db3f7/docs/unreleased.html#relnotes-25-0-0-195 will be seen <sha1_something>-rc113:21
sean-k-mooneyok +2 then i captured that in the review message13:23
bauzassean-k-mooney: example of a release patch creating the yoga page https://github.com/openstack/nova/commit/d2cba990a6205e5b0361e750c173850cf209a9e613:23
sean-k-mooneyright i tought we needed one like that i woudl prefer to do that before rc1 13:24
sean-k-mooneywe can do it after but i find that messier13:24
bauzashttps://review.opendev.org/c/openstack/nova/+/833243 was the patch 13:24
sean-k-mooneyyep so why are we not doing that in the prelude patch or at least proposing it now13:25
bauzasas you see in the "included in", this was merged *after* yoga GA13:25
sean-k-mooneyso we can merge both together13:25
bauzasyou can't13:25
sean-k-mooneyright i think that is wrong13:25
bauzasprelude has to be merged before RC113:25
sean-k-mooneyyes and after RC1 master is A13:26
opendevreviewMerged openstack/nova master: Test setting the nova job to centos-9-stream  https://review.opendev.org/c/openstack/nova/+/83184413:26
bauzascorrect13:26
sean-k-mooneyso we would have to backport it to stable13:26
sean-k-mooneyi would like to avoid that backport13:26
bauzascorrect, we did it once and we had hard times with ops13:26
sean-k-mooneyby merging it at RC113:26
bauzaswe merged prelude after RC113:26
sean-k-mooneyand using it as the base of the rc tag13:26
bauzasin Newton IIRC13:26
bauzasthat's the usual thing we do13:26
bauzasbut prelude can be merged a bit earler13:27
sean-k-mooneyyep that fin i would just like to also incldue the other patch in rc113:27
sean-k-mooneythe zed version of https://review.opendev.org/c/openstack/nova/+/83324313:27
sean-k-mooneyso we can proceed with the prelude patch as is13:27
bauzasyup, was in Newton https://docs.openstack.org/releasenotes/nova/newton.html#release-notes-14-0-1-stable-newton13:28
sean-k-mooneybut i was trying to avoid another review cycle for the trivail rel note change13:28
bauzasas a consequence, we were only able to provide the prelude section once we released a stable release 13:28
bauzasoperators were angry about it13:29
sean-k-mooneysure but your not listenting to what im saying13:29
sean-k-mooneyim not talking about not providing the prelude in rc113:29
sean-k-mooneywe should13:29
bauzasah, the zed file creation13:29
sean-k-mooneyim saying please add zed to the index in rc113:29
sean-k-mooneyyes13:29
bauzasno, again, we can't13:29
bauzasthis isn't logical13:30
sean-k-mooneywhy yes it is13:30
bauzaswe haven't released officially Zed yet13:30
sean-k-mooneyright but its the release candiate13:30
bauzashence the "unreleased"13:30
bauzascorrect13:30
bauzasbut a candidate13:30
bauzasnot a release 13:30
sean-k-mooneyand ideally there shoudl be no change in that and the final release13:30
bauzasthere could be13:30
bauzassome regression bugfix adding notes13:30
sean-k-mooneyright but in the case that there is no change required we should use the same sha13:30
sean-k-mooneymeaning the candiate should have the same content as the final releas package13:31
bauzasas you see, this is an automated bot https://review.opendev.org/c/openstack/nova/+/83324313:31
bauzasand the release team is doing this for all the managed projects13:31
sean-k-mooneyok fine lest keep the extra paperwork for now13:31
sean-k-mooneybut this is pointless extra work that we shoudl try and avoid going forward13:32
sean-k-mooneywe can maybe chat to the release team about this going forward13:32
sean-k-mooneyits forceing that RC1 can never be the release package13:32
sean-k-mooneyby doing it this way we always have to do a release of a diffenrt sha for the offical release13:33
sean-k-mooneybauzas: can you hit https://review.opendev.org/c/openstack/os-vif/+/85678213:36
sean-k-mooneybauzas: and the folloing patch if you can too13:36
bauzasdone13:37
bauzaswas in the list of https://etherpad.opendev.org/p/nova-zed-rc-potential13:38
sean-k-mooneyack just saw the request form elodilles  in my inbox hence the poke to actully land does13:40
sean-k-mooney*those13:40
opendevreviewMerged openstack/os-vif master: Update master for stable/zed  https://review.opendev.org/c/openstack/os-vif/+/85678213:46
Ugglaquestion about my_block_storage_ip. This flag can be available on each compute nodes or the default is the compute ip. Am I right ?13:50
sean-k-mooneyyes13:50
Ugglais there a way to get this parameter from the api or it can be only provided by the compute node itself ?13:51
sean-k-mooneyonly on the compute13:52
sean-k-mooneythat is why you need to do the grant on the compute not the api13:52
sean-k-mooneyor conductor13:52
sean-k-mooneyit has to be done in the compute agent13:52
Ugglaso it needs a new "entry" in the compute API for this. Correct ?13:53
sean-k-mooneyfor share attament yes you need that anyway13:54
sean-k-mooneythis is an internal detail or the attach_share rpc call13:55
Ugglaso far there is no rpc call for attach. As everything could be done in the API.13:56
sean-k-mooneythat would never work13:56
sean-k-mooneywe need a call to the compute to actully do the mounting of the share ectra13:56
*** Guest305 is now known as dasm13:57
sean-k-mooneywere you jsut goign to put that into spawn or something?13:57
Ugglaattach is just an entry within the db. And mount + real work is done at power_on13:57
sean-k-mooneyi have not look at this in a while so i dont remember the details13:57
sean-k-mooneyi guess that work today only because we require the vm to be off/shelved13:58
sean-k-mooneybut the rpc would be required if we supprot live attach in the future13:58
Ugglayes off13:58
sean-k-mooneyya so unless yo defer the grant to the power on stage13:58
sean-k-mooneyyour going to need an attach_share rpc call13:58
sean-k-mooneyhowever hard reboot should not really call any external services13:59
sean-k-mooneylike it should not udpate cinder attachment or neutron prot bindings13:59
sean-k-mooneyso i woudl find it odd for it to update manila grants13:59
Ugglaok I can implement that in rpc. Can I just make a sync call to rpc get the result and do the rest in the API ?14:00
Ugglaresult = get the ip14:00
Ugglaor is it better to call the rpc and do the required work in the rpc ?14:00
gibibauzas: I left feedback on the prelude14:04
bauzasack, looing14:04
* bauzas doing 3 things at the same time14:04
stephenfinsean-k-mooney: the release note will be moved to zed when the tag is created14:06
stephenfin(sorry, my VPN disconnected and I never noticed)14:06
stephenfin(my ZNC deployment is now behind VPN)14:07
sean-k-mooneyno worries14:09
opendevreviewSylvain Bauza proposed openstack/nova master: Prelude section for Zed release  https://review.opendev.org/c/openstack/nova/+/85746714:10
bauzasgibi: sean-k-mooney: updated ^14:10
bauzasstephenfin: well, not automatically14:11
stephenfinwdym?14:11
bauzasstephenfin: we need to tell reno to look at the new stable/zed branch14:11
gibibauzas: that was fast :)14:11
bauzasstephenfin: I mean, by for example https://review.opendev.org/c/openstack/nova/+/83324314:12
stephenfinbauzas: oh yeah, but the bot will do that14:12
bauzasstephenfin: if we don't merge this file, then none of the files look at the new stable branch14:12
stephenfinyou're right though14:12
sean-k-mooneybauzas: that also has the pbr tag in the commit14:12
bauzasso we need to merge it quickly after the new branch14:12
stephenfinit'll appear under the 26.0.0 tag but the zed page won't exist until created14:13
opendevreviewMerged openstack/os-vif master: Switch to 2023.1 Python3 unit tests and generic template name  https://review.opendev.org/c/openstack/os-vif/+/85678315:18
opendevreviewMerged openstack/python-novaclient master: Switch to 2023.1 Python3 unit tests and generic template name  https://review.opendev.org/c/openstack/python-novaclient/+/85679115:36
opendevreviewMerged openstack/nova master: Bump min oslo.concurrencty to >= 5.0.1  https://review.opendev.org/c/openstack/nova/+/85749115:46
opendevreviewMerged openstack/nova master: Update compute rpc version alias for zed  https://review.opendev.org/c/openstack/nova/+/85570616:50
opendevreviewMerged openstack/nova master: Prelude section for Zed release  https://review.opendev.org/c/openstack/nova/+/85746717:13
nicolasbockHi! I am trying to get Neutron/Designate integration to work and am running into the following issue:17:29
nicolasbock1. Created network with dns_domain17:29
nicolasbock2. Created zone17:29
nicolasbock3. Created server on network17:29
nicolasbockThe server's port will get a dns_assignment with the generic domain from neutron.conf in the fqdn instead of the dns domain from the network. This breaks reverse DNS lookups from the VM.17:29
nicolasbockAm I missing something?17:29
*** dasm is now known as dasm|off21:27

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!