Wednesday, 2022-09-07

opendevreviewMerged openstack/nova stable/wallaby: Avoid unbound instance_uuid var during delete  https://review.opendev.org/c/openstack/nova/+/82883902:20
opendevreviewMerged openstack/nova stable/xena: Retry in CellDatabases fixture when global DB state changes  https://review.opendev.org/c/openstack/nova/+/84094902:21
opendevreviewMerged openstack/nova stable/wallaby: reenable greendns in nova.  https://review.opendev.org/c/openstack/nova/+/83343502:21
opendevreviewMerged openstack/nova stable/train: [ironic] Minimize window for a resource provider to be lost  https://review.opendev.org/c/openstack/nova/+/85354602:55
bauzasgood morning Nova06:34
gibio/07:48
opendevreviewSlawek Kaplonski proposed openstack/nova master: WIP Don't provide MTU value in metadata service if DHCP is enabled  https://review.opendev.org/c/openstack/nova/+/85566408:46
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db)  https://review.opendev.org/c/openstack/nova/+/83119308:47
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects)  https://review.opendev.org/c/openstack/nova/+/83940108:47
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction)  https://review.opendev.org/c/openstack/nova/+/83119408:47
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part)  https://review.opendev.org/c/openstack/nova/+/83309008:47
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api)  https://review.opendev.org/c/openstack/nova/+/83683008:47
opendevreviewribaudr proposed openstack/nova master: Bump compute version and check shares support  https://review.opendev.org/c/openstack/nova/+/85049908:47
opendevreviewribaudr proposed openstack/nova master: Add metadata for shares  https://review.opendev.org/c/openstack/nova/+/85050008:47
opendevreviewribaudr proposed openstack/nova master: Add instance.share_attach notification  https://review.opendev.org/c/openstack/nova/+/85050108:47
opendevreviewribaudr proposed openstack/nova master: Add instance.share_detach notification  https://review.opendev.org/c/openstack/nova/+/85102808:47
opendevreviewribaudr proposed openstack/nova master: Add shares to InstancePayload  https://review.opendev.org/c/openstack/nova/+/85102908:47
opendevreviewribaudr proposed openstack/nova master: Add instance.power_on_error notification  https://review.opendev.org/c/openstack/nova/+/85208408:47
opendevreviewribaudr proposed openstack/nova master: Add instance.power_off_error notification  https://review.opendev.org/c/openstack/nova/+/85227808:47
opendevreviewribaudr proposed openstack/nova master: Add helper methods to attach/detach shares  https://review.opendev.org/c/openstack/nova/+/85208508:47
opendevreviewribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working.  https://review.opendev.org/c/openstack/nova/+/85208608:47
opendevreviewribaudr proposed openstack/nova master: Add virt/libvirt error test cases  https://review.opendev.org/c/openstack/nova/+/85208708:47
opendevreviewribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part)  https://review.opendev.org/c/openstack/nova/+/85482308:47
opendevreviewribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part)  https://review.opendev.org/c/openstack/nova/+/85482408:47
opendevreviewribaudr proposed openstack/nova master: Change microversion to 2.94  https://review.opendev.org/c/openstack/nova/+/85208808:47
stephenfinbauzas: sean-k-mooney: Can one of you look at this? https://review.opendev.org/c/openstack/placement/+/85586209:47
bauzasstephenfin: oh sure09:47
sean-k-mooneystephenfin: i tought gibi had a patch for this09:49
stephenfinthat is gibi's patch :)09:50
sean-k-mooneyoh that is gibis patch09:50
sean-k-mooneyyep bauzas has already hit is so its gran but ya i talked to gibi about that approch so i was already happy with that direction09:50
bauzasI'm not super happy with the cryptic use of SQLA but I'm ok with the patch09:51
sean-k-mooneystephenfin: for placement at least this was jsut an warnign i dont thinik anything was broken09:51
sean-k-mooneycryptic?09:52
sean-k-mooneyoh thet fact we sometime have the rows and somethimes have named tuples (dicts before)09:52
sean-k-mooneywe shoudl fix mixing the type in the cache but that a spereate latent bug09:53
bauzassean-k-mooney: I said cryptic because you really need to understand SQLA internals09:55
bauzasthis is no longer really an ORM09:55
sean-k-mooneyyou dont really09:55
sean-k-mooneythey are issuing deprecation warnings09:55
sean-k-mooneythat tell you exactly what to fix09:55
sean-k-mooneybecause they are trying to do a 2.0 release09:56
sean-k-mooneyso the are getting ready to drop legacy interfaces09:56
bauzaswell, I don't want to discuss that much about it, but I understand your point09:56
opendevreviewMerged openstack/placement master: Make us compatible with oslo.db 12.1.0  https://review.opendev.org/c/openstack/placement/+/85586211:15
artomDo we have a antelope PTG etherpad already?13:50
* artom has a thing13:50
gibiyes13:50
gibihttps://etherpad.opendev.org/p/nova-antelope-ptg13:50
JayFHeya, only one more patch left in the Ironic driver fixes stuff (I still have the CI one that's getting backported... but when these land that becomes less important). https://review.opendev.org/c/openstack/nova/+/821352 this puts the last fix in stable/train18:10
elodillesJayF: nova-tox-validate-backport job failed -> can you re-apply the cherry pick from the stable/ussuri patch? o:)18:14
JayFoh, whoops, I didn't realize that was non-voting, I was just checking ironic job and voting jobs18:14
JayFI'll absolutely fix, ty 18:14
opendevreviewJay Faulkner proposed openstack/nova stable/train: Ignore plug_vifs on the ironic driver  https://review.opendev.org/c/openstack/nova/+/82135218:15
JayFI'll be out of your hair soon ;) this is the last ironic driver fix in Nova in really a long time, until the design issue currently at the spec stage gets fixed18:15
elodillesJayF: no problem & thanks for the update ;) +2'd18:21
melwittwe need sean-k-mooney to come back to ^ as well, I haven't been reviewing it bc I was the one who uploaded it (the backport) originally18:26
*** __ministry is now known as Guest221219:01
fungifinest nova folk... further reviews of https://review.opendev.org/850003 would be much appreciated, in order to avoid releasing zed with a known security bug and creating more backport work20:02
melwittI can take a look at it later today, thanks for the link20:06
*** dasm is now known as dasm|off21:11
sean-k-mooneyfungi: melwitt  +wd21:54
sean-k-mooneyalso reviewed the ironic one21:55
sean-k-mooneyfungi: we are going to bring up that issue with neutron in the PTG too hopefully we can block vnic_type chages for bound port going forward in there api but we will start the backport of that once RC1 is out21:56
JayFthanks :D21:57
sean-k-mooneyno worries :) i needed to do one thing i had left before i finsihed for the night got to drop again soon but hopefully that will land soon21:59
opendevreviewMerged openstack/nova stable/train: Ignore plug_vifs on the ironic driver  https://review.opendev.org/c/openstack/nova/+/82135222:17
fungisean-k-mooney: thanks for the update!22:22
sean-k-mooneyfungi: unfortunetly that failed https://review.opendev.org/c/openstack/nova/+/849985 i think its conflicted with the pci serise which merged since it was writen22:43
fungioh, oof22:44
sean-k-mooneyits proably not that hard to reslove so ill see if we can still get this in zed22:44
fungithere's still time yes. and then we'll want backports of course, but one step at a time22:44
fungiat least it's already public, so the only real looming deadline is not releasing zed with it if we can help that22:45
sean-k-mooneyyep22:45
sean-k-mooneyill check with gibi when they are onlien and pull this locally in the morning and see whast happening22:45
sean-k-mooneyactuly its failiing in a test that its not modifying22:48
sean-k-mooneyfungi: so those tests pass locally for me22:54
sean-k-mooneyim going to recheck it and see but we might have some uninited shareing i dont think this is related to this patch22:55
fungiinteresting. i'll try to keep an eye on it, just wanted to make sure it was on someone's radar22:55

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!