| opendevreview | liuhuajie proposed openstack/nova master: Cleanup py27 support https://review.opendev.org/c/openstack/nova/+/853216 | 03:01 |
|---|---|---|
| opendevreview | Brett Milford proposed openstack/nova master: Handle "no RAM info was set" migration case https://review.opendev.org/c/openstack/nova/+/852002 | 04:21 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/xena: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/853218 | 04:57 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/xena: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/853219 | 04:57 |
| *** gibi_pto is now known as gibi | 07:26 | |
| gibi | o/ | 07:28 |
| *** whoami-rajat__ is now known as whoami-rajat | 08:08 | |
| opendevreview | huanhongda proposed openstack/nova master: WIP:Drop unreliable host_aggregate_map https://review.opendev.org/c/openstack/nova/+/696851 | 08:15 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | 08:25 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | 08:26 |
| *** akekane__ is now known as abhishekk | 08:54 | |
| opendevreview | melanie witt proposed openstack/nova master: virt: Add block_device_info helper to find encrypted disks https://review.opendev.org/c/openstack/nova/+/826529 | 08:58 |
| opendevreview | melanie witt proposed openstack/nova master: blockinfo: Add encryption details to the disk_info mappings when provided https://review.opendev.org/c/openstack/nova/+/772272 | 08:58 |
| opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add disk_info_mapping as an optional attribute of Image https://review.opendev.org/c/openstack/nova/+/826530 | 08:58 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image https://review.opendev.org/c/openstack/nova/+/846246 | 08:58 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | 08:58 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Report ephemeral encryption traits based on imagebackend https://review.opendev.org/c/openstack/nova/+/826753 | 08:58 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | 08:58 |
| opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | 08:58 |
| opendevreview | melanie witt proposed openstack/nova master: imagebackend: Cache the key manager when disk is encrypted https://review.opendev.org/c/openstack/nova/+/826756 | 08:58 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | 08:58 |
| opendevreview | melanie witt proposed openstack/nova master: Follow up changes for ephemeral encryption https://review.opendev.org/c/openstack/nova/+/853254 | 08:58 |
| songwenping | sean-k-mooney: morning, how can we use A100 without create mig? | 09:08 |
| viks__ | Hi, how do i overcome the below error: | 09:12 |
| viks__ | BuildAbortException: Build of instance 1038d9a7-b597-43fd-99a3-bf738c5d2645 aborted: Image 4a1d979d-97d2-4213-8f7a-9bfa879f9687 is unacceptable: fmt=qcow2 backed by: /var/lib/nova/instances/_base/62e5ab9485700cef622708506a70de979257b580 | 09:12 |
| viks__ | https://www.irccloud.com/pastebin/rS24PVRB/ | 09:13 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | 10:36 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | 10:36 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | 10:36 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 10:36 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Add reno for fixing bug 1941005 https://review.opendev.org/c/openstack/nova/+/853265 | 11:19 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/yoga: Reproducer for bug 1983753 https://review.opendev.org/c/openstack/nova/+/853266 | 11:22 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/yoga: Update RequestSpec.pci_request for resize https://review.opendev.org/c/openstack/nova/+/853267 | 11:22 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/yoga: Add reno for fixing bug 1941005 https://review.opendev.org/c/openstack/nova/+/853268 | 11:22 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/xena: Reproducer for bug 1983753 https://review.opendev.org/c/openstack/nova/+/853269 | 11:24 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/xena: Update RequestSpec.pci_request for resize https://review.opendev.org/c/openstack/nova/+/853270 | 11:24 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/xena: Add reno for fixing bug 1941005 https://review.opendev.org/c/openstack/nova/+/853271 | 11:24 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/wallaby: Reproducer for bug 1983753 https://review.opendev.org/c/openstack/nova/+/853273 | 11:30 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/wallaby: Update RequestSpec.pci_request for resize https://review.opendev.org/c/openstack/nova/+/853274 | 11:30 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/wallaby: Add reno for fixing bug 1941005 https://review.opendev.org/c/openstack/nova/+/853275 | 11:30 |
| opendevreview | Elod Illes proposed openstack/nova stable/train: DNM: test preinstall of python3-yaml https://review.opendev.org/c/openstack/nova/+/851861 | 12:25 |
| opendevreview | Elod Illes proposed openstack/nova stable/train: [CI] Fix gate by using zuulv3 live migration and grenade jobs https://review.opendev.org/c/openstack/nova/+/795435 | 12:34 |
| opendevreview | sean mooney proposed openstack/nova master: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/832330 | 13:05 |
| *** dasm|off is now known as dasm | 13:55 | |
| opendevreview | Maksim Malchuk proposed openstack/nova stable/xena: Fix to implement 'pack' or 'spread' VM's NUMA cells https://review.opendev.org/c/openstack/nova/+/829804 | 14:53 |
| opendevreview | Merged openstack/nova master: Fix a deprecation warning about distutils https://review.opendev.org/c/openstack/nova/+/852947 | 14:53 |
| gibi | elodilles: I've updated the nova meeting agenda, you are free to edit your part if needed | 15:21 |
| amorin | hello nova team! | 15:29 |
| elodilles | gibi: ack, thanks! | 15:29 |
| amorin | I am doing an openstack port create --device_id server_id portname | 15:29 |
| amorin | I am expecting the port to be attached to the instance | 15:29 |
| amorin | but the port stays down, until I reboot hard the instance | 15:30 |
| amorin | I cant find any related bug on launchpad for this | 15:30 |
| amorin | is it "normal" behavior?> | 15:30 |
| amorin | it seems nova succesfully receive the port create notification (I can see some logs about adding a binding to that port) | 15:30 |
| amorin | but the port is never plugged in ovs / libvirt xml of the instance | 15:31 |
| amorin | I am running victoria release fyi | 15:31 |
| gibi | amorin: if you want to attach a port to an existing instance then you have to use $ openstack server add port | 15:33 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Request filter for PCI in placement https://review.opendev.org/c/openstack/nova/+/852771 | 15:33 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support resource_class and traits in PCI alias https://review.opendev.org/c/openstack/nova/+/853316 | 15:33 |
| amorin | gibi: yes, I can teach my customers to do so, but some of them are using scripts/tools or I dont know what, and they endup doing a call to neutron | 15:36 |
| amorin | to create a port with a device_id | 15:36 |
| amorin | which is accepted by the API | 15:36 |
| amorin | and allowed for regular users | 15:36 |
| amorin | so I was wondering if this is "normal" or a bug | 15:36 |
| amorin | should I report it? | 15:36 |
| gibi | from nova perspective setting the device_id of a port by an human to point to a server_id is not supported | 15:38 |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: Remove deleted projects from flavor access list https://review.opendev.org/c/openstack/nova/+/849131 | 15:43 |
| sean-k-mooney | amorin: attacing the port via neutron is not supported | 15:43 |
| sean-k-mooney | amorin: it is known behavior that neutron allows it at there api | 15:44 |
| sean-k-mooney | but its is not and has never been supported form a nova perspective | 15:44 |
| amorin | so maybe it should be removed from neutron then? | 15:44 |
| sean-k-mooney | technially detaching a port by clearing the device_id or deleteing the port is also unsupporte but we have code to handel that | 15:45 |
| sean-k-mooney | amorin:techinially thos filed shoudl really be admin ownly | 15:45 |
| sean-k-mooney | or in the future require the service role | 15:45 |
| gibi | ^^ agree | 15:45 |
| sean-k-mooney | so that its its clear they shoudl only be set by another openstack service | 15:46 |
| amorin | should I block that through a custom policy in the mean time? | 15:46 |
| sean-k-mooney | perhaps i think nova uses the admin client when it sets it so that might be viable | 15:46 |
| sean-k-mooney | you could certenly require a custom role and give that to the nova user | 15:46 |
| amorin | this is even allowed from a terraform perspective: https://registry.terraform.io/providers/terraform-provider-openstack/openstack/latest/docs/resources/networking_port_v2#port-with-physical-binding-information | 15:47 |
| amorin | very confusing for end users | 15:48 |
| sean-k-mooney | setting port bindigs needs admin rights | 15:48 |
| sean-k-mooney | and that appear to be for ironic | 15:48 |
| amorin | bindings ok, but device_id is not an admin call | 15:48 |
| sean-k-mooney | its not but its not intened for normal users | 15:48 |
| sean-k-mooney | where you are not using nova i could see a usecase for nomal uses if neutron supported standalone use | 15:49 |
| sean-k-mooney | or you were using ironic without nova with neutron | 15:49 |
| sean-k-mooney | but in the ironic case | 15:49 |
| sean-k-mooney | it still shoudl be ironic setting that | 15:49 |
| sean-k-mooney | this really just feels like terrafome exposeing more of the api then requried | 15:50 |
| amorin | agree | 15:50 |
| gibi | (fyi, nova meeting starts in 10 minutes here in the channel) | 15:50 |
| amorin | ack, dont want to disturb, thanks for your answers anyway! | 15:50 |
| gibi | amorin: you are not disturbing, I mostly noted that to others to prepare :) | 15:52 |
| amorin | ack :) | 15:52 |
| gibi | #startmeeting nova | 16:00 |
| opendevmeet | Meeting started Tue Aug 16 16:00:09 2022 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'nova' | 16:00 |
| gibi | o/ | 16:00 |
| sean-k-mooney | o/ | 16:00 |
| gibi | lets wait a bit for others | 16:01 |
| elodilles | o/ | 16:01 |
| gibi | OK, lets quickly go through the agenda | 16:03 |
| gibi | #topic Bugs (stuck/critical) | 16:03 |
| gibi | we have one critical bug https://bugs.launchpad.net/nova/+bug/1986545 | 16:03 |
| gibi | we forsee a blocking error in 3.10.6 | 16:04 |
| gibi | melwitt promised to look into it | 16:04 |
| gibi | right now we are not hitting it in the gate because there we have 3.10.4 | 16:04 |
| sean-k-mooney | ah yes i vaguly recall seeing that go by on irc | 16:05 |
| gibi | moving on | 16:06 |
| gibi | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 8 new untriaged bugs (-5 since the last meeting) | 16:06 |
| gibi | #link https://storyboard.openstack.org/#!/project/openstack/placement 27 open stories (+0 since the last meeting) in Storyboard for Placement | 16:06 |
| gibi | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:06 |
| gibi | I did a bit of triage this morning | 16:06 |
| gibi | I saw nothing serious to mention https://etherpad.opendev.org/p/nova-bug-triage-20220809 | 16:07 |
| gibi | next on our triage roster is melwitt | 16:07 |
| gibi | it seem she is not up yet, so I will ask her later | 16:07 |
| gibi | any other bug to discuss today? | 16:08 |
| gibi | I assume no | 16:09 |
| gibi | #topic Gate status | 16:09 |
| gibi | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:09 |
| gibi | I don't see any fresh gate bugs there | 16:09 |
| gibi | so I think the master gate is OK | 16:09 |
| gibi | our periodics: | 16:09 |
| gibi | #link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly | 16:09 |
| gibi | #link https://zuul.openstack.org/builds?job_name=tempest-integrated-compute-centos-9-stream&project=openstack%2Fnova&pipeline=periodic-weekly&skip=0 | 16:09 |
| gibi | #link https://zuul.opendev.org/t/openstack/builds?job_name=nova-emulation&pipeline=periodic-weekly&skip=0 | 16:10 |
| gibi | all green | 16:10 |
| gibi | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:10 |
| gibi | #info STOP DOING BLIND RECHECKS aka. 'recheck' https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures | 16:10 |
| gibi | is there any gate related topic for today? | 16:10 |
| elodilles | nothing from me :X | 16:11 |
| gibi | #topic Release Planning | 16:11 |
| gibi | #link https://releases.openstack.org/zed/schedule.html | 16:11 |
| gibi | #info Zed-3 is in 2 weeks | 16:11 |
| gibi | please update the status of the bps in the #link Zed tracking etherpad: https://etherpad.opendev.org/p/nova-zed-blueprint-status | 16:11 |
| gibi | I see some movement on https://review.opendev.org/q/topic:bp%252Fupdate-userdata | 16:12 |
| gibi | and on https://review.opendev.org/q/topic:bp%252Fvirtual-iommu-support | 16:12 |
| gibi | both has some patches that are waiting for review now | 16:12 |
| gibi | I will do a review round tomorrow morning | 16:12 |
| gibi | is there any bp you would like to discuss here today/ | 16:13 |
| gibi | ? | 16:13 |
| sean-k-mooney | just a note that the first patch in the vdpa seires | 16:13 |
| sean-k-mooney | shoudl be ready | 16:13 |
| sean-k-mooney | im still working on the rest | 16:14 |
| gibi | ack, I will try to get to it tomorrow | 16:14 |
| gibi | I'm putting most of my effor to finish the pci in placement series, and there is plenty of patches to review there too :) | 16:15 |
| gibi | fyi if any of you are pushing a bp with a microversion then look at #link https://etherpad.opendev.org/p/nova-zed-microversions-plan please | 16:15 |
| gibi | if nothing else about the blueprints then moving on to | 16:16 |
| gibi | #topic Review priorities | 16:16 |
| gibi | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2) | 16:16 |
| gibi | nothing surprising there I think | 16:17 |
| gibi | would be nice to have this in sync with our core allocation from the bp tracking. I will try to fix my part of that tomorrow when I review | 16:17 |
| gibi | but now moving on | 16:18 |
| gibi | #topic Stable Branches | 16:18 |
| gibi | elodilles: any news? | 16:18 |
| elodilles | not much | 16:18 |
| elodilles | but let's go through of them | 16:18 |
| elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:18 |
| elodilles | #info stable/train (and older) are blocked, see details in the etherpad ^^^ | 16:19 |
| elodilles | #info train probably can be "fixed" by changing grenade & nova-live-migration to zuul v3 job: https://review.opendev.org/c/openstack/nova/+/795435 | 16:19 |
| sean-k-mooney | that sound like a good thing in general | 16:19 |
| elodilles | i've digged up that old patch that was -1'd by me ^^^ | 16:19 |
| gibi | nice | 16:20 |
| elodilles | rebased it and it seems to be working | 16:20 |
| sean-k-mooney | ack | 16:20 |
| sean-k-mooney | i assume the orginal objection was changing form zullv2 to zuul v3 | 16:20 |
| sean-k-mooney | after it was released | 16:20 |
| elodilles | (i mean, with the intermittent failures - volume operations timeout) | 16:20 |
| elodilles | sean-k-mooney: yes | 16:21 |
| elodilles | sean-k-mooney: and at that time it was not really needed for train | 16:21 |
| sean-k-mooney | ack so now that it is are you ok to proceed in this direction? | 16:21 |
| elodilles | but now, somehow it seems it is not facing with the issue we have with the old devstack-gate jobs | 16:22 |
| elodilles | sean-k-mooney: yes | 16:22 |
| elodilles | and that means we can unblock train at least | 16:22 |
| sean-k-mooney | ack then ill try and find time to review it | 16:22 |
| elodilles | stein rocky and queens will be still blocked, though | 16:22 |
| elodilles | sean-k-mooney: ++ | 16:22 |
| elodilles | but probably we can even EOL those branches | 16:23 |
| elodilles | as there are no interested parties around those branches :/ | 16:23 |
| gibi | yeah it seems | 16:23 |
| elodilles | anyway, this is all i think | 16:23 |
| gibi | thanks elodilles | 16:24 |
| elodilles | np | 16:25 |
| gibi | #topic Open discussion | 16:25 |
| gibi | there is noting on the agenda | 16:25 |
| gibi | so speak up now if you have someting | 16:25 |
| elodilles | - | 16:25 |
| gibi | dont be so negative elodilles ;) | 16:26 |
| elodilles | gibi: ++ | 16:26 |
| elodilles | :D | 16:26 |
| JayF | Hey Nova folks; I have a reasonably old Ironic driver backport to stable/victoria, I just found out someone has an install that could use it, if we could land it, I'd appreciate it. https://review.opendev.org/c/openstack/nova/+/800873 (elodilles reviewed it a while back, but I didn't update it for a while because I was between openstack-y jobs) | 16:26 |
| JayF | whoops, didn't mean to send that until the meeting was over, sorry | 16:26 |
| gibi | JayF: that is a good open discussion topic so no worries :) | 16:27 |
| gibi | JayF: I will hit that tomorrow morning and I hope elodilles will do it too | 16:28 |
| sean-k-mooney | JayF: looks like its already merged in stable wallaby | 16:28 |
| JayF | thank you both very much! I will be doing a review of anything that might need backporting to victoria. If that one merges, you might get more :) | 16:28 |
| sean-k-mooney | and that the victoria backport | 16:28 |
| sean-k-mooney | so i dont think that is contoverial | 16:28 |
| sean-k-mooney | the ci logs are mising but they were green | 16:29 |
| JayF | That's what I'm hoping, but I know folks are busy and getting attention is often the difficult part. Just had no real reason to promote it until I met an Ironic user today who is having this specific issue and is already mid-upgrade to Victoria :) | 16:29 |
| sean-k-mooney | so provide this does not need a rebase i think we can just review it as normal | 16:29 |
| sean-k-mooney | ack | 16:30 |
| sean-k-mooney | ill add it to my list | 16:30 |
| gibi | I feel we are done with the today's meeting | 16:32 |
| gibi | thank you all for joining | 16:32 |
| gibi | #endmeeting | 16:32 |
| opendevmeet | Meeting ended Tue Aug 16 16:32:08 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:32 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-16-16.00.html | 16:32 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-16-16.00.txt | 16:32 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-16-16.00.log.html | 16:32 |
| sean-k-mooney | JayF: its a clean cherry pick and the previous branch is already merged so +2 | 16:32 |
| sean-k-mooney | its been a month since zuul last ran but we have not been merging code to victoria much so i expect this should still apply | 16:33 |
| JayF | I'll watch it, if it kicks out V-2 I will take a look | 16:33 |
| elodilles | JayF: thanks for the update, +2'd it | 16:36 |
| sean-k-mooney | elodilles: care to +w too | 16:36 |
| sean-k-mooney | or did you want to hold if for some reason | 16:36 |
| sean-k-mooney | also do assert not fire in our functional tests by default | 16:37 |
| elodilles | sean-k-mooney: nope, just haven't seen that you +2'd already :) but we can wait for the tests to pass again | 16:39 |
| sean-k-mooney | ack | 16:40 |
| sean-k-mooney | oh gibi rechecked | 16:40 |
| sean-k-mooney | just saw that now | 16:40 |
| elodilles | sean-k-mooney: on the other hand, +W probably doesn't hurt, so that it can merge quicker (and we won't forget about +W it later) | 16:40 |
| gibi | sean-k-mooney: yeah I kicked it as I figured I will look at it tomorrow but if you are both agree I trust you so feel free to +A it | 16:41 |
| sean-k-mooney | well the ci will reject it if there is an issue | 16:41 |
| sean-k-mooney | but we can take a look later anyway | 16:41 |
| elodilles | sean-k-mooney: what do you mean by the functional test thing? | 16:41 |
| sean-k-mooney | im debuging why one of my func tests is not working | 16:42 |
| sean-k-mooney | i think the libvirt fixture is incomplete | 16:42 |
| sean-k-mooney | and its not setting something that is always set with real libvirt | 16:42 |
| sean-k-mooney | but my assert is not firing so i think the funciton im looking at is mocked | 16:42 |
| elodilles | but i guess that's a different patch (on master branch?) | 16:44 |
| sean-k-mooney | yes differnt patch | 16:44 |
| sean-k-mooney | its what i was lookign at before the meeting started | 16:45 |
| sean-k-mooney | if dev_path not in (None, ''): | 16:45 |
| elodilles | i see, i thought you want to -W this patch due to some failure, but then it's a different thing | 16:45 |
| sean-k-mooney | raise TypeError() | 16:45 |
| sean-k-mooney | assert dev_path not in (None, ''), ( | 16:45 |
| sean-k-mooney | "dev_path is required to be a non empty path " | 16:45 |
| sean-k-mooney | f"called with: {dev_path}") | 16:45 |
| sean-k-mooney | no | 16:45 |
| sean-k-mooney | so the assert there has no effect in our functional tests | 16:45 |
| sean-k-mooney | but adding the raise breaks them | 16:45 |
| sean-k-mooney | so at least i know the fucntion is being called but asserts are off | 16:46 |
| sean-k-mooney | i had expected tox/stestr to trun asserts on by default | 16:46 |
| sean-k-mooney | i wonder if we should change that | 16:46 |
| sean-k-mooney | and jsut to be 100% clear the ironic patch looks fine no reason to -w | 16:47 |
| elodilles | sean-k-mooney: ack | 16:47 |
| elodilles | sean-k-mooney: i haven't used 'assert', ussually self.assert* is used everywhere | 16:49 |
| sean-k-mooney | i wanted to put it in real code rather then in the tests | 16:50 |
| sean-k-mooney | but its fine this is just for me to fidn where its broken | 16:50 |
| elodilles | oh, i thought you added it in a functional test | 16:51 |
| gibi | sean-k-mooney: interesing find. I agree that we should turn on assert in func test | 16:53 |
| JayF | https://review.opendev.org/c/openstack/nova/+/800873 seems to have cleared CI; if someone wants to toss a workflow+ on it | 17:27 |
| mloza2 | hi, is there way for nova to autostart specific VMs when compute comes up from a crash? | 17:59 |
| melwitt | gibi: ack re: triage this week, I will do it. thanks! | 18:04 |
| sean-k-mooney | gibi: i think there is a python debug envar or something like that to enable them in a non interactive interperter | 18:24 |
| elodilles | JayF: actually it wasn't at that time ('recheck' does not clear the Verified+1), but now it is and +W'd (fun fact, that when I saw in the console log that tests have passed, I +W'd it and gate jobs started to run simultaneously with check jobs, because of the fact that i wrote: 'recheck' does not clear Verified+1) | 18:25 |
| sean-k-mooney | but if asserts do fire in func/unit tests it would allow use to capture preconditions in the code with asserts and if they are ever violated in a unit or func test it would be caught. | 18:25 |
| elodilles | JayF: anyway, hopefully it merges soon :) | 18:26 |
| sean-k-mooney | mloza2: there is a host level config option | 19:10 |
| sean-k-mooney | mloza2: https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.resume_guests_state_on_host_boot | 19:10 |
| opendevreview | Elod Illes proposed openstack/nova stable/train: [CI] Fix gate by using zuulv3 live migration and grenade jobs https://review.opendev.org/c/openstack/nova/+/795435 | 20:26 |
| JayF | elodilles: ...has that always been the behavior? That recheck doesn't clear a V+1? | 20:46 |
| sean-k-mooney | its not recheck the clears it | 20:46 |
| sean-k-mooney | its zuul | 20:47 |
| sean-k-mooney | it only does it when the build set starts | 20:47 |
| sean-k-mooney | or ends i cant rememebr | 20:47 |
| sean-k-mooney | but it will clear the result when the job end i think | 20:47 |
| sean-k-mooney | its a little od because i know the gate pipeline clear it at the start of the jobs | 20:48 |
| JayF | interesting, I'll file that knowledge away | 20:51 |
| sean-k-mooney | i think this is defiend by the pipeline config | 20:51 |
| sean-k-mooney | https://github.com/openstack/project-config/blob/master/zuul.d/pipelines.yaml#L90-L92 | 20:52 |
| sean-k-mooney | JayF: if you look at the check pipline above it it does not have the start action for the gerrit trigger defiend | 20:52 |
| sean-k-mooney | so verifed is only update on success or failure | 20:53 |
| JayF | that makes sense | 20:53 |
| opendevreview | sean mooney proposed openstack/nova master: add sorce dev parsing for vdpa interfaces https://review.opendev.org/c/openstack/nova/+/841016 | 20:56 |
| *** dasm is now known as dasm|off | 22:26 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!