opendevreview | Merged openstack/nova master: Optimize numa_fit_instance_to_host https://review.opendev.org/c/openstack/nova/+/845896 | 01:53 |
---|---|---|
opendevreview | Merged openstack/nova master: Remove workaround for SQLAlchemy < 1.4 https://review.opendev.org/c/openstack/nova/+/852255 | 01:53 |
opendevreview | Merged openstack/nova master: manager: Reduce unnecessary calls https://review.opendev.org/c/openstack/nova/+/795027 | 03:36 |
opendevreview | Merged openstack/nova master: objects: Don't use generic 'Field' container https://review.opendev.org/c/openstack/nova/+/738239 | 03:36 |
opendevreview | Rajesh Tailor proposed openstack/nova master: Fix rescue volume-based instance https://review.opendev.org/c/openstack/nova/+/852737 | 04:24 |
opendevreview | Bence Romsics proposed openstack/nova master: Add limitation to docs about bug 1983570 https://review.opendev.org/c/openstack/nova/+/852168 | 08:34 |
*** tosky_ is now known as tosky | 09:33 | |
opendevreview | Merged openstack/nova stable/wallaby: Adapt to SQLAlchemy 1.4 https://review.opendev.org/c/openstack/nova/+/852099 | 11:20 |
*** gibi is now known as gibi_pto | 16:24 | |
dansmith | melwitt: do we really have no test class for ConductorTaskManager ? | 17:05 |
dansmith | I see various mocks of it, but... | 17:05 |
dansmith | sorry, conductor.ComputeTaskManager I mean | 17:07 |
melwitt | uh dunno. I will look | 17:16 |
melwitt | this says it's for ComputeTaskManager https://github.com/openstack/nova/blob/master/nova/tests/unit/conductor/test_conductor.py#L2238 | 17:19 |
melwitt | dansmith: ^ | 17:20 |
dansmith | ah, yeah, okay, I found that in the greps but it seemed like that was more for tasks/* but yeah I guess maybe that's it | 17:23 |
opendevreview | Dan Smith proposed openstack/nova master: Unify placement client singleton implementations https://review.opendev.org/c/openstack/nova/+/852900 | 17:35 |
opendevreview | Dan Smith proposed openstack/nova master: Avoid startup failure for keystone failures https://review.opendev.org/c/openstack/nova/+/852901 | 17:35 |
dansmith | melwitt: gibi_pto looks to be gone already, but I think this is a reasonable compromise ^ | 17:35 |
melwitt | ack, will look | 17:40 |
dansmith | I haven't run functional tests on that, but it works for me in my devstack if I stop keystone and restart conductor | 17:46 |
melwitt | ack | 18:12 |
*** tosky_ is now known as tosky | 18:16 | |
opendevreview | Dan Smith proposed openstack/nova master: Unify placement client singleton implementations https://review.opendev.org/c/openstack/nova/+/852900 | 18:40 |
opendevreview | Dan Smith proposed openstack/nova master: Avoid n-cond startup abort for keystone failures https://review.opendev.org/c/openstack/nova/+/852901 | 18:40 |
opendevreview | Dan Smith proposed openstack/nova master: Unify placement client singleton implementations https://review.opendev.org/c/openstack/nova/+/852900 | 18:49 |
opendevreview | Dan Smith proposed openstack/nova master: Avoid n-cond startup abort for keystone failures https://review.opendev.org/c/openstack/nova/+/852901 | 18:49 |
dansmith | melwitt: that second set is for you ^ :) | 18:49 |
dansmith | good call on the other exceptions, and the unified handling helps make sure we log the right exception (not responding) for those too | 18:50 |
dansmith | log the right *message* I mean | 18:55 |
* dansmith must need a recharge | 18:56 | |
melwitt | :) | 18:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!