Thursday, 2022-08-11

opendevreviewMerged openstack/nova master: Optimize numa_fit_instance_to_host  https://review.opendev.org/c/openstack/nova/+/84589601:53
opendevreviewMerged openstack/nova master: Remove workaround for SQLAlchemy < 1.4  https://review.opendev.org/c/openstack/nova/+/85225501:53
opendevreviewMerged openstack/nova master: manager: Reduce unnecessary calls  https://review.opendev.org/c/openstack/nova/+/79502703:36
opendevreviewMerged openstack/nova master: objects: Don't use generic 'Field' container  https://review.opendev.org/c/openstack/nova/+/73823903:36
opendevreviewRajesh Tailor proposed openstack/nova master: Fix rescue volume-based instance  https://review.opendev.org/c/openstack/nova/+/85273704:24
opendevreviewBence Romsics proposed openstack/nova master: Add limitation to docs about bug 1983570  https://review.opendev.org/c/openstack/nova/+/85216808:34
*** tosky_ is now known as tosky09:33
opendevreviewMerged openstack/nova stable/wallaby: Adapt to SQLAlchemy 1.4  https://review.opendev.org/c/openstack/nova/+/85209911:20
*** gibi is now known as gibi_pto16:24
dansmithmelwitt: do we really have no test class for ConductorTaskManager ?17:05
dansmithI see various mocks of it, but...17:05
dansmithsorry, conductor.ComputeTaskManager I mean17:07
melwittuh dunno. I will look17:16
melwittthis says it's for ComputeTaskManager https://github.com/openstack/nova/blob/master/nova/tests/unit/conductor/test_conductor.py#L223817:19
melwittdansmith: ^17:20
dansmithah, yeah, okay, I found that in the greps but it seemed like that was more for tasks/* but yeah I guess maybe that's it17:23
opendevreviewDan Smith proposed openstack/nova master: Unify placement client singleton implementations  https://review.opendev.org/c/openstack/nova/+/85290017:35
opendevreviewDan Smith proposed openstack/nova master: Avoid startup failure for keystone failures  https://review.opendev.org/c/openstack/nova/+/85290117:35
dansmithmelwitt: gibi_pto looks to be gone already, but I think this is a reasonable compromise ^17:35
melwittack, will look17:40
dansmithI haven't run functional tests on that, but it works for me in my devstack if I stop keystone and restart conductor17:46
melwittack18:12
*** tosky_ is now known as tosky18:16
opendevreviewDan Smith proposed openstack/nova master: Unify placement client singleton implementations  https://review.opendev.org/c/openstack/nova/+/85290018:40
opendevreviewDan Smith proposed openstack/nova master: Avoid n-cond startup abort for keystone failures  https://review.opendev.org/c/openstack/nova/+/85290118:40
opendevreviewDan Smith proposed openstack/nova master: Unify placement client singleton implementations  https://review.opendev.org/c/openstack/nova/+/85290018:49
opendevreviewDan Smith proposed openstack/nova master: Avoid n-cond startup abort for keystone failures  https://review.opendev.org/c/openstack/nova/+/85290118:49
dansmithmelwitt: that second set is for you ^ :)18:49
dansmithgood call on the other exceptions, and the unified handling helps make sure we log the right exception (not responding) for those too18:50
dansmithlog the right *message* I mean18:55
* dansmith must need a recharge18:56
melwitt:)18:56

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!