Tuesday, 2022-08-09

*** osmanlicilegi is now known as Guest001:48
opendevreviewTyler Stachecki proposed openstack/nova master: libvirt: Check VIF MTU matches network MTU  https://review.opendev.org/c/openstack/nova/+/85236703:07
opendevreviewTyler Stachecki proposed openstack/nova master: libvirt: Check if VIF MTU matches network MTU  https://review.opendev.org/c/openstack/nova/+/85236703:26
opendevreviewOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/nova/+/85133704:01
gibigood morning07:33
gibifolks I've created the Zed bp tracking etherpad https://etherpad.opendev.org/p/nova-zed-blueprint-status please check it out, sign up for review, update status, note if I missed someting. We will look at it again on the todays meeting08:43
gibibauzas: you own me a beer for that ^^ ;)08:44
gibielodilles: I've updated the today's agenda on the wiki, feel free to add your stuff there 08:44
elodillesgibi: ack, thanks!09:05
stephenfingibi: Looking09:19
stephenfinartom: Boo09:19
noonedeadpunkhey there! Does anybody know any reason why https://specs.openstack.org/openstack/nova-specs/specs/ocata/approved/detach-boot-volume.html has not been implemented? As from what I see the only thing left is kind of changing condition here https://opendev.org/openstack/nova/blame/branch/master/nova/api/openstack/compute/volumes.py#L56009:46
noonedeadpunkby adding `instance.vm_state not in (vm_states.SHELVED, vm_states.SHELVED_OFFLOADED)` ?09:47
noonedeadpunkAs detaching from shelved instance should never hurt from my understanding? 09:48
opendevreviewMerged openstack/nova stable/ussuri: [stable-only] Allow Train compute hosts to register with Ussuri  https://review.opendev.org/c/openstack/nova/+/85173210:32
sean-k-mooney[m]i think it kind of stalled out because the person working on it stopped10:33
sean-k-mooney[m]im not sure if there was any technical reason that blocked it10:34
sean-k-mooney[m]noonedeadpunk:   dansmith might remember more or gibi  i think they might have been invovled with that at some point10:34
opendevreviewchenwei proposed openstack/nova master: Remove unicode literal from code  https://review.opendev.org/c/openstack/nova/+/85253810:35
sean-k-mooney[m]^  is such a waste fo ci and review bandwidth10:36
sean-k-mooney[m]also there is someone else arready changing that10:36
noonedeadpunkfor some reason I was quite sure it's implemented :(10:38
noonedeadpunkthe only tricky thing I see on how to re-attach volume to be same device name and how to disallow unshelve when root device is detached10:39
sean-k-mooney[m]one thing that would have to be done in addtion to the detach is likely clearing the delete on terminate info form teh volume too10:39
sean-k-mooney[m]well the name is a hint10:39
sean-k-mooney[m]so you cant rely on that10:40
sean-k-mooney[m]what you really need to be able to do is atach it and set the boot order on the volume10:40
sean-k-mooney[m]so that it will have precidence10:40
noonedeadpunkso basically preserve the order somehow10:40
sean-k-mooney[m]not really10:41
sean-k-mooney[m]the main usecause for detach was you detach the volmue and then delete the vm10:41
sean-k-mooney[m]and use the volume for a differnt vm10:41
sean-k-mooney[m]but if we wanted ot supprot reattaching it we would need a way to specify the boot order on attach as part of the bdms10:41
noonedeadpunkwell that doesn't make much sense then? As for me main usecase would be to workaround not working `openstack server recover` for bfv10:42
sean-k-mooney[m]you can do that when you create a vm but currently you cant update it after the vm is created10:42
sean-k-mooney[m]that is being worked on currently10:42
sean-k-mooney[m]rescue now works10:42
sean-k-mooney[m]and rebuild is in flight10:42
noonedeadpunkas right now if you made a mistake in networking, and was not clever enough to set a password for the user - you need to delete VM, attach volume to another VM, then create third VM that will have same set of ports and volumes in correct order10:43
sean-k-mooney[m]rescuse for volume backed instances is aviable in wallaby maybe before10:43
noonedeadpunkoh, rly? as in Xena rescue is not working10:43
sean-k-mooney[m]rescue shoudl work in xena10:44
noonedeadpunkwell, I just got `Instance 19d5f71e-3dde-474f-9802-7e3d2f512f3b cannot be rescued: Cannot rescue a volume-backed instance (HTTP 400)` 10:45
sean-k-mooney[m]https://specs.openstack.org/openstack/nova-specs/specs/ussuri/implemented/virt-bfv-instance-rescue.html10:45
noonedeadpunkmaybe it's client that does not provide api version...10:45
sean-k-mooney[m]it was implemted in ussuri10:45
sean-k-mooney[m]did you use osc or nova10:45
noonedeadpunkosc ofc10:45
sean-k-mooney[m]i dont think there was a micor version for this10:46
noonedeadpunkshouldn't python-novaclient be deprecated now :p10:46
*** tosky is now known as Guest7110:46
*** tosky_ is now known as tosky10:46
sean-k-mooney[m]oh there is10:46
sean-k-mooney[m]https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#maximum-in-ussuri-and-victoria 10:47
sean-k-mooney[m]2.8710:47
sean-k-mooney[m]noonedeadpunk:  the shell is the python bindings currently are not10:47
noonedeadpunkok, let me check on traits then10:47
noonedeadpunkwell, there's a typo at very list in trait name in microversion history10:52
sean-k-mooney[m]https://github.com/openstack/os-traits/blob/master/os_traits/compute/__init__.py#L3210:53
sean-k-mooney[m]ya its RESCUE_BFV not BFV_RESCUE10:53
sean-k-mooney[m]https://github.com/openstack/nova/commit/5b6f44efff5ad721779fd9a7e80d6a5330fad7d410:54
sean-k-mooney[m]the code uses the correct value10:55
sean-k-mooney[m]and its correct in the spec10:55
sean-k-mooney[m]just reversed in the docs10:55
sean-k-mooney[m]https://specs.openstack.org/openstack/nova-specs/specs/ussuri/implemented/virt-bfv-instance-rescue.html#proposed-change10:55
opendevreviewDmitriy Rabotyagov proposed openstack/nova master: [doc] Fix BFV Rescue trait name in microversion  https://review.opendev.org/c/openstack/nova/+/85254310:56
noonedeadpunkYeah and computes does have this trait10:56
gibiI dont remember much about detach root volume feature but what you discussed above make sense11:03
noonedeadpunkyeah, setting --os-compute-api-version 2.87 works11:03
noonedeadpunkfunny/sad thing though is that `python-openstackclient 5.8.0` throws `osc_lib.exceptions.CommandError: versions supported by client: 2.1 - 2.87`11:04
noonedeadpunkoh, well, it didn't work at the end as instance moved to the error state with `Driver Error: internal error: qemu unexpectedly closed the monitor: 2022-08-09T11:04:55.719928Z qemu-system-x86_64: -blockdev {"driver":"rbd","pool":"vms","image":"c76df07c-02b6-4a28-964c-d7'}`11:09
gibiplease file a bug report on these issues11:10
sean-k-mooney[m]that sound like a qemu crash11:10
opendevreviewMerged openstack/nova stable/yoga: add regression test case for bug 1978983  https://review.opendev.org/c/openstack/nova/+/85223811:13
noonedeadpunkok, so real issue was qemu crash because of `error reading header from c76df07c-02b6-4a28-964c-d703555152b8_disk: No such file or directory`11:15
noonedeadpunksoundsl ike it tried to rescue but clean forgot to create ephemeral first11:16
noonedeadpunkbecause it called `c76df07c-02b6-4a28-964c-d703555152b8_disk.rescue` :D11:18
noonedeadpunkor well, both was provided. So seems that logic just ignores that it should not have ephemeral11:19
sean-k-mooney[m]maybe ya11:20
sean-k-mooney[m]are you also using rbd as the normal backend?11:21
noonedeadpunkyup11:21
sean-k-mooney[m]perhaps it does not like ceph images_backend adn ceph cinder11:21
sean-k-mooney[m]is it the same ceph cluster11:21
noonedeadpunkbut different pools anyway11:22
sean-k-mooney[m]ack11:22
noonedeadpunkand different image names at very least...11:22
sean-k-mooney[m]well rescue uses the same image by default if you dont spcify one11:22
sean-k-mooney[m]but it would be a differnt volume11:23
noonedeadpunkso nova basically generated xml that does contain ephemeral device that was never there since it's bfv11:23
sean-k-mooney[m]i have not personally tried this but we do have tempest testign for this i belive11:23
sean-k-mooney[m]ya that sound like a bug11:23
sean-k-mooney[m]and perhaps one that is fixed already11:23
sean-k-mooney[m]it sound vagly familar11:24
noonedeadpunkwell, it's Xena so I assume it can be...11:24
noonedeadpunkI don't really have time on hands to test it on master right now :(11:24
noonedeadpunkwill write down to play with it later on11:25
noonedeadpunkalso interesting, that xml does not have volumes at all.11:25
sean-k-mooney[m]https://bugs.launchpad.net/nova/+bug/197895811:25
noonedeadpunkyup, sounds familiar11:26
sean-k-mooney[m]https://bugs.launchpad.net/nova/+bug/192660111:27
sean-k-mooney[m]its reported twice11:27
noonedeadpunkfirst one was assigned 58m ago - what a co-incidence :D11:27
sean-k-mooney[m]basically you need to see hw_rescue_bus and hw_rescue_device11:27
noonedeadpunkum, should I set this on flavors then?11:28
sean-k-mooney[m]the image11:28
noonedeadpunkbut this also means that I would need to update all existing instance specs in DB to allow them to be rescued as well?11:29
sean-k-mooney[m]its part of this spec which was implmeented at the same time https://specs.openstack.org/openstack/nova-specs/specs/ussuri/implemented/virt-rescue-stable-disk-devices.html11:29
sean-k-mooney[m]no11:29
sean-k-mooney[m]when we rescue we use the image metadta form the rescue image i belive11:29
sean-k-mooney[m]so just add it to the image11:29
noonedeadpunkah, ok, gotcha now11:29
noonedeadpunkmakes sense11:30
sean-k-mooney[m]generally for reasonse we recommend hw_rescue_bus=usb hw_rescue_device=disk11:30
sean-k-mooney[m]basically if you use a usb rescue bus/device then it does not change the  /dev/sda naming11:31
sean-k-mooney[m]you can just use the same bus as the root disk normally uses too11:32
sean-k-mooney[m]https://specs.openstack.org/openstack/nova-specs/specs/ussuri/implemented/virt-rescue-stable-disk-devices.html#proposed-change11:32
*** bhagyashris is now known as bhagyashris|afk11:44
opendevreviewBalazs Gibizer proposed openstack/nova master: Heal PCI allocation during resize  https://review.opendev.org/c/openstack/nova/+/85239611:54
opendevreviewBalazs Gibizer proposed openstack/nova master: Handle PCI dev reconf with allocations  https://review.opendev.org/c/openstack/nova/+/85239711:54
opendevreviewBalazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement  https://review.opendev.org/c/openstack/nova/+/85046811:54
*** tosky is now known as Guest7712:01
*** tosky__ is now known as tosky12:01
opendevreviewBalazs Gibizer proposed openstack/nova master: Add more test coverage for devname base dev spec  https://review.opendev.org/c/openstack/nova/+/84462512:18
opendevreviewBalazs Gibizer proposed openstack/nova master: Extra tests for remote managed dev spec  https://review.opendev.org/c/openstack/nova/+/84462612:18
opendevreviewBalazs Gibizer proposed openstack/nova master: Unparent PciDeviceSpec from PciAddressSpec  https://review.opendev.org/c/openstack/nova/+/84449112:18
opendevreviewBalazs Gibizer proposed openstack/nova master: Fix PciAddressSpec descendants to call super.__init__  https://review.opendev.org/c/openstack/nova/+/84456512:18
opendevreviewBalazs Gibizer proposed openstack/nova master: Remove dead code from PhysicalPciAddress  https://review.opendev.org/c/openstack/nova/+/84462812:18
opendevreviewBalazs Gibizer proposed openstack/nova master: Clean up mapping input to address spec types  https://review.opendev.org/c/openstack/nova/+/84576512:18
opendevreviewBalazs Gibizer proposed openstack/nova master: Remove unused PF checking from get_function_by_ifname  https://review.opendev.org/c/openstack/nova/+/84577512:18
opendevreviewBalazs Gibizer proposed openstack/nova master: Fix type annotation of pci.Whitelist class  https://review.opendev.org/c/openstack/nova/+/84578012:18
opendevreviewBalazs Gibizer proposed openstack/nova master: Move __str__ to the PciAddressSpec base class  https://review.opendev.org/c/openstack/nova/+/84578112:18
*** tosky is now known as Guest7812:30
*** tosky_ is now known as tosky12:30
*** bhagyashris|afk is now known as bhagyashris12:50
opendevreviewMerged openstack/nova stable/yoga: For evacuation, ignore if task_state is not None  https://review.opendev.org/c/openstack/nova/+/85223512:56
*** tosky is now known as Guest8513:13
*** tosky__ is now known as tosky13:13
*** dasm|off is now known as dasm13:30
sfinucansean-k-mooney[m]: I +W'd this on the assumption that you're happy with it, but feel free to re-review if you'd like https://review.opendev.org/c/openstack/nova/+/826526/4..615:12
sfinucangibi: melwitt: How are we going to unblock that ephemeral encryption series without bauzas around? I assume that's still happening this cycle?15:12
sean-k-mooney[m]sure ill take a look now but i generaly trus your judgement15:13
sfinucansean-k-mooney[m]: Can you give me a summary of what you concluded on the ephemeral vs. disk debate?15:14
sfinucanAt risk of rehashing old arguments, doesn't 'hw_disk_encryption' suggest cinder-backed "disks" (i.e. volumes) will be encrypted also?15:15
sean-k-mooney[m]the term ephemeral is ambigious but its not worth changing as it has mindshare15:15
sfinucancontext is https://review.opendev.org/c/openstack/nova/+/76045415:15
sean-k-mooney[m]so i was ment to drop my -1 and proceed with the current names15:15
sean-k-mooney[m]but escalation15:15
sean-k-mooney[m]so ill do that now15:15
sfinucanAh, no worries15:15
*** sfinucan is now known as stephenfin15:16
stephenfinorder is restored (IRC nick)15:16
gibisfinucan: good question. I hope we can have enough cores to land it. I put together a tracking pad to get cores signing up for reviewing certain series (thanks sean-k-mooney[m] for the idea) https://etherpad.opendev.org/p/nova-zed-blueprint-status15:16
gibiwe will discuss this on the today's meeting15:17
sean-k-mooney[m]sfinucan:  https://review.opendev.org/c/openstack/nova/+/760454/11#message-391f61808b977003be0f33c48e768e37bec8697e15:18
stephenfinsean-k-mooney[m]: thanks15:19
sean-k-mooney[m]hehe i was just going to say i just +w'd the windows enlightements patch15:19
sean-k-mooney[m]so that should be on its way15:19
gibione less to care about15:26
gibithanks15:26
stephenfinsean-k-mooney[m]: another one to drop your -1 from, I think https://review.opendev.org/c/openstack/nova/+/76448615:40
stephenfinsean-k-mooney[m]: and https://review.opendev.org/c/openstack/nova/+/76045515:45
sean-k-mooney[m]stephenfin:  done15:49
gibifyi nova meeting starts in 10 minutes here in the channel15:50
*** dasm is now known as dasm|off15:54
elodilleso/16:02
elodillesgibi: meeting? :)16:02
gibihups16:02
gibi#startmeeting nova16:02
opendevmeetMeeting started Tue Aug  9 16:02:33 2022 UTC and is due to finish in 60 minutes.  The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot.16:02
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:02
opendevmeetThe meeting name has been set to 'nova'16:02
dansmitho/16:02
elodilleso/16:02
gibithis is typical that I remember up until 10 minutes before the actual time :)16:03
sean-k-mooney[m]o/16:03
gibithen I forget16:03
gibianyhow16:03
elodilles:D16:03
gibi#topic Bugs (stuck/critical) 16:04
gibi#info No Critical bug16:04
gibi#link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 11 new untriaged bugs (+0 since the last meeting)16:04
gibi#link https://storyboard.openstack.org/#!/project/openstack/placement 27 open stories (+0 since the last meeting) in Storyboard for Placement 16:04
gibi#info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster16:05
gibithanks elodilles for the bug triage this week16:05
gibi#info bug baton is being passed to gibi16:05
gibiis there any bugs we need to discuss today?16:06
elodillesi had little time, but triaged 3 bugs16:06
elodillesthis one seems interesting: Shelved (offloaded) instance still have port bound to host16:06
gibiyep that sort of a known issue16:07
elodillesoh, i see16:07
gmanno/16:07
gibiprobably it does not break anything but I agree that it is valid16:07
elodillesthen maybe that's it from my side :)16:08
gibiany other bugs from anybody?16:08
*** bauzas is now known as bauzas_pto16:09
gibi#topic Gate status 16:09
*** bauzas_pto is now known as bauzas_away16:09
gibi#link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs 16:09
gibiI dont see any new bug there16:09
gibi#link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly Placement periodic job status 16:09
gibiit is green16:09
gibi#link https://zuul.openstack.org/builds?job_name=tempest-integrated-compute-centos-9-stream&project=openstack%2Fnova&pipeline=periodic-weekly&skip=0 Centos 9 Stream periodic job status16:10
gibigreen too16:10
gibi#link https://zuul.opendev.org/t/openstack/builds?job_name=nova-emulation&pipeline=periodic-weekly&skip=0 Emulation periodic job runs16:10
gibigreen as well16:10
gibi#info Please look at the gate failures and file a bug report with the gate-failure tag.16:10
gibi#info STOP DOING BLIND RECHECKS aka. 'recheck' https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures16:10
gibiany gate issue we need to discuss?16:10
gibiI have one thing16:11
gibiwe merged the switch to unittest.mock that also showed us that in py310 the unittest.mock is more strict16:12
gibiit does not allow mocking the same function twice16:12
gibithis made our py310 non-voting jobs red16:12
gibiwe fixed it once but broke it later again16:13
gibiso I'm fixing it again https://review.opendev.org/c/openstack/nova/+/852464 and making py310 jobs voting for nova16:13
gibito pervent breaking this again16:13
gibiI know that officially we don't support py310 yet16:13
gibibut I don't really want to fix double mocking in AA or BB again16:13
gibiso any disagreement switchin the unittest and functional test jobs with py310 voting?16:14
sean-k-mooney[m]if we can fix the final issues to make it green again16:15
sean-k-mooney[m]then i have no issue with graduating it early16:15
sean-k-mooney[m]it has been stable form what i have seen16:15
gibiI think I made it green again 16:15
gmann+1, many project have it voting and in next cycle we need to run it voting. so +1 on making it voting now16:15
gibiwith https://review.opendev.org/c/openstack/nova/+/85246416:15
sean-k-mooney[m]ack ya i saw you mentioned that we misses a case with fixtures16:16
sean-k-mooney[m]so once that is landed im +1 on making it voting16:16
gibiack16:16
gibiI don't see disagreement so moving on :)16:16
sean-k-mooney[m]actully that does that curretnly16:17
gibi#topic Release Planning 16:17
sean-k-mooney[m]https://review.opendev.org/c/openstack/nova/+/852464/1/.zuul.yaml16:17
sean-k-mooney[m]but yes lets move on16:17
gibiyes, I want to make the switch atomic :)16:17
gibi#link https://releases.openstack.org/zed/schedule.html16:17
gibi#info Zed-3 is in 3 weeks16:17
gibi#link Zed tracking etherpad: https://etherpad.opendev.org/p/nova-zed-blueprint-status16:17
gibi#link https://etherpad.opendev.org/p/nova-zed-microversions-plan16:17
gibiso we have 3 week left to feature freeze16:18
gibiand we have a bunch of features in flight as usual16:18
gibiso it would be good to see what has chance to land 16:18
gibiso I ask you to update https://etherpad.opendev.org/p/nova-zed-blueprint-status with any status I missed16:18
gibiand if you feel you have review bandwidth for some of those features16:18
gibithen please add you name to the feature16:19
gibiso we see where we have enough reviewers 16:19
sean-k-mooney[m]i need to add vdpa to that but its not ready for full review yet16:20
sean-k-mooney[m]so ill hold off until it is16:20
gibisean-k-mooney[m]: hm, I don't know how I missed the vdpa bp16:20
gibior is it just a bug?16:20
sean-k-mooney[m]bug for fist patch specless for final 316:21
gibiack, I see the bug https://bugs.launchpad.net/nova/+bug/1970467 do you have a link to the bp?16:21
sean-k-mooney[m]https://blueprints.launchpad.net/nova/+spec/vdpa-suspend-detach-and-live-migrate16:21
sean-k-mooney[m]it did not have the serise goal or milestone so i added them now16:22
gibiahh that is the reason I missed it. I added it to the pad now16:23
gibicool16:23
gibiany other thing I missed from the pad? or any specific bp we need to discuss now?16:24
gibiOK, then we will look at this again next week, but please keep that status in the pad updated during the week16:26
gibi#topic Review priorities16:27
gibi#link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2)16:27
gibiideally this should be a superset of the bp tracking etherpad commitments16:27
gibibut it isn't16:28
gibinot a big deal16:28
gibimoving on16:28
gibi#topic Stable Branches 16:28
gibimic -> elodilles16:28
elodillesyes, so16:29
elodillesunfortunately nothing news really :/16:29
elodilles#info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci16:29
elodilles#info stable/train (and older) are blocked, see details in the etherpad ^^^16:30
elodillesi did not get there to continue the grenade/live-migration debug on stable/train :/16:30
gibiI have no spare cycle either16:31
sean-k-mooney[m]i think i agree with melwitt however that we shoudl stop rechecking the train use shell patch16:32
sean-k-mooney[m]until we figure out why its failing16:32
elodillesyes, that is completely worthless16:32
sean-k-mooney[m]but i dont have time to look in the near term16:32
sean-k-mooney[m]melwitt:  maybe we coudl -w it to signal that16:33
gibiyepp that make sense16:35
gibianything else about stable?16:35
elodillesnothing from me16:35
gibi#topic Open discussion 16:36
gibinothing on the agenda16:36
gibiis there anything else today/16:37
gibi?16:37
gibithen I will give you back 22 minutes16:38
gibi#endmeeting16:38
opendevmeetMeeting ended Tue Aug  9 16:38:35 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:38
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-09-16.02.html16:38
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-09-16.02.txt16:38
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-09-16.02.log.html16:38
opendevreviewMerged openstack/nova master: Update libvirt enlightenments for Windows  https://review.opendev.org/c/openstack/nova/+/84764116:47
*** dasm|off is now known as dasm18:23
*** lifeless_ is now known as lifeless18:24
melwittstephenfin: thanks for bringing up the ephemeral encryption stuff. I was wary to bother people about it, there's been so much else going on. we'll need bauzas_away to remove his -2 on the bottom patch. IIRC he should be back Aug 30 (2 days before FF), so hopefully he can remove it then cc sean-k-mooney[m] 19:37
melwittsean-k-mooney[m], stephenfin: wrt the naming, I wanted to give everyone a break before bringing it up again 😬 but ... I had thought more about it and thinking about it in the context of the other extra spec/image prop names, I thought "hw_disk_encryption" does seemingly fit better https://github.com/openstack/nova/blob/1220d53c2fd6231bb569a54f004a0e858536e970/nova/objects/image_meta.py#L347-L351 but as you pointed out, there's a19:47
melwitt chance that users might anyway think it could be referring to cinder volumes as well (?). none of the names are a slam dunk really :(19:47
*** dasm is now known as dasm|off20:43

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!