Tuesday, 2022-08-02

opendevreviewmelanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command  https://review.opendev.org/c/openstack/nova/+/82675203:00
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Report ephemeral encryption traits based on imagebackend  https://review.opendev.org/c/openstack/nova/+/82675303:00
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets  https://review.opendev.org/c/openstack/nova/+/82675403:00
opendevreviewmelanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption  https://review.opendev.org/c/openstack/nova/+/82675503:00
opendevreviewmelanie witt proposed openstack/nova master: imagebackend: Cache the key manager when disk is encrypted  https://review.opendev.org/c/openstack/nova/+/82675603:00
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS  https://review.opendev.org/c/openstack/nova/+/77227303:00
opendevreviewAmit Uniyal proposed openstack/nova master: Updated Suspend definition in server concepts doc  https://review.opendev.org/c/openstack/nova/+/85151104:19
opendevreviewOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/nova/+/85133704:31
opendevreviewTony Breeds proposed openstack/placement master: disable traits count check to allow os-traits 2.8.0  https://review.opendev.org/c/openstack/placement/+/85179205:07
opendevreviewTony Breeds proposed openstack/placement master: Update placement for os-traits 2.8.0 release  https://review.opendev.org/c/openstack/placement/+/85179305:07
tonybCan someone take a look at: https://review.opendev.org/c/openstack/requirements/+/849986  The patch is trying to use the latest openstacksdk but it fails "nova.tests.unit.scheduler.client.test_report.SafeConnectedTestCase.test_missing_endpoint"  I suspect that's because openstacksdk reworked the proxy/cache code [ https://review.opendev.org/c/openstack/openstacksdk/+/837802 ] and I'm guessing that it caches 404 (or similar) 05:27
tonybso the second all returns directly from the cache.05:27
* tonyb kinda looks sidelong at stephenfin 05:28
gibigood morning07:29
Ugglagibi, good morning07:30
bauzasgood morning07:44
* bauzas fights with OSC change07:44
opendevreviewTony Breeds proposed openstack/placement master: disable traits count check to allow os-traits 2.8.0  https://review.opendev.org/c/openstack/placement/+/85179207:53
opendevreviewTony Breeds proposed openstack/placement master: Update placement for os-traits 2.8.0 release  https://review.opendev.org/c/openstack/placement/+/85179307:53
opendevreviewRadosÅ‚aw Piliszek proposed openstack/nova master: [docs] Fix mention of custom scheduling after Wallaby  https://review.opendev.org/c/openstack/nova/+/85180708:15
bauzasgibi: around ?08:29
gibibauzas: yes08:29
bauzasgibi: I wanted to discuss your excellent point on https://review.opendev.org/c/openstack/nova/+/838976/3/nova/virt/libvirt/utils.py#59708:29
bauzasfixing it isn't trivial as it either needs to change the callers or to longer use this method08:30
bauzasbut I checked which callers are using this method, and this is only for the reshape method and for the recreating method (when you reboot)08:31
bauzas[sbauza@sbauza nova]$ git grep '\.mdev_uuid2name('08:33
bauzasnova/tests/functional/libvirt/test_reshape.py:                utils.mdev_uuid2name(mdev_uuid))08:33
bauzasnova/tests/functional/libvirt/test_vgpu.py:        mdev_name = libvirt_utils.mdev_uuid2name(uuid)08:33
bauzasnova/tests/functional/libvirt/test_vgpu.py:            mdev_name = libvirt_utils.mdev_uuid2name(mdev)08:33
bauzasnova/tests/functional/libvirt/test_vgpu.py:                libvirt_utils.mdev_uuid2name(mdevs[0]))08:33
bauzasnova/tests/functional/regressions/test_bug_1951656.py:        mdev_name = libvirt_utils.mdev_uuid2name(uuid)08:33
bauzasnova/virt/libvirt/driver.py:                dev_name = libvirt_utils.mdev_uuid2name(mdev_uuid)08:33
bauzasnova/virt/libvirt/driver.py:            dev_name = libvirt_utils.mdev_uuid2name(mdev_uuid)08:33
bauzasso FWIW, I think we could provide a follow-up patch for it, instead of trying to modify all of the above in the same change08:35
gibiI'm not sure what you imply. Is this not a bug right now to use non suffixed mdev_name with libvirt 7.7+?08:36
bauzasgibi: we already have a bug for recreate() 08:40
bauzasso this won't change08:41
gibiOK, so you say, that we use the wrong mdev_name in two cases 1) reshape, but there we only use it internally to nova so libvirt wont see it 2) in recreate but recreate is broken for other reasons as well08:41
gibiDo I understand it correctly?08:42
bauzas1) for reshapes, we no longer do them08:42
gibiexcept FFU08:42
bauzasunless someone wants to reshape from Queens to Rocky08:42
gibiack08:42
bauzasfor 2), you got it08:43
bauzasactually, we could fix https://bugs.launchpad.net/nova/+bug/1900800 once we provide the FUP08:44
gibiso 1) can be an issue if someone FFUs from Queens to Train08:44
bauzas1) only if they run Train with libvirt 7.708:44
gibiyepp08:44
gibiI agree this is low probabability08:45
bauzasand I'm not saying we shouldn't modify uuid2name08:45
bauzasjust saying this couldn't be in the same change08:45
bauzasbut by a FUP08:45
gibiOK, lets have a fup08:45
sean-k-mooney bauzas your on pto for the next two weeks yes? from tomorrow?08:51
bauzassean-k-mooney: from tonight until Aug 2908:51
sean-k-mooneybauzas: did you start trying to port the mdev lib to work around the other issues we have with libvirt08:52
sean-k-mooneyif not that is ok08:52
bauzassean-k-mooney: you mean about using sysfs instead of libvirt for getting the mdevs ?08:53
bauzasno if so08:53
sean-k-mooneyya08:53
sean-k-mooneyok08:53
opendevreviewSylvain Bauza proposed openstack/nova master: Handle mdev devices in libvirt 7.7+  https://review.opendev.org/c/openstack/nova/+/83897608:59
bauzasgibi: sean-k-mooney: update the mdev rename change without modifying the mdev_uuid2name method as we agreed ^09:00
bauzaswill work now on a FUP to fix the recreate method09:00
sean-k-mooneyack09:04
gibidansmith_: when you are up. I have an ovo question. Is there a way to run code before a remotable method is called on the remote end? Like instance.save() is remoteable but I need to run code during instance.save() on the caller side _before_ the rpc call is made to the remote and to call save() there09:21
gibidansmith_: context is https://review.opendev.org/c/openstack/nova/+/85074609:21
gibidansmith_: the instance.mutated_migration_context() is not a remotable obviously, but save() is and I would need state to travell between the mutated_migration_context call and a later save() call09:22
opendevreviewBalazs Gibizer proposed openstack/nova master: Reproducer for bug 1982497  https://review.opendev.org/c/openstack/nova/+/85067209:35
opendevreviewBalazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context  https://review.opendev.org/c/openstack/nova/+/85074609:35
opendevreviewBalazs Gibizer proposed openstack/nova master: Avoid saving instance under mutated migration context  https://review.opendev.org/c/openstack/nova/+/85183209:35
gibidansmith_: or alternatively where to stash data in the instance ovo that travels from local to remote but not persisted09:39
sean-k-mooneygibi: you could decorate the remotable method10:10
gibithe mutated_migration_context does not need to be remotable 10:10
gibihm, 10:10
gibiwe can create two save() methods10:11
sean-k-mooneyright but you were askign could we run somthing ofn the remote before it runs right10:11
gibione non remoteable and one remoteable10:11
sean-k-mooneyim not sure about that10:11
gibiwith different names of course10:11
gibiand the the non remoteable can call the remoteable10:11
gibisean-k-mooney: you are a genius, thanks10:11
sean-k-mooneynormally we would do that the other way around10:12
sean-k-mooneywhat exactuly are you tryign to do by the way10:12
gibiI need to prevent instance.save to persist things if the instance is under mutated migration context10:12
gibiso I need a flag on the instance object10:12
gibibut the mutation happens on the local instance 10:12
gibiwhile save runs on the remote instance10:13
sean-k-mooneyyou can add filed to the instance object directly10:13
sean-k-mooneythey wont be saved or sent over the wire10:13
gibithe second is the problem10:13
sean-k-mooneyas in "instnace.my_flag=True"10:13
gibithe save runs on the remote10:13
gibiso I need to send the flag on the wire (or check the flag on the local side during save, hence the question)10:13
sean-k-mooneyif you want it to be a noop do you10:14
sean-k-mooneyyou dont want it to save10:14
gibicontext in here https://review.opendev.org/c/openstack/nova/+/85183210:14
sean-k-mooneyso add a decorator that checks if its set on teh souce10:14
sean-k-mooneyand just dont forward if the flag is set10:14
gibihm10:14
gibithat also possible10:14
gibiif I decorate before the remoteable decorator10:14
gibithen I can inject thing to the local side10:15
sean-k-mooneyyep it need to be the other decorator10:15
sean-k-mooneyyes10:15
sean-k-mooneyand avoid the rpc entirly10:15
gibiack, thanks10:15
gibiyou answered my question10:15
sean-k-mooney:)10:15
sean-k-mooneyi think we already do this on the instance object by the way. we cachce some things in the object in memory via filed that are never sent on the wire10:16
gibiI will go with a normal function instead of a wrapper applied by a decorator, as the actual logic is highly save + migration context specific10:20
gibiI will do save() -> remoted_save() indirection10:20
sean-k-mooneyhum the issue witht that is you are moving the remoteable decorator to remote_save10:21
sean-k-mooneyisnt that a problem 10:21
gibithe decorator would do the same technically as the function returned from the decorator would be different10:22
gibiI believe it will not be a problem, but we will see10:22
sean-k-mooneyi think it might cause issue for grenade10:22
sean-k-mooneyit woudl technically be an rpc change i think10:23
sean-k-mooneythe decorator would not alter the name of the remote rpc endpoint for the function10:23
sean-k-mooneyit would still be save not remote_save()10:23
*** tosky_ is now known as tosky10:24
gibiahh10:24
gibiwhy we are too clever with these namings10:24
gibi?!10:24
gibibut you are right10:25
gibithe incoming save might fail10:25
gibihm10:25
sean-k-mooneyyou can add a try_save()10:25
gibiactually the incoming save RPC will call Instance.save that will do the checks again10:25
sean-k-mooneyfunction that delegate to save10:25
sean-k-mooneytry_save can check if it should save and then call save10:25
gibitry_save is bad as I don't want to replace all the instance.save calls with instance.try_save10:26
gibibut I need the check at every instance.save call10:26
sean-k-mooneyya that was what i was about to say you would have to do that10:26
sean-k-mooneyso the only ohte way to do this if you dont use a decorator10:26
sean-k-mooneyis to have the context manage replace instance.save within it10:27
sean-k-mooneywhich is kind of messy10:27
gibias the decorator is applied both on the local and on the remote side with the decorator we also call the extra check twice. I think the effect is the same either if I use the decorator or a save -> remote_save indirection10:28
gibibut I will try it out after lunch10:28
gibithanks again10:28
sean-k-mooneycool let me knwo how it goes, enjoy lunch10:29
gibithanks10:29
*** dasm|off is now known as dasm11:06
opendevreviewElod Illes proposed openstack/nova stable/rocky: Move 'check-cherry-picks' test to gate, n-v check  https://review.opendev.org/c/openstack/nova/+/80465411:07
opendevreviewsean mooney proposed openstack/nova master: enable blocked VDPA move operations  https://review.opendev.org/c/openstack/nova/+/83233011:22
opendevreviewElod Illes proposed openstack/nova stable/wallaby: Gracefull recovery when attaching volume fails  https://review.opendev.org/c/openstack/nova/+/82943411:36
opendevreviewBalazs Gibizer proposed openstack/nova master: Avoid saving instance under mutated migration context  https://review.opendev.org/c/openstack/nova/+/85183211:54
opendevreviewBalazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context  https://review.opendev.org/c/openstack/nova/+/85074611:54
gibisean-k-mooney[m]: locally this works ^^ lets see if it passes tempest and grenade11:54
gibidansmith_: meanwhile with sean-k-mooney[m] we figured a solution for my question ^^11:55
artomgibi, I have a concern on https://review.opendev.org/c/openstack/nova/+/851832 - does it sound legit to you? I'm not too sure myself...12:07
*** priteau_ is now known as priteau12:38
opendevreviewMerged openstack/nova master: [docs] Fix mention of custom scheduling after Wallaby  https://review.opendev.org/c/openstack/nova/+/85180712:55
opendevreviewGuillaume Espanel proposed openstack/nova master: Skip useless qemu-img convert when snapshotting  https://review.opendev.org/c/openstack/nova/+/85185412:55
gibiartom: you and sean-k-mooney[m] both raised this, I'm waiting for grenade to prove that it is a real problem or not. If it is then the only way to keep this work is to decorate save() to modify it so the name is kept. 13:00
gibiI'm not sure how the names of the RPC is mapped13:00
gibiin you example you need an old conductor13:01
gibibut I think we say, upgrade your control service first13:01
sean-k-mooneygibi: dansmith_ might be able to help you figure that out but i can point to where that is done of the top of my head13:01
gibiso in theory the conductor will have both save and _remote_save13:01
gibiduring a rolling upgrade13:01
gibiold computes will call save over RPC and that exists13:01
gibinew computes probably will call _remote_save and that also exists in a new conductor13:02
gibisean-k-mooney: ack13:02
artomgibi, for a major version upgrade, yeah, control tier first, so it's not a problem13:23
artomIt's only a problem if we backport13:23
sean-k-mooney[m]my laptop over heated again13:23
sean-k-mooney[m]ill be upstream only for a bit while it cools down and i get the vpn set up elsewhere13:24
artomPour mineral oil in your bathtub and dunk your laptop in there?13:25
gibiartom: hm, if we backport then both the old and the new side will have both save and _remote_save so I don't see the problem about the backport either13:28
opendevreviewRadosÅ‚aw Piliszek proposed openstack/nova stable/yoga: [docs] Fix mention of custom scheduling after Wallaby  https://review.opendev.org/c/openstack/nova/+/85187013:29
opendevreviewBalazs Gibizer proposed openstack/nova master: Remove double mocking  https://review.opendev.org/c/openstack/nova/+/85144513:32
opendevreviewBalazs Gibizer proposed openstack/nova master: hacking: force explicit import of python's mock  https://review.opendev.org/c/openstack/nova/+/70876813:32
opendevreviewBalazs Gibizer proposed openstack/nova master: Remove the PowerVM driver  https://review.opendev.org/c/openstack/nova/+/85034613:32
kashyapgibi: Thx for cleaning up the PowerVM!13:33
gibithat wasn't me13:34
gibiI just rebased13:34
kashyapErr, stephenfin++ :)13:34
kashyapWhat a diffstat: +10 -935013:34
dansmith_artom: gibi sean-k-mooney[m]: I'm really -2 on that approach in general, but -1 for politeness13:45
opendevreviewElod Illes proposed openstack/nova stable/train: DNM: test preinstall of python3-yaml  https://review.opendev.org/c/openstack/nova/+/85186113:46
dansmith_gibi: to answer your question, the methods are mapped automatically, which means it's a problem for minor and major upgrades as artom noted, and why you can't find the method mapping13:46
*** dansmith_ is now known as dansmith13:46
gibidansmith: thanks for the feedback13:46
gibidansmith: so during minor upgrade we allow new compute code to run before the conductor is upgraded?13:48
dansmithyes, any service in any order13:48
gibithat is news for me13:49
gibianyhowe13:49
dansmithbut as I said on the review, this is really an impedance mismatch between compute and manager, it sounds like, and some refactoring there needs to happen instead of doubling down on the original thing, IMHO13:49
dansmithgibi: okay, that's why artom specifically called out minor updates13:49
dansmithbasically, we expect anyone should be able to "yum upgrade" on any node at any time13:49
gibiack, I learned something new today13:50
gibigoing back to the original problem13:50
gibiI don't know what will break if we remove the mutated migration context from the rollback_live_migration_at_destination call13:51
gibiIt was added there on purpose as far as I see13:51
artomYeah, it was so that we roll back the stuff claimed on the destination13:51
dansmithit's something in driver.destroy() that looks to see if there's a migration context, and does more/less stuff during destroy as a result right?13:51
artomActually, maybe not, ignore me until I look at the code again13:52
dansmithas noted, I think that was probably the first bad move13:52
dansmiththe "temporarily mutate instance so I don't have to change code elsewhere"13:53
dansmithended up having a side-effect that we didn't expect, so more flags to prevent side effects is just compounding the problem :)13:53
gibidansmith: I agree with general idea not to add more flags. So lets see if we can figure out how to untangle what we have13:55
dansmith++13:55
gibidansmith: if we are already at the problem the follow up patch https://review.opendev.org/c/openstack/nova/+/850746/3 show another occurence of the save under mutated migration context codepath.13:58
gibiwe call driver.rebuild https://review.opendev.org/c/openstack/nova/+/850746/3 under a mutated context13:58
kashyapgibi: Hey, is there some "openstack server show" command to see the machine type configured on the compute node?  Or 'grep'ing the nova.conf / `sudo virsh dumpxml $instance` the only way?13:58
dansmithgibi: I have to jump on a call, might have a few minutes after before the next one at the top of the next hour13:58
gibiand ironic virt driver saves the instance https://review.opendev.org/c/openstack/nova/+/850746/313:59
bauzaskashyap: you would need to be an admin at least if so13:59
gibidansmith: ack13:59
gibidansmith: no worries13:59
kashyapbauzas: Right, let's say admin.  Is there an admin Nova command?13:59
bauzasthis is a conf opt13:59
bauzasso this shouldn't be an API extension13:59
bauzasin general, we don't want to provide an API for knowing about some config option14:00
kashyapbauzas: Right; fair enough14:00
kashyapbauzas: Note, this is also a metadata and extra_spec property as well14:01
kashyap"this" == guest machine type14:01
kashyapbauzas: So if a user configures a Glance image with that image meta property, they should be able to see14:03
kashyapbauzas: So, `openstack image show` should show it if a user sets it14:05
gibidansmith: so if you have a minute at some point I summarized my second question here https://review.opendev.org/c/openstack/nova/+/850746/3/nova/compute/manager.py#379714:06
opendevreviewElod Illes proposed openstack/nova stable/train: DNM: test preinstall of python3-yaml  https://review.opendev.org/c/openstack/nova/+/85186114:06
gibikashyap: while I understand the need to see what machine type an instance uses, I don't think we have a single place we persist it for the insance. I guess we rely on the fact that we can always regenerate the machine type from the flavor + image + compute config.14:08
kashyapgibi: Great answer; that's exactly what I'm writing for a (downstream) docs question14:09
kashyapIt is set via 3 places as you indicate - per-compute host config; flavor extra spec; or an image metada prop14:09
kashyaps/metada/metadata/14:09
kashyapgibi: Oh, wait - do we actually support this hw:machine_type" via flavor extra_spec?14:16
* kashyap looks up14:16
gibikashyap: I dont see machine_type in https://docs.openstack.org/nova/latest/configuration/extra-specs.html14:21
kashyapgibi: Yeah, me neither: so only two ways - compute config; or image meta14:21
kashyapgibi: For image, a tenant user should be able to see it via `openstack image show`, right?14:22
gibiI think so 14:23
gibikashyap: one thing i see is that nova stores the image meta in instance.system_metadata['image_hw_machine_type'] so that even if the image is changed later the instance has its machine type persisted14:25
kashyapYeah, we do store it in system_metadata (Lee did that work)14:25
gibialso if an admin want to query the machine_type of an instance then it can be done via nova-manage14:26
kashyaphttps://docs.openstack.org/nova/latest/admin/hw-machine-type.html14:26
gibiack, that is the one14:26
kashyapgibi: What about the tenant user?  (Perhaps via `openstack image show`?14:26
gibiopenstack image show only valid the the image properties are not changed after the instance is booted (I'm not sure the image meta could change)14:27
bauzasoh the q35 saga14:27
bauzasforgot about it14:27
bauzashence the nova-manage command14:27
* bauzas does 3 different things at the same time :(14:27
bauzasactually, 4 given I reply14:27
kashyapgibi: Oh, right: "nova-manage image_property show $instance_uuid $property"14:28
kashyap--^ The above is for tenant too, right?14:28
kashyapSo, it'd be: `nova-manage image_property show $instance_uuid hw_machine_type`14:29
gibithe tenant does not have access to nova-manage14:31
gibithat is an admin tool14:31
gibiafaik14:31
kashyapYes, you're right14:31
opendevreviewStanislav Dmitriev proposed openstack/nova master: Add support for sync writes with block migration  https://review.opendev.org/c/openstack/nova/+/85189214:39
opendevreviewMerged openstack/placement master: doc: Comment out language option  https://review.opendev.org/c/openstack/placement/+/84485514:43
opendevreviewBalazs Gibizer proposed openstack/nova master: Do not mutate migration context for rollback_live_migration_at_destination  https://review.opendev.org/c/openstack/nova/+/85183215:00
opendevreviewBalazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context  https://review.opendev.org/c/openstack/nova/+/85074615:00
gibiartom, dansmith: when the other direction ^^. I don't find anything that breaks when I remove the mutation from rollback_live_migration_at_destination so I did so15:01
gibis/when/went/15:01
elodillesbauzas: are you updating the meeting page right now, or is it OK if i edit it?15:12
bauzaselodilles: I'm piling a lot of stuff, please do it by now and then I'll do it 15:13
elodillesbauzas: ack, one sec15:13
elodillesbauzas: done (i tried to be quick :))15:15
opendevreviewBalazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context  https://review.opendev.org/c/openstack/nova/+/85074615:25
bauzasreminder : nova meeting in 25 mins here15:35
gibistephenfin: if you have time, this makes py310 happy with unittest.mock https://review.opendev.org/c/openstack/nova/+/851445/15:37
opendevreviewMerged openstack/python-novaclient master: Microversion 2.91: Support specifying destination host to unshelve  https://review.opendev.org/c/openstack/python-novaclient/+/83165115:47
Ugglagibi, maybe dumb question but how do you properly set in instance in "failure" ?15:54
Ugglainstance.vm_state = vm_states.ERROR and instance.save() ?15:57
gibiit depends on where and when the ERROR condition happened15:59
UgglaI especially wonder about the error msg.15:59
gibiyou might need to report error on an instance event15:59
bauzas#startmeeting nova16:00
opendevmeetMeeting started Tue Aug  2 16:00:04 2022 UTC and is due to finish in 60 minutes.  The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
opendevmeetThe meeting name has been set to 'nova'16:00
bauzashi folks16:00
Ugglao/16:00
gibio/16:00
bauzasok, let's start so people will join16:01
ratailoro/16:01
elodilleso/16:01
bauzas#topic Bugs (stuck/critical) 16:02
bauzas#info No Critical bug16:02
bauzas#link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 11 new untriaged bugs (+1 since the last meeting)16:02
bauzas#link https://storyboard.openstack.org/#!/project/openstack/placement 27 open stories (+0 since the last meeting) in Storyboard for Placement 16:02
bauzasI had a small time for looking at the bugs16:02
bauzasbut I provided an etherpad https://etherpad.opendev.org/p/nova-bug-triage-2022072616:02
bauzasI only triaged two, as at least 3 other bugs need to be looked more16:03
bauzasthat's it16:03
opendevreviewMerged openstack/python-novaclient master: Add support for 2.92 : keypair import mandatory  https://review.opendev.org/c/openstack/python-novaclient/+/85123116:03
bauzasany bug to discuss ?16:03
bauzasbtw. I had fun with https://bugs.launchpad.net/nova/+bug/198326316:04
bauzaslooks we only accept Ussuri computes for Ussuri :p16:05
bauzascould be a FFU issue :)16:05
bauzasjust sayin' :)16:06
bauzasanyway, moving on16:06
bauzas#info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster16:07
bauzaselodilles: do you want to get the bug baton for this week ? :)16:07
elodillesbauzas: yes please! \o/16:08
elodilles:)16:08
bauzassuuuuure16:08
bauzas#info Next bug baton is passed to elodilles16:08
bauzasthat's it for bugds16:08
bauzas#topic Gate status 16:08
bauzas#link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs 16:08
bauzas#link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly Placement periodic job status 16:08
bauzas#link https://zuul.openstack.org/builds?job_name=tempest-integrated-compute-centos-9-stream&project=openstack%2Fnova&pipeline=periodic-weekly&skip=0 Centos 9 Stream periodic job status16:08
bauzas#link https://zuul.opendev.org/t/openstack/builds?job_name=nova-emulation&pipeline=periodic-weekly&skip=0 Emulation periodic job runs16:09
bauzasI've look at all of above ^16:09
bauzaslooked16:09
bauzasno issues I found16:09
bauzas#info Please look at the gate failures and file a bug report with the gate-failure tag.16:09
bauzas#info STOP DOING BLIND RECHECKS aka. 'recheck' https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures16:09
bauzasreally, please stop saying 'recheck'16:09
bauzaslast time, we found 50% nova rechecks that were blind16:10
bauzasI mean, 50% of all the nova rechecks16:10
bauzasmoving on ?16:11
* bauzas wonders whether people are already on PTO :)16:12
gibinope16:12
bauzas#topic Release Planning 16:12
bauzas#link https://releases.openstack.org/zed/schedule.html16:12
bauzas#info Zed-3 is in 4 weeks16:12
bauzasnow, hopefully you've seen my email from yesterday16:12
bauzas#link https://lists.openstack.org/pipermail/openstack-discuss/2022-August/029789.html16:13
bauzasI propose now to look at the etherpad I created16:13
bauzas#link https://etherpad.opendev.org/p/nova-zed-microversions-plan16:14
bauzaswe have 3 open changes asking for a microversion16:14
bauzasso I'd like to ask you folks how we could organize and triage those 3 between them for a microversion16:15
gibifor me it depends on how close they are to land16:16
bauzastwo of them were already modified to use 2.9216:17
bauzasso it looks to me both can be priorital16:17
bauzasone is touching the /servers API 16:17
bauzasbut only by a single rebuild action16:18
bauzasthe other one is  technically a WIP and adding a new API resource /os-server-shares16:18
gibiif the second one is a WIP then I guess the first one has priority: )16:19
bauzasany concerns about this ?16:19
gibibut I guess we don't have to decide it now16:19
opendevreviewBalazs Gibizer proposed openstack/nova master: Fix mocking SafeConnectedTestCase  https://review.opendev.org/c/openstack/nova/+/85190916:19
bauzasgibi: well, I would have preferred to have it decided by now16:20
gibisure, then lets decide :)16:20
bauzasbut it looks that we don't have a lot of folks around16:20
gibianybody has any opinion?16:20
bauzasrajat was asking me about this at least loudly16:20
artomDecide who gets what microversion?16:21
bauzasat least decide who would get 2.9316:21
artomAre all 2 guaranteed (inasmuch as that's possible in upstream world) to land?16:21
artom*all 316:21
bauzasI think we could say yes to https://review.opendev.org/c/openstack/nova/+/81615716:21
bauzasfor 2.9316:21
bauzasdansmith already looked at it and it was already around last cycle16:22
bauzasbut this means we would prioritize this change 16:22
artomI'd say it's up to the owner and reviwers to determine how close something is to land, and to give the next smallest microversion to the closest, then next closest, and so on16:22
bauzasartom: problem is about merge conflicts16:23
bauzasat least we have now https://review.opendev.org/c/openstack/nova/+/816157 and https://review.opendev.org/c/openstack/nova/+/830883 that got merge conflicts16:23
gibi(probably everything is in merge conflict as unittest.mock change landed)16:24
bauzasgibi: and you're just telling me this before I'm going off ? :)16:24
gibibauzas: it is landed yesterday?16:24
bauzashaven't seen it then16:25
gibiAug 01 21:0716:25
bauzasanyway16:25
bauzasif we don't have consensus, let's just tell the owners they need to provide their changes and ask for reviewes16:25
bauzasreviews*16:26
gibiIm fine with https://review.opendev.org/c/openstack/nova/+/816157 being the next one16:28
sean-k-mooney[m]o/16:28
bauzasgibi: cool, then let's prioritize it16:29
bauzaswhoami-rajat and Uggla could then modify their change to ask for 2.95 and we'll see in the meantime if jhartkopf can upload his series soon16:30
bauzasI'll drop a gerrit comment on https://review.opendev.org/c/openstack/nova/+/816157 telling him to rebase quickly16:30
bauzasif he can't, then whoami-rajat could use this API slot16:30
bauzaswfy folks ?16:31
gibior they can both rebase to 2.93 and have a race for landing :)16:31
gibiboth works for me16:31
whoami-rajatlet me know which one is suitable and i will rebase16:31
whoami-rajats/which/whichever16:32
bauzasgibi: yeah, we'll see16:34
bauzasit's the first time we're trying to organize API microversions, I guess we don't wanna be too much optimistic16:34
bauzaswhoami-rajat: I'd say prepare for 2.94 but be ready to propose 2.93 if https://review.opendev.org/c/openstack/nova/+/816157 doesn't get rebased next week16:35
sean-k-mooney[m]normally we only do this if they already have at least 1 +216:35
* artom wonders again if it'd be possible to automate that, and whether the effort would be worth it16:35
artomI guess you can't easily template Python code, which we would need16:36
artomOtherwise, if we keep a single running counter of source in a file or something, folks can just write %{next_microversion} or similar16:36
whoami-rajatack16:36
bauzasI think we're done with this16:37
bauzasmoving on16:37
bauzas#topic Review priorities 16:37
bauzas#link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+label:Review-Priority%252B116:37
bauzasanything to discuss ?16:38
gibibauzas: you need to add OR label+216:39
gibias now the query shows only +116:40
gibiie16:40
gibihttps://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2)16:40
bauzaswait16:40
bauzasbad copy/paste16:40
bauzashttps://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2)16:41
bauzasmy query was ok but I pasted the wrong one in the agenda16:41
gibiahh16:41
gibiOK16:41
bauzasanyway, apart from the mdev issue, I have nothing to say16:42
bauzasgibi: you asked for a FUP, I'm trying to upload it before I leave16:42
gibibauzas: OK16:42
gibiI will check it tomorrow16:42
bauzasif I can't, we'll need billy to write it16:42
bauzasmoving on then16:43
gibido you know the irc nick of billy?16:43
bauzas#topic Stable Branches 16:43
bauzasgibi: nope16:43
gibi:/16:44
bauzas#undo16:44
opendevmeetRemoving item from minutes: #topic Stable Branches 16:44
bauzaspreviously we were having quite a roster for asking to get the IRC nick16:44
gibiwe can move on, I just wanted to ping billy properly16:44
bauzascool16:45
bauzas#topic Stable Branches 16:45
bauzaselodilles: your turn16:45
elodillesyes16:45
elodilles#info stable/pike was EOL'd for nova projects16:45
elodilles#info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci16:46
elodilles#info stable/train (and older) is blocked, see details in the etherpad ^^^16:46
elodillessome extra info for the blocker:16:46
elodillesi did what sean-k-mooney[m] suggested and added a pre-yaml,16:46
elodillesthat installs python3-yaml which gets stuck originally,16:47
elodillesand it installs fine with the pre.yaml,16:47
sean-k-mooney[m]did that work16:47
sean-k-mooney[m]cool16:47
elodillesbut then something else gets stuck :/16:47
sean-k-mooney[m]:)16:47
elodillesso maybe something is crashing in the background...16:47
sean-k-mooney[m]is it still glibc?16:48
sean-k-mooney[m]or somethign else but ya possibly16:48
elodillesanyway, needs further investigation :/16:48
sean-k-mooney[m]ack16:48
elodillessean-k-mooney[m]: something different16:48
elodillessean-k-mooney[m]: now at the ssh keys setup16:48
elodillessean-k-mooney[m]: so seems unrelated from the previous16:49
sean-k-mooney[m]ok16:49
elodillesi guess something else causing the issue in the background16:49
elodillesanyway, that's my info for now :X16:49
bauzasack, thanks16:49
elodilles(and still, any help/idea is welcome o:))16:50
bauzasI wish I could, but I'll be off16:51
bauzaslast topic I guess16:51
bauzas#topic Open discussion 16:51
bauzasI have nothing on the agenda, except reminding that I'll be on PTO until August 29th (included)16:52
gibihave a nice PTO16:52
gibiI will try to run the meetings in the intermi16:52
bauzasI could be around tho, probably tomorrow evening and on monday before I restart16:52
bauzasat least for checking the 25k emails I should get during my vacation period16:53
bauzasthat's all I had, anything else people wanted to discuss ?16:53
gibi-16:53
bauzasif so16:54
bauzasthanks all16:54
bauzas#endmeeting16:54
opendevmeetMeeting ended Tue Aug  2 16:54:27 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:54
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-02-16.00.html16:54
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-02-16.00.txt16:54
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-02-16.00.log.html16:54
elodillesbauzas: have a nice time off o/16:54
gibisean-k-mooney[m], bauzas: could you push through https://review.opendev.org/q/topic:os-traits-2.8.0 ? welcome back tonyb!16:54
Ugglabauzas, have a nice PTO.16:54
sean-k-mooney[m]oh right placment16:55
sean-k-mooney[m]ya 16:55
sean-k-mooney[m]ill review tose now16:55
gibithanks16:55
sean-k-mooney[m]do we want to reenabel the test or jsut leave it disabled16:57
sean-k-mooney[m]i +w'd the frist patch16:57
sean-k-mooney[m]so the requreiment patch should be unblocked16:57
auniyalPlease review this- 17:00
auniyalhttps://review.opendev.org/c/openstack/nova/+/85151117:00
auniyalhttps://review.opendev.org/c/openstack/nova/+/84888617:00
gibisean-k-mooney[m]: lets reenable it. I think we need to move that test to python from gabbi17:02
sean-k-mooney[m]ok we can do that as a followup17:03
sean-k-mooney[m]ill approve renableing it so17:03
gibithanks I will try to do the move tomorrow17:03
sean-k-mooney[m]before you drop17:04
sean-k-mooney[m]https://review.opendev.org/c/openstack/nova/+/83233017:04
sean-k-mooney[m]can you add that to your review list17:04
sean-k-mooney[m]stephenfin: ^ i added the doc you asked for by the way17:04
sean-k-mooney[m]ill try and work on the rest of the chain later this week17:04
stephenfingibi: Done (the double mocking patch)17:04
stephenfinsean-k-mooney[m]: thanks17:05
sean-k-mooney[m]oh the doble mocking patch is up for review17:05
bauzasgibi: I'm about to give it up for the FUP but I found https://launchpad.net/~billy-olsen17:30
opendevreviewStanislav Dmitriev proposed openstack/nova master: Add support for sync writes with block migration  https://review.opendev.org/c/openstack/nova/+/85189217:42
opendevreviewSylvain Bauza proposed openstack/nova master: WIP: Stop using mdev_name2uuid and fix mdev recreation  https://review.opendev.org/c/openstack/nova/+/85192418:15
bauzasgibi: https://review.opendev.org/c/openstack/nova/+/851924 is the FUP I started to write18:15
*** bauzas is now known as bauzas_away18:17
*** kopecmartin_ is now known as kopecmartin19:09
opendevreviewArtom Lifshitz proposed openstack/nova master: Update libvirt enlightenments for Windows  https://review.opendev.org/c/openstack/nova/+/84764120:07
opendevreviewMerged openstack/placement master: disable traits count check to allow os-traits 2.8.0  https://review.opendev.org/c/openstack/placement/+/85179220:24
opendevreviewMerged openstack/nova master: add regression test case for bug 1978983  https://review.opendev.org/c/openstack/nova/+/84910420:24
opendevreviewMerged openstack/nova master: Remove double mocking  https://review.opendev.org/c/openstack/nova/+/85144520:24
opendevreviewMerged openstack/nova master: hacking: force explicit import of python's mock  https://review.opendev.org/c/openstack/nova/+/70876820:25
opendevreviewArtom Lifshitz proposed openstack/nova master: Update libvirt enlightenments for Windows  https://review.opendev.org/c/openstack/nova/+/84764120:48
opendevreviewMerged openstack/placement master: Update placement for os-traits 2.8.0 release  https://review.opendev.org/c/openstack/placement/+/85179321:04
*** dasm is now known as dasm|off21:09
opendevreviewmelanie witt proposed openstack/nova master: block_device_info: Add swap to inline  https://review.opendev.org/c/openstack/nova/+/82652321:33
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Improve creating images INFO log  https://review.opendev.org/c/openstack/nova/+/82652421:33
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Remove defunct comment  https://review.opendev.org/c/openstack/nova/+/82652521:33
opendevreviewmelanie witt proposed openstack/nova master: imagebackend: default by_name image_type to config correctly  https://review.opendev.org/c/openstack/nova/+/82652621:33
opendevreviewmelanie witt proposed openstack/nova master: image_meta: Add ephemeral encryption properties  https://review.opendev.org/c/openstack/nova/+/76045421:33
opendevreviewmelanie witt proposed openstack/nova master: BlockDeviceMapping: Add encryption fields  https://review.opendev.org/c/openstack/nova/+/76045321:33
opendevreviewmelanie witt proposed openstack/nova master: BlockDeviceMapping: Add is_local property  https://review.opendev.org/c/openstack/nova/+/76448521:33
opendevreviewmelanie witt proposed openstack/nova master: compute: Update bdms with ephemeral encryption details when requested  https://review.opendev.org/c/openstack/nova/+/76448621:33
opendevreviewmelanie witt proposed openstack/nova master: virt: Add ephemeral encryption flag  https://review.opendev.org/c/openstack/nova/+/76045521:33
opendevreviewmelanie witt proposed openstack/nova master: scheduler: Add an ephemeral encryption pre filter  https://review.opendev.org/c/openstack/nova/+/76045621:33
opendevreviewmelanie witt proposed openstack/nova master: block_device: Add DriverImageBlockDevice to block_device_info  https://review.opendev.org/c/openstack/nova/+/82652721:33
opendevreviewmelanie witt proposed openstack/nova master: block_device: Add encryption attributes to image and ephemeral disks  https://review.opendev.org/c/openstack/nova/+/82652821:33
opendevreviewmelanie witt proposed openstack/nova master: virt: Add block_device_info helper to find encrypted disks  https://review.opendev.org/c/openstack/nova/+/82652921:33
opendevreviewmelanie witt proposed openstack/nova master: blockinfo: Add encryption details to the disk_info mappings when provided  https://review.opendev.org/c/openstack/nova/+/77227221:33
opendevreviewmelanie witt proposed openstack/nova master: imagebackend: Add disk_info_mapping as an optional attribute of Image  https://review.opendev.org/c/openstack/nova/+/82653021:33
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image  https://review.opendev.org/c/openstack/nova/+/84624621:33
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command  https://review.opendev.org/c/openstack/nova/+/82675221:33
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Report ephemeral encryption traits based on imagebackend  https://review.opendev.org/c/openstack/nova/+/82675321:33
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets  https://review.opendev.org/c/openstack/nova/+/82675421:33
opendevreviewmelanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption  https://review.opendev.org/c/openstack/nova/+/82675521:33
opendevreviewmelanie witt proposed openstack/nova master: imagebackend: Cache the key manager when disk is encrypted  https://review.opendev.org/c/openstack/nova/+/82675621:33
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS  https://review.opendev.org/c/openstack/nova/+/77227321:33
tonybgibi: it's wonderful to be back.  I see that some of the patches have landed.  I'll check on the progress after coffee22:14

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!