| opendevreview | melanie witt proposed openstack/nova master: imagebackend: Cache the key manager when disk is encrypted https://review.opendev.org/c/openstack/nova/+/826756 | 01:39 |
|---|---|---|
| opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/851337 | 04:34 |
| gibi | good morning | 06:09 |
| bauzas | sean-k-mooney: gmann: gibi: thanks for your comments on https://review.opendev.org/c/openstack/nova/+/849133 will respin | 08:39 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: api: Drop generating a keypair and add special chars to naming https://review.opendev.org/c/openstack/nova/+/849133 | 09:06 |
| bauzas | gibi: sean-k-mooney: gmann: reviews welcome on the respined keypair api change, just fixed gmann's points and some doc | 09:06 |
| bauzas | https://review.opendev.org/c/openstack/nova/+/849133/7..8 | 09:07 |
| sean-k-mooney | that still looks fine to me so readded +2 | 09:13 |
| kashyap | Can anyone figure out what's the failure here: https://zuul.opendev.org/t/openstack/build/de15983e71c8421c8623f892daaed414 | 09:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | 09:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Retry /reshape at provider generation conflict https://review.opendev.org/c/openstack/nova/+/851358 | 09:19 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | 09:19 |
| gibi | sean-k-mooney: fyi ^^ I have preliminary allocation healing support | 09:19 |
| gibi | sean-k-mooney: the yesterday's reshape headache was caused by a missing retry logic for reshape when the local provider tree cache is stale | 09:19 |
| gibi | so my code was correct :D | 09:20 |
| gibi | now I will help auniyal then I will look at the keypair patch then look at the double mocking issue | 09:20 |
| admin1 | sean-k-mooney, how do I validate "admin1: no in that config nova should upload the snapshot via the glace http api" ? .. it looks like its calling the http api and getting the error .. | 09:22 |
| sean-k-mooney | admin1: did you check glance to see if the error is on its side. | 09:43 |
| sean-k-mooney | the broken pip could be form reading the image from disk, uploading the image to glance or possible else where | 09:44 |
| sean-k-mooney | but first stpe is proably to determin if there is an error on the glance side or if its just in nova | 09:45 |
| kashyap | bauzas: Since you looked at the master change, can you also please ACK the stable-{wallaby, xena, yoga} backports a the bottom here, please: https://review.opendev.org/q/topic:bug%252F1982853 | 09:55 |
| kashyap | Master change merged | 09:55 |
| bauzas | kashyap: ack | 10:04 |
| kashyap | bauzas: gibi: Both of you gave +2, but neither set Workflow :) - https://review.opendev.org/c/openstack/nova/+/851205 | 10:26 |
| kashyap | (stable/xena) Thanks | 10:26 |
| bauzas | because again, we need to hold for yoga | 10:27 |
| bauzas | don't fight for xena, just relax with a yoga :p | 10:27 |
| bauzas | ok, probably one of the worst puns I made | 10:28 |
| kashyap | Heh | 10:28 |
| kashyap | bauzas: Ah, yes. I thought you +2ed yoga too | 10:29 |
| bauzas | I did +W for yoga | 10:29 |
| bauzas | now that our master is merged | 10:29 |
| kashyap | Yes, you did; I missed to refresh; thx! | 10:30 |
| kashyap | bauzas: Also check wallaby, please, while you have the context | 10:30 |
| kashyap | It has gibi's ACK - https://review.opendev.org/c/openstack/nova/+/851206 | 10:30 |
| bauzas | I'll visit the wallabies | 10:30 |
| bauzas | you sur'ly (ussuri) | 10:31 |
| bauzas | and then I'll take the train | 10:32 |
| bauzas | oh, but again, I missed Victoria | 10:32 |
| kashyap | Heh | 10:34 |
| kashyap | Thanks! | 10:34 |
| kashyap | Yes | 10:34 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: use force down to stabilize the test https://review.opendev.org/c/openstack/nova/+/851368 | 10:38 |
| stephenfin | gibi: sean-k-mooney: I missed your ping yesterday RE: the mock stuff. That sounds like a lot of work. Damn it /o\ | 10:50 |
| gibi | stephenfin: I'm just about to start looking into it to see how much work to fix it | 10:50 |
| gibi | so I hope I will have a better understanding by the end of today | 10:51 |
| stephenfin | Jinx. I was about to say I can try to play around with it but I don't know if I can spend days at it, heh | 10:51 |
| stephenfin | You saw efried's pointer to other projects that have solved this problem already? | 10:51 |
| gibi | yes I saw | 10:51 |
| stephenfin | sweet | 10:51 |
| gibi | we need efried back in nova! | 10:51 |
| stephenfin | I mean, it's not like he needs to sleep | 10:52 |
| stephenfin | You can sleep when you're dead etc. etc. ;-) | 10:52 |
| gibi | yepp, exactly like that :D | 10:53 |
| gibi | I remember we had such poster in the office a couple of years back. | 10:53 |
| gibi | bauzas, sean-k-mooney: can we land this? https://review.opendev.org/c/openstack/os-traits/+/850538 I hate to see the red CI in my series due to that | 10:57 |
| sean-k-mooney | ah that am ill review it now in a sec just finishing an email but ya we will need to do a releas but i can propose that once its merged | 11:01 |
| bauzas | gibi: just a +1 nit https://review.opendev.org/c/openstack/os-traits/+/850538 | 11:02 |
| bauzas | tl;dr: singular or plural ? | 11:02 |
| bauzas | if this is for the root RP, ie. the compute host itself, I guess we could make it plural | 11:03 |
| gibi | it will be on every PCI RP | 11:03 |
| bauzas | if this is for a nested RP | 11:03 |
| bauzas | then singular | 11:03 |
| gibi | but wont be on the root | 11:03 |
| bauzas | ok, then you answered my question, will +2 | 11:03 |
| gibi | thanks | 11:03 |
| sean-k-mooney | i would go plural | 11:04 |
| * bauzas was enough lazy to not look at the spec | 11:04 | |
| bauzas | sean-k-mooney: if this is a PCI RP, then singular | 11:04 |
| sean-k-mooney | based on ACCELERATORS and REMOTE_MANAGED_PORTS | 11:04 |
| bauzas | like "I can manage myself" | 11:04 |
| sean-k-mooney | this is kind of like sheep | 11:05 |
| * bauzas didn't want to derail the series for such a nit | 11:05 | |
| sean-k-mooney | 1 sheep 2 sheep | 11:05 |
| bauzas | damn english folks | 11:05 |
| sean-k-mooney | either works but i think plural is more correct | 11:05 |
| sean-k-mooney | well ok | 11:05 |
| sean-k-mooney | no your right | 11:05 |
| sean-k-mooney | singulaer | 11:05 |
| sean-k-mooney | sicne we have 1 RP per PF | 11:05 |
| sean-k-mooney | i was thinking about the VF inventories | 11:06 |
| gibi | we have 1 PR per multiple VFs | 11:06 |
| gibi | :) | 11:06 |
| gibi | RP | 11:06 |
| sean-k-mooney | ya so this is correct as is | 11:06 |
| gibi | OK | 11:06 |
| bauzas | yeah | 11:06 |
| bauzas | I wasn't discussing about SRIOV | 11:06 |
| bauzas | this is for a PCI ID | 11:06 |
| gibi | btw, bauzas, this trait was not mentioned in the spec so I added a comment to the merged spec now and I will push a follow up on the spec to sync it with the implementation reality | 11:07 |
| bauzas | hence singular | 11:07 |
| sean-k-mooney | gibi: we can update the spec later | 11:07 |
| gibi | yeah I | 11:07 |
| sean-k-mooney | based on the final merged implemeantion | 11:07 |
| gibi | I'm planning to do so | 11:07 |
| bauzas | gibi: ok, so I wasn't lazy then :D | 11:07 |
| bauzas | :ô | 11:07 |
| bauzas | :p | 11:07 |
| gibi | I'm collecting the comments there to know what to update | 11:07 |
| sean-k-mooney | we also move the logic to the compute manager | 11:07 |
| gibi | sean-k-mooney: yepp | 11:07 |
| sean-k-mooney | i dont know if we eplxitly said tiwoudl be in the driver before but its good to document | 11:08 |
| bauzas | gibi: I'll try to look at your series before tuesday eob | 11:08 |
| bauzas | oh wait | 11:09 |
| gibi | bauzas: when you look try to focus on the high level direction and architecture please | 11:09 |
| bauzas | gibi: https://github.com/openstack/os-traits/tree/master/os_traits/hw | 11:09 |
| gibi | we discussed with sean-k-mooney that this is not a hw trait | 11:09 |
| bauzas | could be hw | 11:09 |
| gibi | but more like a capability trait | 11:09 |
| gibi | of the compute service | 11:09 |
| bauzas | meh ok | 11:09 |
| * bauzas needs to lunch | 11:09 | |
| opendevreview | Merged openstack/os-traits master: Add COMPUTE_MANAGED_PCI_DEVICE trait https://review.opendev.org/c/openstack/os-traits/+/850538 | 11:12 |
| gibi | bauzas, sean-k-mooney: thanks! | 11:12 |
| gibi | I'm going to push a os-traits release | 11:13 |
| sean-k-mooney | lets wait a sec | 11:15 |
| bauzas | damn | 11:15 |
| bauzas | | nova | 11 | 22 | 50.0 | | 11:15 |
| bauzas | 50% of blind rechecks | 11:15 |
| bauzas | man ! | 11:15 |
| sean-k-mooney | it would be nice to do https://review.opendev.org/c/openstack/os-traits/+/844336 too | 11:15 |
| bauzas | don't people read our meeting ? :)= | 11:16 |
| sean-k-mooney | ricolin: ^ coudl you respin that quickly and remvoe the none | 11:16 |
| sean-k-mooney | well | 11:17 |
| sean-k-mooney | ricolin: we could leave it i guess | 11:17 |
| sean-k-mooney | ah actully no | 11:17 |
| sean-k-mooney | vioummu=non shouuld not force libvirt | 11:18 |
| sean-k-mooney | so we should remove the trait and not request a trait if you set the exptra spec to none | 11:18 |
| sean-k-mooney | gibi: bauzas alernitivly i could adress my own nit in that patch and ye could review | 11:19 |
| gibi | sean-k-mooney: go for it | 11:19 |
| gibi | I can respin the releasenotes | 11:19 |
| gibi | s/releasenotes/release/ | 11:19 |
| opendevreview | sean mooney proposed openstack/os-traits master: Add traits for vIOMMU https://review.opendev.org/c/openstack/os-traits/+/844336 | 11:21 |
| sean-k-mooney | oh the depends on is wrong | 11:22 |
| opendevreview | sean mooney proposed openstack/os-traits master: Add traits for vIOMMU https://review.opendev.org/c/openstack/os-traits/+/844336 | 11:22 |
| sean-k-mooney | ok ^ should be good to review | 11:23 |
| * gibi clicks | 11:24 | |
| gibi | done +2 | 11:27 |
| gibi | stephenfin, sean-k-mooney: so far I fixed the duplicated mocking in libvirt.test_driver and all of them was either an unnecessary second mocking or can be fixed easily. So I think while it is manual work it can be done. I will try to fix them today and push a patch | 12:19 |
| sean-k-mooney | sound promising | 12:19 |
| gibi | I think it is worth to fix as there was really stupid mistakes caught by this. like mocking the same thing twice in two consecutive decorator and applying assert on the second mock :) | 12:21 |
| opendevreview | ribaudr proposed openstack/python-novaclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-novaclient/+/831651 | 12:43 |
| bauzas | ok, will rebase my novaclient change on top of ^ | 12:48 |
| opendevreview | ribaudr proposed openstack/python-novaclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-novaclient/+/831651 | 12:50 |
| Uggla | bauzas, hoping you will not have too many conflicts. | 12:52 |
| bauzas | Uggla: nope, just one I guess | 12:52 |
| bauzas | for the microversion number | 12:52 |
| *** dasm|off is now known as dasm | 12:57 | |
| opendevreview | Sylvain Bauza proposed openstack/python-novaclient master: Add support for 2.92 : keypair import mandatory https://review.opendev.org/c/openstack/python-novaclient/+/851231 | 13:01 |
| bauzas | Uggla: actually, no merge conflict I got \o/ | 13:01 |
| bauzas | just a simple rebase | 13:01 |
| Uggla | bauzas, \o/ | 13:01 |
| opendevreview | Amit Uniyal proposed openstack/nova master: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/848886 | 13:07 |
| stephenfin | gibi: nice work :) | 13:33 |
| gibi | TIL: if there are both side_effect and return_value is defined on a mock then return_value is ignored | 14:12 |
| gibi | bauzas: when you are around, could you hit https://review.opendev.org/c/openstack/os-traits/+/844336 ? | 14:14 |
| bauzas | I am and I can | 14:15 |
| gibi | thank you | 14:15 |
| gibi | I will update the os-trait release patch once that lands | 14:15 |
| bauzas | done | 14:15 |
| gibi | awesome thanks | 14:17 |
| opendevreview | Merged openstack/os-traits master: Add traits for vIOMMU https://review.opendev.org/c/openstack/os-traits/+/844336 | 14:26 |
| gibi | sean-k-mooney, bauzas: I've updated the os-traits release patch https://review.opendev.org/c/openstack/releases/+/851390 | 14:30 |
| efried | :* | 14:33 |
| gibi | o/ | 14:33 |
| gibi | efried: how is life? | 14:34 |
| efried | Living the dream. Working on https://github.com/openshift/hive/ mostly. Enjoy it a lot. | 14:35 |
| efried | What's new with y'all? | 14:35 |
| gibi | good to hear that | 14:38 |
| gibi | I got involved writing k8s operators to deploy OpenStack so I will look at hive at some point to learn some tricks :) | 14:39 |
| gibi | while also trying to make PCI tracking in Placement happen | 14:40 |
| efried | Not gonna claim hive is the examplar of k8s operators, but it has some pretty cool stuff going on. | 14:44 |
| efried | In theory hive will deploy OpenStack -- though I've never tried it myself. | 14:44 |
| whoami-rajat | hi #openstack-nova , wanted to request reviews on my feature, it's been sitting for 3 months without reviews and just wanted to get it in in the Zed cycle https://review.opendev.org/c/openstack/nova/+/831219 | 14:47 |
| whoami-rajat | 1) https://review.opendev.org/c/openstack/nova/+/820368 | 14:47 |
| whoami-rajat | 2) https://review.opendev.org/c/openstack/nova/+/831219 | 14:47 |
| whoami-rajat | 3) https://review.opendev.org/c/openstack/nova/+/830883 | 14:47 |
| dansmith | whoami-rajat: sorry I lost track of that.. tempest tests are now working? | 14:49 |
| dansmith | whoami-rajat: the top patch is in merge conflict | 14:49 |
| sean-k-mooney | i started reviewing on eof thos yesterday but was tied up with downstream stuff | 15:01 |
| sean-k-mooney | oh it was the tempest patch | 15:01 |
| sean-k-mooney | dansmith: im pretty sure that passwords are optional for rebuild even if you orginaly set one but im not sure about what tempest needs | 15:03 |
| sean-k-mooney | im expecting it to use the ssh key it has | 15:03 |
| sean-k-mooney | and fall back to the default cirros one otherwise based on its config | 15:03 |
| dansmith | sean-k-mooney: yeah, but that code was copied from somewhere else, and it looked to me like it might be required in case they're using passwords instead of keys | 15:04 |
| dansmith | but regardless, it's just not part of the test so the comment was irrelevant I think | 15:04 |
| sean-k-mooney | ack | 15:05 |
| sean-k-mooney | i havent looked at the nova change yet | 15:05 |
| sean-k-mooney | its on my radar | 15:06 |
| sean-k-mooney | whoami-rajat:^ | 15:06 |
| sean-k-mooney | what was for you | 15:07 |
| whoami-rajat | dansmith, yeah, tempest is working, i will rebase the nova patch, not sure if there is any change needed on the tempest patch based on the comments | 15:43 |
| whoami-rajat | sean-k-mooney, some part of the test is taken from rebuilding an image backed instance, and thanks for looking | 15:44 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | 16:14 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | 16:14 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 16:14 |
| whoami-rajat | dansmith, ^ rebased | 16:14 |
| dansmith | ack | 16:21 |
| opendevreview | Oliver Walsh proposed openstack/nova master: Skip cell0 in all-cells min version check https://review.opendev.org/c/openstack/nova/+/851440 | 17:21 |
| opendevreview | Oliver Walsh proposed openstack/nova master: Skip cell0 in all-cells min version check https://review.opendev.org/c/openstack/nova/+/851440 | 17:22 |
| dansmith | owalsh_: so your templated urls don't have DB names in them, it seems | 17:26 |
| owalsh_ | dansmith: correct, has --database_connection='{scheme}://{username}:{password}@{hostname}/?{query}' | 17:27 |
| dansmith | they have hostnames per cell, but I'm not exactly sure why.. are those pointing to hostnames that are VIPs for separate DB instances or something/ | 17:27 |
| owalsh_ | so on the cell1 conductor in nova.conf it the db connection will point to it's mariadb, cell0 is on a different mariadb | 17:27 |
| owalsh_ | both are VIPs | 17:28 |
| dansmith | owalsh_: I need to see the full stack of where this is called from | 17:28 |
| dansmith | owalsh_: I guess the problem is that this is being called from a cell conductor and not a superconductor and that's the problem.. and I guess that's because the cell conductor has api_database configured and thus thinks it is supposed to do the fanout? | 17:29 |
| dansmith | but I want to know what the operation is that gets us here | 17:29 |
| dansmith | actually, | 17:30 |
| dansmith | the superconductor will be the same because templated urls are never going to work if you have DBs on different hostnames but try to use {hostname} since that will only ever resolve to one | 17:30 |
| dansmith | so you probably need to just not use {hostname} in the URLs if the DBs are at specific locations | 17:30 |
| dansmith | if you're using DNS names pointing to VIPs like cell1.foo and cell0.foo, then you don't need the template at all right? | 17:31 |
| owalsh_ | full stack doesn't give any more info but I'll post it. It's called from utils.raise_if_old_compute() in service create() AFAICT | 17:31 |
| dansmith | okay, but need to know what's being done to know who is calling that and for why | 17:32 |
| dansmith | but if we want to exclude cell0 from that check (which *is* specific to computes) we should do it there and not in this generalized method | 17:33 |
| dansmith | however, like I say, that's just punting the can down the road, because a superconductor arrangement like this with multiple cells will not work | 17:33 |
| owalsh_ | ack, in tripleo superconductor will use the same DB server as cell0 so it happens to work | 17:33 |
| dansmith | okay | 17:34 |
| dansmith | but if you use per-db hostnames, then no need for the {hostname} in the template at all right? | 17:34 |
| dansmith | (per-db hostnames being far superior, of course) | 17:34 |
| dansmith | the template was really for the credentials and not the other things, I just added every part of the url into the templating engine for flexibility | 17:35 |
| sean-k-mooney[m] | im having some issues with my work laptop so im going to set up my personal one quickly so ill be on matrix for a bit rather then irc | 17:41 |
| sean-k-mooney[m] | i should see either ping | 17:41 |
| sean-k-mooney[m] | but just an fyi | 17:41 |
| *** gibi is now known as gibi_pto | 17:43 | |
| gibi_pto | I will be off tomorrow, but back on Monday | 17:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Remove double mocking https://review.opendev.org/c/openstack/nova/+/851445 | 17:53 |
| gibi_pto | stephenfin, sean-k-mooney[m]: ^^ it is just a partial fix but I run out of time today and I will be off tomorrow so I pushed it. feel free to take over tomorrow if you have time | 17:54 |
| sean-k-mooney[m] | gibi_pto: ack | 17:59 |
| owalsh_ | dansmith: nova-conductor logs - https://paste.openstack.org/show/b85LsPayPl2QYN6RrDi1/, just noticed that it times out waiting for cell0 after 1 minutes so not fatal | 18:00 |
| owalsh_ | dansmith: even if we just switch to the VIP hostnames might have issues if there is a firewall between the cell conductor and the cell0 db | 18:03 |
| dansmith | owalsh_: yeah, so making that compute-specific check might be good, just needs to be one level up | 18:06 |
| dansmith | I'll look at the logs in just a sec | 18:06 |
| dansmith | owalsh_: yeah it should handle the failure gracefully | 18:08 |
| dansmith | owalsh_: that's not enough to tell what's going on because of how the stack frame gets chopped for a thread, unfortunately | 18:09 |
| dansmith | can you correlate that req-id with the api logs or something? | 18:09 |
| dansmith | owalsh_: nm, I got it.. on service startup | 18:18 |
| owalsh_ | dansmith: hrmm, I guess it's not just the hostname that could be an issue. If cell0 username/password is different to the cell nova db it would also fail | 18:40 |
| dansmith | owalsh_: yep for sure, that's one of the compromises | 18:41 |
| dansmith | but the assertion during design was that credentials are more per-host and less per-database | 18:41 |
| owalsh_ | ack, IIRC for tripleo it's really just the {query} part that mattered as it included the local bind address for each host | 18:43 |
| dansmith | ack | 18:43 |
| owalsh_ | but now that has moved to a local conf file (pymysql version didn't support this at the time) | 18:43 |
| owalsh_ | so could maybe just stop using cell templates, will take a look | 18:44 |
| dansmith | yeah, if possible I'm sure that'd be better | 18:44 |
| opendevreview | Merged openstack/nova master: api: Drop generating a keypair and add special chars to naming https://review.opendev.org/c/openstack/nova/+/849133 | 19:09 |
| owalsh_ | dansmith: re the api db connection currently being set on the cell conductor, I guess we want to keep that? | 20:19 |
| dansmith | owalsh_: "we" being redhat yeah, because we want the affinity check to work | 20:37 |
| *** EugenMayer8 is now known as EugenMayer | 20:46 | |
| *** dasm is now known as dasm|off | 21:47 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!