| opendevreview | melanie witt proposed openstack/nova master: imagebackend: default by_name image_type to config correctly https://review.opendev.org/c/openstack/nova/+/826526 | 02:14 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova master: image_meta: Add ephemeral encryption properties https://review.opendev.org/c/openstack/nova/+/760454 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add encryption fields https://review.opendev.org/c/openstack/nova/+/760453 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add is_local property https://review.opendev.org/c/openstack/nova/+/764485 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: compute: Update bdms with ephemeral encryption details when requested https://review.opendev.org/c/openstack/nova/+/764486 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: virt: Add ephemeral encryption flag https://review.opendev.org/c/openstack/nova/+/760455 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: scheduler: Add an ephemeral encryption pre filter https://review.opendev.org/c/openstack/nova/+/760456 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: block_device: Add DriverImageBlockDevice to block_device_info https://review.opendev.org/c/openstack/nova/+/826527 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to image and ephemeral disks https://review.opendev.org/c/openstack/nova/+/826528 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: virt: Add block_device_info helper to find encrypted disks https://review.opendev.org/c/openstack/nova/+/826529 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: blockinfo: Add encryption details to the disk_info mappings when provided https://review.opendev.org/c/openstack/nova/+/772272 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add disk_info_mapping as an optional attribute of Image https://review.opendev.org/c/openstack/nova/+/826530 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image https://review.opendev.org/c/openstack/nova/+/846246 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Report ephemeral encryption traits based on imagebackend https://review.opendev.org/c/openstack/nova/+/826753 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | 02:14 |
| opendevreview | melanie witt proposed openstack/nova master: Workaround qemu query-migrate issue during live migration https://review.opendev.org/c/openstack/nova/+/842687 | 03:49 |
| opendevreview | liuhuajie proposed openstack/nova master: Remove None for get method, the default value is None https://review.opendev.org/c/openstack/nova/+/850450 | 05:10 |
| opendevreview | Manuel Bentele proposed openstack/nova-specs master: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova-specs/+/849488 | 07:09 |
| opendevreview | Manuel Bentele proposed openstack/nova master: libvirt: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova/+/828675 | 07:27 |
| gibi | o/ | 08:06 |
| bauzas | \o | 08:18 |
| Uggla | o/ | 08:19 |
| * kashyap waves | 08:28 | |
| kashyap | A patch on SPICE, interesting ... upstream SPICE seems almost inactive | 08:28 |
| kashyap | s/almost inactive/dead/ | 08:30 |
| gibi | sean-k-mooney: you probably saw last evening I pushed an update to the pci tracking series. I fixed most of your comments but some is left open with an answer from me, like the owner trait, or the PciDeviceSpec move to PciDevice. I put my oppinonon about those into the reviews | 08:36 |
| sean-k-mooney | ack i did not but ill try to take a look at them today | 08:37 |
| gibi | I promised couple of refactors on top. I will do those now | 08:37 |
| sean-k-mooney | cool | 08:37 |
| gibi | and I noticed a strange functional failure I have to track down (probably a leaked global state somewhere) | 08:37 |
| sean-k-mooney | gibi: is https://review.opendev.org/c/openstack/nova/+/843834 the first patch in the serise | 09:26 |
| sean-k-mooney | i think so but i know that it splits latter | 09:26 |
| gibi | yes, that is the start | 09:27 |
| gibi | I did not update the secondary thread of patches | 09:27 |
| gibi | just the main one | 09:27 |
| sean-k-mooney | cool ill grab coffee and make my way throuhg it | 09:27 |
| gibi | ohh shit, I have an extra file added to that patch :D | 09:27 |
| sean-k-mooney | in the secondary traead there was one change i suggested pulling out an merging first | 09:27 |
| sean-k-mooney | ah q | 09:28 |
| sean-k-mooney | a very good file in deed | 09:28 |
| gibi | there was the restart compute func test enhancement that you asked to split out I will do that todayt | 09:28 |
| gibi | I haven't checked the secondary thread there might be others there too | 09:29 |
| sean-k-mooney | ya that is the one | 09:29 |
| sean-k-mooney | i just think that woudl be nice ot merge ahead of the rest | 09:29 |
| gibi | let me quckly resping the series to remove "q" :D | 09:29 |
| sean-k-mooney | oh its novs git log | 09:29 |
| sean-k-mooney | fun that is nice an recursvice | 09:29 |
| * gibi should stop using git add -A blindly | 09:30 | |
| sean-k-mooney | i never do | 09:30 |
| sean-k-mooney | fable has it that back in the dark dark days of nova | 09:30 |
| sean-k-mooney | someone added the entire ddwrt image or souce to novas git repo | 09:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | 09:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | 09:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | 09:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | 09:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | 09:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | 09:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | 09:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | 09:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | 09:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | 09:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | 09:31 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | 09:31 |
| gibi | jeah I heard that story :) | 09:31 |
| sean-k-mooney | jay should me the commit at one point | 09:31 |
| sean-k-mooney | i think it has been purged form the amin repo but still exists in gerrits copy | 09:32 |
| sean-k-mooney | or did at one point | 09:32 |
| gibi | "q" is removed. hope he will not be mad about it :) | 09:32 |
| sean-k-mooney | but where will we get all the fancy toys now | 09:33 |
| gibi | we need to wait and evolve... | 09:33 |
| sean-k-mooney | im going to read your comment in email and respond to them then ill go back and do a review form the start | 09:38 |
| gibi | thanks | 09:40 |
| opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | 10:07 |
| opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | 10:07 |
| opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | 10:07 |
| opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (drivers) https://review.opendev.org/c/openstack/nova/+/833090 | 10:07 |
| opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | 10:07 |
| opendevreview | ribaudr proposed openstack/nova master: [WIP] Bump compute version and check shares support https://review.opendev.org/c/openstack/nova/+/850499 | 10:07 |
| opendevreview | ribaudr proposed openstack/nova master: [WIP] Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | 10:07 |
| opendevreview | ribaudr proposed openstack/nova master: [WIP] Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | 10:07 |
| opendevreview | Stephen Finucane proposed openstack/placement master: docs: Unset 'language' https://review.opendev.org/c/openstack/placement/+/850505 | 10:29 |
| bauzas | Uggla: made a few comment nits on your unshelve patch | 10:52 |
| bauzas | if you have time to write UTs, would be appreciated before you respin https://review.opendev.org/c/openstack/nova/+/831507/17 | 10:52 |
| bauzas | but if you prefer, I can accept as-it-is and just update https://review.opendev.org/c/openstack/nova/+/845897 | 10:53 |
| bauzas | you could update the compute part UTs in a FUP | 10:53 |
| bauzas | (follow-up patch) | 10:53 |
| sean-k-mooney | gibi: ok ill loop back to review them properly later but responed to the remaining open comments i reluctanlty agree whith why you did not put the fucntion in the pcidevice object | 11:22 |
| gibi | sean-k-mooney: I will do a quick spike on the refactor of PciDeviceSpec to PciDevice but I'm affraid it will be a can of worms | 11:22 |
| sean-k-mooney | leave it for now | 11:23 |
| sean-k-mooney | we can reevaluate in A | 11:23 |
| sean-k-mooney | it would requrie converting the dicts we get rom the hypervior into the pci objects | 11:24 |
| sean-k-mooney | and having the tracker add the tag info ectra to them | 11:24 |
| sean-k-mooney | based on the pci entry they matched | 11:24 |
| sean-k-mooney | so let not go there for now | 11:24 |
| sean-k-mooney | stephenfin: care to re review https://review.opendev.org/c/openstack/nova-specs/+/849488/5 | 11:27 |
| stephenfin | Sure | 11:28 |
| gibi | sean-k-mooney: ack | 11:30 |
| gibi | incoming... | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | 11:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/850510 | 11:43 |
| gibi | sean-k-mooney: I moved the libvirt func test compute restart change to the beggining | 11:44 |
| gibi | it become a bit bigger as I found some existing tests using various local methods to implement the restart | 11:44 |
| gibi | so I had to move them to the new function | 11:44 |
| Uggla | bauzas, could we have a really quick chat beginning of the afternoon, just to be clear about what you expect. | 11:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | 11:55 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | 11:55 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | 11:55 |
| sean-k-mooney | gibi: thats why i wanted it to be a sperate change form the serise i had obseved some old and new tests that did it | 11:57 |
| sean-k-mooney | and having one implemenation is good | 11:57 |
| gibi | yepp | 11:57 |
| gibi | good suggestion | 11:57 |
| sean-k-mooney | ok i have a downstream call in a minute and have not had coffee thismoring eventhough fyera work me up 2 hours before i normally do | 11:58 |
| sean-k-mooney | so coffee -> meetting -> then code review :) | 11:58 |
| gibi | sean-k-mooney: no worries, I have things to do :) | 11:58 |
| * gibi go and gets something to eat | 11:59 | |
| bauzas | Uggla: in 10 mins if you can | 12:02 |
| Uggla | bauzas, no pb, just ping me when you can. | 12:03 |
| bauzas | Uggla: ack, doing something first | 12:20 |
| bauzas | Uggla : https://meet.google.com/dji-oznv-cfz | 12:30 |
| bauzas | (people can join if they wish) | 12:30 |
| Uggla | bauzas, ok joining | 12:30 |
| * bauzas just grabs a tshirt first :) | 12:30 | |
| ricolin | sean-k-mooney: regarding https://review.opendev.org/c/openstack/nova/+/830646/12/nova/tests/unit/virt/libvirt/test_driver.py#8651 | 13:42 |
| ricolin | you mean only q35 and AArch64 are acceptable, and we will raise errors when providing iommu with all other arch? | 13:42 |
| sean-k-mooney | yes | 13:43 |
| sean-k-mooney | we cannot ignore a request for a feature | 13:43 |
| sean-k-mooney | if the arch does not supprot it we must reject teh boot request | 13:43 |
| sean-k-mooney | ricolin: this should not actully get that far really | 13:44 |
| sean-k-mooney | the reason is that on those plathform we will not be reporting the traits | 13:44 |
| sean-k-mooney | so we shoudl not get as far as generating the xml | 13:44 |
| sean-k-mooney | but the current logic is incorrect we shoudl be raising an error if for some reason we are on a ppc64 host and we manage to get to this point in the virt driver | 13:45 |
| sean-k-mooney | ricolin: the contract that nova provides is if you ask for a feature we will either fail to find a host that can provide that and set the instnace to error or we will boot a vm with that feature enabled | 13:48 |
| sean-k-mooney | ricolin: so for this feature you need to provide that same guarentee | 13:48 |
| *** dasm|off is now known as dasm|ruck | 13:48 | |
| ricolin | okay | 13:49 |
| ricolin | I will add that error | 13:49 |
| ricolin | you think on the libvirt driver works, or you're thinking elsewhere? | 13:49 |
| ricolin | I mean place to add that check and raise error | 13:49 |
| sean-k-mooney | so you shoudl raise the error in the libvirt driver | 13:50 |
| sean-k-mooney | but in https://review.opendev.org/c/openstack/nova/+/844507/5 | 13:50 |
| sean-k-mooney | you shoudl only report the iommu traits if you are on arm or x86 | 13:50 |
| sean-k-mooney | that will prevent the libvirt hosts form being select if its say ppc64 or mips | 13:51 |
| sean-k-mooney | so https://review.opendev.org/c/openstack/nova/+/844507/5/nova/virt/libvirt/driver.py#12102 need to check the architechtre. | 13:51 |
| ricolin | got it | 13:54 |
| ricolin | thanks sean-k-mooney | 13:54 |
| gibi | sean-k-mooney: about the owner trait in the pci series. I can propose a standard trait for sure. I'm wondering if this will be really a compute capability traits as those are added to the root RP. I more thought about an RP type trait, expressing that this is a PCI RP. | 14:11 |
| opendevreview | Balazs Gibizer proposed openstack/os-traits master: Add HW_PCI_DEVICE trait https://review.opendev.org/c/openstack/os-traits/+/850538 | 14:56 |
| gibi | sean-k-mooney: I can go with the combination of ^^ and OWNER_NOVA | 14:56 |
| gibi | that will express what I need | 14:57 |
| gibi | later if we need a capability trait for scheduling then I will add one too | 14:57 |
| sean-k-mooney | it does not really feel like a HW trait to me | 14:57 |
| sean-k-mooney | more COMPUTE but i prefer HW over CUSTOM_ | 14:58 |
| sean-k-mooney | gibi: its not an atirbute of the hardware its an atibute of the compute serivce | 14:58 |
| sean-k-mooney | and its ablity to track pci device in this case via placment | 14:58 |
| sean-k-mooney | if it was a properly of a specific pci device it woudl go under HW | 14:58 |
| sean-k-mooney | is there a particalr reason you went with HW? | 14:59 |
| gibi | I think we are still after two different things. You want to indicate that the compute can track PCI in Placement. I want to indicate that a specific RP represents a PCI device managed by Nova | 14:59 |
| gibi | for the former I agree that is a compute capability trait | 14:59 |
| sean-k-mooney | rigth but the later is not an atribute of the RP | 15:00 |
| sean-k-mooney | its an atribute of the resouce clase tracked by one fo the inventires | 15:00 |
| gibi | lets continue after the meeting... | 15:00 |
| sean-k-mooney | sure | 15:00 |
| gibi | I think I go your point. this is not a hw feature so the trait should not be under HW | 15:58 |
| gibi | I will move it under COMPUTE | 15:58 |
| opendevreview | Balazs Gibizer proposed openstack/os-traits master: Add COMPUTE_MANAGED_PCI_DEVICE trait https://review.opendev.org/c/openstack/os-traits/+/850538 | 16:13 |
| gibi | sean-k-mooney: moved ^^ | 16:13 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | 16:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | 16:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | 16:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | 16:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | 16:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | 16:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | 16:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | 16:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | 16:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Move provider_tree RP creation to PciResourceProvider https://review.opendev.org/c/openstack/nova/+/850546 | 16:52 |
| *** akekane_ is now known as abhishekk | 17:09 | |
| opendevreview | sean mooney proposed openstack/nova master: single pass instance info fetch in host manager https://review.opendev.org/c/openstack/nova/+/623558 | 18:10 |
| opendevreview | Amit Uniyal proposed openstack/nova master: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/849104 | 19:29 |
| opendevreview | Rico Lin proposed openstack/nova master: Add locked_memory extra spec and image property https://review.opendev.org/c/openstack/nova/+/778347 | 21:09 |
| opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | 21:09 |
| opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | 21:09 |
| *** dasm|ruck is now known as dasm|off | 23:41 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!