Monday, 2022-07-18

opendevreviewMerged openstack/nova stable/wallaby: Add missing condition  https://review.opendev.org/c/openstack/nova/+/84701104:28
opendevreviewMerged openstack/nova master: Update the file for IPv4-only or IPv6-only network  https://review.opendev.org/c/openstack/nova/+/46589105:00
opendevreviewMerged openstack/nova master: etc: Highlight absence of packages from config gen  https://review.opendev.org/c/openstack/nova/+/84979605:12
opendevreviewMerged openstack/nova stable/victoria: libvirt: make mdev types name attribute be optional  https://review.opendev.org/c/openstack/nova/+/75440107:02
bauzasgood Monday everyone07:16
* bauzas is back from the mountains07:16
sean-k-mooneybauzas: o/07:18
sean-k-mooneyim up too early for me to say if its good yet but i should proably go have coffee and then form an opipion07:19
bauzas:)07:20
* bauzas is looking at his emails but then he'll provide an email for the specs07:20
sean-k-mooneybauzas: we have one that we like the general idea of but wanted more info from the autuhor and were considering giving a freeze exception if they provide that info by the team meeting07:22
bauzassean-k-mooney: I haven't looked yet at the open specs07:23
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova-specs/+/84948807:23
bauzasoh I remember having seen it 07:23
bauzasit was created by July 11...07:23
sean-k-mooneythe rest can all get procedual -2 or abandoned07:24
sean-k-mooneybauzas: its small stephen was even wondering if it shoudl be a specless blueprint before i pointed out they had a spec07:24
sean-k-mooneybauzas: did you enjoy you time in th emountains07:25
bauzassean-k-mooney: oh yes :) https://twitter.com/matthewdbooth/status/154725210917908070507:27
sean-k-mooney:)07:27
gibigood morning08:04
sean-k-mooneyo/08:11
sean-k-mooneybauzas: i reviewed https://review.opendev.org/c/openstack/nova/+/849133 while you were away id allowing space intentional? over all i think this looks good as is08:12
bauzassean-k-mooney: excellent catch08:13
bauzasthis part was just rebased from the previous effort 08:13
bauzasI need to reconsider this08:13
sean-k-mooneyit proably ok to allow space08:13
bauzaseither way, I also need to rebase my work on Uggla's unshelve-to-host API part08:14
sean-k-mooneyi jsut would not personally use it08:14
bauzassean-k-mooney: honestly, I need to consider the RFC08:14
sean-k-mooneyok no rush08:14
sean-k-mooneyso are we agreeing on merging the unshelve-to-host change first08:15
bauzasin theory, keynames are quite well defined as being the user@machine08:15
sean-k-mooneyto not have a microverion conflict08:15
bauzassean-k-mooney: yeah, I was about to propose an etherpad tomorrow at the nova meeting08:15
sean-k-mooneyok cool08:15
bauzasto identify quite a sequence of API changes08:15
Ugglabauzas, fyi I'm trying to fix what I have broken in my local virtiofs patches, then I will review the unshelve comments from gibi and yours.08:19
gibiUggla: ack08:19
bauzasUggla: np, I'd like to test some crazy thing, being to use the 2.92 microversion *without* rebasing on your series08:22
sean-k-mooneygibi: quick question you have a rather nice doc on ports with resocue request in the admin section08:37
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/doc/source/admin/ports-with-resource-requests.rst08:37
sean-k-mooneyi was goign to add a similar doc to the reference section orgianlly for vdpa but now im reconsidering08:38
sean-k-mooneydo you think the admin section would be better08:38
sean-k-mooneyi think it proably is since admin sepam sotb be where we have vgpu and sev ectra08:39
sean-k-mooneyi should proably cross link it form https://github.com/openstack/nova/blob/master/doc/source/admin/networking.rst too08:40
gibiit feels more like an adminy thing08:40
gibi+1 on crosslinking08:41
sean-k-mooneyok ill go work on that so. i think the first vdpa patch is basically ready to merge but stephen raise a good point about docs so im goign to work on that now and then push a new version08:41
gibiack08:50
bauzasok, yoga open specs abandoned09:37
bauzasas I said in my email, I won't -2 yet https://review.opendev.org/c/openstack/nova-specs/+/849488 until next meeting09:38
bauzasand I appreciate reviews of https://review.opendev.org/c/openstack/nova-specs/+/84201509:39
UgglaCould someone help me in the beginning of the afternoon. I have issues with 3 unit tests but can not figure out why.09:48
sean-k-mooneyproably have you posted the failing patch for review or the output of the tox results somewhere09:49
Ugglasean-k-mooney, not yet09:53
Ugglasean-k-mooney, doing it right now09:53
Ugglasean-k-mooney, this is the tests issues: https://paste.openstack.org/show/bkFrl9uor71V8QBjPcF1/09:54
Ugglasean-k-mooney, code is here: https://github.com/uggla/nova/tree/bp/manila_shares_attachments09:55
UgglaIt seems something is wrong with the placement API.09:57
sean-k-mooneythose dont sound like they shoudl be related to your patches10:07
sean-k-mooneyyou might want to rebase your patches to the tip of master and see if they go away10:07
gibiyepp the schema validation error might be related to the recent bump on jsonschema 10:08
gibiand that is fixed on master10:08
sean-k-mooneyrecent as in merged on friday i think10:09
Ugglasean-k-mooney, I think about it and rebase. But it is still present.10:16
sean-k-mooneytry add -r 10:18
sean-k-mooneyto have tox recreate teh venv10:19
sean-k-mooneyill try running it myself with master shortly10:19
sean-k-mooneyjust getting something to drink10:19
gibiUggla: I pulled your branch but the unit tests, you see failing, are passing for me locally10:43
gibi(I added the os_trats change manually to the venv)10:45
sean-k-mooneydoing the same currently10:49
sean-k-mooney======10:51
sean-k-mooneyTotals10:51
sean-k-mooney======10:51
sean-k-mooneyRan: 16546 tests in 76.0306 sec.10:51
sean-k-mooney - Passed: 1648710:51
sean-k-mooney - Skipped: 5810:51
sean-k-mooney - Expected Fail: 110:51
sean-k-mooney - Unexpected Success: 010:51
sean-k-mooney - Failed: 010:51
sean-k-mooneySum of execute time for each test: 3190.1976 sec.10:51
sean-k-mooneyso ya with clean envs if i install the os-traits repo into the env10:51
sean-k-mooneythen it seams to work fine10:51
sean-k-mooneyat least on ubuntu 22.0410:52
sean-k-mooneyUggla: if that is the only issue you have and you have fixed up any other patch comments i would push it and see if the ci complains10:52
sean-k-mooneysfinucan: can you swap the order of the first two patches https://review.opendev.org/c/openstack/nova/+/850006/111:27
sean-k-mooneythe dataclasses dep seams to be causing issues on the first patch11:27
sfinucansure11:29
opendevreviewStephen Finucane proposed openstack/nova master: Remove unused requirement  https://review.opendev.org/c/openstack/nova/+/85000611:30
opendevreviewStephen Finucane proposed openstack/nova master: Fix compatibility with jsonschema 4.x  https://review.opendev.org/c/openstack/nova/+/84986711:30
opendevreviewStephen Finucane proposed openstack/nova master: Bump jsonschema minimum to 4.0.0  https://review.opendev.org/c/openstack/nova/+/85002111:30
sfinucansean-k-mooney: done11:30
sean-k-mooneythanks11:30
*** sfinucan is now known as stephenfin11:30
sean-k-mooneyill read my +2 to those11:30
sean-k-mooney*readd11:31
sean-k-mooneystephenfin: can you weigh in on https://review.opendev.org/c/openstack/os-traits/+/844336/1/os_traits/compute/viommu.py#24 by the way11:32
sean-k-mooneydo we need an auto trait? it might be nice but im not sure we do11:32
sean-k-mooneyit would simplfy the prefileter so im inclined ot leave it but drop none11:33
opendevreviewMerged openstack/os-traits master: Add 'COMPUTE_STORAGE_VIRTIO_FS', 'COMPUTE_MEM_BACKING_FILE'  https://review.opendev.org/c/openstack/os-traits/+/83276911:38
sean-k-mooneyUggla: ill propose  a release of os-traits later this week there is one other patch i want to land11:40
sean-k-mooneybut that will allow you to use it form pypi once we have done the release and unblock the nova series form merging.11:41
sean-k-mooneywell its still WIP but more it will unblock the unit/functional tests form passign in the gate11:43
Ugglasean-k-mooney, cool thx11:43
opendevreviewsean mooney proposed openstack/nova master: enable blocked VDPA move operations  https://review.opendev.org/c/openstack/nova/+/83233011:46
opendevreviewsean mooney proposed openstack/nova master: enable blocked VDPA move operations  https://review.opendev.org/c/openstack/nova/+/83233011:51
opendevreviewBalazs Gibizer proposed openstack/nova master: Gracefully ERROR in _init_instance if vnic_type changed  https://review.opendev.org/c/openstack/nova/+/85000311:56
opendevreviewBalazs Gibizer proposed openstack/nova master: Gracefully ERROR in _init_instance if vnic_type changed  https://review.opendev.org/c/openstack/nova/+/85000311:58
opendevreviewBalazs Gibizer proposed openstack/nova master: Move uwsgi-gmr reno to the proper place  https://review.opendev.org/c/openstack/nova/+/85015212:01
Ugglagibi, just get a new fresh repo from my code and still having the unit tests failing.... becoming crazy...12:22
sean-k-mooneywhat version of python are you using and what os12:23
Uggla3.10.512:23
UgglaFedora 3612:23
sean-k-mooneyi see well that could be the issue12:23
sean-k-mooney3.10 support is experimental12:24
sean-k-mooneyill see if i get the same issue with 3.1012:24
sean-k-mooneyoh hum12:24
sean-k-mooneyi was using 3.10.412:24
Ugglabut within tox 3.9 is used no ?12:24
sean-k-mooneyonly if you run tox -e py3912:25
sean-k-mooneyi ran with 3.10.4 so its not 3.1012:25
Ugglayep this is what I run.12:26
sean-k-mooneywell this seams to work on ubuntu so it might be a fedora dep issue12:26
sean-k-mooneyalthough im not sure what would cause that to fail12:26
Ugglasean-k-mooney, it seems it happened to me on Friday after a rebase to split patches... I thought I did something wrong...12:30
fungisean-k-mooney: did you see my question on https://launchpad.net/bugs/1981813 (just trying to confirm the bug type change was intentional before i add an ossa bugtask)?13:07
opendevreviewManuel Bentele proposed openstack/nova-specs master: Add configuration options to set SPICE compression settings  https://review.opendev.org/c/openstack/nova-specs/+/84948813:10
opendevreviewManuel Bentele proposed openstack/nova master: libvirt: Add configuration options to set SPICE compression settings  https://review.opendev.org/c/openstack/nova/+/82867513:12
*** dasm|off is now known as dasm|ruck13:43
bauzasdang.14:28
bauzashttps://blueprints.launchpad.net/nova/+spec/configurable-instance-domains from https://specs.openstack.org/openstack/nova-specs/specs/zed/approved/configurable-instance-domains.html is giving me HTTP40414:28
bauzaslooks like artom forgot to create it14:28
bauzasalso, I'm a bit surprised we merged a spec within one day for an instance modification, but OK14:29
sean-k-mooneyoh well thats an easy fix at least14:29
sean-k-mooneyit was basically the same change we did for hostname 2 cyles ago14:30
sean-k-mooneyso that is not really contovial at least in my view14:30
sean-k-mooneywe proably should have added both orginally14:30
bauzasmmmm14:31
bauzaswe'll see whether it would be a problem later14:31
sean-k-mooneyif you think there is a design issue we can revert the spec.14:33
sean-k-mooneyare you worried we missed something specific14:33
bauzaswell14:36
bauzasI'm afraid it's about a large table 14:36
bauzaswithin also a cells v2 DB14:37
bauzasso we need to make sure the upgrade will work for large operators having a lot of instances and cells14:37
sean-k-mooneywe had the option to not do a db migration and store it in the instance_system_metadtaa14:37
sean-k-mooneystephenfin: at least seam to prefer treating it like a first class porperty on the instance object and therefor storing it in the instance table14:38
sean-k-mooneyso we can revsit that but we should be abel to make additive changes to the db14:39
sean-k-mooneybauzas: stephenfin  was suggesting this si a good way to test the new alembic migration flow as its relitivly low risk14:40
bauzasfortunately, we don't need to modify the data14:40
sean-k-mooneyright it just a new nullable column14:40
bauzasbut yeah, we need to explain the operators that it would be an ALTER for the instances table 14:41
bauzasalso, making sure we also add it to the shadow table14:41
sean-k-mooneyis the release note not sufficent for that14:41
bauzasit will I guess14:42
bauzassean-k-mooney: I don't see the default policy for seeing the domain attribute value and putting it14:43
bauzassean-k-mooney: I guess this is enduser ?14:43
bauzasalso, we'll change the notification, as you said, so we need to modify the spec to no longer say "none" to notifications impact14:45
sean-k-mooneyit woudl admin_or_opwner14:45
sean-k-mooneythe same as hostname14:45
sean-k-mooneyor project_member in the new RBAC schem for update and project_reader for viewing14:46
sean-k-mooneywe can capture this extra detail in a follow up patch 14:46
sean-k-mooneycan you leave that feedback for atrom on the patch 14:47
dansmithoh are we talking about the domain spec?14:48
sean-k-mooneyyes14:48
dansmithsubmitted and merged in less than 24 hours.. that was not cool, IMHO14:48
gibiI take the blame14:49
gibiI was under the impression that it is verry similar to what we already did 14:49
gibiabout the hostname14:49
sean-k-mooneyit is but the question i really have are there outstanding questions that needed to be adressed14:49
dansmithyeah, but that's not a good (enough) excuse :)14:49
sean-k-mooneyi did not think there were14:50
gibidansmith: I see now14:50
sean-k-mooneybut if there are as i mentioned above we can revert or adress in a followup14:50
dansmithI've put some general and specific concerns in there14:50
sean-k-mooneydo we dissagre directionally on the change14:50
dansmithtechnically the process is to fast revert when there wasn't time for feedback14:50
dansmithI know there's a deadline at hand, but still...14:51
sean-k-mooneyack well we can follow the spec freeze excpetion process14:51
sean-k-mooneywhich is ask for exception in team meeting and then basicaly have till end of week or next meeting to agree or punt14:51
sean-k-mooneyhum artom does not apper to be on upstream or downstream irc but ill ping them when they are about to readback and review the spec14:54
gibiartom is on PTO this week14:55
sean-k-mooneybauzas: dansmith  do either of ye want to propose the revert patch14:55
sean-k-mooneyoh14:55
sean-k-mooneyok14:55
dansmith>:(14:55
sean-k-mooneywell in that case i can proably recuse myself form the spec review and take it over  and adress the feedback14:55
sean-k-mooneyif the rest of ye feel ok with reviewing it14:55
gibisean-k-mooney: works for me14:56
sean-k-mooneyor we punt it to next cycle14:56
bauzasI don't know what to say14:58
bauzasthe blueprint isn't created yet14:58
bauzasso technically even if the spec is merged, we don't track its progress14:58
bauzasnow, about the spec14:59
bauzasI have a few left comments14:59
sean-k-mooneyya sorry i tought we had a check in the ci that the url existied but i guess not i didnt think to check that manually14:59
bauzasmy concern being the discrepancy between neutron's dns_domain and nova's domain and how we reconcile them14:59
sean-k-mooneywell there isnnt a depency here15:00
sean-k-mooneywe optionally can set the port dns_domain if the extension extis for port that are create by nova15:00
bauzasanyway, we have to join some internal meeting15:00
gibiI fixed the missing bp for you :) https://blueprints.launchpad.net/nova/+spec/configurable-instance-domains15:00
sean-k-mooneybut nova had no dep no neutron to consime that value in teh current version15:01
sean-k-mooneyif that is not clear then we should capture that in the spec15:01
bauzascan anyone tell me why https://review.opendev.org/c/openstack/nova/+/828675/ shows tempest-integrated-compute-centos-9-stream job being run on check pipeline while https://review.opendev.org/c/openstack/nova/+/849463/1/.zuul.yaml was merged ?15:18
bauzasI suspect because of default project config in zuul ?15:18
sean-k-mooneyit might be due to needing a rebase15:20
sean-k-mooneyill take a look after our downstream call15:20
kashyapIs anyone else seeing these RETRY_LIMIT failures on stable/wallaby? - https://zuul.opendev.org/t/openstack/build/8f8a3dab99fa41c9ac30efaf6f3a21e015:20
kashyapIt looks like it's failing due to failing access to some of the Ubuntu repos15:21
melwittbauzas: gentle reminder about this patch that is proposing to change a piece of logic in the 'nova-manage placement audit' command https://review.opendev.org/c/openstack/nova/+/84441815:45
bauzassean-k-mooney: c9s job runs b/c of tempest https://opendev.org/openstack/tempest/src/branch/master/zuul.d/integrated-gate.yaml#L38715:46
bauzasso we need to keep the non-voting flag 15:47
sean-k-mooney or we remove that template15:47
bauzasexplicitely in our .zuul 15:47
sean-k-mooneyand add the jobs manually15:47
sean-k-mooneywell better lets update that template15:48
sean-k-mooneywe can move it to the periodic-weekly pipelien in that template15:48
bauzassean-k-mooney: do you feel brave enough to propose a patch against it ?15:48
bauzasI feel my time is short those weeks15:49
sean-k-mooneysure i can do it15:49
* sean-k-mooney has been sucesffully nerd sniped by bauzas :)15:50
bauzas:)15:50
sean-k-mooneybauzas: https://review.opendev.org/c/openstack/tempest/+/85024216:06
bauzas+16:07
bauzas+1d16:07
*** akekane_ is now known as abhishekk16:41
stephenfinmelwitt: Care to +2 this? https://review.opendev.org/c/openstack/nova/+/850006/ Hopefully I've addressed you query16:45
stephenfin*your16:46
sean-k-mooneybauzas: dansmith https://review.opendev.org/c/openstack/nova-specs/+/849765/comments/83b8b648_d024291817:08
sean-k-mooneydoes that ^ work for ye if so bauzas ping me when the revert is proposed and ill ack it and draft a updated version of the spec 17:09
sean-k-mooneywith that said it 31C and 45% humitity outside and my office is warmer so im going to call it a day17:10
opendevreviewSylvain Bauza proposed openstack/nova master: api: Drop generating a keypair and add special chars to naming  https://review.opendev.org/c/openstack/nova/+/84913317:11
bauzassean-k-mooney: gibi: Uggla: fwiw, I just uploaded a v2.92 API change without rebasing from Uggla so please hold your +W17:12
bauzasbut it looks like we easily accept it 17:12
bauzaswithout having a 2.9117:12
bauzasI'll create another branch locally from Uggla's series and I'll see whether I get a merge conflict17:13
sean-k-mooneyack care to put a -w on it until then17:19
sean-k-mooneyi likely wont have time to review it again until tommorw anyway17:19
sean-k-mooneyjust going to go get dinner shortly17:19
melwittstephenfin: oh, yup, thanks for explaining that17:19
bauzasI resolved the conflicts easily17:21
melwittbah, no Aardvark >:(  https://lists.openstack.org/pipermail/openstack-discuss/2022-July/029608.html17:47
dansmithyeah :(17:48
sean-k-mooneyAnteater is closeest17:48
dansmithdid I miss them looking for suggestions or did they just decide on a few options to vote on?17:50
sean-k-mooneyi dont recally it coming up but also didnt look for it specifically17:50
sean-k-mooneyso i assume the latter17:50
bauzasapart from Antelope, don't know the other options meanings.18:04
bauzasthis cycle, looks like the names are more misunderstandable than the other times18:05
bauzasWallaby, Xena, Yoga, Zed, all of those were meaningful for a non-native speaker18:06
sean-k-mooneyXena is the best warrior princess :)18:06
bauzasthat's also why I thought geonamings were better18:07
bauzasexcept rare situations, in general those were understandable by anyone18:07
sean-k-mooneytrain choo choo18:07
bauzasso we have to pick between 3 animals? ok18:09
* bauzas wonders how many people will appreciate Anchovy and then Beetle if we go this way18:10
melwittew, hope not Beetle18:10
sean-k-mooneywe shoudl go with pizza toppings18:11
melwittBear18:11
sean-k-mooneyand then wait for the flame ware wehn we get to pineapple18:11
bauzassean-k-mooney: love the idea18:11
melwittthat would be pretty funny18:11
bauzasbut before Pineapple, people would have to be convinced Oyster can be a good name18:12
sean-k-mooneypepperoni vs pineapple18:12
sean-k-mooneyi can see the devisions formaing already18:12
bauzasbon appetit https://oyster-obsession.com/category/oyster-recipes/oyster-pizza-recipes/18:13
melwitt😂 18:13
sean-k-mooneyi have heard worse ideas18:14
bauzasfor B, easy peasy : Blue cheese18:14
sean-k-mooneysee worse idea  ^ for pizza toping then oysters 18:16
bauzasoysters and blue cheese always match18:18
sean-k-mooneymy home town makes blue chseese its even somewhat famous but i never really liked blue cheese18:25
sean-k-mooneyhttps://en.wikipedia.org/wiki/J%26L_Grubb18:26
opendevreviewMerged openstack/nova master: Remove unused requirement  https://review.opendev.org/c/openstack/nova/+/85000618:59
colby_bauzas: I worked with sean-k-mooney last week on our vgpu issue. I created a bug: https://bugs.launchpad.net/nova/+bug/1981631. Im happy to provide any info needed. I did some debugging by logging variables and its definitely trying to use a new resource_provider(pci address) instead of one of the ones already created19:07
opendevreviewMerged openstack/nova master: Fix compatibility with jsonschema 4.x  https://review.opendev.org/c/openstack/nova/+/84986719:19
spatelis devstack support centos-8 stream? 19:40
*** tosky_ is now known as tosky19:45
*** dasm|ruck is now known as dasm|off21:27

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!