| opendevreview | Artom Lifshitz proposed openstack/nova-specs master: Configurable instance domains https://review.opendev.org/c/openstack/nova-specs/+/849765 | 00:26 |
|---|---|---|
| auniyal | O/ | 07:38 |
| auniyal | tox -e <test> don't always runs same | 07:38 |
| auniyal | tox -re functional-py38 -- regressions.test_bug_1857306.py | 07:38 |
| auniyal | The specified regex doesn't match with anythingERROR: InvocationError for command /opt/stack/nova/.tox/functional-py38/bin/stestr --test-path=./nova/tests/functional run regressions.test_bug_1857306.py (exited with code 1) | 07:38 |
| auniyal | sometime -re works to recreate testing venv, but not always | 07:39 |
| auniyal | tried giving full path as well - nova.tests.functional.regressions.test_bug_1857306.py | 07:41 |
| gibi | auniyal: you don't need the '--' also you should try without the '.py' suffix | 07:45 |
| auniyal | oh yes, removed .py and -- it ran, thanks gibi | 07:48 |
| gibi | the name you give at the end of the tox command is actually a regex matching for the fully qualified name of the test function | 07:49 |
| sean-k-mooney[m] | there is a flag you can pass to use file paths i think | 08:29 |
| sean-k-mooney[m] | but ya by default its a regex of the fully qualified function/module name | 08:29 |
| opendevreview | Stephen Finucane proposed openstack/nova master: etc: Highlight absence of packages from config gen https://review.opendev.org/c/openstack/nova/+/849796 | 08:55 |
| *** efried1 is now known as efried | 09:09 | |
| opendevreview | Manuel Bentele proposed openstack/nova master: libvirt: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova/+/828675 | 12:08 |
| sean-k-mooney | gibi: if your about i think this is a fairly simple spec https://review.opendev.org/c/openstack/nova-specs/+/849488 related to ^ | 12:09 |
| stephenfin | sean-k-mooney: gibi: specless BP? https://review.opendev.org/c/openstack/nova/+/828675 | 12:20 |
| stephenfin | see my comment in there. Personally I'd rather turn on sensible defaults and leave it at that, but perhaps Manuel has a good reason for why we can't do that | 12:21 |
| * stephenfin hates unnecessary knobs and dials | 12:21 | |
| stephenfin | s/hates/dislikes/ | 12:23 |
| sean-k-mooney | stephenfin: they have a spec proposed and it looked good to me so specless or approve the one they have | 12:24 |
| sean-k-mooney | stephenfin: apprently the compression algortiom depends on teh buidl of spice used | 12:24 |
| sean-k-mooney | them mentioned that in the spec comment | 12:25 |
| stephenfin | Oh, nice. I hadn't seen that | 12:25 |
| * stephenfin looks | 12:25 | |
| sean-k-mooney | if there are default that work for most/everyone im also ok to implemnt those and review that in the code patch | 12:25 |
| sean-k-mooney | ah they have auto for most of them as a default | 12:26 |
| sean-k-mooney | cool | 12:26 |
| * sean-k-mooney is sad we are removing spice downstream because its much better for vdi | 12:27 | |
| stephenfin | agreed :( | 12:31 |
| stephenfin | oh well | 12:31 |
| stephenfin | left comments on the spec | 12:31 |
| stephenfin | ...too | 12:31 |
| sean-k-mooney | when you say enable by default | 12:32 |
| sean-k-mooney | its really only enabled by "default" if there is a way to enable something else | 12:32 |
| sean-k-mooney | are you suggesting we hardcode something | 12:32 |
| sean-k-mooney | since i think they had a sane default for basially all the config optiosn | 12:33 |
| stephenfin | sean-k-mooney: Yeah, basically hardcode the defaults they've proposed and don't bother with the knobs | 12:35 |
| stephenfin | unless we have a good reason to add them (e.g. someone would have a good reason to disable that compression) | 12:35 |
| sean-k-mooney | im not really that pushed eitehr way. i assume there is a tradeoff between bandwith and cpu | 12:36 |
| sean-k-mooney | as there almost always is for compression | 12:36 |
| sean-k-mooney | so it might be somthign that an operator wants to optimise for differently depenidn on there usecase | 12:36 |
| sean-k-mooney | stephenfin: https://review.opendev.org/c/openstack/nova-specs/+/849488/3/specs/zed/approved/spice-compression-support.rst#114 | 12:38 |
| sean-k-mooney | libvirt apprently has default for this too and that is what they are using | 12:38 |
| sean-k-mooney | as the defalt so hardcoding what they propsoed would be the same as doing nothing | 12:38 |
| stephenfin | hmm, it looks like libvirt's defaults are pretty sane, no? | 12:39 |
| stephenfin | I wonder why they're not good enough | 12:39 |
| sean-k-mooney | again i would guess this comes done to wanting to optimise for wan vs lan vs edge vdi deployments | 12:40 |
| sean-k-mooney | in some cases bandwith might be the costly case in other cpu | 12:40 |
| sean-k-mooney | im really not stongly opionated on this but that is what i was assuming when reviewing | 12:41 |
| stephenfin | Okay, makes sense. I suspect adding these knobs is the correct decision in that case. I'll just wait for Manuel to pipe up and defend themselves :) | 12:41 |
| sean-k-mooney | ack | 12:41 |
| stephenfin | If nothing else, we'll get better docs on the advantages/disadvantages of configuring these things | 12:41 |
| sean-k-mooney | stephenfin: by the way artom copy pasted your --hostname spec to add --domain and im mostly ok with it but care to have a look at https://review.opendev.org/c/openstack/nova-specs/+/849765 | 12:42 |
| * stephenfin prepares plagiarism suit | 12:43 | |
| sean-k-mooney | this is related to the whole fqdn in displayname mess | 12:43 |
| stephenfin | reviewed | 12:53 |
| stephenfin | actually, let me have a look through some of the other specs. I missed the spec review day | 12:53 |
| *** dasm|off is now known as dasm | 12:53 | |
| * gibi reads back | 12:58 | |
| gibi | I have no hard opinion about spice compression. I agree with you to see if we really need this. But if there is a solid use case then I'm OK with having this. | 13:01 |
| gibi | for a spec we are a bit late but I think if this is close then bauzas will not be against landing it next week | 13:02 |
| sean-k-mooney | so we just want to defer the details fo the config options to the code review | 13:03 |
| sean-k-mooney | *do we | 13:04 |
| gibi | If I understand correctly the current default is sane and if we decide not to add knobs then there is nothing to implement. So I think this needs to be decided before the codereview | 13:09 |
| sean-k-mooney | ack that is my understanidng too | 13:10 |
| gibi | so hope Manuel can come back this week or early next week | 13:10 |
| sean-k-mooney | i assuem they wanted to make this change because they had limitation with the current defaults but those are not captured in teh spec | 13:10 |
| gibi | yeah, and if they have then I think we will not block them to add the knob | 13:11 |
| gibi | we just need to know those limitations :) | 13:11 |
| sean-k-mooney | for something this small i would be supportive of a spec freeze excption | 13:11 |
| sean-k-mooney | if they can document why they need this feature next week | 13:11 |
| gibi | I will be supporting for the exception too | 13:12 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | 13:20 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311 | 13:20 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380 | 13:20 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | 13:20 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704 | 13:20 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs https://review.opendev.org/c/openstack/nova/+/768509 | 13:20 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/768852 | 13:20 |
| artom | stephenfin, your proposed changes section as just *so* well written ;) | 13:30 |
| artom | Thanks for the reviews, I'll push a new rev soon | 13:31 |
| opendevreview | Artom Lifshitz proposed openstack/nova-specs master: Configurable instance domains https://review.opendev.org/c/openstack/nova-specs/+/849765 | 14:00 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Replace tenant_id with project_id in os-quota-sets path https://review.opendev.org/c/openstack/nova/+/768851 | 14:09 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Replace tenant_id with project_id in Limits API https://review.opendev.org/c/openstack/nova/+/768862 | 14:09 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Replace tenants* with projects* of policies https://review.opendev.org/c/openstack/nova/+/765315 | 14:09 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Replace tenant* with project* in codes https://review.opendev.org/c/openstack/nova/+/769329 | 14:09 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Remove use of pkg_resources https://review.opendev.org/c/openstack/nova/+/740661 | 14:45 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Fix compatibility with jsonschema 4.x https://review.opendev.org/c/openstack/nova/+/849867 | 14:45 |
| stephenfin | gibi: sean-k-mooney: trivial changes there to fix jsonschema 4.x compat and make nova _slightly_ faster by avoiding use of pkg_resources (which is slooooow) ^ | 14:48 |
| gibi | stephenfin: I will check it | 14:49 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: libvirt: remove default cputune shares value https://review.opendev.org/c/openstack/nova/+/824048 | 15:55 |
| opendevreview | Dmitry Tantsur proposed openstack/nova master: Add a proper schema version to network_data.json https://review.opendev.org/c/openstack/nova/+/849881 | 16:00 |
| artom | sean-k-mooney, stephenfin, any chance we can finalize the domain spec before EOD? | 17:09 |
| sean-k-mooney | ill take a look at it again shortly so yes? | 17:40 |
| artom | \o/ | 17:40 |
| *** dasm is now known as Guest5013 | 17:59 | |
| *** Guest5013 is now known as dasm | 18:01 | |
| opendevreview | Artom Lifshitz proposed openstack/nova-specs master: Configurable instance domains https://review.opendev.org/c/openstack/nova-specs/+/849765 | 18:07 |
| sean-k-mooney | artom: +2 on ^ stephenfin melwitt gibi incase ye are still about | 18:15 |
| sean-k-mooney | artom: on other commit is something we add examples of the updatead api payload or psudo api requests | 18:15 |
| sean-k-mooney | in this case i dont think you need to do that | 18:16 |
| artom | Which other commit? | 18:16 |
| artom | Oh, if I respin this spec? | 18:16 |
| sean-k-mooney | sorry other specs | 18:16 |
| artom | stephenfin didn't do it, and this is just plagiarizing his domain spec ;) | 18:16 |
| sean-k-mooney | so somethinmes we add example post/put payloads | 18:16 |
| sean-k-mooney | but i think thats overkill for a this | 18:17 |
| sean-k-mooney | /domin/hostname | 18:17 |
| sean-k-mooney | i.e his spec was hostname yours is domain | 18:17 |
| sean-k-mooney | anyway i didnt see anything worth another respin but im happy to rereview if others do | 18:18 |
| opendevreview | Merged openstack/nova master: Remove use of pkg_resources https://review.opendev.org/c/openstack/nova/+/740661 | 18:22 |
| gibi | sean-k-mooney, artom: I'm +2+Ad the domain spec | 18:22 |
| artom | That was fast | 18:22 |
| gibi | I read fast :) | 18:22 |
| sean-k-mooney | and the content was familar :P | 18:23 |
| gibi | yeah | 18:23 |
| artom | Yeah, it's not like we kept rehashing it every second tech call for the past 4 months | 18:23 |
| artom | Oh wiat | 18:23 |
| gibi | I could swear I read this before somewher | 18:23 |
| gibi | e | 18:23 |
| sean-k-mooney | artom: implementaiton wil be ready by tueseday yes | 18:24 |
| artom | https://i.imgflip.com/6ms8wt.jpg | 18:24 |
| gibi | artom: so will you abandon https://review.opendev.org/c/openstack/nova-specs/+/840974 ? | 18:25 |
| sean-k-mooney | its not mutually exclucive but i would at least punt it to AA | 18:25 |
| artom | Done | 18:25 |
| sean-k-mooney | cool | 18:25 |
| artom | It's not mutually exclusive, but there isn't much point to it | 18:25 |
| artom | Like, what would use those per-NIC domain fields? | 18:26 |
| artom | If we care about cloud-init, then it's only --domain | 18:26 |
| sean-k-mooney | well linux support FQDNs per interface | 18:26 |
| sean-k-mooney | so technially you chould have a script that called systemd-resolved to configure that or network manager | 18:27 |
| sean-k-mooney | but its nice ot have rather then required | 18:27 |
| sean-k-mooney | so for now lets focus on --domain | 18:27 |
| sean-k-mooney | and if people ask for the metadata we can add that in AA | 18:27 |
| opendevreview | Ghanshyam proposed openstack/nova master: Keep legacy admin behaviour in new RBAC https://review.opendev.org/c/openstack/nova/+/849209 | 18:28 |
| opendevreview | Merged openstack/nova-specs master: Configurable instance domains https://review.opendev.org/c/openstack/nova-specs/+/849765 | 18:31 |
| opendevreview | Rico Lin proposed openstack/nova master: libvirt: Ignore LibvirtConfigObject kwargs https://review.opendev.org/c/openstack/nova/+/830644 | 20:31 |
| opendevreview | Rico Lin proposed openstack/nova master: libvirt: Remove unnecessary TODO https://review.opendev.org/c/openstack/nova/+/830645 | 20:31 |
| opendevreview | Rico Lin proposed openstack/nova master: add locked_memory extra spec and image property https://review.opendev.org/c/openstack/nova/+/778347 | 20:31 |
| opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | 20:31 |
| opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | 20:31 |
| *** dasm is now known as dasm|off | 21:23 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
