Friday, 2022-06-17

opendevreviewmelanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command  https://review.opendev.org/c/openstack/nova/+/82675203:27
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image  https://review.opendev.org/c/openstack/nova/+/84624603:27
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image  https://review.opendev.org/c/openstack/nova/+/84624604:35
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command  https://review.opendev.org/c/openstack/nova/+/82675204:35
*** elodilles_pto is now known as elodilles06:46
gibibauzas, sean-k-mooney: can we get a second opinion on https://review.opendev.org/c/openstack/nova/+/831507/comment/b9fbbb2c_8e65c98e/ about the possible refactor?07:44
gibiUggla: I don't want to be a heavy handed core but I really don't like the 14 conditionals in the unshelve code07:47
Ugglagibi, hi08:01
gibio/08:02
Ugglagibi, ok i'm gonna change in that way.08:06
gibiUggla: don't rush, I just asked bauzas and sean-k-mooney oppinion about it above08:06
Ugglagibi, I agree that usually having so many conditions is not great.08:07
gibicores: easy win for a +A (doc patch) https://review.opendev.org/c/openstack/placement/+/84573008:18
gibicores: also an easy +A (unit test stabilization) https://review.opendev.org/c/openstack/nova/+/84592208:22
bauzasgibi: sorry was afk due to some appointment08:35
bauzasUggla: will try to do the review today08:35
Ugglabauzas, ok08:40
bauzasfinishing up my GPU patch08:40
bauzasgibi: do you think we could workaround https://bugs.launchpad.net/nova/+bug/1874664 with some flavor extraspec ?08:47
bauzasit's a placement issue08:48
bauzasif you look at the issue, we try to use the same RP https://paste.opendev.org/show/b9A9TdUl1dzTJaNtbrCd/08:48
bauzasfor both allocations08:49
gibibauzas: I will check in a minute09:01
gibibauzas: have you checked that multicreate without vgpu can boot two instance on the same host? (I'm wondering if we do that)09:05
bauzasgibi: good question, I dunno09:08
bauzasgibi: so, my fix I created was using this bug number but I'll then create a separate other 09:09
gibibauzas: I see the limitation09:20
gibibauzas: it is not placement09:20
gibibauzas: in that test placement returns 2 allocation candidate09:20
gibione for each pGPU09:20
gibibut nova only able to consume the first allocation candidate per host09:21
gibibauzas: https://github.com/openstack/nova/blob/93a65f06df67ce39d65827692150c78013c7f6d5/nova/scheduler/manager.py#L382-L38809:21
gibinova only tries to first a_c, for both instance09:22
gibi*tries to claim the first09:22
gibiit succeeds for the first instance but obviously fails for the second09:22
gibithe TODO from jaypipes is valid09:22
gibiif you resolve that TODO then the test_multiple_instance_create_filling_up_capacity test case will be able to boot both instances on the same host09:23
bauzasgibi: looking09:24
bauzasgibi: thanks for finding the RCA09:33
gibiI think we can implement that TODO 09:33
gibiwithout adding to much complexity with sorting 09:33
gibiit would not be optimal but would be better than what we have today09:33
gibiI'm affraid the gate is broken on master09:39
gibihttps://zuul.opendev.org/t/openstack/builds?job_name=tempest-integrated-compute-centos-9-stream&skip=009:39
gibilibvirt.libvirtError: internal error: unable to execute QEMU command 'netdev_add': File descriptor named '(null)' has not been found09:40
bauzasgibi: what a Friday09:49
bauzasCentos 9 Stream /o\09:49
gibibauzas: reported a bug https://bugs.launchpad.net/nova/+bug/1979047 please triage it and set it critical I will drop a mail to the ML09:49
bauzasgibi: we need to make this job non-voting09:50
gibiare we give up on this job? :)09:51
bauzasgibi: the priority is to unblock the gate09:51
bauzaswant me to write it ?09:52
gibiI sent a mail to the ML09:53
bauzasI'll propose the patch at least09:54
bauzaswe're on a Friday09:54
gibibauzas: my philosophy: sure unblock the gate in 2-3 days if nobody found a quick solution. but keep the pain a bit around to motivate people to try and find a solution first :)09:55
bauzasgibi: my philosophy: remove support from something which breaks and you'll suddently find people who care09:55
bauzaseither way, patch is being forged, we need two cores for approving it, so there is no direct impact *yet*09:56
gibiOK, lets go with yours this time :)09:56
gibiI will +2 the non-voting patch 09:56
opendevreviewSylvain Bauza proposed openstack/nova master: zuul: Temporarly put Centos9 Stream job non-voting  https://review.opendev.org/c/openstack/nova/+/84629210:03
bauzasgibi: feel free to add a reply to your email with this patch number10:03
opendevreviewSylvain Bauza proposed openstack/nova master: zuul: Temporarly put Centos9 Stream job non-voting  https://review.opendev.org/c/openstack/nova/+/84629210:04
gibibauzas: thanks +2. done the ML update10:07
gibibauzas: the grenade job on master also look baaaad https://zuul.opendev.org/t/openstack/builds?job_name=nova-grenade-multinode&project=openstack%2Fnova&branch=master&skip=010:17
gibithat seem to be a different error10:18
gibiDetails: {'type': 'SecurityGroupInUse', 'message': 'Security Group 40f249d7-9c4e-432c-91d7-d68ef7ac05b0 in use.', 'detail': ''}10:18
bauzasyup, saw10:18
bauzasdamn10:19
sean-k-mooneyi can take a look at it too i guess10:23
opendevreviewMerged openstack/placement master: Add WA about resource_providers.can_host removal  https://review.opendev.org/c/openstack/placement/+/84573010:23
sean-k-mooneyso i guessl libvirt need to be udated for a new qemu release?10:24
sean-k-mooneyto fix interface attach10:24
sean-k-mooneyor they broke there api compat and we need to adress that10:24
gibisean-k-mooney: I added the libvirt and qemu versions to the bugreport I don't know if any of those are fresh10:25
tkajinamgibi, the bug title reminds me this https://bugzilla.redhat.com/show_bug.cgi?id=209285610:26
gibitkajinam: good find. That very much like it10:27
tkajinamwe pinned libvirt to workaround this in tripleo10:27
sean-k-mooneyya i was about to ping danpb and ask about that bug10:28
gibibauzas: I'm going to open a bug on tempest about the security group issue 10:29
bauzasgibi: cool10:29
gibihttps://bugs.launchpad.net/tempest/+bug/197905210:33
bauzasI need to go off10:35
bauzas(fortunately, wasn't doing gym today)10:36
bauzasbut I have my kid with me so I need to cook :)10:36
gibilet me know what did you cook when you are back10:36
gibiI need inspiration10:36
sean-k-mooneyim considerign firing up my new(ish) BBQ this evening and cookig somethign or at least doing that at the weekend10:45
gibisounds nice :)10:45
sean-k-mooneysince i invested in a "kamado joe big joe 3" i might as well make use of it. i had left over chicken form tha tlast time in the freezer which i had last night. it was pretty tasty10:47
sean-k-mooneyi did a prime rib roast on it before and it was amazing, also did really nice potatos corn and fish10:48
sean-k-mooneyits been 50:50 for bread sofar. the first loaf was nice the second i didnt have the dome heat soaked enouch so it went way to high then too low so the bread did not cook to the center but im pretty happy all in all10:50
gibiI need ribs :)10:51
*** whoami-rajat__ is now known as whoami-rajat11:33
bauzassean-k-mooney: hah, I'm a BBQ lover12:35
bauzaskamados <312:36
bauzasI have a Weber Genesis  2 (gas)  at home with a plancha, so usually, I cook both vegetables and potatoes while the meat is grilling12:37
bauzasin general, sausages as it's French thing12:37
bauzashttps://www.bestfranceforever.com/you-cant-have-a-french-barbecue-without-these-10-ingredients/12:39
bauzas(sorry for the URL name... :)12:39
* bauzas is amazed how the cultures are different between countries when it comes to BBQingf12:41
sean-k-mooneyyep12:47
sean-k-mooneythere is a lot of variation12:47
opendevreviewSylvain Bauza proposed openstack/nova master: Add a functest for verifying multiple VGPU allocations  https://review.opendev.org/c/openstack/nova/+/84574713:27
opendevreviewSylvain Bauza proposed openstack/nova master: Support multiple allocations for vGPUs  https://review.opendev.org/c/openstack/nova/+/84575713:27
Ugglabauzas, looking at your BBQ damned it is connected !13:50
bauzaswell, yes and no13:50
bauzasmy BBQ *can* be connected13:51
bauzasand indeed I use a grill temperature sensor that's connected for my meat cooking13:52
bauzasbut not a weber13:52
Ugglabauzas, meat cooking pro !13:52
bauzasUggla: unfortunately, my middle name isn't Rafa :)13:57
bauzasonly French people looking at YT can understand :)13:58
Ugglabauzas, I don't have the ref...14:01
bauzasUggla: https://www.youtube.com/c/LeBarbecueDeRafa14:01
sean-k-mooneyi went with a ceramic grill basically because i wanted the charcol taste but didnt want to have to worry about tending a fire or unstable temperatures14:02
bauzassean-k-mooney: I have charcoil tasting with my Weber flavorizers tho14:03
sean-k-mooneythat and it can be used for low an slow smokes or you can use it as a pizza oven14:03
bauzassean-k-mooney: and eventually after 15 years of grilling, I gave up playing with charcoil 14:04
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: fake: Ensure need_legacy_block_device_info returns False  https://review.opendev.org/c/openstack/nova/+/84394714:42
*** whoami-rajat__ is now known as whoami-rajat14:43
bauzasgibi: there for a question about https://github.com/openstack/nova/blob/93a65f06df67ce39d65827692150c78013c7f6d5/nova/scheduler/manager.py#L382-L388 ?14:54
bauzasshould hopefully be quick, I want to be on weekend :)14:55
gibisure, hit me14:55
bauzasgibi: so I tested with my functest14:55
bauzaswe return the allocations 14:55
sean-k-mooney do we where?14:56
bauzasgibi: so, I guess we should loop over all the allocations until claim_resources() returns True, right?14:56
gibiright14:56
bauzasok, looks to me simple then14:57
gibiat some point we might want to be smarter than linear looping but the loop is still better than what we have today14:57
gibibauzas: probably it worth adding extra multicreate tests around this case when you add the loop14:58
sean-k-mooneywell for the pci in placment stuff we have introduced a way to filter the list of allocations per hosts14:58
gibisean-k-mooney: yeah that is one smartness14:58
sean-k-mooneyso hopefully its short today and it will be refined in the future14:58
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: fake: Ensure need_legacy_block_device_info returns False  https://review.opendev.org/c/openstack/nova/+/84394714:58
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: Add a regression test for bug 1939545  https://review.opendev.org/c/openstack/nova/+/84394814:58
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: compute: Ensure updates to bdms during pre_live_migration are saved  https://review.opendev.org/c/openstack/nova/+/84394914:58
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: fup: Make connection_info returned by CinderFixture unique per attachment  https://review.opendev.org/c/openstack/nova/+/84459814:58
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: fup: Assert state of connection_info during LM rollback in func tests  https://review.opendev.org/c/openstack/nova/+/84459914:58
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: fake: Ensure need_legacy_block_device_info returns False  https://review.opendev.org/c/openstack/nova/+/84395015:25
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: functional: Use tempdir for CONF.instances_path  https://review.opendev.org/c/openstack/nova/+/84620415:25
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: Add a regression test for bug 1939545  https://review.opendev.org/c/openstack/nova/+/84395115:25
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: compute: Ensure updates to bdms during pre_live_migration are saved  https://review.opendev.org/c/openstack/nova/+/84395215:25
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: fup: Make connection_info returned by CinderFixture unique per attachment  https://review.opendev.org/c/openstack/nova/+/84460615:25
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: fup: Assert state of connection_info during LM rollback in func tests  https://review.opendev.org/c/openstack/nova/+/84460715:25
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: fake: Ensure need_legacy_block_device_info returns False  https://review.opendev.org/c/openstack/nova/+/84395817:18
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: tests: work around malformed serial XML  https://review.opendev.org/c/openstack/nova/+/84474317:18
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: functional: Use tempdir for CONF.instances_path  https://review.opendev.org/c/openstack/nova/+/84475017:18
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: Add a regression test for bug 1939545  https://review.opendev.org/c/openstack/nova/+/84395917:18
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: compute: Ensure updates to bdms during pre_live_migration are saved  https://review.opendev.org/c/openstack/nova/+/84396017:18
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: fup: Make connection_info returned by CinderFixture unique per attachment  https://review.opendev.org/c/openstack/nova/+/84474417:18
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: func: Add live migration rollback volume attachment tests  https://review.opendev.org/c/openstack/nova/+/84474517:18
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: fup: Assert state of connection_info during LM rollback in func tests  https://review.opendev.org/c/openstack/nova/+/84474617:18
opendevreviewBalazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting  https://review.opendev.org/c/openstack/nova/+/84618717:46
opendevreviewBalazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits  https://review.opendev.org/c/openstack/nova/+/84621817:46
opendevreviewBalazs Gibizer proposed openstack/nova master: Reject PCI dependent device config  https://review.opendev.org/c/openstack/nova/+/84643517:46
opendevreviewBalazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config  https://review.opendev.org/c/openstack/nova/+/84643617:46
opendevreviewArtom Lifshitz proposed openstack/nova stable/wallaby: Add a regression test for bug 1939545  https://review.opendev.org/c/openstack/nova/+/84367918:26
opendevreviewArtom Lifshitz proposed openstack/nova stable/wallaby: compute: Ensure updates to bdms during pre_live_migration are saved  https://review.opendev.org/c/openstack/nova/+/84368018:26
opendevreviewArtom Lifshitz proposed openstack/nova stable/wallaby: fup: Make connection_info returned by CinderFixture unique per attachment  https://review.opendev.org/c/openstack/nova/+/84459418:26
opendevreviewArtom Lifshitz proposed openstack/nova stable/wallaby: fup: Assert state of connection_info during LM rollback in func tests  https://review.opendev.org/c/openstack/nova/+/84459518:26
artomgdi I'll the hashes right one day18:26
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: Add a regression test for bug 1939545  https://review.opendev.org/c/openstack/nova/+/84394818:57
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: compute: Ensure updates to bdms during pre_live_migration are saved  https://review.opendev.org/c/openstack/nova/+/84394918:57
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: fup: Make connection_info returned by CinderFixture unique per attachment  https://review.opendev.org/c/openstack/nova/+/84459818:57
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: fup: Assert state of connection_info during LM rollback in func tests  https://review.opendev.org/c/openstack/nova/+/84459918:57
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: Add a regression test for bug 1939545  https://review.opendev.org/c/openstack/nova/+/84395119:03
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: compute: Ensure updates to bdms during pre_live_migration are saved  https://review.opendev.org/c/openstack/nova/+/84395219:03
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: fup: Make connection_info returned by CinderFixture unique per attachment  https://review.opendev.org/c/openstack/nova/+/84460619:03
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: fup: Assert state of connection_info during LM rollback in func tests  https://review.opendev.org/c/openstack/nova/+/84460719:03
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: Add a regression test for bug 1939545  https://review.opendev.org/c/openstack/nova/+/84395919:11
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: compute: Ensure updates to bdms during pre_live_migration are saved  https://review.opendev.org/c/openstack/nova/+/84396019:11
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: fup: Make connection_info returned by CinderFixture unique per attachment  https://review.opendev.org/c/openstack/nova/+/84474419:11
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: func: Add live migration rollback volume attachment tests  https://review.opendev.org/c/openstack/nova/+/84474519:11
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: fup: Assert state of connection_info during LM rollback in func tests  https://review.opendev.org/c/openstack/nova/+/84474619:11
opendevreviewArtom Lifshitz proposed openstack/nova stable/wallaby: Add a regression test for bug 1939545  https://review.opendev.org/c/openstack/nova/+/84367919:23
opendevreviewArtom Lifshitz proposed openstack/nova stable/wallaby: compute: Ensure updates to bdms during pre_live_migration are saved  https://review.opendev.org/c/openstack/nova/+/84368019:23
opendevreviewArtom Lifshitz proposed openstack/nova stable/wallaby: fup: Make connection_info returned by CinderFixture unique per attachment  https://review.opendev.org/c/openstack/nova/+/84459419:23
opendevreviewArtom Lifshitz proposed openstack/nova stable/wallaby: fup: Assert state of connection_info during LM rollback in func tests  https://review.opendev.org/c/openstack/nova/+/84459519:23
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: Add a regression test for bug 1939545  https://review.opendev.org/c/openstack/nova/+/84394821:15
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: compute: Ensure updates to bdms during pre_live_migration are saved  https://review.opendev.org/c/openstack/nova/+/84394921:15
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: fup: Make connection_info returned by CinderFixture unique per attachment  https://review.opendev.org/c/openstack/nova/+/84459821:15
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: fup: Assert state of connection_info during LM rollback in func tests  https://review.opendev.org/c/openstack/nova/+/84459921:15
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: Add a regression test for bug 1939545  https://review.opendev.org/c/openstack/nova/+/84395121:19
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: compute: Ensure updates to bdms during pre_live_migration are saved  https://review.opendev.org/c/openstack/nova/+/84395221:19
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: fup: Make connection_info returned by CinderFixture unique per attachment  https://review.opendev.org/c/openstack/nova/+/84460621:19
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: fup: Assert state of connection_info during LM rollback in func tests  https://review.opendev.org/c/openstack/nova/+/84460721:19
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: Add a regression test for bug 1939545  https://review.opendev.org/c/openstack/nova/+/84395921:23
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: compute: Ensure updates to bdms during pre_live_migration are saved  https://review.opendev.org/c/openstack/nova/+/84396021:23
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: fup: Make connection_info returned by CinderFixture unique per attachment  https://review.opendev.org/c/openstack/nova/+/84474421:23
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: func: Add live migration rollback volume attachment tests  https://review.opendev.org/c/openstack/nova/+/84474521:23
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: fup: Assert state of connection_info during LM rollback in func tests  https://review.opendev.org/c/openstack/nova/+/84474621:23

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!