opendevreview | Ghanshyam proposed openstack/placement master: Fix py310 unit test job https://review.opendev.org/c/openstack/placement/+/845074 | 01:43 |
---|---|---|
opendevreview | Merged openstack/placement master: Update python testing as per zed cycle testing runtime https://review.opendev.org/c/openstack/placement/+/845059 | 02:32 |
*** abhishekk is now known as akekane|home | 05:01 | |
*** akekane|home is now known as abhishekk | 05:01 | |
*** mfo is now known as Guest1558 | 12:47 | |
*** mfo_ is now known as mfo | 12:47 | |
opendevreview | ribaudr proposed openstack/nova master: Allow unshelve to a specific host (compute_api part) https://review.opendev.org/c/openstack/nova/+/831507 | 13:04 |
opendevreview | ribaudr proposed openstack/nova master: Allow unshelve to a specific host (REST API part) https://review.opendev.org/c/openstack/nova/+/845129 | 13:04 |
*** dasm|ruck|afk is now known as dasm|ruck | 13:31 | |
Uggla | sean-k-mooney, if you can find time to review ^ patches, it would be cool. | 13:44 |
artom | sean-k-mooney, instance.pcpuset is the *host* CPU IDs for that instance? | 14:03 |
sean-k-mooney | i think so i woudl have too double check | 14:13 |
sean-k-mooney | for a pinned instance that is | 14:13 |
sean-k-mooney | and it would be in the instance numa toploloy object | 14:14 |
sean-k-mooney | here https://github.com/openstack/nova/blob/master/nova/objects/instance_numa.py#L75= | 14:14 |
sean-k-mooney | not directly on the instance object | 14:14 |
sean-k-mooney | cpu_pinning_raw i think is the dict that map logicl to host cpu | 14:15 |
sean-k-mooney | https://github.com/openstack/nova/commit/867d4471013bf6a70cd3e9e809daf80ea358df92 | 14:16 |
*** whoami-rajat__ is now known as whoami-rajat | 14:16 | |
sean-k-mooney | so ya this is related to mixed cpus | 14:16 |
sean-k-mooney | so i think this is actully the logical guest cpus | 14:16 |
sean-k-mooney | not the host ones | 14:17 |
sean-k-mooney | its tracking which cpus are pinned | 14:17 |
artom | Weird, because looking at the libvirt driver code... | 14:17 |
artom | https://opendev.org/openstack/nova/src/branch/master/nova/virt/libvirt/driver.py#L8429 | 14:18 |
sean-k-mooney | it might be the host ones i just have not looke at this lately so dont have the context loaded right now | 14:18 |
artom | That looks like it's binary-AND'ig with the host available dedicated CPUs | 14:18 |
sean-k-mooney | this is in _get_host_numa_topology | 14:20 |
sean-k-mooney | so this is not using the instance numa toplogy | 14:20 |
sean-k-mooney | we are just using the same variable name i thikn | 14:20 |
artom | Ah right | 14:21 |
artom | OK, I guess the spec lays that to rest: Add the ``pcpuset`` field in ``InstanceNUMACell`` object to track the dedicated | 14:22 |
artom | vCPUs of the instance NUMA cell, and the original ``InstanceNUMACell.cpuset`` | 14:22 |
artom | is special for shared vCPU then. | 14:22 |
sean-k-mooney | yes | 14:23 |
sean-k-mooney | so this is trackign the bitmas of pinned vs floating cpus in the mixed case | 14:23 |
sean-k-mooney | if cpu policy = shared or dediceted only one of them wil have data | 14:24 |
sean-k-mooney | for mixed both do | 14:24 |
sean-k-mooney | and then the cpu_pinning_raw dict | 14:24 |
sean-k-mooney | maps the locgical cpu to a host cpu | 14:24 |
*** whoami-rajat__ is now known as whoami-rajat | 15:38 | |
opendevreview | Sven Kieske proposed openstack/nova stable/yoga: libvirt: Add a workaround to skip compareCPU() on destination https://review.opendev.org/c/openstack/nova/+/845045 | 16:44 |
opendevreview | ribaudr proposed openstack/nova master: Allow unshelve to a specific host https://review.opendev.org/c/openstack/nova/+/831507 | 16:53 |
opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: DNM: Reproduction trial for bug 1975490 https://review.opendev.org/c/openstack/nova/+/845168 | 18:57 |
*** dasm|ruck is now known as dasm|ruck|afk | 21:05 | |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843959 | 21:33 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843960 | 21:33 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844744 | 21:33 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: func: Add live migration rollback volume attachment tests https://review.opendev.org/c/openstack/nova/+/844745 | 21:33 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844746 | 21:33 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!