| opendevreview | Merged openstack/nova stable/yoga: Adds regression test for bug LP#1944619 https://review.opendev.org/c/openstack/nova/+/838788 | 00:01 |
|---|---|---|
| opendevreview | Merged openstack/nova stable/yoga: Fix pre_live_migration rollback https://review.opendev.org/c/openstack/nova/+/836014 | 00:01 |
| opendevreview | Merged openstack/nova stable/ussuri: [stable-only] Drop lower-constraints job https://review.opendev.org/c/openstack/nova/+/838033 | 01:10 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | 03:18 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311 | 03:18 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380 | 03:18 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | 03:18 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704 | 03:18 |
| *** EugenMayer1 is now known as EugenMayer | 06:20 | |
| bauzas | good morning Nova | 06:53 |
| Uggla | bauzas, o/ | 07:32 |
| Uggla | bauzas, did you sleep well after the spicy food ? | 07:32 |
| tobias-urdin | good morning o/ | 07:34 |
| gibi | good morning | 07:35 |
| * gibi will be off before noon to do a dryrun on his summit talk with the other presenter | 07:36 | |
| gibi | hehh my old E/// wifi account still works in the local E/// building | 07:37 |
| tobias-urdin | sean-k-mooney: maybe u could check this libvirt blocker when u are online https://review.opendev.org/c/openstack/nova/+/838976 | 07:41 |
| bauzas | Uggla: yes indeed ;) | 07:53 |
| kashyap | gibi: Good luck with the preso! | 08:04 |
| bauzas | gibi: break a leg ;) | 08:05 |
| * bauzas changes his hardware for the optic fiber and packages his old ONT | 08:06 | |
| bauzas | Free (French operator) <3 you missed me | 08:06 |
| bauzas | (I missed you* actually) | 08:07 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs https://review.opendev.org/c/openstack/nova/+/768509 | 08:08 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenants* with projects* of policies https://review.opendev.org/c/openstack/nova/+/765315 | 08:08 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in os-quota-sets path https://review.opendev.org/c/openstack/nova/+/768851 | 08:30 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in Limits API https://review.opendev.org/c/openstack/nova/+/768862 | 08:30 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenant* with project* in codes https://review.opendev.org/c/openstack/nova/+/769329 | 08:30 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/842288 | 08:30 |
| brinzhang0 | bauzas: hi, I would you like to review the remove_tenant series patches https://review.opendev.org/q/topic:bp%252Fremove-tenant-id | 08:35 |
| bauzas | brinzhang0: sure, I'll do | 08:35 |
| brinzhang0 | thx | 08:35 |
| sean-k-mooney | gibi: does https://review.opendev.org/c/openstack/tempest/+/842140/3/tempest/api/compute/base.py#482= make sense | 09:25 |
| sean-k-mooney | the jobs failed on the test we were trying to fix so its obviouly not working in its current form | 09:25 |
| Uggla | sean-k-mooney, can you have a quick look at my comment on https://review.opendev.org/c/openstack/nova-specs/+/831506 and tell me what you think about it ? | 09:42 |
| sean-k-mooney | im just reading a differnt one but suer ill look at it soon | 09:45 |
| Uggla | sean-k-mooney, thx | 09:46 |
| sean-k-mooney | cool one -1 down for the day now for the next :P | 09:49 |
| sean-k-mooney | Uggla: i dont see a new comment form you since the last ones i posted | 09:50 |
| sean-k-mooney | which one specifically did you want me to look at | 09:50 |
| * bauzas reviews Uggla's spec by now | 09:54 | |
| sean-k-mooney | bauzas: before you do | 09:55 |
| sean-k-mooney | bauzas: can you respond to gmann on yoru spec | 09:55 |
| bauzas | sean-k-mooney: sure, will look | 09:55 |
| sean-k-mooney | bauzas: can you pull in the change to allow @ in the keypair name | 09:55 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova-specs/+/785674 | 09:56 |
| sean-k-mooney | this comment https://review.opendev.org/c/openstack/nova-specs/+/840217/3#message-81ccda58cd8f18ba84569bec794083b5572eb1e0= | 09:56 |
| bauzas | gosh, I got lost with all the back-and-forths | 09:57 |
| bauzas | and I forgot to upload my comments | 09:57 |
| bauzas | oh, merging with another spec, I see | 09:57 |
| sean-k-mooney | its a really trivial spec so if you can merge that into your it woudl be nice to do both in one micro verion | 09:58 |
| sean-k-mooney | ya it just add ing @ and . | 09:58 |
| sean-k-mooney | to the regex | 09:58 |
| sean-k-mooney | so you can name the keypair me@my.domain | 09:58 |
| sean-k-mooney | bauzas: if your ok with that we could also make that update as a FUP | 09:59 |
| sean-k-mooney | assuming that works for gmann | 10:00 |
| bauzas | sean-k-mooney: will add a new revision | 10:00 |
| bauzas | better than a FUP | 10:00 |
| sean-k-mooney | cool ill be AFK for 20 mins or so but ill review it as soon as im back if its up | 10:00 |
| Uggla | sean-k-mooney, bauzas, oops sorry I forget to hit the reply button. | 10:04 |
| Uggla | sean-k-mooney, bauzas, my comment should be available now. | 10:05 |
| opendevreview | Rajat Dhasmana proposed openstack/nova-specs master: Repropose volume backed server rebuild spec https://review.opendev.org/c/openstack/nova-specs/+/840155 | 10:13 |
| opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes to remove keypair generation https://review.opendev.org/c/openstack/nova-specs/+/840217 | 10:15 |
| bauzas | gmann: sean-k-mooney: honestly the xena spec was not explaining how to modify the parameters | 10:22 |
| bauzas | gmann: sean-k-mooney: because we validate the keypair name not by the API but rather by a specific method https://github.com/openstack/nova/blob/4939318649650b60dd07d161b80909e70d0e093e/nova/compute/api.py#L6615 | 10:22 |
| bauzas | so we'll need to either pass a parameter down to the compute api to tell about the microversion, or create a different parameter type for the older microversions (and remove this method) | 10:24 |
| bauzas | not that simple honestly | 10:24 |
| songwenping | Hi team, my env meet the error when boot vm: Failed to create PTY:no such file or dirctory, the qemu version is 2.10.0 and libvirt is 3.9.0, any guys have any solutions? | 10:24 |
| bauzas | the simpliest is passing down some flag to the compute API of course | 10:24 |
| *** whoami-rajat__ is now known as whoami-rajat | 10:36 | |
| sean-k-mooney | bauzas: honestly my prefence would be to not require a microversion and jsut start accpeting . and @ | 10:43 |
| sean-k-mooney | gmann: is a microverions stictly required here | 10:44 |
| sean-k-mooney | to me the spec was required becauses it is an api change | 10:44 |
| sean-k-mooney | i was not sold on needing to opt into this behavior with a microverion | 10:44 |
| sean-k-mooney | i know we have an exemtimption for 500->200 in this case its 400->200 but this partaclar change seams harmless to me | 10:47 |
| bauzas | sean-k-mooney: I'm going afk for lunch but let's discuss this around 1230UTC if you want with gmann | 10:48 |
| sean-k-mooney | bauzas: by the way this is not actully happenign in the comptue agent is it | 10:48 |
| sean-k-mooney | bauzas: the keyparis are in teh api db | 10:48 |
| sean-k-mooney | and we can crete them without any instnace or host | 10:48 |
| bauzas | yeah, it's just a API DB | 10:49 |
| sean-k-mooney | so this cant actully be runnign in the compute-agent | 10:49 |
| sean-k-mooney | so there is not rpc impact here | 10:49 |
| sean-k-mooney | this is executing in the api service | 10:49 |
| * bauzas needs to be off | 10:50 | |
| sean-k-mooney | bauzas: its called directly from the api here https://github.com/openstack/nova/blob/4939318649650b60dd07d161b80909e70d0e093e/nova/api/openstack/compute/keypairs.py#L113 | 10:50 |
| bauzas | yes | 10:50 |
| sean-k-mooney | ok lets discuss when your back | 10:50 |
| sean-k-mooney | but this looks like a trivial change to me honestly | 10:51 |
| sean-k-mooney | since its all in the same process | 10:51 |
| sean-k-mooney | we dont need to worry about rpc impact if we jsut add a paramater | 10:51 |
| sean-k-mooney | its not remotable | 10:51 |
| bauzas | the question is not about the remotable usage, but rather about the microversion needed or not | 10:52 |
| sean-k-mooney | well it certenly does not need a second microversion | 10:53 |
| sean-k-mooney | im not sure it need one at all since it backwards compatible | 10:53 |
| bauzas | as we validate the name in the compute.api module, we need to pass some flag to it if we want a microversion for that | 10:53 |
| sean-k-mooney | or we move the funciton | 10:53 |
| sean-k-mooney | the only caller is in nova/api/openstack/compute/keypairs.py | 10:54 |
| bauzas | we could | 10:54 |
| bauzas | actually, it could be better | 10:54 |
| sean-k-mooney | we could leave that to the patch review honestly im not sure it needs to be in the spec | 10:55 |
| sean-k-mooney | this is an internal detail within the api process | 10:55 |
| opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes to remove keypair generation https://review.opendev.org/c/openstack/nova-specs/+/840217 | 10:55 |
| sean-k-mooney | go have lunch | 10:55 |
| sean-k-mooney | we can chat when you are back | 10:55 |
| gibi | sean-k-mooney: I've pushed a new PS for the tempest SSHABLE fix based on you suggestion, so we will see | 11:13 |
| sean-k-mooney | i breifly looked at the tempest config and it looked liek verification was configured | 11:21 |
| sean-k-mooney | so i would have expected it to trigger your chage | 11:22 |
| sean-k-mooney | so notre really sure why your orgininal patch would not work other then maybe we have to wait for both | 11:23 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Revert "zuul: Skip block migration with attached volumes tests due to bug #1931702" https://review.opendev.org/c/openstack/nova/+/812473 | 11:23 |
| kashyap | gibi: So we're indeed skipping that | 11:24 |
| kashyap | Err, it's a revert | 11:24 |
| kashyap | Yep, makes sense, from reading the commit message. | 11:24 |
| gibi | kashyap: I have no information why it should work now, but at least we can gather that information | 11:25 |
| kashyap | Yeah | 11:25 |
| gibi | it is related to another SSHABLE tempest fix in https://review.opendev.org/c/openstack/tempest/+/817772 | 11:25 |
| tobias-urdin | sean-k-mooney: please have a quick look at https://review.opendev.org/c/openstack/nova/+/838976 when you have time, i need to go afk for a while but will be back later today | 11:33 |
| sean-k-mooney | sure | 11:35 |
| sean-k-mooney | oh this is for the nodedev name change | 11:36 |
| sean-k-mooney | ya im aware of that | 11:36 |
| tobias-urdin | ack :) | 11:36 |
| gibi | I've just finished reviewing that | 11:37 |
| gibi | I have some comments and a request for tests | 11:37 |
| sean-k-mooney | just seeing them as i click | 11:38 |
| sean-k-mooney | gibi: replied inline | 11:47 |
| gibi | thanks | 11:51 |
| *** sfinucan is now known as stephenfin | 12:04 | |
| opendevreview | Merged openstack/nova stable/train: [stable-only] Drop lower-constraints job https://review.opendev.org/c/openstack/nova/+/838037 | 12:44 |
| opendevreview | Mohammed Naser proposed openstack/nova master: Fix race condition in _get_pci_passthrough_devices https://review.opendev.org/c/openstack/nova/+/840993 | 12:49 |
| sean-k-mooney | gibi: are you working on https://bugs.launchpad.net/nova/+bug/1971760 i was going to try and find time today to push a patch to make spawn_n actully be spwan and see if that helps | 13:07 |
| gibi | sean-k-mooney: I have an env where I try to reproduce the leak itself but I had no time to kick that env enough. I'm not sure I can reproduce the leak in a reproducible way | 13:08 |
| gibi | so it is hard to test any changesd | 13:08 |
| sean-k-mooney | i think it will hapen if a thread that is invoked with spawn_n raises an excpeiton | 13:09 |
| sean-k-mooney | that is not caugt before the entry porint of the spawn_n call | 13:09 |
| gibi | I tried that | 13:09 |
| gibi | it does not create the leak | 13:09 |
| gibi | I tried vif plug timeout | 13:10 |
| sean-k-mooney | well my other tought was maybe itst related to https://bugs.launchpad.net/oslo.messaging/+bug/1949964 | 13:10 |
| gibi | I havent looked at ^^ yet | 13:10 |
| gibi | so feel free to propose a patch but it will be hard to prove it solved the issue except if mnaser are willing to take that patch to his env and let it running for a while | 13:11 |
| sean-k-mooney | i was hoping to be able to tweak https://github.com/eventlet/eventlet/issues/731#issue-1032856809 to repoduce it but ya i just want to see if we do https://github.com/eventlet/eventlet/issues/731#issuecomment-968135262 will it help | 13:16 |
| sean-k-mooney | well will it work with nova | 13:16 |
| sean-k-mooney | i was considering putting it behind a workaround config option so we could get feedback | 13:17 |
| gibi | yeah either we need a way to reproduce or we need to make this optional and ask for feedback | 13:18 |
| gibi | overall I don't see problems replacing our spawn_n calls with spawn | 13:18 |
| gibi | It should not cause any additional issue | 13:19 |
| gibi | but it might not fix the current one | 13:19 |
| gibi | :) | 13:19 |
| sean-k-mooney | :) ya that is kind of what i was thinking too | 13:19 |
| sean-k-mooney | it should not make things worse it just might not have any effect at all | 13:20 |
| gibi | yepp | 13:21 |
| gibi | there is a small memory / cpu overhead in case of spawn as it does wrap the greenlet into a GreenThread object but we don't have that much greenlets that it causes issues | 13:22 |
| gibi | except when we start leaking them :D | 13:23 |
| opendevreview | sean mooney proposed openstack/nova master: [DNM] allow mokey patching spawn_n to spawn https://review.opendev.org/c/openstack/nova/+/842359 | 13:35 |
| opendevreview | sean mooney proposed openstack/nova master: [DNM] allow monkey patching spawn_n to spawn https://review.opendev.org/c/openstack/nova/+/842359 | 13:36 |
| sean-k-mooney | i have not test ^ and it currently defaults to enabled | 13:36 |
| sean-k-mooney | but we will see what the ci thinks | 13:37 |
| sean-k-mooney | gibi shoudl i also add you greenlet state reporting | 13:37 |
| gibi | you can pull the patch top of it just for data | 13:38 |
| gibi | but it does not prove anything as CI is basically doing a lot of operations then stops, so there is now time for the numbers to settle to a baseline | 13:38 |
| sean-k-mooney | ya but the data could be interesting to compare | 13:39 |
| sean-k-mooney | shall i cherry pick your patch so? | 13:39 |
| sean-k-mooney | or rebase on it | 13:39 |
| gibi | just cherry pick top of yours | 13:41 |
| opendevreview | sean mooney proposed openstack/nova master: DNM: log number of green(thread|let)s periodically https://review.opendev.org/c/openstack/nova/+/841040 | 13:42 |
| sean-k-mooney | cool | 13:42 |
| sean-k-mooney | so looking at the output of the previous run | 13:42 |
| sean-k-mooney | we see both greenthreadds and greenlets | 13:42 |
| sean-k-mooney | and we are not expecting to only see greenthreads with my patch | 13:42 |
| gibi | yepp we expect only greenthreads and no naked greenlets | 13:43 |
| gibi | greenlets are implemented in a C extension greenthreads are proper python objects implemented by eventlet | 13:44 |
| sean-k-mooney | so looking at the output from the test run | 13:44 |
| sean-k-mooney | teh greenthrad sayed pretty constant | 13:45 |
| sean-k-mooney | but the greenlets were more or less slowly increaing over time | 13:45 |
| gibi | I see same behavior locally too, but most of the time after couple of minutes of idle time the greenlets also decreased back to baseline. | 13:45 |
| sean-k-mooney | https://termbin.com/dzg3 | 13:46 |
| gibi | in CI there is no couple of minutes of idle time | 13:46 |
| frickler | gibi: kashyap: fyi I had another fix for this in tempest recentish https://review.opendev.org/c/openstack/tempest/+/835382 | 13:46 |
| gibi | but it would be interesting to see what happens there | 13:46 |
| frickler | this = volume attachments | 13:46 |
| sean-k-mooney | ah for tagged attachments | 13:47 |
| gibi | frickler: yepp, that helps too. thanks. we need to track down all the detach scenarios | 13:47 |
| sean-k-mooney | ya | 13:47 |
| gibi | all volume detach operation is potenitally affected | 13:47 |
| sean-k-mooney | and attach since we do detach as a cleanup action | 13:48 |
| gibi | sean-k-mooney: good point, yes | 13:48 |
| sean-k-mooney | you know technially this could affect nics too | 13:49 |
| sean-k-mooney | i dont think we have ever seen it affect them | 13:49 |
| sean-k-mooney | but both are just virtual pci devices form qemus point of view | 13:50 |
| sean-k-mooney | just one is virtio-blk and the other is virtio-net | 13:50 |
| gibi | yeah, I never see this in case of interfaces | 13:51 |
| ricolin | sean-k-mooney: stephenfin | 13:51 |
| gibi | probably something is different down in the stack | 13:51 |
| gibi | either qemu dev handling or the guest OS dev handling | 13:51 |
| gibi | nova today uses the same codepath | 13:51 |
| sean-k-mooney | gibi: ya. i guess network attach/detach is more common and porably better tested | 13:52 |
| ricolin | if you got some time, please help to review https://review.opendev.org/c/openstack/nova-specs/+/840310 as mnaser already laeve some comments would like to have your feedback:) | 13:52 |
| gibi | also probably force pulling out a disk is more problematic from data consistency perspective than pulling a netdev | 13:52 |
| *** dasm|off is now known as dasm | 13:52 | |
| sean-k-mooney | right the netdev is mostly stateless | 13:53 |
| sean-k-mooney | ricolin: i think its stephenfin's feedback we need really | 13:54 |
| sean-k-mooney | i dont like exposing the aw_bits but i understand that ye have a need for it | 13:54 |
| ricolin | sean-k-mooney: cool, thanks:) | 13:55 |
| sean-k-mooney | i think hw_viommu_model is the write absraction for opting in as we use the same pattern for contoling the graphic deviecs or nic models | 13:55 |
| sean-k-mooney | gibi: hum https://review.opendev.org/c/openstack/tempest/+/842140 still failed the same way | 14:03 |
| sean-k-mooney | frickler: ^ any idea why | 14:03 |
| gibi | sean-k-mooney: yeah, this is where my tempest knowledge ends. probably something is different in the network setup of this test | 14:05 |
| frickler | sean-k-mooney: I'll take a look later, in a meeting now | 14:05 |
| sean-k-mooney | gibi: possible i can see in the tempest output it waited for it to go form resize verify to active | 14:05 |
| sean-k-mooney | and tehn it tries to ssh in | 14:05 |
| sean-k-mooney | but it didn not work | 14:06 |
| sean-k-mooney | "fixed_ip_address": "10.1.0.10" | 14:07 |
| sean-k-mooney | ip-route:10.1.0.0/28 dev eth0 scope link src 10.1.0.10 | 14:07 |
| sean-k-mooney | ah | 14:07 |
| sean-k-mooney | ## ping -c 5 10.1.0.1 | 14:08 |
| sean-k-mooney | PING 10.1.0.1 (10.1.0.1): 56 data bytes | 14:08 |
| sean-k-mooney | --- 10.1.0.1 ping statistics --- | 14:08 |
| sean-k-mooney | 5 packets transmitted, 0 packets received, 100% packet loss | 14:08 |
| sean-k-mooney | the vm cannot ping its gateway | 14:08 |
| sean-k-mooney | gibi: my guess is security groups | 14:10 |
| bauzas | gmann: to clarify the new release naming thingy, it would be something like "2022.2 Arbitrary" for the AA release ? | 14:12 |
| bauzas | where "Arbitrary" be chosen by the Foundation folks | 14:12 |
| bauzas | right? | 14:12 |
| sean-k-mooney | where "Arbitrary" is aardvark so say it dansmith :) | 14:13 |
| sean-k-mooney | havnt actully read the most recent status of this | 14:13 |
| sean-k-mooney | so also interested | 14:13 |
| dansmith | I would love them to choose such a name to make my point, but yes, it's going to be aardvark :) | 14:13 |
| dansmith | the name will be the name, the version will be 2022.2 | 14:13 |
| sean-k-mooney | gibi: it might be becasue the server is not being created with teh validation resouces initally | 14:17 |
| bauzas | dansmith: if it was named a-ha, it could take on me | 14:17 |
| sean-k-mooney | gibi: so it might not hwave an sshkey | 14:17 |
| gibi | sean-k-mooney: OK, that I can fix | 14:18 |
| dansmith | bauzas: you win today | 14:18 |
| sean-k-mooney | gibi: we are not calling https://review.opendev.org/c/openstack/tempest/+/842140/4/tempest/api/compute/volumes/test_attach_volume.py#45= | 14:18 |
| gibi | thanks for looking at it | 14:18 |
| sean-k-mooney | here https://review.opendev.org/c/openstack/tempest/+/842140/4/tempest/api/compute/volumes/test_attach_volume.py#384 | 14:18 |
| bauzas | dansmith: heh, thanks for the explanation anyway | 14:19 |
| sean-k-mooney | so we are not waiting for the server to be sshable before we attach the multi attach volume | 14:19 |
| * bauzas didn't wanted to tell he googled "aardvark" | 14:19 | |
| sean-k-mooney | a is for aardvark is an amican thing we normally say ant or similar | 14:20 |
| dansmith | it's perfect because it starts with AA | 14:20 |
| sean-k-mooney | yep | 14:20 |
| dansmith | I challenge the rest of you to pick names for the other letters that begin thusly :) | 14:20 |
| sean-k-mooney | dansmith: the real question is the next AB or BB becaue one is much more of a challange | 14:25 |
| dansmith | sean-k-mooney: well, I had assumed BB, but maybe AB would be appropriate for the naming | 14:25 |
| dansmith | however, I think all the things would have to start with A and somewhat defeat the point | 14:25 |
| dansmith | however, these are the foundations' problems now :) | 14:26 |
| sean-k-mooney | this is not what i was looking for but its cute so https://www.pinterest.ie/morganlimehouse/bb-animals/ | 14:27 |
| bauzas | AB are two capital letters known a lot by French | 14:28 |
| bauzas | lots of french cheapy soap series | 14:28 |
| opendevreview | sean mooney proposed openstack/nova master: [DNM] allow monkey patching spawn_n to spawn https://review.opendev.org/c/openstack/nova/+/842359 | 14:32 |
| opendevreview | sean mooney proposed openstack/nova master: DNM: log number of green(thread|let)s periodically https://review.opendev.org/c/openstack/nova/+/841040 | 14:32 |
| opendevreview | sean mooney proposed openstack/nova master: [DNM] allow monkey patching spawn_n to spawn https://review.opendev.org/c/openstack/nova/+/842359 | 14:37 |
| opendevreview | sean mooney proposed openstack/nova master: DNM: log number of green(thread|let)s periodically https://review.opendev.org/c/openstack/nova/+/841040 | 14:37 |
| gmann | bauzas: dansmith sean-k-mooney on release name, we still discussing how to use it in development cycle (number only or number and name both ), should be ready by this week (plan to discuss in TC meeting tomorrow ) - https://review.opendev.org/c/openstack/governance/+/841800 | 14:53 |
| gmann | but yes, name will be all foundation things now | 14:53 |
| bauzas | Uggla: sean-k-mooney: dansmith: gibi: gave -1 for https://review.opendev.org/c/openstack/nova-specs/+/831506 just to make sure we have a consensus | 14:54 |
| gmann | bauzas: sean-k-mooney on keypair allowing @|. as it will be error -> success, it is ok for backward compatibility but we need to have microversion for interoperability | 14:56 |
| Uggla | bauzas, no pb. I agree. Have you seen my proposal to add another API parameter to mange the pin/unpin az of instances ? | 14:57 |
| bauzas | gmann: ok, so we would be only accepting those only by the new microversion, reight? | 14:57 |
| gmann | bauzas: yes | 14:58 |
| bauzas | gmann: ok, then that's what I wroter | 14:58 |
| gmann | bauzas: this is code change ref author did for that spec - https://review.opendev.org/c/openstack/nova/+/781076/ | 14:58 |
| gmann | bauzas: yeah, I am +2 on spec, just waiting for melwitt if she has anything before +w. | 14:58 |
| gibi | I left a question with a -1 on that ^^ | 15:12 |
| bauzas | gibi: replied https://review.opendev.org/c/openstack/nova-specs/+/840217/5/specs/zed/approved/keypair-generation-removal.rst#66 | 15:23 |
| bauzas | tl;dr: 'ssh' keytype is the default if the param is not passed | 15:24 |
| bauzas | which makes sense, as the fingerprint only needs to be generated differently if this comes from a x509 cert | 15:24 |
| gibi | replied | 15:25 |
| gibi | does it make sense to return type ssh for x509 keypairs ? | 15:26 |
| sean-k-mooney | not realy | 15:27 |
| sean-k-mooney | x509 is for winrm | 15:27 |
| sean-k-mooney | not ssh | 15:27 |
| sean-k-mooney | it can be used for other things | 15:27 |
| sean-k-mooney | we just assume the user will tell us if its not ssh | 15:27 |
| gibi | I think today if no type is specified and an x509 key is imported nova will save type=ssh for it | 15:27 |
| sean-k-mooney | but we dont really use that for anything | 15:27 |
| bauzas | gibi: no it won't work | 15:28 |
| gibi | we dont use type but we do return it on the API | 15:28 |
| bauzas | gibi: because the fingerprint will be generated using a SSH way | 15:28 |
| sean-k-mooney | bauzas: what fingreprint | 15:28 |
| sean-k-mooney | we are uploading the fingerprint right | 15:28 |
| bauzas | gibi: atm, if you import a pubkey, nova generates a fingerprint using the key type you provided, or ssh as default | 15:29 |
| bauzas | sean-k-mooney: no, we're generating it | 15:29 |
| bauzas | https://github.com/openstack/nova/blob/4939318649650b60dd07d161b80909e70d0e093e/nova/compute/api.py#L6658 | 15:29 |
| sean-k-mooney | when you use x509 you would import the fingerprint the same way we impor the public key | 15:29 |
| gmann | I think gibi point is valid, one way is to mention in api-ref that we should expect 'type' if importing x509 otherwise it will be default to ssh | 15:29 |
| gmann | or return None as default if not passed | 15:29 |
| gibi | can we make ``type`` required in this new api microversion | 15:30 |
| gibi | ? | 15:30 |
| bauzas | sean-k-mooney: https://github.com/openstack/nova/blob/4939318649650b60dd07d161b80909e70d0e093e/nova/compute/api.py#L6729-L6733 | 15:30 |
| sean-k-mooney | hum ok | 15:30 |
| bauzas | gibi: looks to me a bikeshed | 15:30 |
| bauzas | gibi: 99% of users will import an openssh generated key | 15:30 |
| gmann | yeah, I think returning None as default s ok as that is what pattern we use in API where we return the things which are passed | 15:31 |
| gibi | OK, then check the imported key and if it is not ssh then set the type accordingly automatically | 15:31 |
| bauzas | but the 1% of opiniated users that wanna use x509 certs will make sure they correctly set the type, like we did previously | 15:31 |
| bauzas | gmann: gibi: I don't see the need for a breaking change here | 15:31 |
| bauzas | we just want to stop generating a key | 15:32 |
| bauzas | for pubkey imports, I don't think we should change anything | 15:32 |
| gmann | but if we see from user point of view that generating fingureprint as ssh for x509 if type is not passed is also wrong https://github.com/openstack/nova/blob/4939318649650b60dd07d161b80909e70d0e093e/nova/compute/api.py#L6729-L6733 | 15:33 |
| gmann | bauzas: yeah, it will be same as it is currently so this is not new things we are adding in this spec | 15:33 |
| gmann | I mean no 'type' in request create same mismatch currently also and after this spec also. | 15:34 |
| bauzas | gmann: gibi: honestly, I'm more intended to document this in the API reference but not make it mandatory | 15:34 |
| bauzas | it will be a PITA for 99% of our users | 15:34 |
| bauzas | like, "type is optional but defaulted to ssh, you're warned" | 15:35 |
| gmann | that work for me, having it in api-ref is enough i think. | 15:35 |
| bauzas | I'll just change the apiref parameter documentation for all the microversions, since this is already the same | 15:36 |
| gmann | I am ok with either 1. in api-ref 2. return as None but not in favor of making it mandatory | 15:36 |
| bauzas | gmann: none is meaningless since we especially generated a fingerprint using the openssh toolbox | 15:36 |
| gmann | yeah that too | 15:36 |
| bauzas | actually, not by openssh itself, but folliwing the openssh reference (base64) | 15:37 |
| gmann | bauzas: +1 on api -ref and yes that can be done for all microversion not specific to this one | 15:37 |
| bauzas | gmann: want me to write it down on the spec ? | 15:38 |
| gmann | bauzas: I do not think that is needed as it is same behavior currently also and we are just documenting it. | 15:39 |
| bauzas | gmann: cool, then I'll add a comment in the spec change | 15:40 |
| bauzas | at least if gibi is happy with this | 15:40 |
| gmann | yeah | 15:40 |
| gibi | bauzas: yes this "bug" exists today regardless of your spec, but as your spec bumping the microversion for keypairs I thought we could fix this in the same microversion | 16:04 |
| gibi | but I digress. Lets at least document this behavior in the API ref | 16:06 |
| gibi | I'm removing my -1 | 16:06 |
| gibi | done | 16:07 |
| opendevreview | Stephen Finucane proposed openstack/osc-placement master: Remove six https://review.opendev.org/c/openstack/osc-placement/+/842386 | 16:09 |
| opendevreview | ribaudr proposed openstack/nova-specs master: libvirt: Allow Manila shares to be directly attached to instances https://review.opendev.org/c/openstack/nova-specs/+/833669 | 16:11 |
| bauzas | gibi: <3 | 16:13 |
| melwitt | stephenfin: did you see this and the patch above it? https://review.opendev.org/c/openstack/osc-placement/+/812262 I had thought I had seen some remove six patches before and found these | 16:43 |
| opendevreview | Erlon R. Cruz proposed openstack/nova stable/xena: Adds regression test for bug LP#1944619 https://review.opendev.org/c/openstack/nova/+/838550 | 16:59 |
| opendevreview | Erlon R. Cruz proposed openstack/nova stable/xena: Fix pre_live_migration rollback https://review.opendev.org/c/openstack/nova/+/836015 | 16:59 |
| opendevreview | Merged openstack/osc-placement master: Remove usage of six https://review.opendev.org/c/openstack/osc-placement/+/812262 | 18:33 |
| opendevreview | Merged openstack/osc-placement master: Remove usage of six https://review.opendev.org/c/openstack/osc-placement/+/815223 | 18:38 |
| opendevreview | Merged openstack/nova stable/stein: [stable-only] Drop lower-constraints job https://review.opendev.org/c/openstack/nova/+/838038 | 19:11 |
| opendevreview | sean mooney proposed openstack/nova master: [DNM] allow monkey patching spawn_n to spawn https://review.opendev.org/c/openstack/nova/+/842359 | 21:15 |
| opendevreview | sean mooney proposed openstack/nova master: DNM: log number of green(thread|let)s periodically https://review.opendev.org/c/openstack/nova/+/841040 | 21:15 |
| mnaser | has anyone been able to successfully run pep8 .. locally? | 21:44 |
| mnaser | got a bunch of failures on stable/wallaby .. `nova/virt/libvirt/driver.py:621:12: error: Cannot determine type of '_disk_cachemode'` | 21:45 |
| sean-k-mooney | am yes | 21:45 |
| sean-k-mooney | im just about to finish for the day again but i can try it quickly | 21:45 |
| mnaser | i'm on macos so im wondering if there's something in the py version i'm running | 21:45 |
| mnaser | i have py 3.8.9 | 21:45 |
| sean-k-mooney | perhaps we dont relaly supprot anything other then linux | 21:45 |
| sean-k-mooney | we used to be able to run them on cygwin but that was broken a long time ago | 21:46 |
| mnaser | yeah but it seems weird/odd that mypy stuff would fail | 21:46 |
| mnaser | since that seems more of a linter | 21:46 |
| sean-k-mooney | my mac is downstiar i could try that there too | 21:46 |
| mnaser | maybe i should use multipass or whatnot | 21:47 |
| sean-k-mooney | or you could dual boot linux on your mac | 21:48 |
| sean-k-mooney | it should work however | 21:48 |
| mnaser | i think with an m1 mac that's a bit of a reach yet :P | 21:48 |
| sean-k-mooney | nope | 21:48 |
| sean-k-mooney | i have dual booted debian | 21:48 |
| sean-k-mooney | and even got devstack to run | 21:48 |
| mnaser | oh that's interesting lol | 21:48 |
| sean-k-mooney | with a lot of work | 21:48 |
| sean-k-mooney | but the unit test worked on both arch and debian | 21:49 |
| mnaser | i feel like a lot of things won't work though, so multipass / vm is a decent middle ground :p | 21:49 |
| sean-k-mooney | booting a vm on linux id cause a kernel crash however | 21:49 |
| sean-k-mooney | ya i used udm too | 21:49 |
| sean-k-mooney | that actully works pretty well | 21:50 |
| sean-k-mooney | udm to deploy a ubuntu 20.04 arm vm | 21:50 |
| sean-k-mooney | and then install what you want in that | 21:50 |
| mnaser | udm? | 21:50 |
| sean-k-mooney | udm is a front end for qemu on mac | 21:51 |
| sean-k-mooney | hum is it udm | 21:51 |
| mnaser | udm is "université de montréal" for what i know :p | 21:51 |
| sean-k-mooney | oh utm | 21:52 |
| sean-k-mooney | https://mac.getutm.app/ | 21:52 |
| sean-k-mooney | i just used this template https://mac.getutm.app/gallery/ubuntu-20-04 | 21:52 |
| mnaser | ouu nice | 21:52 |
| mnaser | yeah i've just been relying on multipass since ubuntu is a decent base for what i need, but this is really useful | 21:53 |
| sean-k-mooney | it uses macos's version of kvm but no nested virt on m1 | 21:53 |
| sean-k-mooney | i have pep8 running ill quickly grab my mac and try it there too brb | 21:54 |
| sean-k-mooney | oh it passed on linux | 21:54 |
| mnaser | i guess it could be an env thing | 21:55 |
| sean-k-mooney | maybe use -r to recreate the tox env | 21:56 |
| sean-k-mooney | if you change branch that can cause weird issues if you have not recareted it recently | 21:56 |
| mnaser | i think i might just save myself the mess and do my dev in a vm | 21:57 |
| mnaser | not ideal but meh | 21:57 |
| sean-k-mooney | how do you get python normally | 21:58 |
| sean-k-mooney | are you using it form homebrew or another way | 21:58 |
| mnaser | homebrew | 21:58 |
| mnaser | but my python on this box is a bit of an embarassing mess :) | 21:58 |
| sean-k-mooney | you could try using a venv to run tox | 21:59 |
| sean-k-mooney | to get a clean python env | 21:59 |
| mnaser | im thinking running it in a vm is probably easier | 22:01 |
| sean-k-mooney | by the way we ahve seen things like different version of sqlite3 break functinal test on different distors before | 22:01 |
| sean-k-mooney | but not sure what would be similar for pep8 | 22:01 |
| mnaser | which will reflect the state of our ci the closst oo | 22:01 |
| mnaser | sean-k-mooney: im thinking it probably has to do with libvirt-python if i had to guess based on the fact its mostly having to do with libvirt | 22:01 |
| mnaser | and since libvirt on macos is weird prolly | 22:02 |
| sean-k-mooney | ya maybe | 22:02 |
| sean-k-mooney | although we dont actully install that for our tox envs | 22:02 |
| mnaser | all the errors were in "nova/virt/libvirt/driver.py" so /shrug | 22:03 |
| mnaser | well it passed just fine inside multipass vm on my box soooo | 22:05 |
| sean-k-mooney | ya i also cant get it to run natively on macos for other reasons | 22:06 |
| sean-k-mooney | i do not have python form homebrew i have it from the nix package manager | 22:07 |
| sean-k-mooney | its unhappy with 2to3 and suds-jurko | 22:07 |
| sean-k-mooney | althoug i could jsut not install the vmware lib | 22:07 |
| mnaser | yeah i had to manually install that with a lot of really complicated ways | 22:11 |
| sean-k-mooney | im getting clan compliation errors trying to build type-ast | 22:14 |
| sean-k-mooney | so looks like there are some cpython module compat issue with macos on arm | 22:15 |
| sean-k-mooney | works find with linux vm or otherwise however | 22:15 |
| sean-k-mooney | proably would be fine with macos and x86 for that mater but macos and arm is pushing it just a little too far | 22:16 |
| sean-k-mooney | vms are still pretty quick on m1 | 22:16 |
| sean-k-mooney | my base spec m1 air is technically faster at running the test in a vm them my amin work laptop is nativly | 22:17 |
| *** dasm is now known as dasm|off | 22:32 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!