| bauzas | good morning Nova | 08:00 |
|---|---|---|
| * kashyap waves | 08:08 | |
| Uggla | bauzas, o/ | 08:11 |
| *** abhishekk is now known as akekane|home | 08:31 | |
| *** akekane|home is now known as abhishekk | 08:31 | |
| opendevreview | Merged openstack/nova master: Switch libvirt event timeout message to warning https://review.opendev.org/c/openstack/nova/+/840985 | 09:36 |
| opendevreview | ribaudr proposed openstack/nova master: Allow unshelve to a specific host https://review.opendev.org/c/openstack/nova/+/831507 | 09:37 |
| opendevreview | ribaudr proposed openstack/python-novaclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-novaclient/+/831651 | 09:47 |
| kashyap | Uggla: Hey, from a quick skim, you might want to split that "unshelve to a specific host" into a few patches. As it seems to be touching a lot of files in ine go. | 09:49 |
| Uggla | kashyap, I'm gonna have a look. I need to think what could be the best split. | 09:52 |
| kashyap | Uggla: One idea could be to split based on "one logical change per commit". It ensures that in case something needs to be reverted, it can be easily done | 09:54 |
| kashyap | (And also many other reasons: https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes) | 09:54 |
| sean-k-mooney | Uggla: i tend to split by subsystem | 09:58 |
| sean-k-mooney | or binary that im touching | 09:58 |
| sean-k-mooney | not always but its rare i will touch the api and compute node in one patch | 09:58 |
| sean-k-mooney | or db and api | 09:59 |
| Uggla | sean-k-mooney, yep but here it is only api. | 09:59 |
| sean-k-mooney | ya for that patch the api microverison bump shoudl be the last patch | 09:59 |
| sean-k-mooney | the valdiation code can be a sperat patch | 09:59 |
| sean-k-mooney | not sure about the rest | 09:59 |
| sean-k-mooney | i would not expect that chagne to be more the 2-5 patches honestly | 10:00 |
| sean-k-mooney | its not partacalarly large, you could put all the docs changes in one | 10:00 |
| sean-k-mooney | the unit and fucntional test shoudl be in the patch that changes the behavior not groupted into one patch | 10:01 |
| Uggla | sean-k-mooney, yes I was thinking about moving the doc in another patch. | 10:02 |
| sean-k-mooney | i often do the docs changes inlien but have also split them in the past. docs patche can land after feature freeze | 10:04 |
| sean-k-mooney | not that i hope it will take that long to land your code but just somethign to keep in mind if we are getting close to m3 | 10:04 |
| *** whoami-rajat__ is now known as whoami-rajat | 10:40 | |
| *** dasm|off is now known as dasm | 14:01 | |
| opendevreview | Rico Lin proposed openstack/nova-specs master: Add vIOMMU device support for libvirt driver https://review.opendev.org/c/openstack/nova-specs/+/840310 | 18:34 |
| ricolin | sean-k-mooney: stephenfin just update https://review.opendev.org/c/openstack/nova-specs/+/840310 mnaser also leave some comment in patch to targeting your why question, please kindly take another review on it. Thanks! :) | 18:38 |
| mnaser | ricolin: might wanna fix pep8 :) | 19:13 |
| *** dasm is now known as dasm|off | 21:12 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!